[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #12 from Alex Granni --- Yes, 3.0.5.a.2 has this problem solved. Thank you. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #11 from William Deegan --- I've pushed out an alpha package for you to verify your issue is now resolved. https://github.com/SCons/scons/releases/tag/3.0.5a2 Also available at: pip install --index-url https://test.pypi.org/simple/ scons==3.0.5.a2 Please let us know if this works! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #10 from William Deegan --- If you'd like to be notified when the fix gets merged into SCons please add yourself to: https://github.com/SCons/scons/pull/3311 Hopefully I'll get this wrapped up (need a test to cover this) and into master this weekend and it'll make it into the next release (3.0.5 or 3.1 are the most likely version strings) -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 Jose Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Component|glsl-compiler |Mesa core QA Contact|intel-3d-bugs@lists.freedes |mesa-dev@lists.freedesktop. |ktop.org|org --- Comment #9 from Jose Fonseca --- Workaround pushed. Thanks everybody. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #8 from Jose Fonseca --- (In reply to Alex Granni from comment #7) > I'd go for this way as 3.0.4 is also affected. OK. I'll assume I have your Tested-By and post it for review. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443
--- Comment #7 from Alex Granni ---
I'd go for this way as 3.0.4 is also affected:
diff --git a/scons/gallium.py b/scons/gallium.py
index 963834a5fbc..565f19f3f1a 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -308,7 +308,10 @@ def generate(env):
if env.GetOption('num_jobs') <= 1:
env.SetOption('num_jobs', num_jobs())
-env.Decider('MD5-timestamp')
+scons_version = distutils.version.StrictVersion(SCons.__version__)
+if scons_version < distutils.version.StrictVersion('3.0.2') or \
+ scons_version > distutils.version.StrictVersion('3.0.4'):
+env.Decider('MD5-timestamp')
env.SetOption('max_drift', 60)
# C preprocessor options
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443
--- Comment #6 from Jose Fonseca ---
How about this as workaround:
diff --git a/scons/gallium.py b/scons/gallium.py
index 963834a5fbc..565f19f3f1a 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -308,7 +308,10 @@ def generate(env):
if env.GetOption('num_jobs') <= 1:
env.SetOption('num_jobs', num_jobs())
-env.Decider('MD5-timestamp')
+scons_version = distutils.version.StrictVersion(SCons.__version__)
+if scons_version < distutils.version.StrictVersion('3.0.2') or \
+ scons_version >= distutils.version.StrictVersion('3.0.4'):
+env.Decider('MD5-timestamp')
env.SetOption('max_drift', 60)
# C preprocessor options
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 --- Comment #5 from William Deegan --- Found some issues with the patch I attached. Should have an updated one tomorrow. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 William Deegan changed: What|Removed |Added CC||b...@baddogconsulting.com --- Comment #4 from William Deegan --- Created attachment 143466 --> https://bugs.freedesktop.org/attachment.cgi?id=143466=edit Trial patch to fix issue Trial patch to SCons to address issue. Please apply to SCons/Node/FS.py and let me know if it resolves the issue. The bug seems to be windows only and has to do with looking up info about previous build to decide if a target needs to be built. I'm still running tests locally on it against mesa win build. Next I'll run against SCons' own test suite. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443
--- Comment #3 from William Deegan ---
If you comment out line 311 in mesascons/gallium.py
# env.Decider('MD5-timestamp')
You can use SCons 3.0.4.
3.0.4 had a bugfix for a longstanding issue where it was possible that
md5-timestamp in conjunction with changing the number of implicit dependencies
(think header files) could yield (infrequently) corrupted content signatures in
the sconsign file.
By defaulting the decider to MD5, you'll have a temporary workaround and be
able to use SCons 3.0.4
I'm investigating this further currently.
It looks like with the bugfix in 3.0.4 api_exec.obj somehow doesn't have
nir_opcodes.h (which is a generated file) as an implicit dependency, thus
nir_opcodes.h isn't being generated before api_exec.c is compiled.
--
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [Bug 109443] Build failure with MSVC when using Scons >= 3.0.2
https://bugs.freedesktop.org/show_bug.cgi?id=109443 Alex Granni changed: What|Removed |Added Summary|Build failure with MSVC |Build failure with MSVC |2017 when using Scons >=|when using Scons >= 3.0.2 |3.0.2 | -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
