[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #30 from Roland Scheidegger  ---
Frankly I don't know if the offset scaling makes any sense.
IMHO using the formula for fixed-point depth buffers d3d10 requires (luckily at
least for float formats everybody (gl, vulkan, d3d10) agrees on the exact
formula) would be way less trouble for everybody (pretty sure that would
correspond to offset_scale of 1.0), although I'm not entirely sure it would
actually fit the guarantee (of both gl and vulkan) that fragments always be
distinguishable if they only differ by the implementation-defined r...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-05-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

Samuel Pitoiset  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|NEW |RESOLVED

--- Comment #29 from Samuel Pitoiset  ---
No because it's not a bug.

Per the Vulkan spec "26.11.3. Depth Bias":

"depthBiasSlopeFactor scales the maximum depth slope of the polygon, and
depthBiasConstantFactor scales an implementation-dependent constant that
relates to the usable resolution of the depth buffer."

and,

"The minimum resolvable difference r is an implementation-dependent parameter
that depends on the depth buffer representation."

That means, it might render differently based on that implementation-dependent
parameter. Note that it likely renders something different with NVIDIA as well.

Closing as we can't do anything.
Thanks for the report!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-05-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #28 from tempel.jul...@gmail.com ---
Would it be possible to ship this with one of the 19.1-rcs?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #27 from tempel.jul...@gmail.com ---
Yey, it seems it is fixed without any drawbacks, as far as I can tell. :)

HotS:
amdvlk:
https://abload.de/img/amdvlkbjjv9.png

radv old:
https://abload.de/img/radvoldl3kd3.png

radv new:
https://abload.de/img/radvnewd8k1o.png



Hitman 2:
amdvlk:
https://abload.de/img/amdvlkbyjub.png

radv old:
https://abload.de/img/radvopjos.png

radv new:
https://abload.de/img/radvnewy2ks5.png


Once again: Thanks big time! :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-05-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #26 from Samuel Pitoiset  ---
Created attachment 144120
  --> https://bugs.freedesktop.org/attachment.cgi?id=144120=edit
bias change

Can you try with this change applied?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #24 from tempel.jul...@gmail.com ---
Created attachment 144115
  --> https://bugs.freedesktop.org/attachment.cgi?id=144115=edit
hitman 2 renderdoc capture 6/6

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #25 from tempel.jul...@gmail.com ---
Upload complete.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #23 from tempel.jul...@gmail.com ---
Created attachment 144114
  --> https://bugs.freedesktop.org/attachment.cgi?id=144114=edit
hitman 2 renderdoc capture 5

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #22 from tempel.jul...@gmail.com ---
Created attachment 144113
  --> https://bugs.freedesktop.org/attachment.cgi?id=144113=edit
hitman 2 renderdoc capture 4

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #21 from tempel.jul...@gmail.com ---
Created attachment 144112
  --> https://bugs.freedesktop.org/attachment.cgi?id=144112=edit
hitman 2 renderdoc capture 3

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #20 from tempel.jul...@gmail.com ---
Created attachment 144111
  --> https://bugs.freedesktop.org/attachment.cgi?id=144111=edit
hitman 2 renderdoc capture 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #19 from tempel.jul...@gmail.com ---
Created attachment 144110
  --> https://bugs.freedesktop.org/attachment.cgi?id=144110=edit
hitman 2 renderdoc capture 1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #18 from tempel.jul...@gmail.com ---
Compressing and uploading the capture is on its way.

Here are current screenshots showing the issue with latest mesa-git. When you
switch between the images, you can clearly see some shadows missing with radv
vs. amdvlk at the fence and at the trees in the background. This is completely
reproducible, such as the issue in HotS.
https://abload.de/img/amdvlk86jjt.png
https://abload.de/img/radvikk6c.png

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #17 from Samuel Pitoiset  ---
Yes, please attach a new trace.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

tempel.jul...@gmail.com changed:

   What|Removed |Added

Summary|small shadows are not drawn |small shadows are not drawn
   |in Heroes of the Storm  |in various games (shadow
   ||map bias issue?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109599] small shadows are not drawn in various games (shadow map bias issue?)

2019-04-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109599

--- Comment #16 from tempel.jul...@gmail.com ---
I changed the ticket title accordingly. Would a renderdoc capture for Hitman be
desirable?

If you're really mean (which I'm of course not, issue is hardly noticeable) you
could say that radv doesn't render lots of games correctly, so would an update
regarding the matter be possible? ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev