[Mesa-dev] [Bug 28577] Incorrect specular highlights on backfaces

2010-06-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28577

--- Comment #2 from Tim Evans t.ev...@aranz.com 2010-06-17 19:42:28 PDT ---
Created an attachment (id=36354)
 View: https://bugs.freedesktop.org/attachment.cgi?id=36354
 Review: https://bugs.freedesktop.org/review?bug=28577attachment=36354

Patch against mesa-7.8.2 that fixes this problem

In ss_tritmp.h, the backface specular values are copied into the vertex attrib
array using SS_SPEC. SS_SPEC converts the values from float [0,1] to uint8
[0,255], but the vertex attrib array is float, and the values are used as if
they were [0,1] later.  Changing the definition of SS_SPEC to COPY_4V fixes the
problem for me.  Attaching a patch to that effect.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [Bug 28577] Incorrect specular highlights on backfaces

2010-06-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28577

--- Comment #1 from Tim Evans t.ev...@aranz.com 2010-06-16 17:41:11 PDT ---
In case it matters, I've reproduced this problem on Mesa 7.7.1 and 7.8.1, both
on win32 with the GDI interface, compiled with Visual C++ 2008 with
optimisation disabled. My machine is running Windows Vista 64.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev