[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Timothy Arceri  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #18 from Timothy Arceri  ---
r600 + llvm is never going to be completed. Closing as won't fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Marc Dietrich marvi...@gmx.de changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #17 from Marc Dietrich marvi...@gmx.de ---
reopened because r600 is still missing sin/cos functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Tom Stellard tstel...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #16 from Tom Stellard tstel...@gmail.com 2012-06-19 10:15:01 PDT 
---
This bug is fixed in git by commit 7c005d5687eeca5b3115f69a681d21e61741c5dc

I pushed the sin/cos and dos2unix patches.  I think the third patch that
teaches the backend about r600 should be modified to include the changes
suggest by Alex.  If you want to respin the patch and send it to the mailing
list I'll review/commit it.

Thanks for the patches!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #4 from Tom Stellard tstel...@gmail.com 2012-06-18 06:39:24 PDT 
---
(In reply to comment #3)
 Just hit this bug with HoN.
 Apparently there is a pattern for AMDIL.sin, but not for AMDGPU.sin:
 
 class SIN_Common bits32 inst : R600_1OP 
   inst, SIN,
   [(set R600_Reg32:$dst, (int_AMDIL_sin R600_Reg32:$src))]{
   let Trig = 1;
 }

That pattern in the SIN_Common class is stale and should be removed.

For evergreen and newer, there is a pattern for int_AMGPU_sin:

def : TRIG_eg SIN_eg, int_AMDGPU_sin;

R700 chips normalize trigonometric inputs the same was as Evergreen+, so the
correct fix would be to create a SIN_r700 instruction and use the TRIG_eg class
to create a pattern for it.  This will also require adding a predicate to
identify r700 chips, because r600 normalizes the inputs differently.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #5 from Török Edwin edwin+m...@etorok.net 2012-06-18 10:24:59 PDT 
---
Created attachment 63183
  -- https://bugs.freedesktop.org/attachment.cgi?id=63183
SIN/COS_r700 as suggested

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #6 from Török Edwin edwin+m...@etorok.net 2012-06-18 10:28:38 PDT 
---
(In reply to comment #4)
 
 R700 chips normalize trigonometric inputs the same was as Evergreen+, so the
 correct fix would be to create a SIN_r700 instruction and use the TRIG_eg 
 class
 to create a pattern for it.

Thanks, the attached patch seems to fix the problem for me.

  This will also require adding a predicate to
 identify r700 chips, because r600 normalizes the inputs differently.

Oldest chip listed is OCL_DEVICE_RV710, so it would appear that R600_LLVM
only supports chips = RV710 and doesn't support R600 at all. Am I missing
something?
Anyway the patch checks for HD4XXX and = RV710.

(In reply to comment #5)
 Created attachment 63183 [details] [review]
 SIN/COS_r700 as suggested

This patch makes HoN stop crashing, but it'll actually fall back to using TGSI
(due to indirect addressing) so I don't know if the rendering would be correct.
Piglit tests about sin/cos pass though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #7 from Tom Stellard tstel...@gmail.com 2012-06-18 10:45:42 PDT 
---
(In reply to comment #6)
 (In reply to comment #4)
  
  R700 chips normalize trigonometric inputs the same was as Evergreen+, so the
  correct fix would be to create a SIN_r700 instruction and use the TRIG_eg 
  class
  to create a pattern for it.
 
 Thanks, the attached patch seems to fix the problem for me.
 
   This will also require adding a predicate to
  identify r700 chips, because r600 normalizes the inputs differently.
 
 Oldest chip listed is OCL_DEVICE_RV710, so it would appear that R600_LLVM
 only supports chips = RV710 and doesn't support R600 at all. Am I missing
 something?
 Anyway the patch checks for HD4XXX and = RV710.
 
Currently R600 chips are treated as RV710 chips, which is another bug.  To fix
this, we need to modify the r600_llvm_gpu_string() function in r600_llvm.c to
return r600 for R600 chips.  Then we need to add a processor type for it in
Processors.td, and finally we need to handle the r600 processor in
AMDIL7XXDevice.cpp (No need to create a AMDIL6XXDevice class). For R600
mDeviceFlag should be 0.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #8 from Tom Stellard tstel...@gmail.com 2012-06-18 10:57:31 PDT 
---
Comment on attachment 63183
  -- https://bugs.freedesktop.org/attachment.cgi?id=63183
SIN/COS_r700 as suggested

 
@@ -809,13 +812,21 @@ def RECIP_UINT_eg : RECIP_UINT_Common0x94;
 /* Evergreen / Cayman Instructions */
 /* --- */
 
-let Predicates = [isEGorCayman] in {
-  
 class TRIG_eg InstR600 trig, Intrinsic intr : Pat
   (intr R600_Reg32:$src),
   (trig (MUL (MOV_IMM_I32 (i32 ALU_LITERAL_X), CONST.TWO_PI_INV), 
 R600_Reg32:$src))
 ;
 
+let Predicates = [isR700] in {
+  /* R700 normalizes inputs to SIN/COS the same as EG */
+  def SIN_r700 : SIN_Common0x6E;
+  def COS_r700 : COS_Common0x6F;
+
+  def : TRIG_eg SIN_r700, int_AMDGPU_sin;
+  def : TRIG_eg COS_r700, int_AMDGPU_cos;
+}

Can you move these R700 instruction definitions above the Evergreen Only
instructions, so the chip definitions are in chronological order.  There should
also be an 'R700 Only Instructions' header comment similar to the 'Evergreen
Only' header.

Could you also delete the TRIG_HELPER_r700 class as well as the header comment
above it now that it is no longer needed.

Otherwise looks good. If possible, use git-format-patch when you repost.  It
will make it easier for me to commit and push.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Török Edwin edwin+m...@etorok.net changed:

   What|Removed |Added

  Attachment #63183|0   |1
is obsolete||

--- Comment #9 from Török Edwin edwin+m...@etorok.net 2012-06-18 11:42:11 PDT 
---
Created attachment 63186
  -- https://bugs.freedesktop.org/attachment.cgi?id=63186
v2 R700 sin/cos

moved instructions above EG. Also removed obsolete int_AMDGPU_cos pattern
similar to the sin one.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #10 from Török Edwin edwin+m...@etorok.net 2012-06-18 11:45:26 
PDT ---
Created attachment 63187
  -- https://bugs.freedesktop.org/attachment.cgi?id=63187
treat r600 separately from rv710

Note: Processors.td has wrong EOLs, you'll probably need to dos2unix before
applying this patch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #11 from Török Edwin edwin+m...@etorok.net 2012-06-18 11:46:11 
PDT ---
Created attachment 63188
  -- https://bugs.freedesktop.org/attachment.cgi?id=63188
dos2unix Processors.td

git doesn't like it otherwise.

To apply:
git am --ignore-whitespace 0002-radeon-llvm-fix-CR-LF.patch
git am 0003-radeon-llvm-treat-r600-separately-from-rv710.patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #12 from Török Edwin edwin+m...@etorok.net 2012-06-18 11:46:38 
PDT ---
(In reply to comment #8)
 
 Can you move these R700 instruction definitions above the Evergreen Only
 instructions, so the chip definitions are in chronological order.  There 
 should
 also be an 'R700 Only Instructions' header comment similar to the 'Evergreen
 Only' header.
 
 Could you also delete the TRIG_HELPER_r700 class as well as the header comment
 above it now that it is no longer needed.
 
 Otherwise looks good. If possible, use git-format-patch when you repost.  It
 will make it easier for me to commit and push.

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #13 from Török Edwin edwin+m...@etorok.net 2012-06-18 11:48:12 
PDT ---
(In reply to comment #7)

 Currently R600 chips are treated as RV710 chips, which is another bug.  To fix
 this, we need to modify the r600_llvm_gpu_string() function in r600_llvm.c to
 return r600 for R600 chips.  Then we need to add a processor type for it in
 Processors.td, and finally we need to handle the r600 processor in
 AMDIL7XXDevice.cpp (No need to create a AMDIL6XXDevice class). For R600
 mDeviceFlag should be 0.

Attached a patch for this, Processors.td has wrong EOLs though so you may need
to apply 0002 to clean up the CR/LF, and then 0003.

BTW I noticed that RV670 is treated as R700, but according to RadeonFeature on
the wiki thats a R600 class GPU. Which one is right?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #14 from Török Edwin edwin+m...@etorok.net 2012-06-18 11:49:37 
PDT ---
(In reply to comment #13)
 (In reply to comment #7)
 
  Currently R600 chips are treated as RV710 chips, which is another bug.  To 
  fix
  this, we need to modify the r600_llvm_gpu_string() function in r600_llvm.c 
  to
  return r600 for R600 chips.  Then we need to add a processor type for it 
  in
  Processors.td, and finally we need to handle the r600 processor in
  AMDIL7XXDevice.cpp (No need to create a AMDIL6XXDevice class). For R600
  mDeviceFlag should be 0.
 
 Attached a patch for this, Processors.td has wrong EOLs though so you may need
 to apply 0002 to clean up the CR/LF, and then 0003.
 
 BTW I noticed that RV670 is treated as R700, but according to RadeonFeature on
 the wiki thats a R600 class GPU. Which one is right?

Also I don't have a R600 to test, and this probably doesn't fix sin/cos on the
R600, so I'll leave that for someone else to fix.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #15 from Alex Deucher ag...@yahoo.com 2012-06-18 20:56:16 PDT ---
(In reply to comment #13)
 BTW I noticed that RV670 is treated as R700, but according to RadeonFeature on
 the wiki thats a R600 class GPU. Which one is right?

We probably need to add several strings for r6xx asics as there are some slight
variants between the various r6xx asics.  Something like:

r600 - R600
rv6xx - RV610, RV630, RV620, RV635, RS780, RS880
rv670 - RV670

RV670 supports doubles and a couple of other features that are not supported by
other r6xx asics.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Török Edwin edwin+m...@etorok.net changed:

   What|Removed |Added

 CC||edwin+m...@etorok.net

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #1 from Laurent carlier lordhea...@gmail.com 2012-06-12 08:23:59 
PDT ---
Amnesia game also hit that error with llvm

OpenGL renderer string: Gallium 0.4 on AMD RV770
OpenGL version string: 2.1 Mesa 8.1-devel (git-529476b)

R6000_LLVM=0 workaround the problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

--- Comment #2 from Thomas Capricelli or...@freehackers.org 2012-06-12 
14:19:56 PDT ---
Hit by this bug when trying flightgear on latest
libdrm/mesa/xorg-server/xf86-video-ati. All compiled today from
git/svn/whatever:

LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Thomas Capricelli or...@freehackers.org changed:

   What|Removed |Added

 CC||or...@freehackers.org

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 50317] [r600g+llvm] Piglit test failures: LLVM ERROR: Cannot select: target intrinsic %llvm.AMDGPU.sin

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50317

Kai k...@dev.carbon-project.org changed:

   What|Removed |Added

 CC||tstel...@gmail.com

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev