Re: [Mesa-dev] [PATCH] Don't fail if libX11 isn't installed
Hi, On 10 October 2012 01:07, Dan Nicholson dbn.li...@gmail.com wrote: On Oct 8, 2012 10:49 PM, Matt Turner matts...@gmail.com wrote: Wow, it's been like that since 2008. Reviewed-by: Matt Turner matts...@gmail.com Originally configure basically supported only GLX either through DRI or Xlib, so Xlib was basically required. Not so much nowadays. Reviewed-by: Dan Nicholson dbn.li...@gmail.com Thanks for the reviews - can someone please push this? Cheers, Daniel ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Don't fail if libX11 isn't installed
On 10/14/2012 06:26 PM, Daniel Stone wrote: Hi, On 10 October 2012 01:07, Dan Nicholson dbn.li...@gmail.com wrote: On Oct 8, 2012 10:49 PM, Matt Turner matts...@gmail.com wrote: Wow, it's been like that since 2008. Reviewed-by: Matt Turner matts...@gmail.com Originally configure basically supported only GLX either through DRI or Xlib, so Xlib was basically required. Not so much nowadays. Reviewed-by: Dan Nicholson dbn.li...@gmail.com Thanks for the reviews - can someone please push this? Cheers, Daniel Pushed. Sorry this got overlooked! --Ken ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Don't fail if libX11 isn't installed
On Oct 8, 2012 10:49 PM, Matt Turner matts...@gmail.com wrote: On Mon, Oct 8, 2012 at 8:27 PM, Daniel Stone dan...@fooishbar.org wrote: configure.ac would previously refuse to complete if libX11 wasn't installed, even if we'd disabled GLX and weren't building an X11 EGL platform. Make the check simply set the no_x variable that's used (but never set) immediately below for what looks like this very case. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 72c2b8c..8b727c0 100644 --- a/configure.ac +++ b/configure.ac @@ -816,7 +816,7 @@ if test x$enable_dri = xyes; then fi dnl Find out if X is available. -PKG_CHECK_MODULES([X11], [x11]) +PKG_CHECK_MODULES([X11], [x11], [no_x=no], [no_x=yes]) dnl Try to tell the user that the --x-* options are only used when dnl pkg-config is not available. This must be right after AC_PATH_XTRA. -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev Wow, it's been like that since 2008. Reviewed-by: Matt Turner matts...@gmail.com Originally configure basically supported only GLX either through DRI or Xlib, so Xlib was basically required. Not so much nowadays. Reviewed-by: Dan Nicholson dbn.li...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] Don't fail if libX11 isn't installed
configure.ac would previously refuse to complete if libX11 wasn't installed, even if we'd disabled GLX and weren't building an X11 EGL platform. Make the check simply set the no_x variable that's used (but never set) immediately below for what looks like this very case. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 72c2b8c..8b727c0 100644 --- a/configure.ac +++ b/configure.ac @@ -816,7 +816,7 @@ if test x$enable_dri = xyes; then fi dnl Find out if X is available. -PKG_CHECK_MODULES([X11], [x11]) +PKG_CHECK_MODULES([X11], [x11], [no_x=no], [no_x=yes]) dnl Try to tell the user that the --x-* options are only used when dnl pkg-config is not available. This must be right after AC_PATH_XTRA. -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] Don't fail if libX11 isn't installed
On Mon, Oct 8, 2012 at 8:27 PM, Daniel Stone dan...@fooishbar.org wrote: configure.ac would previously refuse to complete if libX11 wasn't installed, even if we'd disabled GLX and weren't building an X11 EGL platform. Make the check simply set the no_x variable that's used (but never set) immediately below for what looks like this very case. Signed-off-by: Daniel Stone dan...@fooishbar.org --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 72c2b8c..8b727c0 100644 --- a/configure.ac +++ b/configure.ac @@ -816,7 +816,7 @@ if test x$enable_dri = xyes; then fi dnl Find out if X is available. -PKG_CHECK_MODULES([X11], [x11]) +PKG_CHECK_MODULES([X11], [x11], [no_x=no], [no_x=yes]) dnl Try to tell the user that the --x-* options are only used when dnl pkg-config is not available. This must be right after AC_PATH_XTRA. -- 1.7.10.4 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev Wow, it's been like that since 2008. Reviewed-by: Matt Turner matts...@gmail.com ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
