Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Dylan Baker
Quoting Marek Olšák (2018-12-04 12:21:58)
> There is still the issue that DEBUG is not defined in debug builds if I set
> CFLAGS and CXXFLAGS.
> 
> Marek

What does you command line look like, and what version of meson do you have?

I can do:
$ CFLAGS=-Dfoobar CXXFLAGS=-Dfoobar meson build -Dbuildtype=debug
$ grep 'DDEBUG' build/build.ninja

and I see 2055 definitions of -DDEBUG

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Marek Olšák
There is still the issue that DEBUG is not defined in debug builds if I set
CFLAGS and CXXFLAGS.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [PATCH] build: remove autotools

2018-12-04 Thread Eric Engestrom
On Monday, 2018-12-03 09:31:21 -0800, Dylan Baker wrote:
> There are now no known distributions using autotools, meson has all of
> the features that autotools does. We don't need two build systems to do
> exactly the same thing, meson is faster, easier to maintain, and used by
> more devs than autotools. Let's reduce the ongoing burden of maintaining
> autotools.
> 
> This removes the following:
>  - configure.ac
>  - autogen.sh
>  - Makefile.*.am
>  - Makefile.am
>  - Makefile.sources (which are used only by autotools)
>  - travis jobs for autotools
>  - docs for autotools
>  - .gitignore
> ---
> 
> Eric, can I make a really strange and selfish request and send out the 
> version I
> wrote last week? I know it seems strange, but after all the work I've done to
> get meson going it would be very satisfying to me to push the remove-autotools
> patch.

Of course! As much as I'd love to be the one to pull the trigger, you
deserve it way more ;)

> 
> This differs from Eric's patch AFAICT in that it removes the travis jobs and 
> the
> Makefile.sources files that are not used by android or scons

Could you re-send it with --irreversible-delete to remove the diffs of
the 200+ files that were simply deleted? This is quire hard to review
right now :(

> diff --git a/.travis.yml b/.travis.yml
> index 6b50d49e143..f659a22ed5d 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -59,7 +59,7 @@ matrix:
>  - env:
>  - LABEL="meson loaders/classic DRI"
>  - BUILD=meson
> -- DRI_DRIVERS="i915,i965,r100,r200,swrast,nouveau"
> +- DRI_DRIVERS="swrast,i915,i965,r100,r200,swrast,nouveau"

Unrelated changed, and a no-op I believe?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev