Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
Rob Clark writes: > On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote: >> >> Rob Clark writes: >> >> > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner >> > wrote: >> >> >> >> Use u_transfer_helper_resource_create(..) instead which uses the >> >> resource_create(..) function specified in u_transfer_vtbl. >> >> >> >> Signed-off-by: Christian Gmeiner >> >> --- >> >> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c >> >> b/src/gallium/auxiliary/util/u_transfer_helper.c >> >> index 14c4d56392d..a5c3c026e71 100644 >> >> --- a/src/gallium/auxiliary/util/u_transfer_helper.c >> >> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c >> >> @@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx, >> >> .depth0 = 1, >> >> .array_size = 1, >> >> }; >> >> - trans->ss = pscreen->resource_create(pscreen, ); >> >> + trans->ss = u_transfer_helper_resource_create(pscreen, ); >> > >> > >> > So I *think* the thinking here was to use pscreen->resource_create() >> > in case there are multiple things the transfer-helper has to deal >> > with, like MSAA+RGTC.. >> > >> > (I can't guarantee that actually works.. but that was the reasoning..) >> >> So, I believe that pscreen->resource_create should be set to >> u_transfer_helper_resource_create if you're using u_transfer_helper. >> freedreno, v3d, iris, panfrost all do this. vc4 doesn't but that's just >> a bug that doesn't matter becuase it doesn't do rgtc or z32fs8. >> >> If you've wrapped something around pscreen->resource_create's call of >> u_transfer_helper_resource_create for some reason, then I think you'd >> still want to have that called from the MSAA map path. > > Ahh, good point.. so I guess this change should be fine. Although > also not entirely clear about what it is fixing? What I'm saying is I think the unpatched code is actually best, though. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote: > > Rob Clark writes: > > > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner > > wrote: > >> > >> Use u_transfer_helper_resource_create(..) instead which uses the > >> resource_create(..) function specified in u_transfer_vtbl. > >> > >> Signed-off-by: Christian Gmeiner > >> --- > >> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c > >> b/src/gallium/auxiliary/util/u_transfer_helper.c > >> index 14c4d56392d..a5c3c026e71 100644 > >> --- a/src/gallium/auxiliary/util/u_transfer_helper.c > >> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c > >> @@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx, > >> .depth0 = 1, > >> .array_size = 1, > >> }; > >> - trans->ss = pscreen->resource_create(pscreen, ); > >> + trans->ss = u_transfer_helper_resource_create(pscreen, ); > > > > > > So I *think* the thinking here was to use pscreen->resource_create() > > in case there are multiple things the transfer-helper has to deal > > with, like MSAA+RGTC.. > > > > (I can't guarantee that actually works.. but that was the reasoning..) > > So, I believe that pscreen->resource_create should be set to > u_transfer_helper_resource_create if you're using u_transfer_helper. > freedreno, v3d, iris, panfrost all do this. vc4 doesn't but that's just > a bug that doesn't matter becuase it doesn't do rgtc or z32fs8. > > If you've wrapped something around pscreen->resource_create's call of > u_transfer_helper_resource_create for some reason, then I think you'd > still want to have that called from the MSAA map path. Ahh, good point.. so I guess this change should be fine. Although also not entirely clear about what it is fixing? BR, -R > -BEGIN PGP SIGNATURE- > > iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyKrPoACgkQtdYpNtH8 > nuj64g//ZbahuV6CRilGDBPUNbKCJP9Pp7GErDqgNWZgrc0tAJ+xLLFLyJ/WZXzz > ThH4OfLgjcUQ1k+tHC/hftJBpqWsFzFYG+d9LsDLdqlbGB0anzILCaNtpzhj9AoW > 0GXahC724XlXU+V6qVxTPPXzvaAaDqZHfyBAgiUAorS/Wvdkc2ECtZuFk+1LcfHx > xdlyKankMuo0sghMBOF+npncW9J2fgya3UW43GD/DvcHckzd0eUuGkUNPOZduvAU > BaD3xlQI2RcwxPPFatrQejDBYcOBxF1FFa6oUN6E5MuOWULKcYBvrdNxIpLvBEMv > cC+dRqTDdoVZtXeTmB6BegFYo2ujq9xk+jy+OosAcIrJl9mhHi4ghbFGCVzs45ei > WeiN13RXH5jfBDdO/Yj3KmI1UzDGLL5Ef1THTD3mm8RpoYBndZ5HGUvYjpw3GGeS > 83RVOhVoNaA0ZmU9APj3ohkAnFNPcWWUTti7VPkZECznwD+OC/4fbFMAqGtGwfPM > gS12v5L3+JoYUpM49SbEEMi60mM9goGyag/AMAfa55ffbgc9r6ddZitG0+uwQ7/E > iLBlYxCHnpx5mtpmfEi4riLMCTq5R668K+2dHX1C6h2hizzmfnNuzYVWnZJOflZ3 > rKbBg6DeNkTBLry6y8o+UqQPzezbvtzu/Iu0EMHIWBUM8yX18ZI= > =u3ZV > -END PGP SIGNATURE- ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
Rob Clark writes: > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner > wrote: >> >> Use u_transfer_helper_resource_create(..) instead which uses the >> resource_create(..) function specified in u_transfer_vtbl. >> >> Signed-off-by: Christian Gmeiner >> --- >> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c >> b/src/gallium/auxiliary/util/u_transfer_helper.c >> index 14c4d56392d..a5c3c026e71 100644 >> --- a/src/gallium/auxiliary/util/u_transfer_helper.c >> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c >> @@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx, >> .depth0 = 1, >> .array_size = 1, >> }; >> - trans->ss = pscreen->resource_create(pscreen, ); >> + trans->ss = u_transfer_helper_resource_create(pscreen, ); > > > So I *think* the thinking here was to use pscreen->resource_create() > in case there are multiple things the transfer-helper has to deal > with, like MSAA+RGTC.. > > (I can't guarantee that actually works.. but that was the reasoning..) So, I believe that pscreen->resource_create should be set to u_transfer_helper_resource_create if you're using u_transfer_helper. freedreno, v3d, iris, panfrost all do this. vc4 doesn't but that's just a bug that doesn't matter becuase it doesn't do rgtc or z32fs8. If you've wrapped something around pscreen->resource_create's call of u_transfer_helper_resource_create for some reason, then I think you'd still want to have that called from the MSAA map path. signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
Hi Eric > > Use u_transfer_helper_resource_create(..) instead which uses the > > resource_create(..) function specified in u_transfer_vtbl. > > I would need to run this through the CTS, as the stacking in > u_transfer_helper is fragile. What's fixed for you by this patch? I am playing around with u_transfer_helper stuff for etnaviv and just run over it. I need that change for my 'lets try to use u_transfer_helper for tile resolve blits' but piglit is not happy about it. So if i ever get it working I will resend this patch within a patch series. But good to know that u_transfer_helper is fragile :) -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
Christian Gmeiner writes: > Use u_transfer_helper_resource_create(..) instead which uses the > resource_create(..) function specified in u_transfer_vtbl. I would need to run this through the CTS, as the stacking in u_transfer_helper is fragile. What's fixed for you by this patch? signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner
wrote:
>
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c
> b/src/gallium/auxiliary/util/u_transfer_helper.c
> index 14c4d56392d..a5c3c026e71 100644
> --- a/src/gallium/auxiliary/util/u_transfer_helper.c
> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c
> @@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx,
> .depth0 = 1,
> .array_size = 1,
> };
> - trans->ss = pscreen->resource_create(pscreen, );
> + trans->ss = u_transfer_helper_resource_create(pscreen, );
So I *think* the thinking here was to use pscreen->resource_create()
in case there are multiple things the transfer-helper has to deal
with, like MSAA+RGTC..
(I can't guarantee that actually works.. but that was the reasoning..)
BR,
-R
> if (!trans->ss) {
>free(trans);
>return NULL;
> --
> 2.20.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
On Friday, March 1, 2019 7:55:18 AM PST Christian Gmeiner wrote:
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c
> b/src/gallium/auxiliary/util/u_transfer_helper.c
> index 14c4d56392d..a5c3c026e71 100644
> --- a/src/gallium/auxiliary/util/u_transfer_helper.c
> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c
> @@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx,
> .depth0 = 1,
> .array_size = 1,
> };
> - trans->ss = pscreen->resource_create(pscreen, );
> + trans->ss = u_transfer_helper_resource_create(pscreen, );
> if (!trans->ss) {
>free(trans);
>return NULL;
>
Reviewed-by: Kenneth Graunke
signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
Am Fr., 1. März 2019 um 16:54 Uhr schrieb Christian Gmeiner
:
>
> Use u_transfer_helper_resource_create(..) instead which uses the
> resource_create(..) function specified in u_transfer_vtbl.
>
> Signed-off-by: Christian Gmeiner
> ---
> src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c
> b/src/gallium/auxiliary/util/u_transfer_helper.c
> index 14c4d56392d..a5c3c026e71 100644
> --- a/src/gallium/auxiliary/util/u_transfer_helper.c
> +++ b/src/gallium/auxiliary/util/u_transfer_helper.c
> @@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx,
> .depth0 = 1,
> .array_size = 1,
> };
> - trans->ss = pscreen->resource_create(pscreen, );
> + trans->ss = u_transfer_helper_resource_create(pscreen, );
> if (!trans->ss) {
>free(trans);
>return NULL;
> --
> 2.20.1
>
ping
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly
Use u_transfer_helper_resource_create(..) instead which uses the
resource_create(..) function specified in u_transfer_vtbl.
Signed-off-by: Christian Gmeiner
---
src/gallium/auxiliary/util/u_transfer_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/util/u_transfer_helper.c
b/src/gallium/auxiliary/util/u_transfer_helper.c
index 14c4d56392d..a5c3c026e71 100644
--- a/src/gallium/auxiliary/util/u_transfer_helper.c
+++ b/src/gallium/auxiliary/util/u_transfer_helper.c
@@ -182,7 +182,7 @@ transfer_map_msaa(struct pipe_context *pctx,
.depth0 = 1,
.array_size = 1,
};
- trans->ss = pscreen->resource_create(pscreen, );
+ trans->ss = u_transfer_helper_resource_create(pscreen, );
if (!trans->ss) {
free(trans);
return NULL;
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
