Re: [Mesa-dev] [PATCH] gallium: work around libtool relink issue for libdrm

[Emil Velikov]

On 5 March 2018 at 16:41, Roman Gilg  wrote:
> This is similar to commit 90633079. libtool links first to system directories
> instead of custom locations of libdrm on relinking. Since a more recent libdrm
> version than the one provided by the system is often needed when compiling
> mesa, make sure this works by putting libdrm in front.
>
> See also: https://bugs.freedesktop.org/show_bug.cgi?id=100259
>
> Signed-off-by: Roman Gilg 
> ---
>  src/gallium/targets/dri/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/targets/dri/Makefile.am 
> b/src/gallium/targets/dri/Makefile.am
> index 1d05d91..509faff 100644
> --- a/src/gallium/targets/dri/Makefile.am
> +++ b/src/gallium/targets/dri/Makefile.am
> @@ -52,9 +52,9 @@ gallium_dri_la_LIBADD = \
> $(top_builddir)/src/gallium/drivers/rbug/librbug.la \
> $(top_builddir)/src/gallium/drivers/trace/libtrace.la \
> $(top_builddir)/src/mapi/shared-glapi/libglapi.la \
> +   $(LIBDRM_LIBS) \
> $(SELINUX_LIBS) \
> $(EXPAT_LIBS) \
> -   $(LIBDRM_LIBS) \
> $(GALLIUM_COMMON_LIB_DEPS)
>
It feels like a fragile workaround, although it will have no negative effects.
Hence - ship it ;-)

Reviewed-by: Emil Velikov 

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium: work around libtool relink issue for libdrm

[Roman Gilg]

This is similar to commit 90633079. libtool links first to system directories
instead of custom locations of libdrm on relinking. Since a more recent libdrm
version than the one provided by the system is often needed when compiling
mesa, make sure this works by putting libdrm in front.

See also: https://bugs.freedesktop.org/show_bug.cgi?id=100259

Signed-off-by: Roman Gilg 
---
 src/gallium/targets/dri/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/targets/dri/Makefile.am 
b/src/gallium/targets/dri/Makefile.am
index 1d05d91..509faff 100644
--- a/src/gallium/targets/dri/Makefile.am
+++ b/src/gallium/targets/dri/Makefile.am
@@ -52,9 +52,9 @@ gallium_dri_la_LIBADD = \
$(top_builddir)/src/gallium/drivers/rbug/librbug.la \
$(top_builddir)/src/gallium/drivers/trace/libtrace.la \
$(top_builddir)/src/mapi/shared-glapi/libglapi.la \
+   $(LIBDRM_LIBS) \
$(SELINUX_LIBS) \
$(EXPAT_LIBS) \
-   $(LIBDRM_LIBS) \
$(GALLIUM_COMMON_LIB_DEPS)
 
 EXTRA_gallium_dri_la_DEPENDENCIES = \
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev