Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2
Choose a well-named branch on your mesa repository that you will use to
trigger i965 CI builds. Provide me with the branch name and the repo
details, and I will configure the build.
When you force-push to the branch, your build will start. You will get
a notification when the build starts, and when it finishes. Results
will appear on mesa-ci.01.org a few minutes after the final
notification.
Erik Faye-Lund writes:
> On Tue, 2018-12-04 at 10:33 -0800, Mark Janes wrote:
>> Tested-by: Mark Janes
>>
>> Erik Faye-Lund writes:
>>
>> > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's
>> > make
>> > sure the enums are accepted.
>> >
>> > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums
>> > before gles3"
>> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
>> > Signed-off-by: Erik Faye-Lund
>> > ---
>> > Whoops, seems I missed an extension to enable RG-textures. Sorry
>> > for the
>> > breakage!
>>
>> You are welcome to test on the i965 CI, which will quickly catch
>> these
>> errors for you.
>
> I would love to! How do I do that?
>
> I can't see an obvious way of triggering something here:
> https://mesa-ci.01.org/
>
>>
>> > src/mesa/main/context.h | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
>> > index cdda8cf2012..7de10e9924b 100644
>> > --- a/src/mesa/main/context.h
>> > +++ b/src/mesa/main/context.h
>> > @@ -378,7 +378,8 @@ _mesa_has_packed_float(const struct gl_context
>> > *ctx)
>> > static inline bool
>> > _mesa_has_rg_textures(const struct gl_context *ctx)
>> > {
>> > - return _mesa_has_ARB_texture_rg(ctx) || _mesa_is_gles3(ctx);
>> > + return _mesa_has_ARB_texture_rg(ctx) ||
>> > _mesa_has_EXT_texture_rg(ctx) ||
>> > + _mesa_is_gles3(ctx);
>> > }
>> >
>> > static inline bool
>> > --
>> > 2.19.2
>> ___
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2
On Tue, 2018-12-04 at 10:33 -0800, Mark Janes wrote:
> Tested-by: Mark Janes
>
> Erik Faye-Lund writes:
>
> > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's
> > make
> > sure the enums are accepted.
> >
> > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums
> > before gles3"
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
> > Signed-off-by: Erik Faye-Lund
> > ---
> > Whoops, seems I missed an extension to enable RG-textures. Sorry
> > for the
> > breakage!
>
> You are welcome to test on the i965 CI, which will quickly catch
> these
> errors for you.
I would love to! How do I do that?
I can't see an obvious way of triggering something here:
https://mesa-ci.01.org/
>
> > src/mesa/main/context.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
> > index cdda8cf2012..7de10e9924b 100644
> > --- a/src/mesa/main/context.h
> > +++ b/src/mesa/main/context.h
> > @@ -378,7 +378,8 @@ _mesa_has_packed_float(const struct gl_context
> > *ctx)
> > static inline bool
> > _mesa_has_rg_textures(const struct gl_context *ctx)
> > {
> > - return _mesa_has_ARB_texture_rg(ctx) || _mesa_is_gles3(ctx);
> > + return _mesa_has_ARB_texture_rg(ctx) ||
> > _mesa_has_EXT_texture_rg(ctx) ||
> > + _mesa_is_gles3(ctx);
> > }
> >
> > static inline bool
> > --
> > 2.19.2
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2
Thanks, pushed :)
On Tue, 2018-12-04 at 15:03 -0500, Marek Olšák wrote:
> Reviewed-by: Marek Olšák
>
> Marek
>
> On Tue, Dec 4, 2018 at 6:51 AM Erik Faye-Lund <
> erik.faye-l...@collabora.com> wrote:
> > rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's
> > make
> > sure the enums are accepted.
> >
> > Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums
> > before gles3"
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
> > Signed-off-by: Erik Faye-Lund
> > ---
> > Whoops, seems I missed an extension to enable RG-textures. Sorry
> > for the
> > breakage!
> >
> > src/mesa/main/context.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
> > index cdda8cf2012..7de10e9924b 100644
> > --- a/src/mesa/main/context.h
> > +++ b/src/mesa/main/context.h
> > @@ -378,7 +378,8 @@ _mesa_has_packed_float(const struct gl_context
> > *ctx)
> > static inline bool
> > _mesa_has_rg_textures(const struct gl_context *ctx)
> > {
> > - return _mesa_has_ARB_texture_rg(ctx) || _mesa_is_gles3(ctx);
> > + return _mesa_has_ARB_texture_rg(ctx) ||
> > _mesa_has_EXT_texture_rg(ctx) ||
> > + _mesa_is_gles3(ctx);
> > }
> >
> > static inline bool
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2
Reviewed-by: Marek Olšák
Marek
On Tue, Dec 4, 2018 at 6:51 AM Erik Faye-Lund
wrote:
> rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make
> sure the enums are accepted.
>
> Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3"
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
> Signed-off-by: Erik Faye-Lund
> ---
> Whoops, seems I missed an extension to enable RG-textures. Sorry for the
> breakage!
>
> src/mesa/main/context.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
> index cdda8cf2012..7de10e9924b 100644
> --- a/src/mesa/main/context.h
> +++ b/src/mesa/main/context.h
> @@ -378,7 +378,8 @@ _mesa_has_packed_float(const struct gl_context *ctx)
> static inline bool
> _mesa_has_rg_textures(const struct gl_context *ctx)
> {
> - return _mesa_has_ARB_texture_rg(ctx) || _mesa_is_gles3(ctx);
> + return _mesa_has_ARB_texture_rg(ctx) || _mesa_has_EXT_texture_rg(ctx)
> ||
> + _mesa_is_gles3(ctx);
> }
>
> static inline bool
> --
> 2.19.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2
Tested-by: Mark Janes
Erik Faye-Lund writes:
> rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make
> sure the enums are accepted.
>
> Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3"
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
> Signed-off-by: Erik Faye-Lund
> ---
> Whoops, seems I missed an extension to enable RG-textures. Sorry for the
> breakage!
You are welcome to test on the i965 CI, which will quickly catch these
errors for you.
> src/mesa/main/context.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
> index cdda8cf2012..7de10e9924b 100644
> --- a/src/mesa/main/context.h
> +++ b/src/mesa/main/context.h
> @@ -378,7 +378,8 @@ _mesa_has_packed_float(const struct gl_context *ctx)
> static inline bool
> _mesa_has_rg_textures(const struct gl_context *ctx)
> {
> - return _mesa_has_ARB_texture_rg(ctx) || _mesa_is_gles3(ctx);
> + return _mesa_has_ARB_texture_rg(ctx) || _mesa_has_EXT_texture_rg(ctx) ||
> + _mesa_is_gles3(ctx);
> }
>
> static inline bool
> --
> 2.19.2
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] mesa/main: fix up _mesa_has_rg_textures for gles2
rg-textures are supported in GLES 2.0 if EXT_texture_rg, so let's make
sure the enums are accepted.
Fixes: 510b6424607 "mesa/main: do not allow rg-textures enums before gles3"
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108936
Signed-off-by: Erik Faye-Lund
---
Whoops, seems I missed an extension to enable RG-textures. Sorry for the
breakage!
src/mesa/main/context.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
index cdda8cf2012..7de10e9924b 100644
--- a/src/mesa/main/context.h
+++ b/src/mesa/main/context.h
@@ -378,7 +378,8 @@ _mesa_has_packed_float(const struct gl_context *ctx)
static inline bool
_mesa_has_rg_textures(const struct gl_context *ctx)
{
- return _mesa_has_ARB_texture_rg(ctx) || _mesa_is_gles3(ctx);
+ return _mesa_has_ARB_texture_rg(ctx) || _mesa_has_EXT_texture_rg(ctx) ||
+ _mesa_is_gles3(ctx);
}
static inline bool
--
2.19.2
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
