Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

[Kai Wasserbäch]

Hey Thomas,
Thomas Hellstrom wrote on 07.09.2017 10:53:
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as not-rendered-to,
> the idea being that it should be marked as "rendered-to" again as soon as
> any rendering was touching the front.
>
> Now the latter part never happened, because it was part of a state
> validation and we never marked that part of the state as dirty.
>
> So mark the framebuffer state dirty after a frontbuffer flush.
> (fdo bugzilla 102496)
>
> Signed-off-by: Thomas Hellstrom 
> Tested-by: Dieter Nützel 
> Tested-by: Bruce Cherniak 
> Tested-By: Gert Wollny 

I think the customary lines for bug references and fixed commits are:

 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102496
 Fixes: eceb671002 (mesa/st: Reduce the number of frontbuffer flush calls)

As those get picked up by the scripts for eg. stable management. You might want
to use those tags.

Cheers,
Kai




signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

[Emil Velikov]

Hi Thomas,

On 7 September 2017 at 09:53, Thomas Hellstrom  wrote:
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as not-rendered-to,
> the idea being that it should be marked as "rendered-to" again as soon as
> any rendering was touching the front.
>
> Now the latter part never happened, because it was part of a state
> validation and we never marked that part of the state as dirty.
>
> So mark the framebuffer state dirty after a frontbuffer flush.
> (fdo bugzilla 102496)
>
Please use the following tags.
They will help us reference the bug in the release notes and we can
track exactly where the fix is needed.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102496
Fixes: eceb6710024 ("mesa/st: Reduce the number of frontbuffer flush calls")

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

[Marek Olšák]

Reviewed-by: Marek Olšák 

Marek

On Thu, Sep 7, 2017 at 10:53 AM, Thomas Hellstrom  wrote:
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as not-rendered-to,
> the idea being that it should be marked as "rendered-to" again as soon as
> any rendering was touching the front.
>
> Now the latter part never happened, because it was part of a state
> validation and we never marked that part of the state as dirty.
>
> So mark the framebuffer state dirty after a frontbuffer flush.
> (fdo bugzilla 102496)
>
> Signed-off-by: Thomas Hellstrom 
> Tested-by: Dieter Nützel 
> Tested-by: Bruce Cherniak 
> Tested-By: Gert Wollny 
> ---
>  src/mesa/state_tracker/st_manager.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_manager.c 
> b/src/mesa/state_tracker/st_manager.c
> index 07c430d..6c7d836 100644
> --- a/src/mesa/state_tracker/st_manager.c
> +++ b/src/mesa/state_tracker/st_manager.c
> @@ -1044,6 +1044,9 @@ st_manager_flush_frontbuffer(struct st_context *st)
>stfb->iface->flush_front(>iface, stfb->iface,
> ST_ATTACHMENT_FRONT_LEFT);
>strb->defined = GL_FALSE;
> +
> +  /* Trigger an update of strb->defined on next draw */
> +  st->dirty |= ST_NEW_FB_STATE;
> }
>  }
>
> --
> 2.7.4
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

[Cherniak, Bruce]

Reviewed-by: Bruce Cherniak  

> On Sep 7, 2017, at 3:53 AM, Thomas Hellstrom  wrote:
> 
> This fixes a regression introduced with commit
> eceb6710024716433069d705fbd873d6d136c2cc:
> "mesa/st: Reduce the number of frontbuffer flush calls"
> where we, after flushing the front buffer marked it as not-rendered-to,
> the idea being that it should be marked as "rendered-to" again as soon as
> any rendering was touching the front.
> 
> Now the latter part never happened, because it was part of a state
> validation and we never marked that part of the state as dirty.
> 
> So mark the framebuffer state dirty after a frontbuffer flush.
> (fdo bugzilla 102496)
> 
> Signed-off-by: Thomas Hellstrom 
> Tested-by: Dieter Nützel 
> Tested-by: Bruce Cherniak 
> Tested-By: Gert Wollny 
> ---
> src/mesa/state_tracker/st_manager.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/state_tracker/st_manager.c 
> b/src/mesa/state_tracker/st_manager.c
> index 07c430d..6c7d836 100644
> --- a/src/mesa/state_tracker/st_manager.c
> +++ b/src/mesa/state_tracker/st_manager.c
> @@ -1044,6 +1044,9 @@ st_manager_flush_frontbuffer(struct st_context *st)
>   stfb->iface->flush_front(>iface, stfb->iface,
>ST_ATTACHMENT_FRONT_LEFT);
>   strb->defined = GL_FALSE;
> +
> +  /* Trigger an update of strb->defined on next draw */
> +  st->dirty |= ST_NEW_FB_STATE;
>}
> }
> 
> -- 
> 2.7.4
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] mesa/st: Fix frontbuffer rendering regression

[Thomas Hellstrom]

This fixes a regression introduced with commit
eceb6710024716433069d705fbd873d6d136c2cc:
"mesa/st: Reduce the number of frontbuffer flush calls"
where we, after flushing the front buffer marked it as not-rendered-to,
the idea being that it should be marked as "rendered-to" again as soon as
any rendering was touching the front.

Now the latter part never happened, because it was part of a state
validation and we never marked that part of the state as dirty.

So mark the framebuffer state dirty after a frontbuffer flush.
(fdo bugzilla 102496)

Signed-off-by: Thomas Hellstrom 
Tested-by: Dieter Nützel 
Tested-by: Bruce Cherniak 
Tested-By: Gert Wollny 
---
 src/mesa/state_tracker/st_manager.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/state_tracker/st_manager.c 
b/src/mesa/state_tracker/st_manager.c
index 07c430d..6c7d836 100644
--- a/src/mesa/state_tracker/st_manager.c
+++ b/src/mesa/state_tracker/st_manager.c
@@ -1044,6 +1044,9 @@ st_manager_flush_frontbuffer(struct st_context *st)
   stfb->iface->flush_front(>iface, stfb->iface,
ST_ATTACHMENT_FRONT_LEFT);
   strb->defined = GL_FALSE;
+
+  /* Trigger an update of strb->defined on next draw */
+  st->dirty |= ST_NEW_FB_STATE;
}
 }
 
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev