Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
Sorry about that, I've only used git email maybe three times in my life :)
On 2019-07-15 10:09 a.m., Michel Dänzer wrote:
> On 2019-07-15 3:58 p.m., Jeremy Newton wrote:
>> Thanks Marek and Michel, see the updated patch below:
> FYI, this kind of commentary should be after the --- line, or it will be
> included as part of the Git commit log by tools like "git am".
>
>
>> The amdgpu dri is used for the closed source AMD driver. Since this driver
>> does not implement multimedia, we fall back to radeonsi in mesa to do
>> multimedia. This corrects the Gallium driver name for when it is set to
>> amdgpu.
>>
>> This will allow dropping the amdgpu-pro specific GBM implementation in
>> favour of Mesa's libgbm.
>>
>> Signed-off-by: Jeremy Newton
>> Signed-off-by: Marek Olšák
>> Reviewed-by: Michel Dänzer
>> ---
>> src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
>> b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
>> index 960d63b2c31..6e889539c92 100644
>> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
>> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
>> @@ -194,6 +194,11 @@ pipe_loader_drm_probe_fd_nodup(struct
>> pipe_loader_device **dev, int fd)
>> if (!ddev->base.driver_name)
>> goto fail;
>>
>> + if (strcmp(ddev->base.driver_name, "amdgpu") == 0) {
>> + FREE(ddev->base.driver_name);
>> + ddev->base.driver_name = strdup("radeonsi");
>> + }
>> +
>> struct util_dl_library **plib = NULL;
>> #ifndef GALLIUM_STATIC_TARGETS
>> plib = >lib;
>>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
Am 15.07.19 um 16:15 schrieb Michel Dänzer: On 2019-07-15 4:11 p.m., Newton, Jeremy wrote: Sorry about that, I've only used git email maybe three times in my life :) Nothing to apologize for, everybody has to learn that kind of thing. :) To be honest even after more than a decade I still get this wrong from time to time. So really don't worry about stuff like that :) Christian. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
On 2019-07-15 at 16:01, Jeremy Newton wrote:
> Thanks Marek and Michel, see the updated patch below:
>
> The amdgpu dri is used for the closed source AMD driver. Since this driver
> does not implement multimedia, we fall back to radeonsi in mesa to do
> multimedia. This corrects the Gallium driver name for when it is set to
> amdgpu.
>
> This will allow dropping the amdgpu-pro specific GBM implementation in
> favour of Mesa's libgbm.
>
> Signed-off-by: Jeremy Newton
> Signed-off-by: Marek Olšák
> Reviewed-by: Michel Dänzer
All the tools expect valid email addresses; could you please fix those?
> ---
> src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> index 960d63b2c31..6e889539c92 100644
> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> @@ -194,6 +194,11 @@ pipe_loader_drm_probe_fd_nodup(struct
> pipe_loader_device **dev, int fd)
> if (!ddev->base.driver_name)
>goto fail;
>
> + if (strcmp(ddev->base.driver_name, "amdgpu") == 0) {
> + FREE(ddev->base.driver_name);
> + ddev->base.driver_name = strdup("radeonsi");
> + }
> +
> struct util_dl_library **plib = NULL;
> #ifndef GALLIUM_STATIC_TARGETS
> plib = >lib;
> --
> 2.20.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
On 2019-07-15 4:11 p.m., Newton, Jeremy wrote: > Sorry about that, I've only used git email maybe three times in my life :) Nothing to apologize for, everybody has to learn that kind of thing. :) -- Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
Sorry about that, I've only used git email maybe three times in my life :)
On Mon, Jul 15, 2019 at 10:00 AM Jeremy Newton wrote:
> Thanks Marek and Michel, see the updated patch below:
>
> The amdgpu dri is used for the closed source AMD driver. Since this driver
> does not implement multimedia, we fall back to radeonsi in mesa to do
> multimedia. This corrects the Gallium driver name for when it is set to
> amdgpu.
>
> This will allow dropping the amdgpu-pro specific GBM implementation in
> favour of Mesa's libgbm.
>
> Signed-off-by: Jeremy Newton
> Signed-off-by: Marek Olšák
> Reviewed-by: Michel Dänzer
> ---
> src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> index 960d63b2c31..6e889539c92 100644
> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> @@ -194,6 +194,11 @@ pipe_loader_drm_probe_fd_nodup(struct
> pipe_loader_device **dev, int fd)
> if (!ddev->base.driver_name)
>goto fail;
>
> + if (strcmp(ddev->base.driver_name, "amdgpu") == 0) {
> + FREE(ddev->base.driver_name);
> + ddev->base.driver_name = strdup("radeonsi");
> + }
> +
> struct util_dl_library **plib = NULL;
> #ifndef GALLIUM_STATIC_TARGETS
> plib = >lib;
> --
> 2.20.1
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
On 2019-07-15 3:58 p.m., Jeremy Newton wrote:
> Thanks Marek and Michel, see the updated patch below:
FYI, this kind of commentary should be after the --- line, or it will be
included as part of the Git commit log by tools like "git am".
> The amdgpu dri is used for the closed source AMD driver. Since this driver
> does not implement multimedia, we fall back to radeonsi in mesa to do
> multimedia. This corrects the Gallium driver name for when it is set to
> amdgpu.
>
> This will allow dropping the amdgpu-pro specific GBM implementation in
> favour of Mesa's libgbm.
>
> Signed-off-by: Jeremy Newton
> Signed-off-by: Marek Olšák
> Reviewed-by: Michel Dänzer
> ---
> src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> index 960d63b2c31..6e889539c92 100644
> --- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> +++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
> @@ -194,6 +194,11 @@ pipe_loader_drm_probe_fd_nodup(struct pipe_loader_device
> **dev, int fd)
> if (!ddev->base.driver_name)
>goto fail;
>
> + if (strcmp(ddev->base.driver_name, "amdgpu") == 0) {
> + FREE(ddev->base.driver_name);
> + ddev->base.driver_name = strdup("radeonsi");
> + }
> +
> struct util_dl_library **plib = NULL;
> #ifndef GALLIUM_STATIC_TARGETS
> plib = >lib;
>
--
Earthling Michel Dänzer | https://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
Thanks Marek and Michel, see the updated patch below:
The amdgpu dri is used for the closed source AMD driver. Since this driver
does not implement multimedia, we fall back to radeonsi in mesa to do
multimedia. This corrects the Gallium driver name for when it is set to
amdgpu.
This will allow dropping the amdgpu-pro specific GBM implementation in
favour of Mesa's libgbm.
Signed-off-by: Jeremy Newton
Signed-off-by: Marek Olšák
Reviewed-by: Michel Dänzer
---
src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
index 960d63b2c31..6e889539c92 100644
--- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
+++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
@@ -194,6 +194,11 @@ pipe_loader_drm_probe_fd_nodup(struct pipe_loader_device
**dev, int fd)
if (!ddev->base.driver_name)
goto fail;
+ if (strcmp(ddev->base.driver_name, "amdgpu") == 0) {
+ FREE(ddev->base.driver_name);
+ ddev->base.driver_name = strdup("radeonsi");
+ }
+
struct util_dl_library **plib = NULL;
#ifndef GALLIUM_STATIC_TARGETS
plib = >lib;
--
2.20.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
On 2019-07-11 8:08 p.m., Marek Olšák wrote: > From: Jeremy Newton > > The amdgpu dri is used for the closed source AMD driver. Since this driver > does not implement multimedia, we fall back to radeonsi in mesa to do > multimedia. This corrects the dri driver name for when it is set to amdgpu. "Gallium driver name" instead of "dri driver name" might make it slightly clearer why this is done. Also, might be worth adding something to the commit log that this will allow dropping the amdgpu-pro specific GBM implementation in favour of Mesa's. Either way, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | https://www.amd.com Libre software enthusiast | Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] pipe-loader: use radeonsi for MM if amdgpu dri is used
From: Jeremy Newton
The amdgpu dri is used for the closed source AMD driver. Since this driver
does not implement multimedia, we fall back to radeonsi in mesa to do
multimedia. This corrects the dri driver name for when it is set to amdgpu.
Signed-off-by: Jeremy Newton
Signed-off-by: Marek Olšák
---
src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
index 960d63b2c31..6e889539c92 100644
--- a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
+++ b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c
@@ -187,20 +187,25 @@ pipe_loader_drm_probe_fd_nodup(struct pipe_loader_device
**dev, int fd)
} else {
ddev->base.type = PIPE_LOADER_DEVICE_PLATFORM;
}
ddev->base.ops = _loader_drm_ops;
ddev->fd = fd;
ddev->base.driver_name = loader_get_driver_for_fd(fd);
if (!ddev->base.driver_name)
goto fail;
+ if (strcmp(ddev->base.driver_name, "amdgpu") == 0) {
+ FREE(ddev->base.driver_name);
+ ddev->base.driver_name = strdup("radeonsi");
+ }
+
struct util_dl_library **plib = NULL;
#ifndef GALLIUM_STATIC_TARGETS
plib = >lib;
#endif
ddev->dd = get_driver_descriptor(ddev->base.driver_name, plib);
if (!ddev->dd)
goto fail;
*dev = >base;
return true;
--
2.17.1
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
