Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10-bit VP9 decode
Please ping Leo Liu since I'm currently on vacation. Christian. Am 05.07.2019 10:55 schrieb "Vishwakarma, Pratik" : On 6/28/2019 12:32 PM, Christian König wrote: > Am 28.06.19 um 07:09 schrieb Vishwakarma, Pratik: >> Fix si_vid_is_format_supported to expose support >> for 10-bit VP9 decode using P016 format. Without >> this change, 10-bit decode will be exposed only >> for HEVC even though newer hardware support >> 10-bit decode for VP9. >> >> Signed-off-by: Pratik Vishwakarma > > Reviewed-by: Christian König Thanks Christian. How to get this patch merged? > >> --- >> src/gallium/drivers/radeonsi/si_get.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/gallium/drivers/radeonsi/si_get.c >> b/src/gallium/drivers/radeonsi/si_get.c >> index 4e23d283ab7..8cc5933f9bc 100644 >> --- a/src/gallium/drivers/radeonsi/si_get.c >> +++ b/src/gallium/drivers/radeonsi/si_get.c >> @@ -709,6 +709,10 @@ static boolean si_vid_is_format_supported(struct >> pipe_screen *screen, >> return (format == PIPE_FORMAT_NV12) || >> (format == PIPE_FORMAT_P016); >> +/* Vp9 profile 2 supports 10 bit decoding using P016 */ >> +if (profile == PIPE_VIDEO_PROFILE_VP9_PROFILE2) >> +return format == PIPE_FORMAT_P016; >> + >> /* we can only handle this one with UVD */ >> if (profile != PIPE_VIDEO_PROFILE_UNKNOWN) >> return format == PIPE_FORMAT_NV12; > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10-bit VP9 decode
On 6/28/2019 12:32 PM, Christian König wrote: > Am 28.06.19 um 07:09 schrieb Vishwakarma, Pratik: >> Fix si_vid_is_format_supported to expose support >> for 10-bit VP9 decode using P016 format. Without >> this change, 10-bit decode will be exposed only >> for HEVC even though newer hardware support >> 10-bit decode for VP9. >> >> Signed-off-by: Pratik Vishwakarma > > Reviewed-by: Christian König Thanks Christian. How to get this patch merged? > >> --- >> src/gallium/drivers/radeonsi/si_get.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/gallium/drivers/radeonsi/si_get.c >> b/src/gallium/drivers/radeonsi/si_get.c >> index 4e23d283ab7..8cc5933f9bc 100644 >> --- a/src/gallium/drivers/radeonsi/si_get.c >> +++ b/src/gallium/drivers/radeonsi/si_get.c >> @@ -709,6 +709,10 @@ static boolean si_vid_is_format_supported(struct >> pipe_screen *screen, >> return (format == PIPE_FORMAT_NV12) || >> (format == PIPE_FORMAT_P016); >> + /* Vp9 profile 2 supports 10 bit decoding using P016 */ >> + if (profile == PIPE_VIDEO_PROFILE_VP9_PROFILE2) >> + return format == PIPE_FORMAT_P016; >> + >> /* we can only handle this one with UVD */ >> if (profile != PIPE_VIDEO_PROFILE_UNKNOWN) >> return format == PIPE_FORMAT_NV12; > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10-bit VP9 decode
Am 28.06.19 um 07:09 schrieb Vishwakarma, Pratik: Fix si_vid_is_format_supported to expose support for 10-bit VP9 decode using P016 format. Without this change, 10-bit decode will be exposed only for HEVC even though newer hardware support 10-bit decode for VP9. Signed-off-by: Pratik Vishwakarma Reviewed-by: Christian König --- src/gallium/drivers/radeonsi/si_get.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 4e23d283ab7..8cc5933f9bc 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium/drivers/radeonsi/si_get.c @@ -709,6 +709,10 @@ static boolean si_vid_is_format_supported(struct pipe_screen *screen, return (format == PIPE_FORMAT_NV12) || (format == PIPE_FORMAT_P016); + /* Vp9 profile 2 supports 10 bit decoding using P016 */ + if (profile == PIPE_VIDEO_PROFILE_VP9_PROFILE2) + return format == PIPE_FORMAT_P016; + /* we can only handle this one with UVD */ if (profile != PIPE_VIDEO_PROFILE_UNKNOWN) return format == PIPE_FORMAT_NV12; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] radeonsi: Expose support for 10-bit VP9 decode
Fix si_vid_is_format_supported to expose support for 10-bit VP9 decode using P016 format. Without this change, 10-bit decode will be exposed only for HEVC even though newer hardware support 10-bit decode for VP9. Signed-off-by: Pratik Vishwakarma --- src/gallium/drivers/radeonsi/si_get.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 4e23d283ab7..8cc5933f9bc 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium/drivers/radeonsi/si_get.c @@ -709,6 +709,10 @@ static boolean si_vid_is_format_supported(struct pipe_screen *screen, return (format == PIPE_FORMAT_NV12) || (format == PIPE_FORMAT_P016); + /* Vp9 profile 2 supports 10 bit decoding using P016 */ + if (profile == PIPE_VIDEO_PROFILE_VP9_PROFILE2) + return format == PIPE_FORMAT_P016; + /* we can only handle this one with UVD */ if (profile != PIPE_VIDEO_PROFILE_UNKNOWN) return format == PIPE_FORMAT_NV12; -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH] radeonsi: Expose support for 10 bit VP9 decode
On 2019-06-26 11:56 p.m., Vishwakarma, Pratik wrote: > Fix si_vid_is_format_supported to expose > support for 10-bit VP9 decode using P016 format You could have a better commit message here, like what it will cause by missing this patch. Regards, Leo > > Signed-off-by: Pratik Vishwakarma > --- > src/gallium/drivers/radeonsi/si_get.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/drivers/radeonsi/si_get.c > b/src/gallium/drivers/radeonsi/si_get.c > index 4e23d283ab7..8cc5933f9bc 100644 > --- a/src/gallium/drivers/radeonsi/si_get.c > +++ b/src/gallium/drivers/radeonsi/si_get.c > @@ -709,6 +709,10 @@ static boolean si_vid_is_format_supported(struct > pipe_screen *screen, > return (format == PIPE_FORMAT_NV12) || > (format == PIPE_FORMAT_P016); > > + /* Vp9 profile 2 supports 10 bit decoding using P016 */ > + if (profile == PIPE_VIDEO_PROFILE_VP9_PROFILE2) > + return format == PIPE_FORMAT_P016; > + > /* we can only handle this one with UVD */ > if (profile != PIPE_VIDEO_PROFILE_UNKNOWN) > return format == PIPE_FORMAT_NV12; ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] radeonsi: Expose support for 10 bit VP9 decode
Fix si_vid_is_format_supported to expose support for 10-bit VP9 decode using P016 format Signed-off-by: Pratik Vishwakarma --- src/gallium/drivers/radeonsi/si_get.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_get.c b/src/gallium/drivers/radeonsi/si_get.c index 4e23d283ab7..8cc5933f9bc 100644 --- a/src/gallium/drivers/radeonsi/si_get.c +++ b/src/gallium/drivers/radeonsi/si_get.c @@ -709,6 +709,10 @@ static boolean si_vid_is_format_supported(struct pipe_screen *screen, return (format == PIPE_FORMAT_NV12) || (format == PIPE_FORMAT_P016); + /* Vp9 profile 2 supports 10 bit decoding using P016 */ + if (profile == PIPE_VIDEO_PROFILE_VP9_PROFILE2) + return format == PIPE_FORMAT_P016; + /* we can only handle this one with UVD */ if (profile != PIPE_VIDEO_PROFILE_UNKNOWN) return format == PIPE_FORMAT_NV12; -- 2.17.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
