Re: [Mesa-dev] [PATCH] vulkan: do not expose surface/swapchain extensions on Android

2018-03-05 Thread Jason Ekstrand 
Reviewed-by: Jason Ekstrand 

At some point, we could add some code to the XML parser to parse extension
dependencies and maybe do this automatically.  However, that's a pile of
work to avoid a two-line change so let's not bother for now.

On Mon, Mar 5, 2018 at 8:46 AM, Tapani Pälli  wrote:

> On Android surface/swapchain extensions are implemented by the loader.
> Patch
> modifies both anv and radv extension scripts disabling currently exposed
> ones. See also earlier commit 9f763c1f9b.
>
> Signed-off-by: Tapani Pälli 
> ---
>  src/amd/vulkan/radv_extensions.py  | 4 ++--
>  src/intel/vulkan/anv_extensions.py | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_extensions.py b/src/amd/vulkan/radv_
> extensions.py
> index 92b1ea3e14..6a323ea9b0 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -65,9 +65,9 @@ EXTENSIONS = [
>  Extension('VK_KHR_external_semaphore_fd', 1,
> 'device->rad_info.has_syncobj'),
>  Extension('VK_KHR_get_memory_requirements2',  1, True),
>  Extension('VK_KHR_get_physical_device_properties2',   1, True),
> -Extension('VK_KHR_get_surface_capabilities2', 1, True),
> +Extension('VK_KHR_get_surface_capabilities2', 1,
> 'RADV_HAS_SURFACE'),
>  Extension('VK_KHR_image_format_list', 1, True),
> -Extension('VK_KHR_incremental_present',   1, True),
> +Extension('VK_KHR_incremental_present',   1,
> 'RADV_HAS_SURFACE'),
>  Extension('VK_KHR_maintenance1',  1, True),
>  Extension('VK_KHR_maintenance2',  1, True),
>  Extension('VK_KHR_push_descriptor',   1, True),
> diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_
> extensions.py
> index 8d39038c43..4e5af7da2a 100644
> --- a/src/intel/vulkan/anv_extensions.py
> +++ b/src/intel/vulkan/anv_extensions.py
> @@ -68,7 +68,7 @@ EXTENSIONS = [
>  Extension('VK_KHR_get_physical_device_properties2',   1, True),
>  Extension('VK_KHR_get_surface_capabilities2', 1,
> 'ANV_HAS_SURFACE'),
>  Extension('VK_KHR_image_format_list', 1, True),
> -Extension('VK_KHR_incremental_present',   1, True),
> +Extension('VK_KHR_incremental_present',   1,
> 'ANV_HAS_SURFACE'),
>  Extension('VK_KHR_maintenance1',  1, True),
>  Extension('VK_KHR_maintenance2',  1, True),
>  Extension('VK_KHR_push_descriptor',   1, True),
> --
> 2.13.6
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] vulkan: do not expose surface/swapchain extensions on Android

2018-03-05 Thread Tapani Pälli 
On Android surface/swapchain extensions are implemented by the loader. Patch
modifies both anv and radv extension scripts disabling currently exposed
ones. See also earlier commit 9f763c1f9b.

Signed-off-by: Tapani Pälli 
---
 src/amd/vulkan/radv_extensions.py  | 4 ++--
 src/intel/vulkan/anv_extensions.py | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/amd/vulkan/radv_extensions.py 
b/src/amd/vulkan/radv_extensions.py
index 92b1ea3e14..6a323ea9b0 100644
--- a/src/amd/vulkan/radv_extensions.py
+++ b/src/amd/vulkan/radv_extensions.py
@@ -65,9 +65,9 @@ EXTENSIONS = [
 Extension('VK_KHR_external_semaphore_fd', 1, 
'device->rad_info.has_syncobj'),
 Extension('VK_KHR_get_memory_requirements2',  1, True),
 Extension('VK_KHR_get_physical_device_properties2',   1, True),
-Extension('VK_KHR_get_surface_capabilities2', 1, True),
+Extension('VK_KHR_get_surface_capabilities2', 1, 
'RADV_HAS_SURFACE'),
 Extension('VK_KHR_image_format_list', 1, True),
-Extension('VK_KHR_incremental_present',   1, True),
+Extension('VK_KHR_incremental_present',   1, 
'RADV_HAS_SURFACE'),
 Extension('VK_KHR_maintenance1',  1, True),
 Extension('VK_KHR_maintenance2',  1, True),
 Extension('VK_KHR_push_descriptor',   1, True),
diff --git a/src/intel/vulkan/anv_extensions.py 
b/src/intel/vulkan/anv_extensions.py
index 8d39038c43..4e5af7da2a 100644
--- a/src/intel/vulkan/anv_extensions.py
+++ b/src/intel/vulkan/anv_extensions.py
@@ -68,7 +68,7 @@ EXTENSIONS = [
 Extension('VK_KHR_get_physical_device_properties2',   1, True),
 Extension('VK_KHR_get_surface_capabilities2', 1, 
'ANV_HAS_SURFACE'),
 Extension('VK_KHR_image_format_list', 1, True),
-Extension('VK_KHR_incremental_present',   1, True),
+Extension('VK_KHR_incremental_present',   1, 
'ANV_HAS_SURFACE'),
 Extension('VK_KHR_maintenance1',  1, True),
 Extension('VK_KHR_maintenance2',  1, True),
 Extension('VK_KHR_push_descriptor',   1, True),
-- 
2.13.6

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev