Re: [Mesa-dev] [PATCH 0/6] Update mesa state handling past VAO changes.
The series LGTM. Reviewed-by: Brian Paul On 05/12/2019 07:05 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, The series is a collection of comment updates and state handling cleanup past the VAO changes that went into mesa. There are two fixes for potential bugs in state handling included. There were no reports accoring that, and it does not change the outcome of intels CI. please review best Mathias Mathias Fröhlich (6): mesa/vbo: Update Comment to what is actually happening. mesa: Fix old outdated variable name in a comment. mesa: Make _mesa_set_varying_vp_inputs static in state.c. mesa: Fix test for setting the _NEW_VARYING_VP_INPUTS flag. mesa: Avoid setting _NEW_VARYING_VP_INPUTS in non fixed function mode. mesa: Set _NEW_VARYING_VP_INPUTS iff varying_vp_inputs are set. src/mesa/main/ff_fragment_shader.cpp | 2 ++ src/mesa/main/ffvertex_prog.c| 3 +++ src/mesa/main/state.c| 38 +++- src/mesa/main/state.h| 6 + src/mesa/vbo/vbo_exec_draw.c | 4 +-- 5 files changed, 27 insertions(+), 26 deletions(-) -- 2.21.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH 0/6] Update mesa state handling past VAO changes.
From: Mathias Fröhlich Hi Brian, The series is a collection of comment updates and state handling cleanup past the VAO changes that went into mesa. There are two fixes for potential bugs in state handling included. There were no reports accoring that, and it does not change the outcome of intels CI. please review best Mathias Mathias Fröhlich (6): mesa/vbo: Update Comment to what is actually happening. mesa: Fix old outdated variable name in a comment. mesa: Make _mesa_set_varying_vp_inputs static in state.c. mesa: Fix test for setting the _NEW_VARYING_VP_INPUTS flag. mesa: Avoid setting _NEW_VARYING_VP_INPUTS in non fixed function mode. mesa: Set _NEW_VARYING_VP_INPUTS iff varying_vp_inputs are set. src/mesa/main/ff_fragment_shader.cpp | 2 ++ src/mesa/main/ffvertex_prog.c| 3 +++ src/mesa/main/state.c| 38 +++- src/mesa/main/state.h| 6 + src/mesa/vbo/vbo_exec_draw.c | 4 +-- 5 files changed, 27 insertions(+), 26 deletions(-) -- 2.21.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev