Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

2017-08-28 Thread Leo Liu 



On 08/28/2017 04:53 AM, Emil Velikov wrote:

On 28 August 2017 at 03:33, Leo Liu  wrote:

On 08/27/2017 01:52 PM, Emil Velikov wrote:

On 25 August 2017 at 18:17, Leo Liu  wrote:

Signed-off-by: Leo Liu 
---
   src/gallium/drivers/radeon/radeon_uvd.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeon/radeon_uvd.c
b/src/gallium/drivers/radeon/radeon_uvd.c
index 648a493b59..228f654af1 100644
--- a/src/gallium/drivers/radeon/radeon_uvd.c
+++ b/src/gallium/drivers/radeon/radeon_uvd.c
@@ -969,7 +969,7 @@ static void get_mjpeg_slice_header(struct
ruvd_decoder *dec, struct pipe_mjpeg_p
  continue;

  buf[size++] = i;
-   memcpy((buf + size),
>quantization_table.quantiser_table, 64);
+   memcpy((buf + size),
>quantization_table.quantiser_table[i], 64);

Can you mention a bit in the commit message "The index was missing"
and add a Fixes/stable tag?

Sure. Is "Fixes" enough ? since the original patch this fix based on is not
in stable branch yet.


Fixes should be enough, but sometimes it's not easy to track exact
offending commit.
Here that's easy ;-)

Fixes: 130d1f456b8 ("radeon/uvd: reconstruct MJPEG bitstream")


Same here, and will squash it in the commit message when committed.

Thanks,
Leo


Thanks
Emil


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

2017-08-28 Thread Emil Velikov 
On 28 August 2017 at 03:33, Leo Liu  wrote:
> On 08/27/2017 01:52 PM, Emil Velikov wrote:
>>
>> On 25 August 2017 at 18:17, Leo Liu  wrote:
>>>
>>> Signed-off-by: Leo Liu 
>>> ---
>>>   src/gallium/drivers/radeon/radeon_uvd.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/gallium/drivers/radeon/radeon_uvd.c
>>> b/src/gallium/drivers/radeon/radeon_uvd.c
>>> index 648a493b59..228f654af1 100644
>>> --- a/src/gallium/drivers/radeon/radeon_uvd.c
>>> +++ b/src/gallium/drivers/radeon/radeon_uvd.c
>>> @@ -969,7 +969,7 @@ static void get_mjpeg_slice_header(struct
>>> ruvd_decoder *dec, struct pipe_mjpeg_p
>>>  continue;
>>>
>>>  buf[size++] = i;
>>> -   memcpy((buf + size),
>>> >quantization_table.quantiser_table, 64);
>>> +   memcpy((buf + size),
>>> >quantization_table.quantiser_table[i], 64);
>>
>> Can you mention a bit in the commit message "The index was missing"
>> and add a Fixes/stable tag?
>
> Sure. Is "Fixes" enough ? since the original patch this fix based on is not
> in stable branch yet.
>
Fixes should be enough, but sometimes it's not easy to track exact
offending commit.
Here that's easy ;-)

Fixes: 130d1f456b8 ("radeon/uvd: reconstruct MJPEG bitstream")

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

2017-08-27 Thread Leo Liu 



On 08/27/2017 01:52 PM, Emil Velikov wrote:

On 25 August 2017 at 18:17, Leo Liu  wrote:

Signed-off-by: Leo Liu 
---
  src/gallium/drivers/radeon/radeon_uvd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeon/radeon_uvd.c 
b/src/gallium/drivers/radeon/radeon_uvd.c
index 648a493b59..228f654af1 100644
--- a/src/gallium/drivers/radeon/radeon_uvd.c
+++ b/src/gallium/drivers/radeon/radeon_uvd.c
@@ -969,7 +969,7 @@ static void get_mjpeg_slice_header(struct ruvd_decoder 
*dec, struct pipe_mjpeg_p
 continue;

 buf[size++] = i;
-   memcpy((buf + size), >quantization_table.quantiser_table, 
64);
+   memcpy((buf + size), 
>quantization_table.quantiser_table[i], 64);

Can you mention a bit in the commit message "The index was missing"
and add a Fixes/stable tag?
Sure. Is "Fixes" enough ? since the original patch this fix based on is 
not in stable branch yet.


Leo



There's no point in re-sending, just for ^^. Feel free to squash locally.

Thanks
Emil


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

2017-08-27 Thread Emil Velikov 
On 25 August 2017 at 18:17, Leo Liu  wrote:
> Signed-off-by: Leo Liu 
> ---
>  src/gallium/drivers/radeon/radeon_uvd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeon/radeon_uvd.c 
> b/src/gallium/drivers/radeon/radeon_uvd.c
> index 648a493b59..228f654af1 100644
> --- a/src/gallium/drivers/radeon/radeon_uvd.c
> +++ b/src/gallium/drivers/radeon/radeon_uvd.c
> @@ -969,7 +969,7 @@ static void get_mjpeg_slice_header(struct ruvd_decoder 
> *dec, struct pipe_mjpeg_p
> continue;
>
> buf[size++] = i;
> -   memcpy((buf + size), 
> >quantization_table.quantiser_table, 64);
> +   memcpy((buf + size), 
> >quantization_table.quantiser_table[i], 64);
Can you mention a bit in the commit message "The index was missing"
and add a Fixes/stable tag?
There's no point in re-sending, just for ^^. Feel free to squash locally.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] radeon/uvd: fix MJPEG quantization table index

2017-08-25 Thread Leo Liu 
Signed-off-by: Leo Liu 
---
 src/gallium/drivers/radeon/radeon_uvd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeon/radeon_uvd.c 
b/src/gallium/drivers/radeon/radeon_uvd.c
index 648a493b59..228f654af1 100644
--- a/src/gallium/drivers/radeon/radeon_uvd.c
+++ b/src/gallium/drivers/radeon/radeon_uvd.c
@@ -969,7 +969,7 @@ static void get_mjpeg_slice_header(struct ruvd_decoder 
*dec, struct pipe_mjpeg_p
continue;
 
buf[size++] = i;
-   memcpy((buf + size), >quantization_table.quantiser_table, 
64);
+   memcpy((buf + size), 
>quantization_table.quantiser_table[i], 64);
size += 64;
}
 
-- 
2.11.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev