Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-30 Thread Ian Romanick 
I sent a couple small comments on patches 3 and 4.  Barring any actual
problems there, the series is

Reviewed-by: Ian Romanick 

On 11/29/2017 11:23 AM, Emil Velikov wrote:
> From: Emil Velikov 
> 
> The extension was never implemented and seemingly never will.
> The DRI based libGL dropped support for it over 10 years ago.
> 
> Cc: Brian Paul 
> Cc: Ian Romanick 
> Signed-off-by: Emil Velikov 
> ---
>  src/mesa/drivers/x11/fakeglx.c | 26 --
>  src/mesa/drivers/x11/glxapi.c  | 35 ---
>  src/mesa/drivers/x11/glxapi.h  |  7 ---
>  3 files changed, 68 deletions(-)
> 
> diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c
> index d2a099f9a20..8902a7cd667 100644
> --- a/src/mesa/drivers/x11/fakeglx.c
> +++ b/src/mesa/drivers/x11/fakeglx.c
> @@ -2759,28 +2759,6 @@ Fake_glXSet3DfxModeMESA( int mode )
>  
>  
>  
> -/*** GLX_NV_vertex_array range ***/
> -static void *
> -Fake_glXAllocateMemoryNV( GLsizei size,
> -  GLfloat readFrequency,
> -  GLfloat writeFrequency,
> -  GLfloat priority )
> -{
> -   (void) size;
> -   (void) readFrequency;
> -   (void) writeFrequency;
> -   (void) priority;
> -   return NULL;
> -}
> -
> -
> -static void 
> -Fake_glXFreeMemoryNV( GLvoid *pointer )
> -{
> -   (void) pointer;
> -}
> -
> -
>  /*** GLX_MESA_agp_offset ***/
>  
>  static GLuint
> @@ -3009,10 +2987,6 @@ _mesa_GetGLXDispatchTable(void)
> /*** GLX_MESA_set_3dfx_mode ***/
> glx.Set3DfxModeMESA = Fake_glXSet3DfxModeMESA;
>  
> -   /*** GLX_NV_vertex_array_range ***/
> -   glx.AllocateMemoryNV = Fake_glXAllocateMemoryNV;
> -   glx.FreeMemoryNV = Fake_glXFreeMemoryNV;
> -
> /*** GLX_MESA_agp_offset ***/
> glx.GetAGPOffsetMESA = Fake_glXGetAGPOffsetMESA;
>  
> diff --git a/src/mesa/drivers/x11/glxapi.c b/src/mesa/drivers/x11/glxapi.c
> index 52e60265697..ff8b2b2ce16 100644
> --- a/src/mesa/drivers/x11/glxapi.c
> +++ b/src/mesa/drivers/x11/glxapi.c
> @@ -1019,37 +1019,6 @@ glXSet3DfxModeMESA(int mode)
>  
>  
>  
> -/*** GLX_NV_vertex_array_range ***/
> -
> -void PUBLIC *
> -glXAllocateMemoryNV( GLsizei size,
> - GLfloat readFrequency,
> - GLfloat writeFrequency,
> - GLfloat priority )
> -{
> -   struct _glxapi_table *t;
> -   Display *dpy = glXGetCurrentDisplay();
> -   GET_DISPATCH(dpy, t);
> -   if (!t)
> -  return NULL;
> -   return t->AllocateMemoryNV(size, readFrequency, writeFrequency, priority);
> -}
> -
> -
> -void PUBLIC
> -glXFreeMemoryNV( GLvoid *pointer )
> -{
> -   struct _glxapi_table *t;
> -   Display *dpy = glXGetCurrentDisplay();
> -   GET_DISPATCH(dpy, t);
> -   if (!t)
> -  return;
> -   t->FreeMemoryNV(pointer);
> -}
> -
> -
> -
> -
>  /*** GLX_MESA_agp_offset */
>  
>  GLuint PUBLIC
> @@ -1288,10 +1257,6 @@ static struct name_address_pair GLX_functions[] = {
> /*** GLX_ARB_get_proc_address ***/
> { "glXGetProcAddressARB", (__GLXextFuncPtr) glXGetProcAddressARB },
>  
> -   /*** GLX_NV_vertex_array_range ***/
> -   { "glXAllocateMemoryNV", (__GLXextFuncPtr) glXAllocateMemoryNV },
> -   { "glXFreeMemoryNV", (__GLXextFuncPtr) glXFreeMemoryNV },
> -
> /*** GLX_MESA_agp_offset ***/
> { "glXGetAGPOffsetMESA", (__GLXextFuncPtr) glXGetAGPOffsetMESA },
>  
> diff --git a/src/mesa/drivers/x11/glxapi.h b/src/mesa/drivers/x11/glxapi.h
> index cc4f902925b..a4930b10dca 100644
> --- a/src/mesa/drivers/x11/glxapi.h
> +++ b/src/mesa/drivers/x11/glxapi.h
> @@ -186,13 +186,6 @@ struct _glxapi_table {
> /*** GLX_MESA_set_3dfx_mode ***/
> Bool (*Set3DfxModeMESA)(int mode);
>  
> -   /*** GLX_NV_vertex_array_range ***/
> -   void * (*AllocateMemoryNV)( GLsizei size,
> -   GLfloat readFrequency,
> -   GLfloat writeFrequency,
> -   GLfloat priority );
> -   void (*FreeMemoryNV)( GLvoid *pointer );
> -
> /*** GLX_MESA_agp_offset ***/
> GLuint (*GetAGPOffsetMESA)( const GLvoid *pointer );
>  
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-30 Thread Emil Velikov 
On 29 November 2017 at 20:41, Adam Jackson  wrote:
> On Wed, 2017-11-29 at 19:23 +, Emil Velikov wrote:
>> From: Emil Velikov 
>>
>> The extension was never implemented and seemingly never will.
>> The DRI based libGL dropped support for it over 10 years ago.
>
> Series is:
>
> Reviewed-by: Adam Jackson 
>
Thank for the confirmation Adam.

> There's some stubs in src/glx/glxcmds.c that can go in the bin too.
>
Yes, GLX_MESA_pixmap_colormap bits are for the the next "delete some
code" round ;-)

-Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-29 Thread Adam Jackson 
On Wed, 2017-11-29 at 19:23 +, Emil Velikov wrote:
> From: Emil Velikov 
> 
> The extension was never implemented and seemingly never will.
> The DRI based libGL dropped support for it over 10 years ago.

Series is:

Reviewed-by: Adam Jackson 

There's some stubs in src/glx/glxcmds.c that can go in the bin too.

- ajax
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-29 Thread Brian Paul 

Series looks OK to me.

Reviewed-by: Brian Paul 

On 11/29/2017 12:23 PM, Emil Velikov wrote:

From: Emil Velikov 

The extension was never implemented and seemingly never will.
The DRI based libGL dropped support for it over 10 years ago.

Cc: Brian Paul 
Cc: Ian Romanick 
Signed-off-by: Emil Velikov 
---
  src/mesa/drivers/x11/fakeglx.c | 26 --
  src/mesa/drivers/x11/glxapi.c  | 35 ---
  src/mesa/drivers/x11/glxapi.h  |  7 ---
  3 files changed, 68 deletions(-)

diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c
index d2a099f9a20..8902a7cd667 100644
--- a/src/mesa/drivers/x11/fakeglx.c
+++ b/src/mesa/drivers/x11/fakeglx.c
@@ -2759,28 +2759,6 @@ Fake_glXSet3DfxModeMESA( int mode )



-/*** GLX_NV_vertex_array range ***/
-static void *
-Fake_glXAllocateMemoryNV( GLsizei size,
-  GLfloat readFrequency,
-  GLfloat writeFrequency,
-  GLfloat priority )
-{
-   (void) size;
-   (void) readFrequency;
-   (void) writeFrequency;
-   (void) priority;
-   return NULL;
-}
-
-
-static void
-Fake_glXFreeMemoryNV( GLvoid *pointer )
-{
-   (void) pointer;
-}
-
-
  /*** GLX_MESA_agp_offset ***/

  static GLuint
@@ -3009,10 +2987,6 @@ _mesa_GetGLXDispatchTable(void)
 /*** GLX_MESA_set_3dfx_mode ***/
 glx.Set3DfxModeMESA = Fake_glXSet3DfxModeMESA;

-   /*** GLX_NV_vertex_array_range ***/
-   glx.AllocateMemoryNV = Fake_glXAllocateMemoryNV;
-   glx.FreeMemoryNV = Fake_glXFreeMemoryNV;
-
 /*** GLX_MESA_agp_offset ***/
 glx.GetAGPOffsetMESA = Fake_glXGetAGPOffsetMESA;

diff --git a/src/mesa/drivers/x11/glxapi.c b/src/mesa/drivers/x11/glxapi.c
index 52e60265697..ff8b2b2ce16 100644
--- a/src/mesa/drivers/x11/glxapi.c
+++ b/src/mesa/drivers/x11/glxapi.c
@@ -1019,37 +1019,6 @@ glXSet3DfxModeMESA(int mode)



-/*** GLX_NV_vertex_array_range ***/
-
-void PUBLIC *
-glXAllocateMemoryNV( GLsizei size,
- GLfloat readFrequency,
- GLfloat writeFrequency,
- GLfloat priority )
-{
-   struct _glxapi_table *t;
-   Display *dpy = glXGetCurrentDisplay();
-   GET_DISPATCH(dpy, t);
-   if (!t)
-  return NULL;
-   return t->AllocateMemoryNV(size, readFrequency, writeFrequency, priority);
-}
-
-
-void PUBLIC
-glXFreeMemoryNV( GLvoid *pointer )
-{
-   struct _glxapi_table *t;
-   Display *dpy = glXGetCurrentDisplay();
-   GET_DISPATCH(dpy, t);
-   if (!t)
-  return;
-   t->FreeMemoryNV(pointer);
-}
-
-
-
-
  /*** GLX_MESA_agp_offset */

  GLuint PUBLIC
@@ -1288,10 +1257,6 @@ static struct name_address_pair GLX_functions[] = {
 /*** GLX_ARB_get_proc_address ***/
 { "glXGetProcAddressARB", (__GLXextFuncPtr) glXGetProcAddressARB },

-   /*** GLX_NV_vertex_array_range ***/
-   { "glXAllocateMemoryNV", (__GLXextFuncPtr) glXAllocateMemoryNV },
-   { "glXFreeMemoryNV", (__GLXextFuncPtr) glXFreeMemoryNV },
-
 /*** GLX_MESA_agp_offset ***/
 { "glXGetAGPOffsetMESA", (__GLXextFuncPtr) glXGetAGPOffsetMESA },

diff --git a/src/mesa/drivers/x11/glxapi.h b/src/mesa/drivers/x11/glxapi.h
index cc4f902925b..a4930b10dca 100644
--- a/src/mesa/drivers/x11/glxapi.h
+++ b/src/mesa/drivers/x11/glxapi.h
@@ -186,13 +186,6 @@ struct _glxapi_table {
 /*** GLX_MESA_set_3dfx_mode ***/
 Bool (*Set3DfxModeMESA)(int mode);

-   /*** GLX_NV_vertex_array_range ***/
-   void * (*AllocateMemoryNV)( GLsizei size,
-   GLfloat readFrequency,
-   GLfloat writeFrequency,
-   GLfloat priority );
-   void (*FreeMemoryNV)( GLvoid *pointer );
-
 /*** GLX_MESA_agp_offset ***/
 GLuint (*GetAGPOffsetMESA)( const GLvoid *pointer );




___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/5] xlib: remove empty GLX_NV_vertex_array_range stubs

2017-11-29 Thread Emil Velikov 
From: Emil Velikov 

The extension was never implemented and seemingly never will.
The DRI based libGL dropped support for it over 10 years ago.

Cc: Brian Paul 
Cc: Ian Romanick 
Signed-off-by: Emil Velikov 
---
 src/mesa/drivers/x11/fakeglx.c | 26 --
 src/mesa/drivers/x11/glxapi.c  | 35 ---
 src/mesa/drivers/x11/glxapi.h  |  7 ---
 3 files changed, 68 deletions(-)

diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c
index d2a099f9a20..8902a7cd667 100644
--- a/src/mesa/drivers/x11/fakeglx.c
+++ b/src/mesa/drivers/x11/fakeglx.c
@@ -2759,28 +2759,6 @@ Fake_glXSet3DfxModeMESA( int mode )
 
 
 
-/*** GLX_NV_vertex_array range ***/
-static void *
-Fake_glXAllocateMemoryNV( GLsizei size,
-  GLfloat readFrequency,
-  GLfloat writeFrequency,
-  GLfloat priority )
-{
-   (void) size;
-   (void) readFrequency;
-   (void) writeFrequency;
-   (void) priority;
-   return NULL;
-}
-
-
-static void 
-Fake_glXFreeMemoryNV( GLvoid *pointer )
-{
-   (void) pointer;
-}
-
-
 /*** GLX_MESA_agp_offset ***/
 
 static GLuint
@@ -3009,10 +2987,6 @@ _mesa_GetGLXDispatchTable(void)
/*** GLX_MESA_set_3dfx_mode ***/
glx.Set3DfxModeMESA = Fake_glXSet3DfxModeMESA;
 
-   /*** GLX_NV_vertex_array_range ***/
-   glx.AllocateMemoryNV = Fake_glXAllocateMemoryNV;
-   glx.FreeMemoryNV = Fake_glXFreeMemoryNV;
-
/*** GLX_MESA_agp_offset ***/
glx.GetAGPOffsetMESA = Fake_glXGetAGPOffsetMESA;
 
diff --git a/src/mesa/drivers/x11/glxapi.c b/src/mesa/drivers/x11/glxapi.c
index 52e60265697..ff8b2b2ce16 100644
--- a/src/mesa/drivers/x11/glxapi.c
+++ b/src/mesa/drivers/x11/glxapi.c
@@ -1019,37 +1019,6 @@ glXSet3DfxModeMESA(int mode)
 
 
 
-/*** GLX_NV_vertex_array_range ***/
-
-void PUBLIC *
-glXAllocateMemoryNV( GLsizei size,
- GLfloat readFrequency,
- GLfloat writeFrequency,
- GLfloat priority )
-{
-   struct _glxapi_table *t;
-   Display *dpy = glXGetCurrentDisplay();
-   GET_DISPATCH(dpy, t);
-   if (!t)
-  return NULL;
-   return t->AllocateMemoryNV(size, readFrequency, writeFrequency, priority);
-}
-
-
-void PUBLIC
-glXFreeMemoryNV( GLvoid *pointer )
-{
-   struct _glxapi_table *t;
-   Display *dpy = glXGetCurrentDisplay();
-   GET_DISPATCH(dpy, t);
-   if (!t)
-  return;
-   t->FreeMemoryNV(pointer);
-}
-
-
-
-
 /*** GLX_MESA_agp_offset */
 
 GLuint PUBLIC
@@ -1288,10 +1257,6 @@ static struct name_address_pair GLX_functions[] = {
/*** GLX_ARB_get_proc_address ***/
{ "glXGetProcAddressARB", (__GLXextFuncPtr) glXGetProcAddressARB },
 
-   /*** GLX_NV_vertex_array_range ***/
-   { "glXAllocateMemoryNV", (__GLXextFuncPtr) glXAllocateMemoryNV },
-   { "glXFreeMemoryNV", (__GLXextFuncPtr) glXFreeMemoryNV },
-
/*** GLX_MESA_agp_offset ***/
{ "glXGetAGPOffsetMESA", (__GLXextFuncPtr) glXGetAGPOffsetMESA },
 
diff --git a/src/mesa/drivers/x11/glxapi.h b/src/mesa/drivers/x11/glxapi.h
index cc4f902925b..a4930b10dca 100644
--- a/src/mesa/drivers/x11/glxapi.h
+++ b/src/mesa/drivers/x11/glxapi.h
@@ -186,13 +186,6 @@ struct _glxapi_table {
/*** GLX_MESA_set_3dfx_mode ***/
Bool (*Set3DfxModeMESA)(int mode);
 
-   /*** GLX_NV_vertex_array_range ***/
-   void * (*AllocateMemoryNV)( GLsizei size,
-   GLfloat readFrequency,
-   GLfloat writeFrequency,
-   GLfloat priority );
-   void (*FreeMemoryNV)( GLvoid *pointer );
-
/*** GLX_MESA_agp_offset ***/
GLuint (*GetAGPOffsetMESA)( const GLvoid *pointer );
 
-- 
2.15.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev