Re: [Mesa-dev] [PATCH 2/2] virgl: reduce some default capset limits.

[Stéphane Marchesin]

On Tue, Feb 20, 2018 at 5:49 PM, Dave Airlie  wrote:
> From: Dave Airlie 
>
> Since v2 might take a while to rollout, we should reduce
> these inside some gathered minimums and then v2 can increase
> them using host values.
>
> Signed-off-by: Dave Airlie 

Reviewed-by: Stéphane Marchesin 

> ---
>  src/gallium/drivers/virgl/virgl_winsys.h | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/gallium/drivers/virgl/virgl_winsys.h 
> b/src/gallium/drivers/virgl/virgl_winsys.h
> index d633678597b..95e21a8afde 100644
> --- a/src/gallium/drivers/virgl/virgl_winsys.h
> +++ b/src/gallium/drivers/virgl/virgl_winsys.h
> @@ -114,17 +114,17 @@ struct virgl_winsys {
>   */
>  static inline void virgl_ws_fill_new_caps_defaults(struct virgl_drm_caps 
> *caps)
>  {
> -   caps->caps.v2.min_aliased_point_size = 0.f;
> +   caps->caps.v2.min_aliased_point_size = 1.f;
> caps->caps.v2.max_aliased_point_size = 255.f;
> -   caps->caps.v2.min_smooth_point_size = 0.f;
> -   caps->caps.v2.max_smooth_point_size = 255.f;
> -   caps->caps.v2.min_aliased_line_width = 0.f;
> -   caps->caps.v2.max_aliased_line_width = 255.f;
> +   caps->caps.v2.min_smooth_point_size = 1.f;
> +   caps->caps.v2.max_smooth_point_size = 190.f;
> +   caps->caps.v2.min_aliased_line_width = 1.f;
> +   caps->caps.v2.max_aliased_line_width = 10.f;
> caps->caps.v2.min_smooth_line_width = 0.f;
> -   caps->caps.v2.max_smooth_line_width = 255.f;
> -   caps->caps.v2.max_texture_lod_bias = 16.0f;
> +   caps->caps.v2.max_smooth_line_width = 10.f;
> +   caps->caps.v2.max_texture_lod_bias = 15.0f;
> caps->caps.v2.max_geom_output_vertices = 256;
> -   caps->caps.v2.max_geom_total_output_components = 16384;
> +   caps->caps.v2.max_geom_total_output_components = 1024;
> caps->caps.v2.max_vertex_outputs = 32;
> caps->caps.v2.max_vertex_attribs = 16;
> caps->caps.v2.max_shader_patch_varyings = 0;
> --
> 2.14.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] virgl: reduce some default capset limits.

[Dave Airlie]

From: Dave Airlie 

Since v2 might take a while to rollout, we should reduce
these inside some gathered minimums and then v2 can increase
them using host values.

Signed-off-by: Dave Airlie 
---
 src/gallium/drivers/virgl/virgl_winsys.h | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/gallium/drivers/virgl/virgl_winsys.h 
b/src/gallium/drivers/virgl/virgl_winsys.h
index d633678597b..95e21a8afde 100644
--- a/src/gallium/drivers/virgl/virgl_winsys.h
+++ b/src/gallium/drivers/virgl/virgl_winsys.h
@@ -114,17 +114,17 @@ struct virgl_winsys {
  */
 static inline void virgl_ws_fill_new_caps_defaults(struct virgl_drm_caps *caps)
 {
-   caps->caps.v2.min_aliased_point_size = 0.f;
+   caps->caps.v2.min_aliased_point_size = 1.f;
caps->caps.v2.max_aliased_point_size = 255.f;
-   caps->caps.v2.min_smooth_point_size = 0.f;
-   caps->caps.v2.max_smooth_point_size = 255.f;
-   caps->caps.v2.min_aliased_line_width = 0.f;
-   caps->caps.v2.max_aliased_line_width = 255.f;
+   caps->caps.v2.min_smooth_point_size = 1.f;
+   caps->caps.v2.max_smooth_point_size = 190.f;
+   caps->caps.v2.min_aliased_line_width = 1.f;
+   caps->caps.v2.max_aliased_line_width = 10.f;
caps->caps.v2.min_smooth_line_width = 0.f;
-   caps->caps.v2.max_smooth_line_width = 255.f;
-   caps->caps.v2.max_texture_lod_bias = 16.0f;
+   caps->caps.v2.max_smooth_line_width = 10.f;
+   caps->caps.v2.max_texture_lod_bias = 15.0f;
caps->caps.v2.max_geom_output_vertices = 256;
-   caps->caps.v2.max_geom_total_output_components = 16384;
+   caps->caps.v2.max_geom_total_output_components = 1024;
caps->caps.v2.max_vertex_outputs = 32;
caps->caps.v2.max_vertex_attribs = 16;
caps->caps.v2.max_shader_patch_varyings = 0;
-- 
2.14.3

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev