Re: [Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

[Emil Velikov]

On 27 July 2016 at 16:19, Jason Ekstrand  wrote:
> Thanks. We only had that because at one point we weren't using the loader
> and dota2 needed it. No longer an issue...
>
Damien, are you still keeping track of oddly parsed emails by patchwork ?
Jason's reply seems to have confused patchwork to change the author
[1]. It also detected 5 revisions of this series, although I could be
the one to "blame" there ;-)

Related: all the /series pages seem to be unhappy if you're navigating
through history (go back/forward). Is that intentional - can I suggest
opting for the /patches approach ?

Thanks
Emil

[1] https://patchwork.freedesktop.org/patch/101314/
[2] https://patchwork.freedesktop.org/series/10320/
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

[Eric Engestrom]

On Wed, Jul 27, 2016 at 02:02:54PM +0100, Emil Velikov wrote:
> From: Emil Velikov 
> 
> The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not

+"advertise"

> that the driver supports the extension. Furturmore the functions are empty 
> stubs.

"furthermore" :)

> 
> Remove those until we get a proper implementation and json notation.
> 
> Cc: "12.0" 
> Cc: Jason Ekstrand 
> Signed-off-by: Emil Velikov 
> ---
>  src/intel/vulkan/anv_device.c | 20 
>  1 file changed, 20 deletions(-)
> 
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index e445c96..8f1a617 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -1792,23 +1792,3 @@ void anv_DestroyFramebuffer(
>  
> anv_free2(>alloc, pAllocator, fb);
>  }
> -
> -void vkCmdDbgMarkerBegin(
> -VkCommandBuffer  commandBuffer,
> -const char* pMarker)
> -   __attribute__ ((visibility ("default")));
> -
> -void vkCmdDbgMarkerEnd(
> -   VkCommandBuffer  commandBuffer)
> -   __attribute__ ((visibility ("default")));
> -
> -void vkCmdDbgMarkerBegin(
> -VkCommandBuffer  commandBuffer,
> -const char* pMarker)
> -{
> -}
> -
> -void vkCmdDbgMarkerEnd(
> -VkCommandBuffer  commandBuffer)
> -{
> -}
> -- 
> 2.9.0
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

[Jason Ekstrand]

Thanks. We only had that because at one point we weren't using the loader
and dota2 needed it. No longer an issue...

On Jul 27, 2016 6:03 AM, "Emil Velikov"  wrote:

From: Emil Velikov 

The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not
that the driver supports the extension. Furturmore the functions are empty
stubs.

Remove those until we get a proper implementation and json notation.

Cc: "12.0" 
Cc: Jason Ekstrand 
Signed-off-by: Emil Velikov 
---
 src/intel/vulkan/anv_device.c | 20 
 1 file changed, 20 deletions(-)

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index e445c96..8f1a617 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1792,23 +1792,3 @@ void anv_DestroyFramebuffer(

anv_free2(>alloc, pAllocator, fb);
 }
-
-void vkCmdDbgMarkerBegin(
-VkCommandBuffer  commandBuffer,
-const char* pMarker)
-   __attribute__ ((visibility ("default")));
-
-void vkCmdDbgMarkerEnd(
-   VkCommandBuffer  commandBuffer)
-   __attribute__ ((visibility ("default")));
-
-void vkCmdDbgMarkerBegin(
-VkCommandBuffer  commandBuffer,
-const char* pMarker)
-{
-}
-
-void vkCmdDbgMarkerEnd(
-VkCommandBuffer  commandBuffer)
-{
-}
--
2.9.0
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/6] anv: remove dummy VK_DEBUG_MARKER_EXT entry points

[Emil Velikov]

From: Emil Velikov 

The vkCmdDbgMarker{Begin,End} symbols are exported, yet the json does not
that the driver supports the extension. Furturmore the functions are empty 
stubs.

Remove those until we get a proper implementation and json notation.

Cc: "12.0" 
Cc: Jason Ekstrand 
Signed-off-by: Emil Velikov 
---
 src/intel/vulkan/anv_device.c | 20 
 1 file changed, 20 deletions(-)

diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index e445c96..8f1a617 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -1792,23 +1792,3 @@ void anv_DestroyFramebuffer(
 
anv_free2(>alloc, pAllocator, fb);
 }
-
-void vkCmdDbgMarkerBegin(
-VkCommandBuffer  commandBuffer,
-const char* pMarker)
-   __attribute__ ((visibility ("default")));
-
-void vkCmdDbgMarkerEnd(
-   VkCommandBuffer  commandBuffer)
-   __attribute__ ((visibility ("default")));
-
-void vkCmdDbgMarkerBegin(
-VkCommandBuffer  commandBuffer,
-const char* pMarker)
-{
-}
-
-void vkCmdDbgMarkerEnd(
-VkCommandBuffer  commandBuffer)
-{
-}
-- 
2.9.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev