Re: [Mesa-dev] [PATCH mesa] freedreno: add missing include

[Rob Clark]

On Mon, Mar 5, 2018 at 12:52 PM, Eric Engestrom
 wrote:
> Fixes: 26a9321d0ae819f2a49d7 "freedreno: add global_bindings state"
> Cc: Rob Clark 
> Signed-off-by: Eric Engestrom 
> ---
>  src/gallium/drivers/freedreno/freedreno_state.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/drivers/freedreno/freedreno_state.c 
> b/src/gallium/drivers/freedreno/freedreno_state.c
> index 05717da95995e5cec6a5..907653e64af244bcc364 100644
> --- a/src/gallium/drivers/freedreno/freedreno_state.c
> +++ b/src/gallium/drivers/freedreno/freedreno_state.c
> @@ -40,6 +40,8 @@
>  #include "freedreno_query_hw.h"
>  #include "freedreno_util.h"
>
> +#include 
> +

hmm, freedreno_util.h already has

  #include 

which should in theory be enough..

But I did screw up and push the 'add global bindings state' before
spinning a libdrm release and bumping mesa's libdrm_freedreno version
dependency.  Not sure if that could be related to the compile error
you were hitting?

BR,
-R

>  /* All the generic state handling.. In case of CSO's that are specific
>   * to the GPU version, when the bind and the delete are common they can
>   * go in here.
> --
> Cheers,
>   Eric
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa] freedreno: add missing include

[Eric Engestrom]

Fixes: 26a9321d0ae819f2a49d7 "freedreno: add global_bindings state"
Cc: Rob Clark 
Signed-off-by: Eric Engestrom 
---
 src/gallium/drivers/freedreno/freedreno_state.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/drivers/freedreno/freedreno_state.c 
b/src/gallium/drivers/freedreno/freedreno_state.c
index 05717da95995e5cec6a5..907653e64af244bcc364 100644
--- a/src/gallium/drivers/freedreno/freedreno_state.c
+++ b/src/gallium/drivers/freedreno/freedreno_state.c
@@ -40,6 +40,8 @@
 #include "freedreno_query_hw.h"
 #include "freedreno_util.h"
 
+#include 
+
 /* All the generic state handling.. In case of CSO's that are specific
  * to the GPU version, when the bind and the delete are common they can
  * go in here.
-- 
Cheers,
  Eric

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev