Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
Quoting Thierry Reding (2018-12-18 14:19:32) > On Tue, Dec 18, 2018 at 11:34:31AM -0800, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-12-18 09:43:18) > > > > > > > > > On December 18, 2018 5:36:19 PM UTC, Dylan Baker > > > wrote: > > > > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > > > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > > > > wrote: > > > > > > > > > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > > > > > Under what circumstances would tegra have a vdpau > > > > implementation? > > > > > > > > > > > > I don't know about that, but this patch brings meson on par with > > > > > > autotools. Are you saying autotools was wrong and it should be > > > > removed > > > > > > there instead? > > > > > > > > > > > > FtR, src/gallium/targets/vdpau/Makefile.am includes > > > > > > src/gallium/drivers/tegra/Automake.inc which adds tegra to the > > > > > > TARGET_DRIVERS, which in turn produces libvdpau_tegra.so > > > > > > > > > > > > If this was wrong, then that include on line 60 of > > > > > > src/gallium/targets/vdpau/Makefile.am should be removed. > > > > > > > > > > > > This line was added by Thierry Reding (cc'ed) when he first > > > > introduced > > > > > > tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". > > > > > > > > > > I'd like to hear tagr opine on this, but AFAIK tegra is a > > > > > renderonly-style driver, which uses nouveau as its actual rendering > > > > > backend. While nouveau does support VDPAU, the decoding engines are > > > > > not available as part of the GPU device on Tegra platforms. They > > > > still > > > > > have decoders, they're just separate platform devices (which I > > > > suspect > > > > > operate very similarly to their desktop GPU counterparts, but that's > > > > a > > > > > separate matter). > > > > > > > > > > -ilia > > > > > > > > Ping? > > > > > > I suggest we land this patch to bring meson on par with autotools, and if > > > we decide later > > > that autotools was wrong, we can just remove it from both places at once; > > > ack? > > > > I'd vote lets at least give Thierry till tomorrow to respond, and we can > > merge > > it tomorrow around this time if he hasn't, with the remove fallback if tegra > > shouldn't have a vdpau module? Does that sound reasonable to everyone? > > Sorry, I completely missed this. Ilia is right, Tegra doesn't have any > decoding engines in the GPU. Ilia is also correct that the engines are > separate devices and similar to their desktop GPU counterparts. While > it'd technically be possible to somehow enable video decoding in the > Tegra gallium driver (I had done some prototyping on this a while ago), > it doesn't look like the best option at this point. The problem is that > gallium makes a bunch of assumptions that just don't apply to Tegra. > > At this point, it seems more likely that video decoding will be > implemented as V4L2 memory-to-memory drivers. > > So I think we should just remove the vdpau support for Tegra from the > autotools build. It's completely non-functional and there are no plans > to make it work. > > Thierry Perfect, Thanks Thierry! Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
On Tue, Dec 18, 2018 at 11:34:31AM -0800, Dylan Baker wrote: > Quoting Eric Engestrom (2018-12-18 09:43:18) > > > > > > On December 18, 2018 5:36:19 PM UTC, Dylan Baker > > wrote: > > > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > > > wrote: > > > > > > > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > > > > Under what circumstances would tegra have a vdpau > > > implementation? > > > > > > > > > > I don't know about that, but this patch brings meson on par with > > > > > autotools. Are you saying autotools was wrong and it should be > > > removed > > > > > there instead? > > > > > > > > > > FtR, src/gallium/targets/vdpau/Makefile.am includes > > > > > src/gallium/drivers/tegra/Automake.inc which adds tegra to the > > > > > TARGET_DRIVERS, which in turn produces libvdpau_tegra.so > > > > > > > > > > If this was wrong, then that include on line 60 of > > > > > src/gallium/targets/vdpau/Makefile.am should be removed. > > > > > > > > > > This line was added by Thierry Reding (cc'ed) when he first > > > introduced > > > > > tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". > > > > > > > > I'd like to hear tagr opine on this, but AFAIK tegra is a > > > > renderonly-style driver, which uses nouveau as its actual rendering > > > > backend. While nouveau does support VDPAU, the decoding engines are > > > > not available as part of the GPU device on Tegra platforms. They > > > still > > > > have decoders, they're just separate platform devices (which I > > > suspect > > > > operate very similarly to their desktop GPU counterparts, but that's > > > a > > > > separate matter). > > > > > > > > -ilia > > > > > > Ping? > > > > I suggest we land this patch to bring meson on par with autotools, and if > > we decide later > > that autotools was wrong, we can just remove it from both places at once; > > ack? > > I'd vote lets at least give Thierry till tomorrow to respond, and we can merge > it tomorrow around this time if he hasn't, with the remove fallback if tegra > shouldn't have a vdpau module? Does that sound reasonable to everyone? Sorry, I completely missed this. Ilia is right, Tegra doesn't have any decoding engines in the GPU. Ilia is also correct that the engines are separate devices and similar to their desktop GPU counterparts. While it'd technically be possible to somehow enable video decoding in the Tegra gallium driver (I had done some prototyping on this a while ago), it doesn't look like the best option at this point. The problem is that gallium makes a bunch of assumptions that just don't apply to Tegra. At this point, it seems more likely that video decoding will be implemented as V4L2 memory-to-memory drivers. So I think we should just remove the vdpau support for Tegra from the autotools build. It's completely non-functional and there are no plans to make it work. Thierry signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
Quoting Eric Engestrom (2018-12-18 09:43:18) > > > On December 18, 2018 5:36:19 PM UTC, Dylan Baker wrote: > > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > > wrote: > > > > > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > > > Under what circumstances would tegra have a vdpau > > implementation? > > > > > > > > I don't know about that, but this patch brings meson on par with > > > > autotools. Are you saying autotools was wrong and it should be > > removed > > > > there instead? > > > > > > > > FtR, src/gallium/targets/vdpau/Makefile.am includes > > > > src/gallium/drivers/tegra/Automake.inc which adds tegra to the > > > > TARGET_DRIVERS, which in turn produces libvdpau_tegra.so > > > > > > > > If this was wrong, then that include on line 60 of > > > > src/gallium/targets/vdpau/Makefile.am should be removed. > > > > > > > > This line was added by Thierry Reding (cc'ed) when he first > > introduced > > > > tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". > > > > > > I'd like to hear tagr opine on this, but AFAIK tegra is a > > > renderonly-style driver, which uses nouveau as its actual rendering > > > backend. While nouveau does support VDPAU, the decoding engines are > > > not available as part of the GPU device on Tegra platforms. They > > still > > > have decoders, they're just separate platform devices (which I > > suspect > > > operate very similarly to their desktop GPU counterparts, but that's > > a > > > separate matter). > > > > > > -ilia > > > > Ping? > > I suggest we land this patch to bring meson on par with autotools, and if we > decide later > that autotools was wrong, we can just remove it from both places at once; ack? I'd vote lets at least give Thierry till tomorrow to respond, and we can merge it tomorrow around this time if he hasn't, with the remove fallback if tegra shouldn't have a vdpau module? Does that sound reasonable to everyone? Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
On December 18, 2018 5:36:19 PM UTC, Dylan Baker wrote: > Quoting Ilia Mirkin (2018-12-06 09:39:25) > > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > wrote: > > > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > > Under what circumstances would tegra have a vdpau > implementation? > > > > > > I don't know about that, but this patch brings meson on par with > > > autotools. Are you saying autotools was wrong and it should be > removed > > > there instead? > > > > > > FtR, src/gallium/targets/vdpau/Makefile.am includes > > > src/gallium/drivers/tegra/Automake.inc which adds tegra to the > > > TARGET_DRIVERS, which in turn produces libvdpau_tegra.so > > > > > > If this was wrong, then that include on line 60 of > > > src/gallium/targets/vdpau/Makefile.am should be removed. > > > > > > This line was added by Thierry Reding (cc'ed) when he first > introduced > > > tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". > > > > I'd like to hear tagr opine on this, but AFAIK tegra is a > > renderonly-style driver, which uses nouveau as its actual rendering > > backend. While nouveau does support VDPAU, the decoding engines are > > not available as part of the GPU device on Tegra platforms. They > still > > have decoders, they're just separate platform devices (which I > suspect > > operate very similarly to their desktop GPU counterparts, but that's > a > > separate matter). > > > > -ilia > > Ping? I suggest we land this patch to bring meson on par with autotools, and if we decide later that autotools was wrong, we can just remove it from both places at once; ack? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
Quoting Ilia Mirkin (2018-12-06 09:39:25) > On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom > wrote: > > > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > > Under what circumstances would tegra have a vdpau implementation? > > > > I don't know about that, but this patch brings meson on par with > > autotools. Are you saying autotools was wrong and it should be removed > > there instead? > > > > FtR, src/gallium/targets/vdpau/Makefile.am includes > > src/gallium/drivers/tegra/Automake.inc which adds tegra to the > > TARGET_DRIVERS, which in turn produces libvdpau_tegra.so > > > > If this was wrong, then that include on line 60 of > > src/gallium/targets/vdpau/Makefile.am should be removed. > > > > This line was added by Thierry Reding (cc'ed) when he first introduced > > tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". > > I'd like to hear tagr opine on this, but AFAIK tegra is a > renderonly-style driver, which uses nouveau as its actual rendering > backend. While nouveau does support VDPAU, the decoding engines are > not available as part of the GPU device on Tegra platforms. They still > have decoders, they're just separate platform devices (which I suspect > operate very similarly to their desktop GPU counterparts, but that's a > separate matter). > > -ilia Ping? signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
On Thu, Dec 6, 2018 at 12:17 PM Eric Engestrom wrote: > > On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > > Under what circumstances would tegra have a vdpau implementation? > > I don't know about that, but this patch brings meson on par with > autotools. Are you saying autotools was wrong and it should be removed > there instead? > > FtR, src/gallium/targets/vdpau/Makefile.am includes > src/gallium/drivers/tegra/Automake.inc which adds tegra to the > TARGET_DRIVERS, which in turn produces libvdpau_tegra.so > > If this was wrong, then that include on line 60 of > src/gallium/targets/vdpau/Makefile.am should be removed. > > This line was added by Thierry Reding (cc'ed) when he first introduced > tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". I'd like to hear tagr opine on this, but AFAIK tegra is a renderonly-style driver, which uses nouveau as its actual rendering backend. While nouveau does support VDPAU, the decoding engines are not available as part of the GPU device on Tegra platforms. They still have decoders, they're just separate platform devices (which I suspect operate very similarly to their desktop GPU counterparts, but that's a separate matter). -ilia ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
On Thursday, 2018-12-06 12:07:06 -0500, Ilia Mirkin wrote: > Under what circumstances would tegra have a vdpau implementation? I don't know about that, but this patch brings meson on par with autotools. Are you saying autotools was wrong and it should be removed there instead? FtR, src/gallium/targets/vdpau/Makefile.am includes src/gallium/drivers/tegra/Automake.inc which adds tegra to the TARGET_DRIVERS, which in turn produces libvdpau_tegra.so If this was wrong, then that include on line 60 of src/gallium/targets/vdpau/Makefile.am should be removed. This line was added by Thierry Reding (cc'ed) when he first introduced tegra support in 1755f608f5201e0a23f00 "tegra: Initial support". > On Thu, Dec 6, 2018 at 11:57 AM Eric Engestrom > wrote: > > > > From: Igor Gnatenko > > > > Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker" > > Cc: Dylan Baker > > --- > > src/gallium/targets/vdpau/meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/gallium/targets/vdpau/meson.build > > b/src/gallium/targets/vdpau/meson.build > > index 005cf642498d68a0b395..0c09b2b811429b5688b8 100644 > > --- a/src/gallium/targets/vdpau/meson.build > > +++ b/src/gallium/targets/vdpau/meson.build > > @@ -51,13 +51,14 @@ libvdpau_gallium = shared_library( > > libpipe_loader_static, libws_null, libwsw, libswdri, libswkmsdri, > >], > >dependencies : [ > > -dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, > > +dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, > > driver_tegra, > >], > >link_depends : vdpau_link_depends, > > ) > > foreach d : [[with_gallium_r300, 'r300'], > > [with_gallium_r600, 'r600'], > > [with_gallium_radeonsi, 'radeonsi'], > > + [with_gallium_tegra, 'tegra'], > > [with_gallium_nouveau, 'nouveau']] > >if d[0] > > vdpau_drivers += 'libvdpau_@0@.so.1.0.0'.format(d[1]) > > -- > > Cheers, > > Eric > > > > ___ > > mesa-dev mailing list > > mesa-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
Under what circumstances would tegra have a vdpau implementation? On Thu, Dec 6, 2018 at 11:57 AM Eric Engestrom wrote: > > From: Igor Gnatenko > > Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker" > Cc: Dylan Baker > --- > src/gallium/targets/vdpau/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/targets/vdpau/meson.build > b/src/gallium/targets/vdpau/meson.build > index 005cf642498d68a0b395..0c09b2b811429b5688b8 100644 > --- a/src/gallium/targets/vdpau/meson.build > +++ b/src/gallium/targets/vdpau/meson.build > @@ -51,13 +51,14 @@ libvdpau_gallium = shared_library( > libpipe_loader_static, libws_null, libwsw, libswdri, libswkmsdri, >], >dependencies : [ > -dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, > +dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, > driver_tegra, >], >link_depends : vdpau_link_depends, > ) > foreach d : [[with_gallium_r300, 'r300'], > [with_gallium_r600, 'r600'], > [with_gallium_radeonsi, 'radeonsi'], > + [with_gallium_tegra, 'tegra'], > [with_gallium_nouveau, 'nouveau']] >if d[0] > vdpau_drivers += 'libvdpau_@0@.so.1.0.0'.format(d[1]) > -- > Cheers, > Eric > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH mesa] meson: add missing tegra vdpau driver
From: Igor Gnatenko Fixes: 68076b87474e7959c161 "meson: build gallium vdpau state tracker" Cc: Dylan Baker --- src/gallium/targets/vdpau/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/targets/vdpau/meson.build b/src/gallium/targets/vdpau/meson.build index 005cf642498d68a0b395..0c09b2b811429b5688b8 100644 --- a/src/gallium/targets/vdpau/meson.build +++ b/src/gallium/targets/vdpau/meson.build @@ -51,13 +51,14 @@ libvdpau_gallium = shared_library( libpipe_loader_static, libws_null, libwsw, libswdri, libswkmsdri, ], dependencies : [ -dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, +dep_thread, driver_r300, driver_r600, driver_radeonsi, driver_nouveau, driver_tegra, ], link_depends : vdpau_link_depends, ) foreach d : [[with_gallium_r300, 'r300'], [with_gallium_r600, 'r600'], [with_gallium_radeonsi, 'radeonsi'], + [with_gallium_tegra, 'tegra'], [with_gallium_nouveau, 'nouveau']] if d[0] vdpau_drivers += 'libvdpau_@0@.so.1.0.0'.format(d[1]) -- Cheers, Eric ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
