Re: [Mesa-dev] [PATCH v2] ac: add missing 16-bit types to glsl_base_to_llvm_type()

2019-01-14 Thread Bas Nieuwenhuizen
On Mon, Jan 14, 2019 at 5:55 PM Samuel Pitoiset
 wrote:
>
> Fix crashes with
> dEQP-VK.spirv_assembly.instruction.compute.workgroup_memory.*16
>
> v2: - add INT16/UINT16 too
> - update commit description
>
> Signed-off-by: Samuel Pitoiset 
> Reviewed-by: Bas Nieuwenhuizen  (v1)
> ---
>  src/amd/common/ac_nir_to_llvm.c | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 5023b96f92d..f9a3c171b1d 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -3902,8 +3902,13 @@ glsl_base_to_llvm_type(struct ac_llvm_context *ac,
> case GLSL_TYPE_BOOL:
> case GLSL_TYPE_SUBROUTINE:
> return ac->i32;
> +   case GLSL_TYPE_INT16:
> +   case GLSL_TYPE_UINT16:
> +   return ac->i16;
> case GLSL_TYPE_FLOAT: /* TODO handle mediump */

Remove the TODO while you're at it?

Either way, r-b.

> return ac->f32;
> +   case GLSL_TYPE_FLOAT16:
> +   return ac->f16;
> case GLSL_TYPE_INT64:
> case GLSL_TYPE_UINT64:
> return ac->i64;
> --
> 2.20.1
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


[Mesa-dev] [PATCH v2] ac: add missing 16-bit types to glsl_base_to_llvm_type()

2019-01-14 Thread Samuel Pitoiset
Fix crashes with
dEQP-VK.spirv_assembly.instruction.compute.workgroup_memory.*16

v2: - add INT16/UINT16 too
- update commit description

Signed-off-by: Samuel Pitoiset 
Reviewed-by: Bas Nieuwenhuizen  (v1)
---
 src/amd/common/ac_nir_to_llvm.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
index 5023b96f92d..f9a3c171b1d 100644
--- a/src/amd/common/ac_nir_to_llvm.c
+++ b/src/amd/common/ac_nir_to_llvm.c
@@ -3902,8 +3902,13 @@ glsl_base_to_llvm_type(struct ac_llvm_context *ac,
case GLSL_TYPE_BOOL:
case GLSL_TYPE_SUBROUTINE:
return ac->i32;
+   case GLSL_TYPE_INT16:
+   case GLSL_TYPE_UINT16:
+   return ac->i16;
case GLSL_TYPE_FLOAT: /* TODO handle mediump */
return ac->f32;
+   case GLSL_TYPE_FLOAT16:
+   return ac->f16;
case GLSL_TYPE_INT64:
case GLSL_TYPE_UINT64:
return ac->i64;
-- 
2.20.1

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev