Re: [Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

2018-02-21 Thread Aaron Watry 
6 is Acked-By: Aaron Watry 
7-11 (regardless of my comment in 9) are Reviewed-By: Aaron Watry


--Aaron

On Wed, Feb 21, 2018 at 4:50 PM, Pierre Moreau  wrote:
> Reviewed-by: Francisco Jerez 
> Signed-off-by: Pierre Moreau 
> ---
>  src/gallium/state_trackers/clover/api/platform.cpp  | 4 ++--
>  src/gallium/state_trackers/clover/core/platform.cpp | 5 +
>  src/gallium/state_trackers/clover/core/platform.hpp | 2 ++
>  3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/state_trackers/clover/api/platform.cpp 
> b/src/gallium/state_trackers/clover/api/platform.cpp
> index ed86163311..887dfd0a22 100644
> --- a/src/gallium/state_trackers/clover/api/platform.cpp
> +++ b/src/gallium/state_trackers/clover/api/platform.cpp
> @@ -50,7 +50,7 @@ clover::GetPlatformInfo(cl_platform_id d_platform, 
> cl_platform_info param,
>  size_t size, void *r_buf, size_t *r_size) try {
> property_buffer buf { r_buf, size, r_size };
>
> -   obj(d_platform);
> +   auto  = obj(d_platform);
>
> switch (param) {
> case CL_PLATFORM_PROFILE:
> @@ -74,7 +74,7 @@ clover::GetPlatformInfo(cl_platform_id d_platform, 
> cl_platform_info param,
>break;
>
> case CL_PLATFORM_EXTENSIONS:
> -  buf.as_string() = "cl_khr_icd";
> +  buf.as_string() = platform.supported_extensions();
>break;
>
> case CL_PLATFORM_ICD_SUFFIX_KHR:
> diff --git a/src/gallium/state_trackers/clover/core/platform.cpp 
> b/src/gallium/state_trackers/clover/core/platform.cpp
> index 489e8dc5a8..ddd63fc5a0 100644
> --- a/src/gallium/state_trackers/clover/core/platform.cpp
> +++ b/src/gallium/state_trackers/clover/core/platform.cpp
> @@ -39,3 +39,8 @@ platform::platform() : adaptor_range(evals(), devs) {
>}
> }
>  }
> +
> +std::string
> +platform::supported_extensions() const {
> +   return "cl_khr_icd";
> +}
> diff --git a/src/gallium/state_trackers/clover/core/platform.hpp 
> b/src/gallium/state_trackers/clover/core/platform.hpp
> index e849645bbe..b94434c983 100644
> --- a/src/gallium/state_trackers/clover/core/platform.hpp
> +++ b/src/gallium/state_trackers/clover/core/platform.hpp
> @@ -40,6 +40,8 @@ namespace clover {
>platform &
>operator=(const platform ) = delete;
>
> +  std::string supported_extensions() const;
> +
> protected:
>std::vector devs;
> };
> --
> 2.16.2
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 11/21] clover: Move platform extensions definitions to clover/platform.cpp

2018-02-21 Thread Pierre Moreau 
Reviewed-by: Francisco Jerez 
Signed-off-by: Pierre Moreau 
---
 src/gallium/state_trackers/clover/api/platform.cpp  | 4 ++--
 src/gallium/state_trackers/clover/core/platform.cpp | 5 +
 src/gallium/state_trackers/clover/core/platform.hpp | 2 ++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/gallium/state_trackers/clover/api/platform.cpp 
b/src/gallium/state_trackers/clover/api/platform.cpp
index ed86163311..887dfd0a22 100644
--- a/src/gallium/state_trackers/clover/api/platform.cpp
+++ b/src/gallium/state_trackers/clover/api/platform.cpp
@@ -50,7 +50,7 @@ clover::GetPlatformInfo(cl_platform_id d_platform, 
cl_platform_info param,
 size_t size, void *r_buf, size_t *r_size) try {
property_buffer buf { r_buf, size, r_size };
 
-   obj(d_platform);
+   auto  = obj(d_platform);
 
switch (param) {
case CL_PLATFORM_PROFILE:
@@ -74,7 +74,7 @@ clover::GetPlatformInfo(cl_platform_id d_platform, 
cl_platform_info param,
   break;
 
case CL_PLATFORM_EXTENSIONS:
-  buf.as_string() = "cl_khr_icd";
+  buf.as_string() = platform.supported_extensions();
   break;
 
case CL_PLATFORM_ICD_SUFFIX_KHR:
diff --git a/src/gallium/state_trackers/clover/core/platform.cpp 
b/src/gallium/state_trackers/clover/core/platform.cpp
index 489e8dc5a8..ddd63fc5a0 100644
--- a/src/gallium/state_trackers/clover/core/platform.cpp
+++ b/src/gallium/state_trackers/clover/core/platform.cpp
@@ -39,3 +39,8 @@ platform::platform() : adaptor_range(evals(), devs) {
   }
}
 }
+
+std::string
+platform::supported_extensions() const {
+   return "cl_khr_icd";
+}
diff --git a/src/gallium/state_trackers/clover/core/platform.hpp 
b/src/gallium/state_trackers/clover/core/platform.hpp
index e849645bbe..b94434c983 100644
--- a/src/gallium/state_trackers/clover/core/platform.hpp
+++ b/src/gallium/state_trackers/clover/core/platform.hpp
@@ -40,6 +40,8 @@ namespace clover {
   platform &
   operator=(const platform ) = delete;
 
+  std::string supported_extensions() const;
+
protected:
   std::vector devs;
};
-- 
2.16.2

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev