Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}
On 5 March 2018 at 21:05, Brian Paulwrote: > > I'm fine with removing them too. If someone really complains, they can > always be restored. > Seriously doubt it'll happen, yet I fully agree. Small correction: only the Xlib based libGLs expose the API. I'll add a note in the release notes, just in case. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}
On 5 March 2018 at 19:08, Ian Romanickwrote: > On 03/05/2018 10:48 AM, Emil Velikov wrote: >> Hi all, >> >> It seems like these two extensions were never implemented or advertised. >> Be that in: >> - glx/dri >> - glx/apple >> - classic xlib-glx >> - gallium xlib-glx >> >> Yet, the entry points were available, hence apps might have linked >> against it. > > If an app was linking with an extension entry point instead of using > glXGetProcAddress, it is the app's bug. > Small correction: only the Xlib based libGLs do so. I'll add a note in the release notes, just in case. Mildly related: Where were you when the GLVND was exposing more and more functions statically, because "there might be some program that uses it". I tried convincing the GLVND people that it's a bad idea, but was futile. Thanks Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}
On 03/05/2018 01:29 PM, Ian Romanick wrote: On 03/05/2018 11:08 AM, Ian Romanick wrote: On 03/05/2018 10:48 AM, Emil Velikov wrote: Hi all, It seems like these two extensions were never implemented or advertised. Be that in: - glx/dri - glx/apple - classic xlib-glx - gallium xlib-glx Yet, the entry points were available, hence apps might have linked against it. If an app was linking with an extension entry point instead of using glXGetProcAddress, it is the app's bug. True, but if we remove it and an app starts failing the end-user just thinks "broken driver" and gets frustrated. I seem to remember writing some GLX stubs years ago for that reason. Furthermore I cannot see any users of those on my system and a courtesy google search. Additionally the Nvidia driver (checked version 390.25) does not implement/advertise them either. That said, I'm fairly confident that we can safely remove the no-op stubs. Even though that the entry points were statically exposed. Brian, Ian, Do you have any recollection about these experimental SGI extensions? Ajax and I had talked about implementing swap_group a few times, but there were some technical challenges that we were too lazy to tackle. I think that's about as far as any of it ever got. I should have also said... Acked-by: Ian RomanickI'm fine with removing them too. If someone really complains, they can always be restored. Acked-by: Brian Paul Thanks Emil Cc: Ian Romanick Cc: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev=DwIGaQ=uilaK90D4TOVoH58JNXRgQ=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA=CvxXt0YOXugGkbbzyxn0jAoAF0A6dRVbzGLLUqFneB8=NKrvsG5BEf-hY9B40F25ozkFXQA9YzWqK8P4QpZ5Xtc= ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev=DwIGaQ=uilaK90D4TOVoH58JNXRgQ=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA=CvxXt0YOXugGkbbzyxn0jAoAF0A6dRVbzGLLUqFneB8=NKrvsG5BEf-hY9B40F25ozkFXQA9YzWqK8P4QpZ5Xtc= ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev=DwIGaQ=uilaK90D4TOVoH58JNXRgQ=Ie7_encNUsqxbSRbqbNgofw0ITcfE8JKfaUjIQhncGA=CvxXt0YOXugGkbbzyxn0jAoAF0A6dRVbzGLLUqFneB8=NKrvsG5BEf-hY9B40F25ozkFXQA9YzWqK8P4QpZ5Xtc= ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}
On 03/05/2018 11:08 AM, Ian Romanick wrote: > On 03/05/2018 10:48 AM, Emil Velikov wrote: >> Hi all, >> >> It seems like these two extensions were never implemented or advertised. >> Be that in: >> - glx/dri >> - glx/apple >> - classic xlib-glx >> - gallium xlib-glx >> >> Yet, the entry points were available, hence apps might have linked >> against it. > > If an app was linking with an extension entry point instead of using > glXGetProcAddress, it is the app's bug. > >> Furthermore I cannot see any users of those on my system and a courtesy >> google search. Additionally the Nvidia driver (checked version 390.25) >> does not implement/advertise them either. >> >> That said, I'm fairly confident that we can safely remove the no-op >> stubs. Even though that the entry points were statically exposed. >> >> Brian, Ian, >> >> Do you have any recollection about these experimental SGI extensions? > > Ajax and I had talked about implementing swap_group a few times, but > there were some technical challenges that we were too lazy to tackle. I > think that's about as far as any of it ever got. I should have also said... Acked-by: Ian Romanick>> Thanks >> Emil >> >> Cc: Ian Romanick >> Cc: Brian Paul >> >> ___ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}
On Mon, 2018-03-05 at 11:08 -0800, Ian Romanick wrote: > On 03/05/2018 10:48 AM, Emil Velikov wrote: > > > > Brian, Ian, > > > > Do you have any recollection about these experimental SGI extensions? > > Ajax and I had talked about implementing swap_group a few times, but > there were some technical challenges that we were too lazy to tackle. I > think that's about as far as any of it ever got. SGI Prism had this working with fglrx, I suspect InfiniteReality had it too. We got part of the server-side support merged to Xorg but I don't think the client side ever saw the light of day. At any rate the empty stubs can't possibly be helping anything. Series is: Reviewed-by: Adam Jackson- ajax ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier, group}
On 03/05/2018 10:48 AM, Emil Velikov wrote: > Hi all, > > It seems like these two extensions were never implemented or advertised. > Be that in: > - glx/dri > - glx/apple > - classic xlib-glx > - gallium xlib-glx > > Yet, the entry points were available, hence apps might have linked > against it. If an app was linking with an extension entry point instead of using glXGetProcAddress, it is the app's bug. > Furthermore I cannot see any users of those on my system and a courtesy > google search. Additionally the Nvidia driver (checked version 390.25) > does not implement/advertise them either. > > That said, I'm fairly confident that we can safely remove the no-op > stubs. Even though that the entry points were statically exposed. > > Brian, Ian, > > Do you have any recollection about these experimental SGI extensions? Ajax and I had talked about implementing swap_group a few times, but there were some technical challenges that we were too lazy to tackle. I think that's about as far as any of it ever got. > Thanks > Emil > > Cc: Ian Romanick> Cc: Brian Paul > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [RFC 0/6] Remove stubbed GLX_SGIX_swap_{barrier,group}
Hi all, It seems like these two extensions were never implemented or advertised. Be that in: - glx/dri - glx/apple - classic xlib-glx - gallium xlib-glx Yet, the entry points were available, hence apps might have linked against it. Furthermore I cannot see any users of those on my system and a courtesy google search. Additionally the Nvidia driver (checked version 390.25) does not implement/advertise them either. That said, I'm fairly confident that we can safely remove the no-op stubs. Even though that the entry points were statically exposed. Brian, Ian, Do you have any recollection about these experimental SGI extensions? Thanks Emil Cc: Ian RomanickCc: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev