Re: [Mesa-dev] Gallium interface rename proposals

[Eric Anholt]

On Sat, Sep 19, 2020 at 3:24 AM Marek Olšák  wrote:
>
> Hi,
>
> I don't know if you have been following gitlab, but there are a few cleanups 
> that I have been considering doing.
>
> Rename PIPE_TRANSFER flags to PIPE_MAP, and pipe_transfer_usage to 
> pipe_map_flags:
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5749
>
> Other proposed renames:
>
> transfer_map -> resource_map
> transfer_unmap -> resource_unmap
> transfer_flush_region -> resource_flush_mapped_range
> draw_vbo -> draw
>
> pipe_transfer_* aux helpers -> pipe_resource_* or pipe_texture_* depending on 
> context. We already have pipe_buffer_map.
>
> I'm inclined to keep the struct pipe_transfer name unchanged to indicate that 
> mappings can cause internal copies.\

I'm a fan of all of these changes, it feels like they get us closer to
normal terminology in the field.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Gallium interface rename proposals

[Brian Paul]

This all sounds find to me, FWIW.

-Brian


On 09/19/2020 04:24 AM, Marek Olšák wrote:

Hi,

I don't know if you have been following gitlab, but there are a few 
cleanups that I have been considering doing.


Rename PIPE_TRANSFER flags to PIPE_MAP, and pipe_transfer_usage to 
pipe_map_flags:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5749 



Other proposed renames:

transfer_map -> resource_map
transfer_unmap -> resource_unmap
transfer_flush_region -> resource_flush_mapped_range
draw_vbo -> draw

pipe_transfer_* aux helpers -> pipe_resource_* or pipe_texture_* 
depending on context. We already have pipe_buffer_map.


I'm inclined to keep the struct pipe_transfer name unchanged to indicate 
that mappings can cause internal copies.


Please let me know your preferences.

Thanks,
Marek


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-devdata=02%7C01%7Cbrianp%40vmware.com%7Cbedfd0817f704e06e75808d85c863fb3%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637361078970597391sdata=qI2%2BFMvRDEIePjAOjbGVwCOusUxyw6I1wwL7fJb%2Blgs%3Dreserved=0



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Gallium interface rename proposals

[Marek Olšák]

Hi,

I don't know if you have been following gitlab, but there are a few
cleanups that I have been considering doing.

Rename PIPE_TRANSFER flags to PIPE_MAP, and pipe_transfer_usage to
pipe_map_flags:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5749

Other proposed renames:

transfer_map -> resource_map
transfer_unmap -> resource_unmap
transfer_flush_region -> resource_flush_mapped_range
draw_vbo -> draw

pipe_transfer_* aux helpers -> pipe_resource_* or pipe_texture_* depending
on context. We already have pipe_buffer_map.

I'm inclined to keep the struct pipe_transfer name unchanged to indicate
that mappings can cause internal copies.

Please let me know your preferences.

Thanks,
Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev