Re: [Mesa-dev] vulkan video + beta header enables
On Fri, 5 Nov 2021 at 11:59, Jason Ekstrand wrote: > > On Thu, Nov 4, 2021 at 8:53 PM Dave Airlie wrote: > > > > Just polling for opinions here on how best to move forward with > > enabling the provisional vulkan beta headers in Mesa and the fallout > > from doing so for people importing updated vulkan headers. > > > > Do we want to allow beta/provisional features in main? > > IMO, it's fine as long as you never land the final patch which flips > on the extension or, if you do, make sure it's very carefully guarded. Well it's a bunch of extensions unfortunately. Like do we want a meson option vulkan_beta? https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13685 If we have a vulkan-beta option, does that just enabling building with the extensions or does it turn on those extensions? or should we have another meson option for that or even an out of tree patch in an MR as you suggest? Dave.
Re: [Mesa-dev] vulkan video + beta header enables
I think maybe a simple policy like: * always disable them for release builds * require env vars to enable at runtime would be enough to avoid having distros pick them up and block people from "relying" on them. Otherwise Jason's comment on collaboration seems sufficient for doing updates to the headers/xml. Might just be something we work with a bit more ad-hoc as more people start to work on/with beta features too. On Thu, 4 Nov 2021 20:59:11 -0500 Jason Ekstrand wrote: > On Thu, Nov 4, 2021 at 8:53 PM Dave Airlie wrote: > > > > Just polling for opinions here on how best to move forward with > > enabling the provisional vulkan beta headers in Mesa and the fallout > > from doing so for people importing updated vulkan headers. > > > > Do we want to allow beta/provisional features in main? > > IMO, it's fine as long as you never land the final patch which flips > on the extension or, if you do, make sure it's very carefully guarded. > > > Do we want to do it only under a meson option that distros never enable? > > RADV_I_KNOW_IM_ASKING_FOR_BETA_FEATURES_WHICH_MAY_NOT_WORK= > > That way, it's harder to put in your .profile. :-P Honestly, though, > just leave the last patch which flips it on in an MR that doesn't get > merged until the extension is final. > > > If we do, who is responsible for updating the beta code on new header > > import, since the video headers are under quite regular changes? > > That needs to be a collaboration between the people working on the > beta feature. Thanks to all the XML code-gen we do, it's pretty hard > to update it one driver at a time. Maybe that'd be possible but > ugh > > --Jason
Re: [Mesa-dev] vulkan video + beta header enables
On Thu, Nov 4, 2021 at 8:53 PM Dave Airlie wrote: > > Just polling for opinions here on how best to move forward with > enabling the provisional vulkan beta headers in Mesa and the fallout > from doing so for people importing updated vulkan headers. > > Do we want to allow beta/provisional features in main? IMO, it's fine as long as you never land the final patch which flips on the extension or, if you do, make sure it's very carefully guarded. > Do we want to do it only under a meson option that distros never enable? RADV_I_KNOW_IM_ASKING_FOR_BETA_FEATURES_WHICH_MAY_NOT_WORK= That way, it's harder to put in your .profile. :-P Honestly, though, just leave the last patch which flips it on in an MR that doesn't get merged until the extension is final. > If we do, who is responsible for updating the beta code on new header > import, since the video headers are under quite regular changes? That needs to be a collaboration between the people working on the beta feature. Thanks to all the XML code-gen we do, it's pretty hard to update it one driver at a time. Maybe that'd be possible but ugh --Jason
[Mesa-dev] vulkan video + beta header enables
Just polling for opinions here on how best to move forward with enabling the provisional vulkan beta headers in Mesa and the fallout from doing so for people importing updated vulkan headers. Do we want to allow beta/provisional features in main? Do we want to do it only under a meson option that distros never enable? If we do, who is responsible for updating the beta code on new header import, since the video headers are under quite regular changes? Dave.
