Re: [Mesa-dev] [PATCH shader-db 1/1] shaders: Add Dolphin’s übershaders

[Emil Velikov]

On 17 August 2017 at 16:23, Emmanuel Gil Peyrot  wrote:
> On Thu, Aug 17, 2017 at 02:04:25PM +0100, Emil Velikov wrote:
>> Hi Emmanuel,
>
> Hi Emil,
>
>>
>> On 5 August 2017 at 04:35, Emmanuel Gil Peyrot  
>> wrote:
>> > These shaders have been generated by Dolphin 9649494f67 on Mesa
>> > 8c26b52349 for an HD4000 GPU.
>> >
>> > They include a lot of uniform branches, mostly on integers, as well as
>> > switch statements branching on small and bounded integers.
>> >
>> > Signed-off-by: Emmanuel Gil Peyrot 
>> > ---
>> >
>> > The actual patch isn’t included because it was more than 1 MiB, I
>> > hosted it on my website instead:
>> > https://linkmauve.fr/files/0001-shaders-Add-Dolphin-s-bershaders.patch
>> >
>> I think these are fine to land, although we'll need a note about the
>> license they're under.
>>
>> Please add a few lines to COPYING and the full license under licenses/
>> Latter if needed, I don't recall which GPL was applicable here.
>
> The COPYING file already lists shaders/dolphin/* as being under GPL2+,
> so I don’t need to do anything more and this patch can land as-is.
>
You're right - the copyright info is already there.
Pushed the patch to master.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH shader-db 1/1] shaders: Add Dolphin’s übershaders

[Emmanuel Gil Peyrot]

On Thu, Aug 17, 2017 at 02:04:25PM +0100, Emil Velikov wrote:
> Hi Emmanuel,

Hi Emil,

> 
> On 5 August 2017 at 04:35, Emmanuel Gil Peyrot  wrote:
> > These shaders have been generated by Dolphin 9649494f67 on Mesa
> > 8c26b52349 for an HD4000 GPU.
> >
> > They include a lot of uniform branches, mostly on integers, as well as
> > switch statements branching on small and bounded integers.
> >
> > Signed-off-by: Emmanuel Gil Peyrot 
> > ---
> >
> > The actual patch isn’t included because it was more than 1 MiB, I
> > hosted it on my website instead:
> > https://linkmauve.fr/files/0001-shaders-Add-Dolphin-s-bershaders.patch
> >
> I think these are fine to land, although we'll need a note about the
> license they're under.
> 
> Please add a few lines to COPYING and the full license under licenses/
> Latter if needed, I don't recall which GPL was applicable here.

The COPYING file already lists shaders/dolphin/* as being under GPL2+,
so I don’t need to do anything more and this patch can land as-is.

> 
> Both squashed and follow-up patches should be fine IMHO.
> 
> Thanks
> Emil

Thanks for the review,

-- 
Emmanuel Gil Peyrot


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH shader-db 1/1] shaders: Add Dolphin’s übershaders

[Emil Velikov]

Hi Emmanuel,

On 5 August 2017 at 04:35, Emmanuel Gil Peyrot  wrote:
> These shaders have been generated by Dolphin 9649494f67 on Mesa
> 8c26b52349 for an HD4000 GPU.
>
> They include a lot of uniform branches, mostly on integers, as well as
> switch statements branching on small and bounded integers.
>
> Signed-off-by: Emmanuel Gil Peyrot 
> ---
>
> The actual patch isn’t included because it was more than 1 MiB, I
> hosted it on my website instead:
> https://linkmauve.fr/files/0001-shaders-Add-Dolphin-s-bershaders.patch
>
I think these are fine to land, although we'll need a note about the
license they're under.

Please add a few lines to COPYING and the full license under licenses/
Latter if needed, I don't recall which GPL was applicable here.

Both squashed and follow-up patches should be fine IMHO.

Thanks
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev