Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Fix black buffers when importing prime fds

2014-09-17 Thread Daniel Stone
Reviewed-by: Daniel Stone dani...@collabora.com

On 16 September 2014 22:29, Emil Velikov emil.l.veli...@gmail.com wrote:

 Another humble ping.

 I realise that i915 hardware is not top priority yet 5 minutes of someone
 experienced with the driver will be greatly appreciated :)

 Cheers,
 Emil

 On 05/09/14 16:20, Emil Velikov wrote:
  Hmm the previous cover letter was not attached to any patches :\
  Anywho, can someone take a few minutes to check this out ?
 
  -Emil
 
  On 27/08/14 08:36, Andreas Pokorny wrote:
  Width and Height of the imported image was never initialized from the
  imported bo.
 
  Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com
  ---
   src/mesa/drivers/dri/i915/intel_screen.c | 2 ++
   1 file changed, 2 insertions(+)
 
  diff --git a/src/mesa/drivers/dri/i915/intel_screen.c
 b/src/mesa/drivers/dri/i915/intel_screen.c
  index 3aaa45f..00d8580 100644
  --- a/src/mesa/drivers/dri/i915/intel_screen.c
  +++ b/src/mesa/drivers/dri/i915/intel_screen.c
  @@ -616,6 +616,8 @@ intel_create_image_from_fds(__DRIscreen *screen,
 return NULL;
  }
 
  +   intel_setup_image_from_dimensions(image);
  +
  image-planar_format = f;
  for (i = 0; i  f-nplanes; i++) {
 index = f-planes[i].buffer_index;
 
 

 ___
 mesa-dev mailing list
 mesa-dev@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Fix black buffers when importing prime fds

2014-09-16 Thread Emil Velikov
Another humble ping.

I realise that i915 hardware is not top priority yet 5 minutes of someone
experienced with the driver will be greatly appreciated :)

Cheers,
Emil

On 05/09/14 16:20, Emil Velikov wrote:
 Hmm the previous cover letter was not attached to any patches :\
 Anywho, can someone take a few minutes to check this out ?
 
 -Emil
 
 On 27/08/14 08:36, Andreas Pokorny wrote:
 Width and Height of the imported image was never initialized from the
 imported bo.

 Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com
 ---
  src/mesa/drivers/dri/i915/intel_screen.c | 2 ++
  1 file changed, 2 insertions(+)

 diff --git a/src/mesa/drivers/dri/i915/intel_screen.c 
 b/src/mesa/drivers/dri/i915/intel_screen.c
 index 3aaa45f..00d8580 100644
 --- a/src/mesa/drivers/dri/i915/intel_screen.c
 +++ b/src/mesa/drivers/dri/i915/intel_screen.c
 @@ -616,6 +616,8 @@ intel_create_image_from_fds(__DRIscreen *screen,
return NULL;
 }
  
 +   intel_setup_image_from_dimensions(image);
 +
 image-planar_format = f;
 for (i = 0; i  f-nplanes; i++) {
index = f-planes[i].buffer_index;

 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Fix black buffers when importing prime fds

2014-09-05 Thread Emil Velikov
Hmm the previous cover letter was not attached to any patches :\
Anywho, can someone take a few minutes to check this out ?

-Emil

On 27/08/14 08:36, Andreas Pokorny wrote:
 Width and Height of the imported image was never initialized from the
 imported bo.
 
 Signed-off-by: Andreas Pokorny andreas.poko...@canonical.com
 ---
  src/mesa/drivers/dri/i915/intel_screen.c | 2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/src/mesa/drivers/dri/i915/intel_screen.c 
 b/src/mesa/drivers/dri/i915/intel_screen.c
 index 3aaa45f..00d8580 100644
 --- a/src/mesa/drivers/dri/i915/intel_screen.c
 +++ b/src/mesa/drivers/dri/i915/intel_screen.c
 @@ -616,6 +616,8 @@ intel_create_image_from_fds(__DRIscreen *screen,
return NULL;
 }
  
 +   intel_setup_image_from_dimensions(image);
 +
 image-planar_format = f;
 for (i = 0; i  f-nplanes; i++) {
index = f-planes[i].buffer_index;
 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev