Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Thomas Helland]

Also, should probably update the release notes.

-Thomas



8. aug. 2017 00.31 skrev "Ian Romanick" :

On 08/07/2017 03:20 PM, Ilia Mirkin wrote:
> On Mon, Aug 7, 2017 at 6:14 PM, Ian Romanick  wrote:
>> On 06/28/2017 06:50 AM, Plamena Manolova wrote:
>>> ARB_polygon_offset_clamp is just the ARB variation
>>> of EXT_polygon_offset_clamp and they operate in an
>>> identical manner, so there's no reason for us not
>>> to advertise it.
>>>
>>> Signed-off-by: Plamena Manolova 
>>> ---
>>>  src/mesa/main/extensions_table.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/mesa/main/extensions_table.h
b/src/mesa/main/extensions_table.h
>>> index 757b7bf..8286c76 100644
>>> --- a/src/mesa/main/extensions_table.h
>>> +++ b/src/mesa/main/extensions_table.h
>>> @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   ,
ARB_pipeline_statistics_query
>>>  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object
  , GLL, GLC,  x ,  x , 2004)
>>>  EXT(ARB_point_parameters, EXT_point_parameters
   , GLL,  x ,  x ,  x , 1997)
>>>  EXT(ARB_point_sprite, ARB_point_sprite
   , GLL, GLC,  x ,  x , 2003)
>>> +EXT(ARB_polygon_offset_clamp,
EXT_polygon_offset_clamp   , GLL, GLC, ES1, ES2, 2017)
>>
>> This should be
  GLL, GLC,  x,   x,  2017
>>
>> With that fixed and docs/features.txt updated, this patch is
>>
>> Reviewed-by: Ian Romanick 
>
> Should probably hook up the dispatch for the function too... and
> update headers so that what we're shipping includes the bits for the
> exts we're exposing.

You are, of course, correct.  I was thinking that this extension just
added an enum like ARB_texture_filter_anisotropic.

>   -ilia
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Ian Romanick]

On 08/07/2017 03:20 PM, Ilia Mirkin wrote:
> On Mon, Aug 7, 2017 at 6:14 PM, Ian Romanick  wrote:
>> On 06/28/2017 06:50 AM, Plamena Manolova wrote:
>>> ARB_polygon_offset_clamp is just the ARB variation
>>> of EXT_polygon_offset_clamp and they operate in an
>>> identical manner, so there's no reason for us not
>>> to advertise it.
>>>
>>> Signed-off-by: Plamena Manolova 
>>> ---
>>>  src/mesa/main/extensions_table.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/mesa/main/extensions_table.h 
>>> b/src/mesa/main/extensions_table.h
>>> index 757b7bf..8286c76 100644
>>> --- a/src/mesa/main/extensions_table.h
>>> +++ b/src/mesa/main/extensions_table.h
>>> @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   , 
>>> ARB_pipeline_statistics_query
>>>  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object  
>>>   , GLL, GLC,  x ,  x , 2004)
>>>  EXT(ARB_point_parameters, EXT_point_parameters 
>>>   , GLL,  x ,  x ,  x , 1997)
>>>  EXT(ARB_point_sprite, ARB_point_sprite 
>>>   , GLL, GLC,  x ,  x , 2003)
>>> +EXT(ARB_polygon_offset_clamp, EXT_polygon_offset_clamp 
>>>   , GLL, GLC, ES1, ES2, 2017)
>>
>> This should be   
>>  GLL, GLC,  x,   x,  2017
>>
>> With that fixed and docs/features.txt updated, this patch is
>>
>> Reviewed-by: Ian Romanick 
> 
> Should probably hook up the dispatch for the function too... and
> update headers so that what we're shipping includes the bits for the
> exts we're exposing.

You are, of course, correct.  I was thinking that this extension just
added an enum like ARB_texture_filter_anisotropic.

>   -ilia
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Ilia Mirkin]

On Mon, Aug 7, 2017 at 6:14 PM, Ian Romanick  wrote:
> On 06/28/2017 06:50 AM, Plamena Manolova wrote:
>> ARB_polygon_offset_clamp is just the ARB variation
>> of EXT_polygon_offset_clamp and they operate in an
>> identical manner, so there's no reason for us not
>> to advertise it.
>>
>> Signed-off-by: Plamena Manolova 
>> ---
>>  src/mesa/main/extensions_table.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/mesa/main/extensions_table.h 
>> b/src/mesa/main/extensions_table.h
>> index 757b7bf..8286c76 100644
>> --- a/src/mesa/main/extensions_table.h
>> +++ b/src/mesa/main/extensions_table.h
>> @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   , 
>> ARB_pipeline_statistics_query
>>  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object   
>>  , GLL, GLC,  x ,  x , 2004)
>>  EXT(ARB_point_parameters, EXT_point_parameters  
>>  , GLL,  x ,  x ,  x , 1997)
>>  EXT(ARB_point_sprite, ARB_point_sprite  
>>  , GLL, GLC,  x ,  x , 2003)
>> +EXT(ARB_polygon_offset_clamp, EXT_polygon_offset_clamp  
>>  , GLL, GLC, ES1, ES2, 2017)
>
> This should be
> GLL, GLC,  x,   x,  2017
>
> With that fixed and docs/features.txt updated, this patch is
>
> Reviewed-by: Ian Romanick 

Should probably hook up the dispatch for the function too... and
update headers so that what we're shipping includes the bits for the
exts we're exposing.

  -ilia
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Ian Romanick]

On 06/28/2017 06:50 AM, Plamena Manolova wrote:
> ARB_polygon_offset_clamp is just the ARB variation
> of EXT_polygon_offset_clamp and they operate in an
> identical manner, so there's no reason for us not
> to advertise it.
> 
> Signed-off-by: Plamena Manolova 
> ---
>  src/mesa/main/extensions_table.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/main/extensions_table.h 
> b/src/mesa/main/extensions_table.h
> index 757b7bf..8286c76 100644
> --- a/src/mesa/main/extensions_table.h
> +++ b/src/mesa/main/extensions_table.h
> @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   , 
> ARB_pipeline_statistics_query
>  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object
> , GLL, GLC,  x ,  x , 2004)
>  EXT(ARB_point_parameters, EXT_point_parameters   
> , GLL,  x ,  x ,  x , 1997)
>  EXT(ARB_point_sprite, ARB_point_sprite   
> , GLL, GLC,  x ,  x , 2003)
> +EXT(ARB_polygon_offset_clamp, EXT_polygon_offset_clamp   
> , GLL, GLC, ES1, ES2, 2017)

This should be  
  GLL, GLC,  x,   x,  2017

With that fixed and docs/features.txt updated, this patch is

Reviewed-by: Ian Romanick 

>  EXT(ARB_post_depth_coverage , ARB_post_depth_coverage
> ,  x , GLC,  x ,  x,  2015)
>  EXT(ARB_program_interface_query , dummy_true 
> , GLL, GLC,  x ,  x , 2012)
>  EXT(ARB_provoking_vertex, EXT_provoking_vertex   
> , GLL, GLC,  x ,  x , 2009)
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Ilia Mirkin]

OK, well, I don't know what our policy is on adding unpublished
extensions. However I've yet to see an ARB extension that says it's
available in GL ES contexts, so at the very least you'd have to
replace ES1, ES2 with x's.

Someone with access to the spec will have to do a proper review of this though.

Cheers,

  -ilia

On Wed, Jun 28, 2017 at 9:55 AM, Manolova, Plamena
 wrote:
> Yes, it doesn't seem to be part of the registry yet, but it's one of the
> requirements for GL 4.6 apparently.
>
> On Wed, Jun 28, 2017 at 4:53 PM, Ilia Mirkin  wrote:
>>
>> Google seems to have no mention of such an extension.
>> https://khronos.org/registry/OpenGL/index_gl.php doesn't either.
>>
>> On Wed, Jun 28, 2017 at 9:50 AM, Plamena Manolova
>>  wrote:
>> > ARB_polygon_offset_clamp is just the ARB variation
>> > of EXT_polygon_offset_clamp and they operate in an
>> > identical manner, so there's no reason for us not
>> > to advertise it.
>> >
>> > Signed-off-by: Plamena Manolova 
>> > ---
>> >  src/mesa/main/extensions_table.h | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/src/mesa/main/extensions_table.h
>> > b/src/mesa/main/extensions_table.h
>> > index 757b7bf..8286c76 100644
>> > --- a/src/mesa/main/extensions_table.h
>> > +++ b/src/mesa/main/extensions_table.h
>> > @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   ,
>> > ARB_pipeline_statistics_query
>> >  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object
>> > , GLL, GLC,  x ,  x , 2004)
>> >  EXT(ARB_point_parameters, EXT_point_parameters
>> > , GLL,  x ,  x ,  x , 1997)
>> >  EXT(ARB_point_sprite, ARB_point_sprite
>> > , GLL, GLC,  x ,  x , 2003)
>> > +EXT(ARB_polygon_offset_clamp, EXT_polygon_offset_clamp
>> > , GLL, GLC, ES1, ES2, 2017)
>> >  EXT(ARB_post_depth_coverage , ARB_post_depth_coverage
>> > ,  x , GLC,  x ,  x,  2015)
>> >  EXT(ARB_program_interface_query , dummy_true
>> > , GLL, GLC,  x ,  x , 2012)
>> >  EXT(ARB_provoking_vertex, EXT_provoking_vertex
>> > , GLL, GLC,  x ,  x , 2009)
>> > --
>> > 2.9.3
>> >
>> > ___
>> > mesa-dev mailing list
>> > mesa-dev@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Manolova, Plamena]

Yes, it doesn't seem to be part of the registry yet, but it's one of the
requirements for GL 4.6 apparently.

On Wed, Jun 28, 2017 at 4:53 PM, Ilia Mirkin  wrote:

> Google seems to have no mention of such an extension.
> https://khronos.org/registry/OpenGL/index_gl.php doesn't either.
>
> On Wed, Jun 28, 2017 at 9:50 AM, Plamena Manolova
>  wrote:
> > ARB_polygon_offset_clamp is just the ARB variation
> > of EXT_polygon_offset_clamp and they operate in an
> > identical manner, so there's no reason for us not
> > to advertise it.
> >
> > Signed-off-by: Plamena Manolova 
> > ---
> >  src/mesa/main/extensions_table.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/mesa/main/extensions_table.h
> b/src/mesa/main/extensions_table.h
> > index 757b7bf..8286c76 100644
> > --- a/src/mesa/main/extensions_table.h
> > +++ b/src/mesa/main/extensions_table.h
> > @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   ,
> ARB_pipeline_statistics_query
> >  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object
>   , GLL, GLC,  x ,  x , 2004)
> >  EXT(ARB_point_parameters, EXT_point_parameters
>  , GLL,  x ,  x ,  x , 1997)
> >  EXT(ARB_point_sprite, ARB_point_sprite
>  , GLL, GLC,  x ,  x , 2003)
> > +EXT(ARB_polygon_offset_clamp, EXT_polygon_offset_clamp
>  , GLL, GLC, ES1, ES2, 2017)
> >  EXT(ARB_post_depth_coverage , ARB_post_depth_coverage
>   ,  x , GLC,  x ,  x,  2015)
> >  EXT(ARB_program_interface_query , dummy_true
>, GLL, GLC,  x ,  x , 2012)
> >  EXT(ARB_provoking_vertex, EXT_provoking_vertex
>  , GLL, GLC,  x ,  x , 2009)
> > --
> > 2.9.3
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa/main: Advertise ARB_polygon_offset_clamp.

[Ilia Mirkin]

Google seems to have no mention of such an extension.
https://khronos.org/registry/OpenGL/index_gl.php doesn't either.

On Wed, Jun 28, 2017 at 9:50 AM, Plamena Manolova
 wrote:
> ARB_polygon_offset_clamp is just the ARB variation
> of EXT_polygon_offset_clamp and they operate in an
> identical manner, so there's no reason for us not
> to advertise it.
>
> Signed-off-by: Plamena Manolova 
> ---
>  src/mesa/main/extensions_table.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/extensions_table.h 
> b/src/mesa/main/extensions_table.h
> index 757b7bf..8286c76 100644
> --- a/src/mesa/main/extensions_table.h
> +++ b/src/mesa/main/extensions_table.h
> @@ -94,6 +94,7 @@ EXT(ARB_pipeline_statistics_query   , 
> ARB_pipeline_statistics_query
>  EXT(ARB_pixel_buffer_object , EXT_pixel_buffer_object
> , GLL, GLC,  x ,  x , 2004)
>  EXT(ARB_point_parameters, EXT_point_parameters   
> , GLL,  x ,  x ,  x , 1997)
>  EXT(ARB_point_sprite, ARB_point_sprite   
> , GLL, GLC,  x ,  x , 2003)
> +EXT(ARB_polygon_offset_clamp, EXT_polygon_offset_clamp   
> , GLL, GLC, ES1, ES2, 2017)
>  EXT(ARB_post_depth_coverage , ARB_post_depth_coverage
> ,  x , GLC,  x ,  x,  2015)
>  EXT(ARB_program_interface_query , dummy_true 
> , GLL, GLC,  x ,  x , 2012)
>  EXT(ARB_provoking_vertex, EXT_provoking_vertex   
> , GLL, GLC,  x ,  x , 2009)
> --
> 2.9.3
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev