Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Michel Dänzer]

On 2019-12-11 7:35 p.m., Marek Olšák wrote:
> 
> Merging a branch:
> 1*) Check that all CI pipelines have succeeded.
> 2) Rebase your local branch and force-push to your private branch.
> 3) Wait ~10 seconds.
> 4) Push that branch to master (git push origin HEAD:master). Gitlab will
> automatically mark the MR as "Merged".

These steps 2-4 should only be used in exceptional cases, as they will
bypass the CI pipeline. Normally, one should either wait for the CI
pipeline to come back green before merging, or click "Merge
automatically when pipeline succeeds".


-- 
Earthling Michel Dänzer   |   https://redhat.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Dylan Baker]

Quoting Nathan Kidd (2019-12-11 06:41:12)
> On 2019-12-10 7:10 p.m., Jason Ekstrand wrote:
> > Quoting Zebediah Figura (2019-12-10 10:58:45)
> > > On 12/10/19 12:21 PM, Matt Turner wrote:
> > > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
> > > > > I think its time we discussed whether we're going to continue to do 
> > > > > patch review
> > > > > on the mailing list, or if it it should all go through gitlab. I 
> > > > > think we should
> > > > > stop using the mailing list, here are some reasons:
> > > > >
> > > > > 1) Most development is happening on gitlab at this point, patches on 
> > > > > the mailing
> > > > >    list are often overlooked
> > > > > 2) The mailing list bypasses CI which potentially breaks the build
> > > >
> > > > What concrete change would you propose?
> > >
> > > Removing mention of the mailing list from documentation would be nice.
> > > Also, currently the README implies that the mailing list is not only
> > > acceptable but preferred: "Note that Mesa uses email mailing-lists for
> > > patches submission, review and discussions."
> > 
> > I think updating README type docs is sufficient and I think it's
> > probably time we did that.  
> 
> As a recent drive-by patch submitter, updating the web page and other
> docs to say "use GitLab" would have been sufficient for me.  As they are
> now it wasn't clear which way is preferred, so I defaulted to using
> mesa-dev@ only to find that the dev focus seems to be in gitlab.fd.o and
> if it wasn't for Roland watching the mailing list my patch seemed likely
> to get missed.
> 
> I also went through the work of subscribing to mesa-stable@ to nominate
> there, but again it feels like I missed the de-facto channel for
> suggesting a stable backport patch.   Hint hint [1]. :)

Gahh, mesa-stable is a mailing list I *do* want to complete purge, MRs for
backports, "cc" or "fixes" in the commit message otherwise. I'll update the docs
to mention that.

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Marek Olšák]

On Wed, Dec 11, 2019 at 12:02 PM Brian Paul  wrote:

> On 12/09/2019 04:07 PM, Dylan Baker wrote:
> > Hi everyone,
> >
> > I think its time we discussed whether we're going to continue to do
> patch review
> > on the mailing list, or if it it should all go through gitlab. I think
> we should
> > stop using the mailing list, here are some reasons:
> >
> > 1) Most development is happening on gitlab at this point, patches on the
> mailing
> > list are often overlooked
> > 2) The mailing list bypasses CI which potentially breaks the build
> > 3) Probably more reasons I'm forgetting.
>
>
> I've had little time for Mesa work the past 18 months.  But I'd say:
>
> 1. I don't think the mesa-dev list should be shut down nor purged from
> the documentation.
>
> 2. I think the complete workflow for submitting patches via gitlab MRs
> should be documented on the Mesa site.  Being a gitlab newbie I wasted a
> lot of time a few months ago trying to figure out the details.  Mesa's
> "Submitting Patches" page is kind of a mess.  It would be great if
> someone could work on that.
>

Yeah, the "Submitting Patches" page is useless, because it doesn't say the
things that you need to know, and it says the things that you mostly do NOT
need to know.

The steps for creating a MR are:
1*) Click "fork" in the Meso repo to create a private repo where you'll
push branches for MRs.
2) git push your branch into your private repo
3) The "git push" command printed a link to create a MR for that branch.
Open it.
4*) Add labels, then click "Allow commits from members who can merge to the
target branch" and click Submit.

Merging a branch:
1*) Check that all CI pipelines have succeeded.
2) Rebase your local branch and force-push to your private branch.
3) Wait ~10 seconds.
4) Push that branch to master (git push origin HEAD:master). Gitlab will
automatically mark the MR as "Merged".

* these are the only steps when you need to use the web UI.

Marek
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Rob Clark]

On Wed, Dec 11, 2019 at 9:58 AM Brian Paul  wrote:
>
> On 12/11/2019 10:42 AM, Jason Ekstrand wrote:
> > On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer  > > wrote:
> >
> > On 2019-12-11 5:47 p.m., Brian Paul wrote:
> >  >
> >  > I've had little time for Mesa work the past 18 months.
> >
> > That makes me sad, I hope you'll have more time again in the future.
>
> Between family life and VMware work, there's little left over.  I'll be
> lurking if nothing else.
>
>
> >  > 1. I don't think the mesa-dev list should be shut down nor purged
> > from
> >  > the documentation.
> >
> > Yeah, I don't think anybody seriously suggested the list should be shut
> > down, just that GitLab is now preferred for patch submission & review.
> >
> >
> >  > Someone mentioned hardly reading the mailing list anymore.  I still
> >  > haven't gotten into the habit of monitoring the MRs page...
> >
> > Instead of monitoring a web page, I recommend setting up notifications
> > via the bell icon on https://gitlab.freedesktop.org/mesa/mesa
> > 
> > 
> > [0]. If
> > you select "Custom", you can select in detail which events you want to
> > get notification e-mails for. Check "New merge request" to get an e-mail
> > for each new MR created. Then you can either enable notifications for
> > other MR events here as well, or enable all notifications for MRs you're
> > interested in using the "Notifications" switch in the right hand panel
> > on each MR's page.
>
> Thanks for the tip!  That's the kind of thing that would be useful to
> document.
>
>
> > You can also subscribe to specific labels which is what I've done.  That
> > way I get e-mails about anything going on in NIR or our Vulkan driver
> > but don't have to see every nouveau MR.
>
> Are labels put on MRs automatically or does the person submitting have
> to do that manually?
>

unfortunately it is manual.. and it is slightly worse in that you need
to have developer permissions in gitlab to add labels..

(some bot that automatically added labels based on some path regex
rules would be super spiffy)

BR,
-R
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Brian Paul]

On 12/11/2019 10:42 AM, Jason Ekstrand wrote:
On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer > wrote:


On 2019-12-11 5:47 p.m., Brian Paul wrote:
 >
 > I've had little time for Mesa work the past 18 months.

That makes me sad, I hope you'll have more time again in the future.


Between family life and VMware work, there's little left over.  I'll be 
lurking if nothing else.




 > 1. I don't think the mesa-dev list should be shut down nor purged
from
 > the documentation.

Yeah, I don't think anybody seriously suggested the list should be shut
down, just that GitLab is now preferred for patch submission & review.


 > Someone mentioned hardly reading the mailing list anymore.  I still
 > haven't gotten into the habit of monitoring the MRs page...

Instead of monitoring a web page, I recommend setting up notifications
via the bell icon on https://gitlab.freedesktop.org/mesa/mesa


[0]. If
you select "Custom", you can select in detail which events you want to
get notification e-mails for. Check "New merge request" to get an e-mail
for each new MR created. Then you can either enable notifications for
other MR events here as well, or enable all notifications for MRs you're
interested in using the "Notifications" switch in the right hand panel
on each MR's page.


Thanks for the tip!  That's the kind of thing that would be useful to 
document.



You can also subscribe to specific labels which is what I've done.  That 
way I get e-mails about anything going on in NIR or our Vulkan driver 
but don't have to see every nouveau MR.


Are labels put on MRs automatically or does the person submitting have 
to do that manually?


-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Jason Ekstrand]

On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer  wrote:

> On 2019-12-11 5:47 p.m., Brian Paul wrote:
> >
> > I've had little time for Mesa work the past 18 months.
>
> That makes me sad, I hope you'll have more time again in the future.
>
>
> > 1. I don't think the mesa-dev list should be shut down nor purged from
> > the documentation.
>
> Yeah, I don't think anybody seriously suggested the list should be shut
> down, just that GitLab is now preferred for patch submission & review.
>
>
> > Someone mentioned hardly reading the mailing list anymore.  I still
> > haven't gotten into the habit of monitoring the MRs page...
>
> Instead of monitoring a web page, I recommend setting up notifications
> via the bell icon on https://gitlab.freedesktop.org/mesa/mesa [0]. If
> you select "Custom", you can select in detail which events you want to
> get notification e-mails for. Check "New merge request" to get an e-mail
> for each new MR created. Then you can either enable notifications for
> other MR events here as well, or enable all notifications for MRs you're
> interested in using the "Notifications" switch in the right hand panel
> on each MR's page.
>

You can also subscribe to specific labels which is what I've done.  That
way I get e-mails about anything going on in NIR or our Vulkan driver but
don't have to see every nouveau MR.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Michel Dänzer]

On 2019-12-11 5:47 p.m., Brian Paul wrote:
> 
> I've had little time for Mesa work the past 18 months.

That makes me sad, I hope you'll have more time again in the future.


> 1. I don't think the mesa-dev list should be shut down nor purged from
> the documentation.

Yeah, I don't think anybody seriously suggested the list should be shut
down, just that GitLab is now preferred for patch submission & review.


> Someone mentioned hardly reading the mailing list anymore.  I still
> haven't gotten into the habit of monitoring the MRs page...

Instead of monitoring a web page, I recommend setting up notifications
via the bell icon on https://gitlab.freedesktop.org/mesa/mesa [0]. If
you select "Custom", you can select in detail which events you want to
get notification e-mails for. Check "New merge request" to get an e-mail
for each new MR created. Then you can either enable notifications for
other MR events here as well, or enable all notifications for MRs you're
interested in using the "Notifications" switch in the right hand panel
on each MR's page.

GitLab notification e-mails contain X-Gitlab-* headers for easy filtering.


[0] Or for the whole Mesa group, if you prefer.


-- 
Earthling Michel Dänzer   |   https://redhat.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Brian Paul]

On 12/09/2019 04:07 PM, Dylan Baker wrote:

Hi everyone,

I think its time we discussed whether we're going to continue to do patch review
on the mailing list, or if it it should all go through gitlab. I think we should
stop using the mailing list, here are some reasons:

1) Most development is happening on gitlab at this point, patches on the mailing
list are often overlooked
2) The mailing list bypasses CI which potentially breaks the build
3) Probably more reasons I'm forgetting.



I've had little time for Mesa work the past 18 months.  But I'd say:

1. I don't think the mesa-dev list should be shut down nor purged from 
the documentation.


2. I think the complete workflow for submitting patches via gitlab MRs 
should be documented on the Mesa site.  Being a gitlab newbie I wasted a 
lot of time a few months ago trying to figure out the details.  Mesa's 
"Submitting Patches" page is kind of a mess.  It would be great if 
someone could work on that.


Someone mentioned hardly reading the mailing list anymore.  I still 
haven't gotten into the habit of monitoring the MRs page...


-Brian
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Nathan Kidd]

On 2019-12-10 7:10 p.m., Jason Ekstrand wrote:
> Quoting Zebediah Figura (2019-12-10 10:58:45)
> > On 12/10/19 12:21 PM, Matt Turner wrote:
> > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
> > > > I think its time we discussed whether we're going to continue to do 
> > > > patch review
> > > > on the mailing list, or if it it should all go through gitlab. I think 
> > > > we should
> > > > stop using the mailing list, here are some reasons:
> > > >
> > > > 1) Most development is happening on gitlab at this point, patches on 
> > > > the mailing
> > > >    list are often overlooked
> > > > 2) The mailing list bypasses CI which potentially breaks the build
> > >
> > > What concrete change would you propose?
> >
> > Removing mention of the mailing list from documentation would be nice.
> > Also, currently the README implies that the mailing list is not only
> > acceptable but preferred: "Note that Mesa uses email mailing-lists for
> > patches submission, review and discussions."
> 
> I think updating README type docs is sufficient and I think it's
> probably time we did that.  

As a recent drive-by patch submitter, updating the web page and other
docs to say "use GitLab" would have been sufficient for me.  As they are
now it wasn't clear which way is preferred, so I defaulted to using
mesa-dev@ only to find that the dev focus seems to be in gitlab.fd.o and
if it wasn't for Roland watching the mailing list my patch seemed likely
to get missed.

I also went through the work of subscribing to mesa-stable@ to nominate
there, but again it feels like I missed the de-facto channel for
suggesting a stable backport patch.   Hint hint [1]. :)

GitLab would have been preferred all round.

-Nathan

[1] llvmpipe: Check thread creation errors
9a80b7fd8f282d4b448f826ff88c8770c079fb72

Prevents a SEGV in situations where thread creation is restricted
(cgroups, ulimit -u, /proc/sys/kernel/threads-max, etc.)
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Jason Ekstrand]

On Tue, Dec 10, 2019 at 4:59 PM Dylan Baker  wrote:

> Quoting Zebediah Figura (2019-12-10 10:58:45)
> > On 12/10/19 12:21 PM, Matt Turner wrote:
> > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker 
> wrote:
> > >>
> > >> Hi everyone,
> > >>
> > >> I think its time we discussed whether we're going to continue to do
> patch review
> > >> on the mailing list, or if it it should all go through gitlab. I
> think we should
> > >> stop using the mailing list, here are some reasons:
> > >>
> > >> 1) Most development is happening on gitlab at this point, patches on
> the mailing
> > >> list are often overlooked
> > >> 2) The mailing list bypasses CI which potentially breaks the build
> > >> 3) Probably more reasons I'm forgetting.
> > >
> > > I think effectively we're already there.
> > >
> > > What concrete change would you propose?
> >
> > Removing mention of the mailing list from documentation would be nice.
> > Also, currently the README implies that the mailing list is not only
> > acceptable but preferred: "Note that Mesa uses email mailing-lists for
> > patches submission, review and discussions."
>
> This would be a good start, I don't know what else to do to stop people
> from
> sending patches, maybe mailman has some kind of hook we can add to spot
> patches
> and mention that gitlab is preferred? No idea.
>

I think updating README type docs is sufficient and I think it's probably
time we did that.  If someone sends a patch to the ML anyway, we should
just go ahead and review it and suggest that next time they open an MR next
time.  I don't think we need a hook or to do anything more forceful.  If
the odd patch ends up on the mailing list, it won't hurt anyone.

As far about "OMG what if a drive-by person sends a patch!" goes I
don't think that's all that likely.  New contributors are far more likely
to understand the PR model from experience with GitHub than they are to
know how to send patches.  (Unless they're already a long-time contributor
to other systems level Linux projects but new to Mesa).  If it does happen,
we shouldn't make a big stink about it.  We should just review the patch
and suggest a pull request for next time.  If the patch needs more than
just rubber-stamp review, maybe say "I've got some comments, mind making a
PR so we can discuss it there?"

If people are all that concerned about CI, we can say that if you are
pushing patches on behalf of someone else, you should create a MR and merge
it that way.

--Jason
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Timothy Arceri]

On 11/12/19 8:54 am, Alex Deucher wrote:

On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker  wrote:


Do we have those and does anyone notice? I personally rarely look at the list
now unless I'm CC'd on something. That seems really bad for drive by
contributors.

But frankly I wouldn't submit to a mailing list as a drive by, it's more work to
get subscribed to mail man (so my patch goes through), set up get-send-email,
and send the patches, then unsubscribe when I'm done than it would be to sign up
for gitlab.fdo using one of the "sign-in-with" options. If you're not subscribed
you go into limbo until a list maintainer approves your patch, and I think any
follow ups. That seems even worse as most people probably aren't aware of that
behavior. Maybe I'm the only one who feels that way though.


I've still seen a few.


The only ones I've seen recently are from some new ? AMD devs and a few 
patches from Jonathan Gray who is a long time contributor.


Having merge request run though basic CI before merging is enough reason 
to no longer suggest people use the mailing list for patch submission. 
I've created a MR to update the docs.


https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3045


 Most drive by contributors generally don't
subscribe to the list.  Since most lists are moderated, the mail
usually makes it through whether they are subscribed or not.  That how
most projects work.  I'm not subscribed to every kernel subsystem
list, but my messages usually make it through.  If we are proposing to
do away with the mailing list, what is the plan for non-patch
discussions?  Opening issues in gitlab?


I don't think this was the suggestion. For non-patch review discussions 
the list still makes sense. The great thing now is that without patches 
being sent to the list its easier to actually notice these discussions.




Alex



Dylan

Quoting Alex Deucher (2019-12-10 07:30:43)

How do we deal with drive by fixes?  E.g., some random user submits a
fix but doesn't want to create a gitlab account just to submit a fix?
Whoever reviews the patch should submit an MR?

Alex

On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:


Hi everyone,

I think its time we discussed whether we're going to continue to do patch review
on the mailing list, or if it it should all go through gitlab. I think we should
stop using the mailing list, here are some reasons:

1) Most development is happening on gitlab at this point, patches on the mailing
list are often overlooked
2) The mailing list bypasses CI which potentially breaks the build
3) Probably more reasons I'm forgetting.

Please discuss,
Dylan
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev


___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Timothy Arceri]

On 11/12/19 5:58 am, Zebediah Figura wrote:

On 12/10/19 12:21 PM, Matt Turner wrote:

On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:


Hi everyone,

I think its time we discussed whether we're going to continue to do 
patch review
on the mailing list, or if it it should all go through gitlab. I 
think we should

stop using the mailing list, here are some reasons:

1) Most development is happening on gitlab at this point, patches on 
the mailing

    list are often overlooked
2) The mailing list bypasses CI which potentially breaks the build
3) Probably more reasons I'm forgetting.


I think effectively we're already there.

What concrete change would you propose?


Removing mention of the mailing list from documentation would be nice. 
Also, currently the README implies that the mailing list is not only 
acceptable but preferred: "Note that Mesa uses email mailing-lists for 
patches submission, review and discussions."


I've sent a merge request:

https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3045



Relatedly, is GitLab preferred also for piglit? The HACKING file there 
also specifically prescribes using the mailing list, but I've noticed 
that patches submitted to the mailing list by myself and another new 
contributor have gone unreviewed for several weeks.


Yes we should update the piglit docs also.




___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Dylan Baker]

Quoting Zebediah Figura (2019-12-10 10:58:45)
> On 12/10/19 12:21 PM, Matt Turner wrote:
> > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
> >>
> >> Hi everyone,
> >>
> >> I think its time we discussed whether we're going to continue to do patch 
> >> review
> >> on the mailing list, or if it it should all go through gitlab. I think we 
> >> should
> >> stop using the mailing list, here are some reasons:
> >>
> >> 1) Most development is happening on gitlab at this point, patches on the 
> >> mailing
> >> list are often overlooked
> >> 2) The mailing list bypasses CI which potentially breaks the build
> >> 3) Probably more reasons I'm forgetting.
> > 
> > I think effectively we're already there.
> > 
> > What concrete change would you propose?
> 
> Removing mention of the mailing list from documentation would be nice. 
> Also, currently the README implies that the mailing list is not only 
> acceptable but preferred: "Note that Mesa uses email mailing-lists for 
> patches submission, review and discussions."

This would be a good start, I don't know what else to do to stop people from
sending patches, maybe mailman has some kind of hook we can add to spot patches
and mention that gitlab is preferred? No idea.

> Relatedly, is GitLab preferred also for piglit? The HACKING file there 
> also specifically prescribes using the mailing list, but I've noticed 
> that patches submitted to the mailing list by myself and another new 
> contributor have gone unreviewed for several weeks.

I think it is preferred at this point. Maybe we should update both mesa and
piglit at the same time.

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Dylan Baker]

Quoting Alex Deucher (2019-12-10 13:54:02)
> On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker  wrote:
> >
> > Do we have those and does anyone notice? I personally rarely look at the 
> > list
> > now unless I'm CC'd on something. That seems really bad for drive by
> > contributors.
> >
> > But frankly I wouldn't submit to a mailing list as a drive by, it's more 
> > work to
> > get subscribed to mail man (so my patch goes through), set up 
> > get-send-email,
> > and send the patches, then unsubscribe when I'm done than it would be to 
> > sign up
> > for gitlab.fdo using one of the "sign-in-with" options. If you're not 
> > subscribed
> > you go into limbo until a list maintainer approves your patch, and I think 
> > any
> > follow ups. That seems even worse as most people probably aren't aware of 
> > that
> > behavior. Maybe I'm the only one who feels that way though.
> 
> I've still seen a few.  Most drive by contributors generally don't
> subscribe to the list.  Since most lists are moderated, the mail
> usually makes it through whether they are subscribed or not.  That how
> most projects work.  I'm not subscribed to every kernel subsystem
> list, but my messages usually make it through.  If we are proposing to
> do away with the mailing list, what is the plan for non-patch
> discussions?  Opening issues in gitlab?
> 
> Alex

I think having non-patch discussions on the mailing list still makes sense,
especially since gitlab issues can be klunky and no-one's suggested a good
alternative. I'm opened to alternatives that aren't slack :)

Dylan


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Alex Deucher]

On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker  wrote:
>
> Do we have those and does anyone notice? I personally rarely look at the list
> now unless I'm CC'd on something. That seems really bad for drive by
> contributors.
>
> But frankly I wouldn't submit to a mailing list as a drive by, it's more work 
> to
> get subscribed to mail man (so my patch goes through), set up get-send-email,
> and send the patches, then unsubscribe when I'm done than it would be to sign 
> up
> for gitlab.fdo using one of the "sign-in-with" options. If you're not 
> subscribed
> you go into limbo until a list maintainer approves your patch, and I think any
> follow ups. That seems even worse as most people probably aren't aware of that
> behavior. Maybe I'm the only one who feels that way though.

I've still seen a few.  Most drive by contributors generally don't
subscribe to the list.  Since most lists are moderated, the mail
usually makes it through whether they are subscribed or not.  That how
most projects work.  I'm not subscribed to every kernel subsystem
list, but my messages usually make it through.  If we are proposing to
do away with the mailing list, what is the plan for non-patch
discussions?  Opening issues in gitlab?

Alex

>
> Dylan
>
> Quoting Alex Deucher (2019-12-10 07:30:43)
> > How do we deal with drive by fixes?  E.g., some random user submits a
> > fix but doesn't want to create a gitlab account just to submit a fix?
> > Whoever reviews the patch should submit an MR?
> >
> > Alex
> >
> > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
> > >
> > > Hi everyone,
> > >
> > > I think its time we discussed whether we're going to continue to do patch 
> > > review
> > > on the mailing list, or if it it should all go through gitlab. I think we 
> > > should
> > > stop using the mailing list, here are some reasons:
> > >
> > > 1) Most development is happening on gitlab at this point, patches on the 
> > > mailing
> > >list are often overlooked
> > > 2) The mailing list bypasses CI which potentially breaks the build
> > > 3) Probably more reasons I'm forgetting.
> > >
> > > Please discuss,
> > > Dylan
> > > ___
> > > mesa-dev mailing list
> > > mesa-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Zebediah Figura]

On 12/10/19 12:21 PM, Matt Turner wrote:

On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:


Hi everyone,

I think its time we discussed whether we're going to continue to do patch review
on the mailing list, or if it it should all go through gitlab. I think we should
stop using the mailing list, here are some reasons:

1) Most development is happening on gitlab at this point, patches on the mailing
list are often overlooked
2) The mailing list bypasses CI which potentially breaks the build
3) Probably more reasons I'm forgetting.


I think effectively we're already there.

What concrete change would you propose?


Removing mention of the mailing list from documentation would be nice. 
Also, currently the README implies that the mailing list is not only 
acceptable but preferred: "Note that Mesa uses email mailing-lists for 
patches submission, review and discussions."


Relatedly, is GitLab preferred also for piglit? The HACKING file there 
also specifically prescribes using the mailing list, but I've noticed 
that patches submitted to the mailing list by myself and another new 
contributor have gone unreviewed for several weeks.



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev



___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Matt Turner]

On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
>
> Hi everyone,
>
> I think its time we discussed whether we're going to continue to do patch 
> review
> on the mailing list, or if it it should all go through gitlab. I think we 
> should
> stop using the mailing list, here are some reasons:
>
> 1) Most development is happening on gitlab at this point, patches on the 
> mailing
>list are often overlooked
> 2) The mailing list bypasses CI which potentially breaks the build
> 3) Probably more reasons I'm forgetting.

I think effectively we're already there.

What concrete change would you propose?
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Dylan Baker]

Adding Daniel (since he could actually turn patchwork off), but I doubt anyone
in mesa is using patchwork at this point, I think all of the people who were
interested have moved to gitlab. We could probably dump it even if we decide to
keep the list.

Just my 2¢.

Dylan

Quoting Marek Olšák (2019-12-09 20:29:48)
> Do we plan to remove the patchwork action on push?
> 
> Marek
> 
> On Mon, Dec 9, 2019 at 9:10 PM Roland Scheidegger  wrote:
> 
> So, I'm guilty of being one of the few still using the mailing list...
> But in any case, certainly I can switch to using MRs if everybody
> prefers that now (meaning, I'm really indifferent to this).
> 
> Roland
> 
> 
> Am 10.12.19 um 00:07 schrieb Dylan Baker:
> > Hi everyone,
> >
> > I think its time we discussed whether we're going to continue to do 
> patch
> review
> > on the mailing list, or if it it should all go through gitlab. I think 
> we
> should
> > stop using the mailing list, here are some reasons:
> >
> > 1) Most development is happening on gitlab at this point, patches on the
> mailing
> >    list are often overlooked
> > 2) The mailing list bypasses CI which potentially breaks the build
> > 3) Probably more reasons I'm forgetting.
> >
> > Please discuss,
> > Dylan
> >
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://nam04.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-dev
> data=
> 
> 02%7C01%7Csroland%40vmware.com%7C1cb75dae042b4427ab2408d77cfc9cdc%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637115296743272638
> sdata=BmiwnAd%2BBZaZqqTwIYn0zqPOQ8jQ1pIzOqtyGhxuEN0%3Dreserved=0
> >
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Dylan Baker]

Do we have those and does anyone notice? I personally rarely look at the list
now unless I'm CC'd on something. That seems really bad for drive by
contributors.

But frankly I wouldn't submit to a mailing list as a drive by, it's more work to
get subscribed to mail man (so my patch goes through), set up get-send-email,
and send the patches, then unsubscribe when I'm done than it would be to sign up
for gitlab.fdo using one of the "sign-in-with" options. If you're not subscribed
you go into limbo until a list maintainer approves your patch, and I think any
follow ups. That seems even worse as most people probably aren't aware of that
behavior. Maybe I'm the only one who feels that way though. 

Dylan

Quoting Alex Deucher (2019-12-10 07:30:43)
> How do we deal with drive by fixes?  E.g., some random user submits a
> fix but doesn't want to create a gitlab account just to submit a fix?
> Whoever reviews the patch should submit an MR?
> 
> Alex
> 
> On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
> >
> > Hi everyone,
> >
> > I think its time we discussed whether we're going to continue to do patch 
> > review
> > on the mailing list, or if it it should all go through gitlab. I think we 
> > should
> > stop using the mailing list, here are some reasons:
> >
> > 1) Most development is happening on gitlab at this point, patches on the 
> > mailing
> >list are often overlooked
> > 2) The mailing list bypasses CI which potentially breaks the build
> > 3) Probably more reasons I'm forgetting.
> >
> > Please discuss,
> > Dylan
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Alex Deucher]

How do we deal with drive by fixes?  E.g., some random user submits a
fix but doesn't want to create a gitlab account just to submit a fix?
Whoever reviews the patch should submit an MR?

Alex

On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker  wrote:
>
> Hi everyone,
>
> I think its time we discussed whether we're going to continue to do patch 
> review
> on the mailing list, or if it it should all go through gitlab. I think we 
> should
> stop using the mailing list, here are some reasons:
>
> 1) Most development is happening on gitlab at this point, patches on the 
> mailing
>list are often overlooked
> 2) The mailing list bypasses CI which potentially breaks the build
> 3) Probably more reasons I'm forgetting.
>
> Please discuss,
> Dylan
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Marek Olšák]

Do we plan to remove the patchwork action on push?

Marek

On Mon, Dec 9, 2019 at 9:10 PM Roland Scheidegger 
wrote:

> So, I'm guilty of being one of the few still using the mailing list...
> But in any case, certainly I can switch to using MRs if everybody
> prefers that now (meaning, I'm really indifferent to this).
>
> Roland
>
>
> Am 10.12.19 um 00:07 schrieb Dylan Baker:
> > Hi everyone,
> >
> > I think its time we discussed whether we're going to continue to do
> patch review
> > on the mailing list, or if it it should all go through gitlab. I think
> we should
> > stop using the mailing list, here are some reasons:
> >
> > 1) Most development is happening on gitlab at this point, patches on the
> mailing
> >list are often overlooked
> > 2) The mailing list bypasses CI which potentially breaks the build
> > 3) Probably more reasons I'm forgetting.
> >
> > Please discuss,
> > Dylan
> >
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-devdata=02%7C01%7Csroland%40vmware.com%7C1cb75dae042b4427ab2408d77cfc9cdc%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637115296743272638sdata=BmiwnAd%2BBZaZqqTwIYn0zqPOQ8jQ1pIzOqtyGhxuEN0%3Dreserved=0
> >
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

[Roland Scheidegger]

So, I'm guilty of being one of the few still using the mailing list...
But in any case, certainly I can switch to using MRs if everybody
prefers that now (meaning, I'm really indifferent to this).

Roland


Am 10.12.19 um 00:07 schrieb Dylan Baker:
> Hi everyone,
> 
> I think its time we discussed whether we're going to continue to do patch 
> review
> on the mailing list, or if it it should all go through gitlab. I think we 
> should
> stop using the mailing list, here are some reasons:
> 
> 1) Most development is happening on gitlab at this point, patches on the 
> mailing
>list are often overlooked
> 2) The mailing list bypasses CI which potentially breaks the build
> 3) Probably more reasons I'm forgetting.
> 
> Please discuss,
> Dylan
> 
> 
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fmesa-devdata=02%7C01%7Csroland%40vmware.com%7C1cb75dae042b4427ab2408d77cfc9cdc%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637115296743272638sdata=BmiwnAd%2BBZaZqqTwIYn0zqPOQ8jQ1pIzOqtyGhxuEN0%3Dreserved=0
> 

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev