Re: Checking for boilerplate

2005-08-24 Thread Ken Williams


On Aug 22, 2005, at 2:07 PM, Andy Lester wrote:

RJBS and I are going to put some tests into Module::Starter to check 
for

boilerplate.  Watch for it tomorrow, maybe tonight.



Personally I still don't think that's the best place for it.  Why make 
all the people who *download* your module check something that should 
be checked at make dist time?


Did people not like the idea of putting these checks as plugins into 
Module::Release?


 -Ken



Re: Apache::Reload on Cpan

2005-08-24 Thread Andreas J. Koenig
 On Mon, 22 Aug 2005 22:10:16 +0100, Smylers [EMAIL PROTECTED] said:

   But that distribution has since been deleted, so it looks like the most
   recent version of Apache::Reload is no longer available.  Apache-Reload
   is over 4 years old; perhaps if you just uploaded a new version (without
   any changes) then this would trick the various indexers into knowing
   where to find Apache::Reload?

  Sometimes the intricacies of how CPAN works confuse me though.

   Me too, which is why I've CCed the module authors list, in case anybody
   else can offer an explanation of this.

If there was ever a Apache::Reload that was newer than the one in
MSERGEANT/Apache-Reload-0.07.tar.gz and that other distribution has
then been removed, that would explain the current state of affairs:
MSERGEANT/Apache-Reload-0.07.tar.gz is not automatically picked up
again by the indexer so the module falls out of the index.

I've just scheduled MSERGEANT/Apache-Reload-0.07.tar.gz for
reindexing, that should make it available through CPAN.pm, CPANPLUS.pm
and search.cpan.org.

BTW, that's something all authors can do for their modules by visiting
PAUSE and clicking Utils-Force Reindexing.

-- 
andreas


Re: Checking for boilerplate

2005-08-24 Thread Chris Dolan

On Aug 24, 2005, at 7:46 AM, Ken Williams wrote:


On Aug 22, 2005, at 2:07 PM, Andy Lester wrote:

RJBS and I are going to put some tests into Module::Starter to  
check for

boilerplate.  Watch for it tomorrow, maybe tonight.


Personally I still don't think that's the best place for it.  Why  
make all the people who *download* your module check something that  
should be checked at make dist time?


Did people not like the idea of putting these checks as plugins  
into Module::Release?


I strongly suspect that the people who use Module::Release are not  
the ones uploading modules with boilerplate.  Putting the test in  
Module::Release is a good idea, but it would not abate the primary  
problem under discussion.


Chris
--
Chris Dolan, Software Developer, Clotho Advanced Media Inc.
608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703

Clotho Advanced Media, Inc. - Creators of MediaLandscape Software  
(http://www.media-landscape.com/) and partners in the revolutionary  
Croquet project (http://www.opencroquet.org/)




Re: Checking for boilerplate

2005-08-24 Thread David Nicol
 I strongly suspect that the people who use Module::Release are not
 the ones uploading modules with boilerplate.  Putting the test in
 Module::Release is a good idea, but it would not abate the primary
 problem under discussion.
 
 Chris

gotta put the checks in PAUSE so it rejects boilerplate-havin modules
-- anything
less won't work



-- 
David L Nicol
http://cronos.advenge.com/pc/Honest_Abe


Re: Checking for boilerplate

2005-08-24 Thread Andy Lester
On Wed, Aug 24, 2005 at 10:51:14AM -0500, David Nicol ([EMAIL PROTECTED]) wrote:
 gotta put the checks in PAUSE so it rejects boilerplate-havin modules
 -- anything
 less won't work

ITYM won't work 100% at solving this problem that really isn't that
huge of a problem anyway.

Remember, CPAN thrives BECAUSE we allow unfettered uploading of shit,
not in spite of it.

http://use.perl.org/~petdance/journal/25684


-- 
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance


Re: Checking for boilerplate

2005-08-24 Thread Chris Dolan

On Aug 24, 2005, at 10:56 AM, Andy Lester wrote:


Remember, CPAN thrives BECAUSE we allow unfettered uploading of shit,
not in spite of it.


Now there's a quote that needs to be added to the use.perl.org footer  
rotation.  :-)

Chris
--
Chris Dolan, Software Developer, Clotho Advanced Media Inc.
608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703

Clotho Advanced Media, Inc. - Creators of MediaLandscape Software  
(http://www.media-landscape.com/) and partners in the revolutionary  
Croquet project (http://www.opencroquet.org/)




Re: Checking for boilerplate

2005-08-24 Thread Andy Lester
On Wed, Aug 24, 2005 at 11:25:56AM -0500, Chris Dolan ([EMAIL PROTECTED]) wrote:
 Remember, CPAN thrives BECAUSE we allow unfettered uploading of shit,
 not in spite of it.
 
 Now there's a quote that needs to be added to the use.perl.org footer  
 rotation.  :-)

It's only funny 'cause it's true.

-- 
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance


Re: Checking for boilerplate

2005-08-24 Thread Ken Williams


On Aug 24, 2005, at 10:37 AM, Chris Dolan wrote:

I strongly suspect that the people who use Module::Release are not the 
ones uploading modules with boilerplate.  Putting the test in 
Module::Release is a good idea, but it would not abate the primary 
problem under discussion.


Well, I myself use Module::Release (of course), in fact I've 
contributed a bunch of code to it, and I *still* upload crap with 
stupid mistakes to CPAN (though I never make the same mistake twice 
anymore).  How do you think I had the idea to put those sanity checks 
into my release process? ;-)


I think seasoned developers make as many silly mistakes as newbies, 
they're just different kinds of mistakes.


I guess what I should do is just write the M::R patch.

 -Ken



Re: Apache::Reload on Cpan

2005-08-24 Thread Smylers
Andreas J. Koenig writes:

 If there was ever a Apache::Reload that was newer than the one in
 MSERGEANT/Apache-Reload-0.07.tar.gz and that other distribution has
 then been removed, that would explain the current state of affairs:

That sounds like the most likely explanation then; thanks for confirming
it.

 I've just scheduled MSERGEANT/Apache-Reload-0.07.tar.gz for
 reindexing ...

Thank you!

Smylers
-- 
May God bless us with enough foolishness to believe that we can make a
difference in this world, so that we can do what others claim cannot be done.


Re: RFC - Test::Stupid module

2005-08-24 Thread _brian_d_foy
In article [EMAIL PROTECTED], A. Pagaltzis
[EMAIL PROTECTED] wrote:

 * _brian_d_foy [EMAIL PROTECTED] [2005-08-22 20:00]:

 Sure, but you and brian aren’t the kind of people who’d need h2xs
 or module-starter or the like anyway. I find it kind of strange
 to be telling people without enough experience to possibly roll
 their own yet to do just that.

I'm telling people to use their favorite module tool to create 
a smaple distribution, templatize it to fix the boilerplate,
then use their own templates.

I am nto telling people to make their own module starter tool.

For people who need h2xs, the difference between them not
understanding what h2xs does and what my solution does is 
not going to matter that much. Both ways give you a directory
of files whether you understand the files or not.

-- 
brian d foy, [EMAIL PROTECTED]


Re: Checking for boilerplate

2005-08-24 Thread _brian_d_foy
In article [EMAIL PROTECTED], Andy Lester
[EMAIL PROTECTED] wrote:

 On Wed, Aug 24, 2005 at 07:46:38AM -0500, Ken Williams ([EMAIL PROTECTED])
 wrote:
  Personally I still don't think that's the best place for it.  Why make 
  all the people who *download* your module check something that should 
  be checked at make dist time?

  Did people not like the idea of putting these checks as plugins into 
  Module::Release?

 We saw putting it in Module::Starter as a place to start.  JFDI and
 all that.  

Well, each module making tool is going to have to tell someone what
its boilerplate looks like. I think each module tool will have to have
it's own boilerplate.t, so each tool might as well make its own.

However, with the right interface, a Module::Release plugin could
get that boilerplate.t from the module tool. :)

-- 
brian d foy, [EMAIL PROTECTED]


Re: Checking for boilerplate

2005-08-24 Thread Randy W. Sims

Ricardo SIGNES wrote:

* Andy Lester [EMAIL PROTECTED] [2005-08-22T15:07:47]


RJBS and I are going to put some tests into Module::Starter to check for
boilerplate.  Watch for it tomorrow, maybe tonight.



Just a little while ago I uploaded 1.41_01, which adds:

  * t/boilerplate.t
  * some bug fixes
  * simple email address obfuscation
  * hook for new, improved plugin architecture

The boilerplate check is simple, but should catch the main offenses --
as long as people test before uploading.


I've played with the new version a bit on Debian Linux and Windows. Just 
a few very very minor comments:


1) I'm not a big fan of email obfuscation, though I might be in the 
minority. Most forms are just as easy to parse as a regular email 
address. And obfuscation feels too much like surrendering. Just my 
opinion. But an option might be nice if not too much trouble.


2) I like the boilerplate tests in M::S. It feels like an appropriate 
place since M::S puts it in, it might as well create tests to make sure 
it gets removed. However, I use M::S a lot for creating quick test 
distros, and that sometimes makes the failing tests annoying. But my 
usage is probably unusual in this reguard. It'd be nice if there were an 
option to diable it, but I can easily create a wrapper that fixes it 
for my purposes.


3) I goofed on the commandline and typod `module-starter --module Foo 
--mb --version` and scratched my head for a while looking for the 'Foo' 
directory. Should have type 'verbose'. Maybe 'version' could be an 
exclusive option, generating an error in the presence of other options? 
Or I should learn to type better.


4) Since M::S can generate distros with a Build.PL it might be nice if 
it also included one. ;)


# vi:et:sw=4 ts=4
use strict;
use warnings;
use 5.6.1;
use Module::Build;

my $build = Module::Build-new(

module_name  = 'Module::Starter',
license  = 'perl',
dist_author  = [
'Andy Lester [EMAIL PROTECTED]',
'Ricardo SIGNES [EMAIL PROTECTED]',
],


script_files = [ 'bin/module-starter' ],

requires = {
'Test::More'= 0,
'ExtUtils::Command' = 0,
'File::Spec'= 0,
'Getopt::Long'  = 0,
'Pod::Usage'= 0,
},
);

$build-create_build_script;
__END__


*NOTE you must also add to Makefile.PL

WriteMakefile(
...
PL_FILES= {}, # don't auto expand 'Build.PL'
);

And, optionally, do a `perl Build.PL`  `perl Build distmeta` to update 
your META.yml file.




Re: Checking for boilerplate

2005-08-24 Thread Randy W. Sims

Wasn't paying attention when I copied prereqs from Makefile.PL

Randy W. Sims wrote:
4) Since M::S can generate distros with a Build.PL it might be nice if 
it also included one. ;)


# vi:et:sw=4 ts=4
use strict;
use warnings;
use 5.6.1;
use Module::Build;

my $build = Module::Build-new(

module_name  = 'Module::Starter',
license  = 'perl',
dist_author  = [
'Andy Lester [EMAIL PROTECTED]',
'Ricardo SIGNES [EMAIL PROTECTED]',
],


script_files = [ 'bin/module-starter' ],


build_requires = {
'Test::More'= 0,
},

requires   = {
'ExtUtils::Command' = 0,
'File::Spec'= 0,
'Getopt::Long'  = 0,
'Pod::Usage'= 0,
},


);

$build-create_build_script;
__END__




Re: Checking for boilerplate

2005-08-24 Thread Andy Lester


1) I'm not a big fan of email obfuscation, though I might be in the 
minority. Most forms are just as easy to parse as a regular email 
address. And obfuscation feels too much like surrendering. Just my 
opinion. But an option might be nice if not too much trouble.


I agree in principle, but I also have all the spam in the Test::Harness 
RT database and it drives me nuts.




--
Andy Lester = [EMAIL PROTECTED] = www.petdance.com = AIM:petdance