Re: [nant-dev] Updates to MSBuild VSNet Tasks
Hi, Please see inline. Thanks, Ryan On Jun 16, 2011, at 2:39 AM, Martin Aliger martin_ali...@gordic.cz wrote: Hi Ryan, sln file handling is some kind of broken since VS2005. They only work with 2002/2003. I would not spend to much time for now in sln file handling in VS2005 and up. Eww, makes sense. Well, not to let my work go to waste, I think I know why it isn't working. The plugins that contains the schema information for VS2005+ solution files (NAnt.MSBuild.dll) doesn't seem to be getting picked up during NAnt's plugin discovery phase. However, I have been having difficulty trying to locate where the plugin discovery phase occurs in NAnt to make sure that they are getting picked up. There is also the fact that the VS2005+ solution plugin classes are marked as internal but I am not sure how much of an impact that is making overall. Discovery mechanism was made by me and Gert some time ago. I could look into it... Thanks Martin. I thought your names looked familiar. :) SolutionFactory.cs is main branching thingy. Providers itself are registred though Core's IPluginConsumer and ISolutionBuildProvider interfaces. I see that and it seems to be working ok with the classes within the NAnt.VSNet assembly. It just won't pickup the classes from the NAnt.MSBuild assembly. If u can point me to where in the code that the solution task begins to search for plugins in external assemblies, I can research further as well. M. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] Updates to MSBuild VSNet Tasks
I just checked and it correctly resolves all the MSBuild providers on my machine. Maybe it is becouse I have NAnt.MSBuild.dll in same directory as NAnt.exe? Maybe plugins do not resolve when in one of those Framework lib which is default for MSBuild assembly atm (no idea why). Or perhaps the order in which assemblies are loaded? The registration is done in PluginScanner class from Core. All loaded types should be send into that (via TypeFactory). Btw: I noticed, the solution providers from MSBuild assembly got VSNet namespace. Maybe it should be changed, for clarity. Martin Aliger -Original Message- From: Ryan Boggs [mailto:rmbo...@gmail.com] Sent: Thursday, June 16, 2011 3:37 PM To: Martin Aliger Cc: Dominik Guder; nant-developers@lists.sourceforge.net Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild VSNet Tasks Importance: Low Hi, Please see inline. Thanks, Ryan On Jun 16, 2011, at 2:39 AM, Martin Aliger martin_ali...@gordic.cz wrote: Hi Ryan, sln file handling is some kind of broken since VS2005. They only work with 2002/2003. I would not spend to much time for now in sln file handling in VS2005 and up. Eww, makes sense. Well, not to let my work go to waste, I think I know why it isn't working. The plugins that contains the schema information for VS2005+ solution files (NAnt.MSBuild.dll) doesn't seem to be getting VS2005+ picked up during NAnt's plugin discovery phase. However, I have been having difficulty trying to locate where the plugin discovery phase occurs in NAnt to make sure that they are getting picked up. There is also the fact that the VS2005+ solution plugin classes are marked as internal but I am not sure how much of an impact that is making overall. Discovery mechanism was made by me and Gert some time ago. I could look into it... Thanks Martin. I thought your names looked familiar. :) SolutionFactory.cs is main branching thingy. Providers itself are registred though Core's IPluginConsumer and ISolutionBuildProvider interfaces. I see that and it seems to be working ok with the classes within the NAnt.VSNet assembly. It just won't pickup the classes from the NAnt.MSBuild assembly. If u can point me to where in the code that the solution task begins to search for plugins in external assemblies, I can research further as well. M. -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] ***SPAM***BAR*** Re: Updates to MSBuild VSNet Tasks
Testing this bug, I found another one. Change OutputPath (MSBuildProject
class) implementation in recent patches to this one:
internal string OutputPath
{
get {
if (OutputDir != null) return OutputDir.FullName;
return _msproj.GetEvaluatedProperty(OutputPath);
}
}
Solutions without explicitlly set OutputPath failed. (all mine test cases
got OutputPath set).
Martin
-Original Message-
From: Ryan Boggs [mailto:rmbo...@gmail.com]
Sent: Thursday, June 16, 2011 3:37 PM
To: Martin Aliger
Cc: Dominik Guder; nant-developers@lists.sourceforge.net
Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild VSNet Tasks
Importance: Low
Hi,
Please see inline.
Thanks,
Ryan
On Jun 16, 2011, at 2:39 AM, Martin Aliger martin_ali...@gordic.cz
wrote:
Hi Ryan, sln file handling is some kind of broken since VS2005. They
only work with 2002/2003. I would not spend to much time for now in
sln file handling in VS2005 and up.
Eww, makes sense. Well, not to let my work go to waste, I think I
know why
it isn't working. The plugins that contains the schema information
for
VS2005+ solution files (NAnt.MSBuild.dll) doesn't seem to be getting
VS2005+ picked
up during NAnt's plugin discovery phase.
However, I have been having difficulty trying to locate where the
plugin
discovery phase occurs in NAnt to make sure that they are getting picked
up.
There is also the fact that the VS2005+ solution plugin classes are
marked as internal but I am not sure how much of an impact that is making
overall.
Discovery mechanism was made by me and Gert some time ago. I could
look into it...
Thanks Martin. I thought your names looked familiar. :)
SolutionFactory.cs is main branching thingy. Providers itself are
registred though Core's IPluginConsumer and ISolutionBuildProvider
interfaces.
I see that and it seems to be working ok with the classes within the
NAnt.VSNet assembly. It just won't pickup the classes from the NAnt.MSBuild
assembly. If u can point me to where in the code that the solution task
begins to search for plugins in external assemblies, I can research further
as well.
M.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
nant-developers mailing list
nant-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] ***SPAM***BAR*** Re: Updates to MSBuild VSNet Tasks
Noted, I will update the patch after work today. I need to make a couple of
tweaks to the patch file anyway so this is good timing.
Thanks,
Ryan
On Jun 16, 2011, at 7:31 AM, Martin Aliger martin_ali...@gordic.cz wrote:
Testing this bug, I found another one. Change OutputPath (MSBuildProject
class) implementation in recent patches to this one:
internal string OutputPath
{
get {
if (OutputDir != null) return OutputDir.FullName;
return _msproj.GetEvaluatedProperty(OutputPath);
}
}
Solutions without explicitlly set OutputPath failed. (all mine test cases
got OutputPath set).
Martin
-Original Message-
From: Ryan Boggs [mailto:rmbo...@gmail.com]
Sent: Thursday, June 16, 2011 3:37 PM
To: Martin Aliger
Cc: Dominik Guder; nant-developers@lists.sourceforge.net
Subject: ***SPAM***BAR*** Re: [nant-dev] Updates to MSBuild VSNet Tasks
Importance: Low
Hi,
Please see inline.
Thanks,
Ryan
On Jun 16, 2011, at 2:39 AM, Martin Aliger martin_ali...@gordic.cz
wrote:
Hi Ryan, sln file handling is some kind of broken since VS2005. They
only work with 2002/2003. I would not spend to much time for now in
sln file handling in VS2005 and up.
Eww, makes sense. Well, not to let my work go to waste, I think I
know why
it isn't working. The plugins that contains the schema information
for
VS2005+ solution files (NAnt.MSBuild.dll) doesn't seem to be getting
VS2005+ picked
up during NAnt's plugin discovery phase.
However, I have been having difficulty trying to locate where the
plugin
discovery phase occurs in NAnt to make sure that they are getting picked
up.
There is also the fact that the VS2005+ solution plugin classes are
marked as internal but I am not sure how much of an impact that is making
overall.
Discovery mechanism was made by me and Gert some time ago. I could
look into it...
Thanks Martin. I thought your names looked familiar. :)
SolutionFactory.cs is main branching thingy. Providers itself are
registred though Core's IPluginConsumer and ISolutionBuildProvider
interfaces.
I see that and it seems to be working ok with the classes within the
NAnt.VSNet assembly. It just won't pickup the classes from the NAnt.MSBuild
assembly. If u can point me to where in the code that the solution task
begins to search for plugins in external assemblies, I can research further
as well.
M.
--
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
___
nant-developers mailing list
nant-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-3317505 ] nunit2 task does not run interal test fixtures
Bugs item #3317505, was opened at 2011-06-16 22:02 Message generated for change (Tracker Item Submitted) made by indr You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tasks Group: 0.91-alpha2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Indr (indr) Assigned to: Nobody/Anonymous (nobody) Summary: nunit2 task does not run interal test fixtures Initial Comment: I switched from TeamCitys NUnit Launcher back to the nunit2 task and noticed after several hours of searching why lesser tests are run that the test fixtures must not be internal, they have to be public. Quite annoying because NUnit states on their home page: a test fixture class may be public, protected, private or internal. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-3317505 ] nunit2 task does not run internal test fixtures
Bugs item #3317505, was opened at 2011-06-16 22:02 Message generated for change (Comment added) made by indr You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tasks Group: 0.91-alpha2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Indr (indr) Assigned to: Nobody/Anonymous (nobody) Summary: nunit2 task does not run internal test fixtures Initial Comment: I switched from TeamCitys NUnit Launcher back to the nunit2 task and noticed after several hours of searching why lesser tests are run that the test fixtures must not be internal, they have to be public. Quite annoying because NUnit states on their home page: a test fixture class may be public, protected, private or internal. -- Comment By: Indr (indr) Date: 2011-06-16 22:03 Message: Fixed typo in summary. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-3317505 ] nunit2 task does not run internal test fixtures
Bugs item #3317505, was opened at 2011-06-16 22:02 Message generated for change (Comment added) made by dogu You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tasks Group: 0.91-alpha2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: indr (indr) Assigned to: Nobody/Anonymous (nobody) Summary: nunit2 task does not run internal test fixtures Initial Comment: I switched from TeamCitys NUnit Launcher back to the nunit2 task and noticed after several hours of searching why lesser tests are run that the test fixtures must not be internal, they have to be public. Quite annoying because NUnit states on their home page: a test fixture class may be public, protected, private or internal. -- Comment By: Dominik Guder (dogu) Date: 2011-06-16 22:27 Message: Nant's nunit2 task uses nunit 2.2.8 and class visibility was opened in 2.5.3 first. It's on our tasklist to either update nunit or provide some kind of dynamic loading. But for now my only idea is to use exec task and run nunit-console. This is also true if you need to test .net 4.0 asseblies. IMHO this is not possible with 2.2.8. -- Comment By: indr (indr) Date: 2011-06-16 22:03 Message: Fixed typo in summary. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
[nant-dev] [ nant-Bugs-3317505 ] nunit2 task does not run internal test fixtures
Bugs item #3317505, was opened at 2011-06-16 13:02 Message generated for change (Comment added) made by rmboggs You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Tasks Group: 0.91-alpha2 Status: Open Resolution: None Priority: 5 Private: No Submitted By: indr (indr) Assigned to: Nobody/Anonymous (nobody) Summary: nunit2 task does not run internal test fixtures Initial Comment: I switched from TeamCitys NUnit Launcher back to the nunit2 task and noticed after several hours of searching why lesser tests are run that the test fixtures must not be internal, they have to be public. Quite annoying because NUnit states on their home page: a test fixture class may be public, protected, private or internal. -- Comment By: Ryan Boggs (rmboggs) Date: 2011-06-16 13:39 Message: Just to add on to Dominik's comment below... I did look into upgrading NUnit on NAnt to something more current (2.5.9+) recently but after looking into this, I realized that such an upgrade would require a significant rewrite of the nunit NAnt task since much of the underlying NUnit API has changed drastically since 2.2. Like Dominik said, plans are in the works but they are on hold for the time being. -- Comment By: Dominik Guder (dogu) Date: 2011-06-16 13:27 Message: Nant's nunit2 task uses nunit 2.2.8 and class visibility was opened in 2.5.3 first. It's on our tasklist to either update nunit or provide some kind of dynamic loading. But for now my only idea is to use exec task and run nunit-console. This is also true if you need to test .net 4.0 asseblies. IMHO this is not possible with 2.2.8. -- Comment By: indr (indr) Date: 2011-06-16 13:03 Message: Fixed typo in summary. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=402868aid=3317505group_id=31650 -- EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev ___ nant-developers mailing list nant-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nant-developers
