Re: [patch 7/7] rfcomm tty: destroy before tty_close()

2008-02-05 Thread David Miller
From: [EMAIL PROTECTED]
Date: Mon, 04 Feb 2008 23:48:20 -0800

 From: Dave Young [EMAIL PROTECTED]
 
 rfcomm dev could be deleted in tty_hangup, so we must not call
 rfcomm_dev_del again to prevent from destroying rfcomm dev before tty
 close.
 
 Signed-off-by: Dave Young [EMAIL PROTECTED]
 Cc: Marcel Holtmann [EMAIL PROTECTED]
 Signed-off-by: Andrew Morton [EMAIL PROTECTED]

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[patch 7/7] rfcomm tty: destroy before tty_close()

2008-02-04 Thread akpm
From: Dave Young [EMAIL PROTECTED]

rfcomm dev could be deleted in tty_hangup, so we must not call
rfcomm_dev_del again to prevent from destroying rfcomm dev before tty
close.

Signed-off-by: Dave Young [EMAIL PROTECTED]
Cc: Marcel Holtmann [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---

 net/bluetooth/rfcomm/tty.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -puN net/bluetooth/rfcomm/tty.c~rfcomm-tty-destroy-before-tty_close 
net/bluetooth/rfcomm/tty.c
--- a/net/bluetooth/rfcomm/tty.c~rfcomm-tty-destroy-before-tty_close
+++ a/net/bluetooth/rfcomm/tty.c
@@ -429,7 +429,8 @@ static int rfcomm_release_dev(void __use
if (dev-tty)
tty_vhangup(dev-tty);
 
-   rfcomm_dev_del(dev);
+   if (!test_bit(RFCOMM_RELEASE_ONHUP, dev-flags))
+   rfcomm_dev_del(dev);
rfcomm_dev_put(dev);
return 0;
 }
_
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html