Re: [netsniff-ng] [PATCH] flowtop: take PKG_CONFIG into account for libnetfilter_conntrack

[Tobias Klauser]

Hi Baruch

On 2017-04-16 at 06:49:27 +0200, Baruch Siach  wrote:
> Use $PKG_CONFIG to determine the linker flags for libnetfilter_conntrack. This
> fixes static link failure like the following:
> 
>   LD  flowtop
> .../usr/x86_64-buildroot-linux-musl/sysroot/usr/lib/../lib64/libnetfilter_conntrack.a(main.o):
>  In function `nfct_open_nfnl':
> main.c:(.text+0x52): undefined reference to `nfnl_subsys_open'
> main.c:(.text+0x69): undefined reference to `nfnl_subsys_close'
> main.c:(.text+0x87): undefined reference to `nfnl_subsys_open'
> main.c:(.text+0xa3): undefined reference to `nfnl_subsys_close'
> .../usr/x86_64-buildroot-linux-musl/sysroot/usr/lib/../lib64/libnetfilter_conntrack.a(main.o):
>  In function `nfct_open':
> main.c:(.text+0xc9): undefined reference to `nfnl_open'
> main.c:(.text+0xf0): undefined reference to `nfnl_close'
> ...
> 
> Signed-off-by: Baruch Siach 

Sorry for taking so long to reply.

Patch now applied, thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] [PATCH] flowtop: take PKG_CONFIG into account for libnetfilter_conntrack

[Baruch Siach]

Use $PKG_CONFIG to determine the linker flags for libnetfilter_conntrack. This
fixes static link failure like the following:

  LDflowtop
.../usr/x86_64-buildroot-linux-musl/sysroot/usr/lib/../lib64/libnetfilter_conntrack.a(main.o):
 In function `nfct_open_nfnl':
main.c:(.text+0x52): undefined reference to `nfnl_subsys_open'
main.c:(.text+0x69): undefined reference to `nfnl_subsys_close'
main.c:(.text+0x87): undefined reference to `nfnl_subsys_open'
main.c:(.text+0xa3): undefined reference to `nfnl_subsys_close'
.../usr/x86_64-buildroot-linux-musl/sysroot/usr/lib/../lib64/libnetfilter_conntrack.a(main.o):
 In function `nfct_open':
main.c:(.text+0xc9): undefined reference to `nfnl_open'
main.c:(.text+0xf0): undefined reference to `nfnl_close'
...

Signed-off-by: Baruch Siach 
---
 flowtop/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/flowtop/Makefile b/flowtop/Makefile
index effe7eb33fc3..e001ce8aaf13 100644
--- a/flowtop/Makefile
+++ b/flowtop/Makefile
@@ -1,5 +1,5 @@
 flowtop-libs = -lurcu \
-   -lnetfilter_conntrack \
+   $(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(PKG_CONFIG) --libs 
libnetfilter_conntrack 2> /dev/null ) \
$(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(PKG_CONFIG) --libs 
ncurses 2> /dev/null \
|| echo '-lncurses') \
$(shell PKG_CONFIG_PATH=$(PKG_CONFIG_PATH) $(PKG_CONFIG) --libs 
tinfo 2> /dev/null ) \
-- 
2.11.0

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.