Re: [PATCH] extracting CISCO_PROXY_PAC env variable

2016-07-06 Thread Thomas Haller 
On Fri, 2016-06-24 at 00:43 +0530, Atul Anand wrote:
> ---
>  src/nm-openconnect-service-openconnect-helper.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/nm-openconnect-service-openconnect-helper.c
> b/src/nm-openconnect-service-openconnect-helper.c
> index 5256d13..f0f9c17 100644
> --- a/src/nm-openconnect-service-openconnect-helper.c
> +++ b/src/nm-openconnect-service-openconnect-helper.c
> @@ -514,6 +514,11 @@ main (int argc, char *argv[])
>   if (val)
>   g_variant_builder_add (, "{sv}",
> NM_VPN_PLUGIN_IP4_CONFIG_DOMAIN, val);
>  
> + /* Proxy */
> + val = str_to_gvariant (getenv ("CISCO_PROXY_PAC"), TRUE);
> + if (val)
> + g_variant_builder_add (, "{sv}",
> NM_VPN_PLUGIN_CONFIG_PROXY_PAC, val);
> +
>   /* MTU  */
>   tmp = getenv ("INTERNAL_IP4_MTU");
>   if (tmp && strlen (tmp)) {


Hi Atul,


patch merged to nm-openconnect:

https://git.gnome.org/browse/network-manager-openconnect/commit/?id=11ec7550bacbc48f58f20332c059768b306b7e17

related is also the NetworkManager commit:
https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=de2ce68a9f8a89c1a84d98d56d6a6983a82e55c5


Thanks,
Thomas

signature.asc
Description: This is a digitally signed message part
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [PATCH] extracting CISCO_PROXY_PAC env variable

2016-07-06 Thread David Woodhouse 
On Fri, 2016-06-24 at 00:43 +0530, Atul Anand wrote:
> ---
>  src/nm-openconnect-service-openconnect-helper.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/nm-openconnect-service-openconnect-helper.c 
> b/src/nm-openconnect-service-openconnect-helper.c
> index 5256d13..f0f9c17 100644
> --- a/src/nm-openconnect-service-openconnect-helper.c
> +++ b/src/nm-openconnect-service-openconnect-helper.c
> @@ -514,6 +514,11 @@ main (int argc, char *argv[])
>   if (val)
>   g_variant_builder_add (, "{sv}", 
> NM_VPN_PLUGIN_IP4_CONFIG_DOMAIN, val);
>  
> + /* Proxy */
> + val = str_to_gvariant (getenv ("CISCO_PROXY_PAC"), TRUE);
> + if (val)
> + g_variant_builder_add (, "{sv}", 
> NM_VPN_PLUGIN_CONFIG_PROXY_PAC, val);
> +
>   /* MTU  */
>   tmp = getenv ("INTERNAL_IP4_MTU");
>   if (tmp && strlen (tmp)) {

I'm looking at doing a 1.2.3 release of NetworkManager-openconnect, and
would quite like to include this (#if NM_CHECK_VERSION(1,3,0))

How close are we to being able to merge the *basics* which at least let
VPN plugins provide the information, even if nothing's yet being *done*
with it?

-- 
David WoodhouseOpen Source Technology Centre
david.woodho...@intel.com  Intel Corporation

smime.p7s
Description: S/MIME cryptographic signature
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list

Re: [PATCH] extracting CISCO_PROXY_PAC env variable

2016-06-28 Thread Lubomir Rintel 
On Fri, 2016-06-24 at 00:43 +0530, Atul Anand wrote:
> ---
>  src/nm-openconnect-service-openconnect-helper.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/nm-openconnect-service-openconnect-helper.c
> b/src/nm-openconnect-service-openconnect-helper.c
> index 5256d13..f0f9c17 100644
> --- a/src/nm-openconnect-service-openconnect-helper.c
> +++ b/src/nm-openconnect-service-openconnect-helper.c
> @@ -514,6 +514,11 @@ main (int argc, char *argv[])
>   if (val)
>   g_variant_builder_add (, "{sv}",
> NM_VPN_PLUGIN_IP4_CONFIG_DOMAIN, val);
>  
> + /* Proxy */
> + val = str_to_gvariant (getenv ("CISCO_PROXY_PAC"), TRUE);
> + if (val)
> + g_variant_builder_add (, "{sv}",
> NM_VPN_PLUGIN_CONFIG_PROXY_PAC, val);
> +
>   /* MTU  */
>   tmp = getenv ("INTERNAL_IP4_MTU");
>   if (tmp && strlen (tmp)) {

This looks obviously alright.

Acked-by: Lubomir Rintel 
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list