[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...

[sesuncedu]

Github user sesuncedu closed the pull request at:

https://github.com/apache/commons-compress/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[sesuncedu]

Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/39
  
Replaced by PR https://github.com/apache/commons-compress/pull/43


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[sesuncedu]

Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/39
  
Closing because there's a new PR without the coveralls bait. 
Coveralls complains. 

The mvnw is not essential yet, but it's good to have  3.5.0 in place.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

[sesuncedu]

Github user sesuncedu commented on the issue:

https://github.com/apache/commons-compress/pull/43
  
That's why there was random coveralls stuff in the PR... 
coverage/coveralls — Coverage decreased (-0.02%) to 84.742%



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #44: Misc Coverage checks

[sesuncedu]

GitHub user sesuncedu opened a pull request:

https://github.com/apache/commons-compress/pull/44

Misc Coverage checks

Various coverage increases to pay for coveralls karma

Signed-off-by: Simon Spero 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress 
COVERAGE-CHECKS-REDUX

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/44.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #44


commit 6c2277ef90dac84fa66536abc16d6dcd14f8400d
Author: Simon Spero 
Date:   2017-06-24T20:53:26Z

Random coveralls bait.

Signed-off-by: Simon Spero 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #43: COMPRESS-413 : Improved build performance with t...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/43
  

[![Coverage 
Status](https://:/builds/12118735/badge)](https://:/builds/12118735)

Coverage decreased (-0.02%) to 84.742% when pulling 
**2fc4afa8f6571048604616a8edb2bbd55b4776f4 on sesuncedu:COMPRESS-413-REDUX** 
into **19e1b02f754a9b7bc969eb17bd52cc36a85c4d74 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #43: COMPRESS-413 : Improved build performance...

[sesuncedu]

GitHub user sesuncedu opened a pull request:

https://github.com/apache/commons-compress/pull/43

COMPRESS-413 : Improved build performance with travis

Now without unrelated sacrifices to coveralls

Signed-off-by: Simon Spero 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413-REDUX

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-compress/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #43


commit 2fc4afa8f6571048604616a8edb2bbd55b4776f4
Author: Simon Spero 
Date:   2017-06-24T20:37:47Z

COMPRESS-413 : Improved build performance with travis

Now without unrelated sacrifices to coveralls

Signed-off-by: Simon Spero 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-compress/pull/39
  

[![Coverage 
Status](https://:/builds/12118668/badge)](https://:/builds/12118668)

Coverage increased (+0.04%) to 84.766% when pulling 
**233536b0d1b1df8296fe254c59af5bed7e8c3e32 on sesuncedu:COMPRESS-413** into 
**4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Commons-Compress JDK-Matrix Build » OpenJDK 8 (on Ubuntu only) #2

[Apache Jenkins Server]

See 


--
Started by upstream project "Commons-Compress JDK-Matrix Build" build number 2
originally caused by:
 Started by user bodewig
[EnvInject] - Loading node environment variables.
Building remotely on beam1 (beam) in workspace 

Cloning the remote Git repository
Cloning repository git://github.com/apache/commons-compress.git
 > git init 
 > 
 >  # timeout=10
Fetching upstream changes from git://github.com/apache/commons-compress.git
 > git --version # timeout=10
 > git fetch --tags --progress git://github.com/apache/commons-compress.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url git://github.com/apache/commons-compress.git # 
 > timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url git://github.com/apache/commons-compress.git # 
 > timeout=10
Fetching upstream changes from git://github.com/apache/commons-compress.git
 > git fetch --tags --progress git://github.com/apache/commons-compress.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision fb9b6180428694c45a8befab3ca32834d99acece 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fb9b6180428694c45a8befab3ca32834d99acece
First time build. Skipping changelog.
[OpenJDK 8 (on Ubuntu only) ] $ /home/jenkins/tools/maven/latest/bin/mvn clean 
test
The JAVA_HOME environment variable is not defined correctly
This environment variable is needed to run this program
NB: JAVA_HOME should point to a JDK not a JRE
Build step 'Invoke top-level Maven targets' marked build as failure

Build failed in Jenkins: Commons-Compress JDK-Matrix Build » JDK 9 b156 (early access build) with project Jigsaw #1

[Apache Jenkins Server]

See 


--
[...truncated 180.92 KB...]
Running org.apache.commons.compress.compressors.deflate.DeflateParametersTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in 
org.apache.commons.compress.compressors.deflate.DeflateParametersTest
Running org.apache.commons.compress.compressors.XZTestCase
XZTestCase: HeapMax=25333596160 bytes 24160.0 MB
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.171 sec - in 
org.apache.commons.compress.compressors.XZTestCase
Running org.apache.commons.compress.compressors.FramedSnappyTestCase
test.txt written, uncompressed bytes: 369, compressed bytes: 53 after 2ms
bla.tar written, uncompressed bytes: 10240, compressed bytes: 971 after 2ms
COMPRESS-256.7z written, uncompressed bytes: 4069842, compressed bytes: 4068310 
after 246ms
bigChunkTest written, uncompressed bytes: 131072, compressed bytes: 131126 
after 12ms
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.474 sec - in 
org.apache.commons.compress.compressors.FramedSnappyTestCase
Running org.apache.commons.compress.compressors.DetectCompressorTestCase
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 sec - in 
org.apache.commons.compress.compressors.DetectCompressorTestCase
Running 
org.apache.commons.compress.compressors.brotli.BrotliCompressorInputStreamTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.075 sec - in 
org.apache.commons.compress.compressors.brotli.BrotliCompressorInputStreamTest
Running org.apache.commons.compress.compressors.BZip2TestCase
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec - in 
org.apache.commons.compress.compressors.BZip2TestCase
Running org.apache.commons.compress.compressors.pack200.Pack200UtilsTest
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.027 sec <<< 
FAILURE! - in org.apache.commons.compress.compressors.pack200.Pack200UtilsTest
testNormalizeInPlace(org.apache.commons.compress.compressors.pack200.Pack200UtilsTest)
  Time elapsed: 0.02 sec  <<< ERROR!
java.util.ServiceConfigurationError: 
sun.util.locale.provider.LocaleDataMetaInfo: Provider 
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo could not be 
instantiated
at 
org.apache.commons.compress.compressors.pack200.Pack200UtilsTest.testNormalizeInPlace(Pack200UtilsTest.java:93)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class 
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo
at 
org.apache.commons.compress.compressors.pack200.Pack200UtilsTest.testNormalizeInPlace(Pack200UtilsTest.java:93)

testNormalize(org.apache.commons.compress.compressors.pack200.Pack200UtilsTest) 
 Time elapsed: 0.007 sec  <<< ERROR!
java.util.ServiceConfigurationError: 
sun.util.locale.provider.LocaleDataMetaInfo: Provider 
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo could not be 
instantiated
at 
org.apache.commons.compress.compressors.pack200.Pack200UtilsTest.testNormalize(Pack200UtilsTest.java:47)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class 
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo
at 
org.apache.commons.compress.compressors.pack200.Pack200UtilsTest.testNormalize(Pack200UtilsTest.java:47)

Running org.apache.commons.compress.compressors.ZTestCase
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec - in 
org.apache.commons.compress.compressors.ZTestCase
Running 
org.apache.commons.compress.compressors.snappy.FramedSnappyCompressorInputStreamTest
Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.133 sec <<< 
FAILURE! - in 
org.apache.commons.compress.compressors.snappy.FramedSnappyCompressorInputStreamTest
readIWAFile(org.apache.commons.compress.compressors.snappy.FramedSnappyCompressorInputStreamTest)
  Time elapsed: 0.003 sec  <<< ERROR!
java.util.ServiceConfigurationError: 
sun.util.locale.provider.LocaleDataMetaInfo: Provider 
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo could not be 
instantiated
at 
org.apache.commons.compress.compressors.snappy.FramedSnappyCompressorInputStreamTest.readIWAFile(FramedSnappyCompressorInputStreamTest.java:154)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class 
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo
at 
org.apache.commons.compress.compressors.snappy.FramedSnappyCompressorInputStreamTest.readIWAFile(FramedSnappyCompressorInputStreamTest.java:154)

Running org.apache.commons.compress.compressors.snappy.SnappyRoundtripTest
COMPRESS-256.7z written, uncompressed bytes: 4069842, compressed bytes: 4067498 
after 303ms
COMPRESS-256.7z.raw.sz read after 11ms
Configuration: tuned for compression ratio
bla.tar written, uncompressed bytes: 10240, compressed bytes: 

[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...

[bodewig]

Github user bodewig commented on the issue:

https://github.com/apache/commons-compress/pull/39
  
Thanks Simon.

TBH I'm not too sure why we've got Travis builds at all, probably so we can 
run Coveralls. I'll leave this request open for those more interested in the 
Travis CI setup. I'll rather invest some time in adding a Jenkins matrix build 
for the JDKs we want to support instead.

Commons Compress aims to be compatible with Java7, no matter how old or 
deprecated, but we already cover that with Jenkins - the pull request builder 
over there uses Oracle JDK 7, so we've got that covered independent of Travis 
CI. We do run SonarQube for Compress already.

Personally I dislike `mvnw` scripts, but this is probably a matter of 
taste. I won't veto its introduction.

Please strip the changes to `AsiExtraField` from this PR, they are 
completely unrelated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #42: COMPRESS-407: Allow use of invalid record...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/42


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #40: COMPRESS-407 Validate Block and Record Si...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-compress pull request #41: COMPRESS-407 - Just Warn

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-compress/pull/41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---