Re: [PR] Bump vite from 4.4.7 to 4.4.12 in /example/vite-react-app [ofbiz-plugins]

2023-12-05 Thread via GitHub


sonarcloud[bot] commented on PR #91:
URL: https://github.com/apache/ofbiz-plugins/pull/91#issuecomment-1841882564

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins=91)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=91=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=91=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=91=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=91=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=91)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=91=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=91=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Bump vite from 4.4.7 to 4.4.12 in /example/vite-react-app [ofbiz-plugins]

2023-12-05 Thread via GitHub


dependabot[bot] opened a new pull request, #91:
URL: https://github.com/apache/ofbiz-plugins/pull/91

   Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 
4.4.7 to 4.4.12.
   
   Changelog
   Sourced from https://github.com/vitejs/vite/blob/v4.4.12/packages/vite/CHANGELOG.md;>vite's
 changelog.
   
   4.4.12 (2023-12-04)
   
   fix: backport https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15223;>#15223,
 proxy html path should be encoded (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15226;>#15226)
 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/15227;>#15227)
 (https://github.com/vitejs/vite/commit/fe8b209;>fe8b209), closes 
https://redirect.github.com/vitejs/vite/issues/15223;>#15223 https://redirect.github.com/vitejs/vite/issues/15226;>#15226 https://redirect.github.com/vitejs/vite/issues/15227;>#15227
   
   4.4.11 (2023-10-05)
   
   revert: fix: use string manipulation instead of regex to inject 
esbuild helpers (https://github.com/vitejs/vite/commit/54e1275;>54e1275), closes https://redirect.github.com/vitejs/vite/issues/14094;>#14094
   
   4.4.10 (2023-10-03)
   
   fix: add source map to Web Workers (fix https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14216;>#14216)
 (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14217;>#14217)
 (https://github.com/vitejs/vite/commit/df6f32f;>df6f32f), closes 
https://redirect.github.com/vitejs/vite/issues/14216;>#14216 https://redirect.github.com/vitejs/vite/issues/14217;>#14217
   fix: handle errors during hasWorkspacePackageJSON function 
(https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14394;>#14394)
 (https://github.com/vitejs/vite/commit/6f6e5de;>6f6e5de), closes 
https://redirect.github.com/vitejs/vite/issues/14394;>#14394
   fix: handle sourcemap correctly when multiple line import exists (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14232;>#14232)
 (https://github.com/vitejs/vite/commit/218861f;>218861f), closes 
https://redirect.github.com/vitejs/vite/issues/14232;>#14232
   fix: if host is specified check whether it is valid (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14013;>#14013)
 (https://github.com/vitejs/vite/commit/b1b816a;>b1b816a), closes 
https://redirect.github.com/vitejs/vite/issues/14013;>#14013
   fix: include vite/types/* in exports field (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14296;>#14296)
 (https://github.com/vitejs/vite/commit/40e99a1;>40e99a1), closes 
https://redirect.github.com/vitejs/vite/issues/14296;>#14296
   fix: initWasm options should be optional (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14152;>#14152)
 (https://github.com/vitejs/vite/commit/119c074;>119c074), closes 
https://redirect.github.com/vitejs/vite/issues/14152;>#14152
   fix: restore builtins list (https://github.com/vitejs/vite/commit/f8b9adb;>f8b9adb)
   fix: use string manipulation instead of regex to inject esbuild helpers 
(https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14094;>#14094)
 (https://github.com/vitejs/vite/commit/128ad8f;>128ad8f), closes 
https://redirect.github.com/vitejs/vite/issues/14094;>#14094
   fix: ws never connects after restarting server if server.hmr.server is 
set (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14127;>#14127)
 (https://github.com/vitejs/vite/commit/441642e;>441642e), closes 
https://redirect.github.com/vitejs/vite/issues/14127;>#14127
   fix(analysis): warnings for dynamic imports that use static template 
literals (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14458;>#14458)
 (https://github.com/vitejs/vite/commit/0c6d289;>0c6d289), closes 
https://redirect.github.com/vitejs/vite/issues/14458;>#14458
   fix(cli): convert special base (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14283;>#14283)
 (https://github.com/vitejs/vite/commit/d4bc0fb;>d4bc0fb), closes 
https://redirect.github.com/vitejs/vite/issues/14283;>#14283
   fix(css): remove pure css chunk sourcemap (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14290;>#14290)
 (https://github.com/vitejs/vite/commit/cd7e033;>cd7e033), closes 
https://redirect.github.com/vitejs/vite/issues/14290;>#14290
   fix(css): reset render cache on renderStart (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14326;>#14326)
 (https://github.com/vitejs/vite/commit/d334b3d;>d334b3d), closes 
https://redirect.github.com/vitejs/vite/issues/14326;>#14326
   fix(glob): trigger HMR for glob in a  package (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14117;>#14117)
 (https://github.com/vitejs/vite/commit/0f582bf;>0f582bf), closes 
https://redirect.github.com/vitejs/vite/issues/14117;>#14117
   fix(import-analysis): preserve importedUrls import order (https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/14465;>#14465)
 (https://github.com/vitejs/vite/commit/269aa43;>269aa43), 

[jira] [Created] (OFBIZ-12871) Can't build OfBiz following developer instructions

2023-12-05 Thread Cooper Oscarfono (Jira)
Cooper Oscarfono created OFBIZ-12871:


 Summary: Can't build OfBiz following developer instructions
 Key: OFBIZ-12871
 URL: https://issues.apache.org/jira/browse/OFBIZ-12871
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: 18.12.04
Reporter: Cooper Oscarfono


Following instructions detailed here:
[https://ofbiz.apache.org/developers.html]

performed the following steps on a fresh Linode running Centos 9, after 
creating a new user:

1. add adoptium repo to install recommended jdk
{code:java}

sudo vi /etc/yum.repos.d/adoptium.repo {code}

added the following:
{code:java}
[Adoptium]
name=Adoptium
baseurl=https://packages.adoptium.net/artifactory/rpm/centos/8/x86_64/
enabled=1
gpgcheck=1
gpgkey=https://packages.adoptium.net/artifactory/api/gpg/key/public {code}

performed dnf update


{code:java}
sudo dnf update
{code}

installed jdk:


{code:java}
sudo dnf install -y temurin-18-jdk {code}

installed git


{code:java}
sudo dnf install -y git{code}

cloned recommended repos:


{code:java}
git clone https://gitbox.apache.org/repos/asf/ofbiz-framework.git 
ofbiz-framework  {code}
 
{code:java}
 git clone https://gitbox.apache.org/repos/asf/ofbiz-plugins.git plugins  {code}

changed into repo directory:


{code:java}
cd ofbiz-framework/ {code}

updated tags 


{code:java}
git fetch --all --tags{code}

checked out correct version


{code:java}
git checkout release18.12.04 {code}

attempted to build


{code:java}
./gradlew cleanAll loadDefault{code}

received the following error:


{code:java}
FAILURE: Build failed with an exception.* What went wrong:
Could not create an instance of type 
org.gradle.initialization.DefaultSettings_Decorated.
> Could not initialize class org.codehaus.groovy.runtime.InvokerHelper* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output. Run with --scan to get full insights.* Get more 
help at https://help.gradle.orgBUILD FAILED in 0s {code}
 
tried again with stacktrace and debug options:


{code:java}
 ./gradlew cleanAll loadDefault --stacktrace --debug
23:35:44.146 [INFO] 
[org.gradle.internal.nativeintegration.services.NativeServices] Initialized 
native services in: /home/sod/.gradle/native
23:35:44.456 [DEBUG] [org.gradle.launcher.daemon.client.DaemonClient] Executing 
build 229e36ac-3c04-48b8-bb01-f909bb6fd24d in daemon client {pid=22244}
23:35:44.462 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding IP addresses for network interface eth0
23:35:44.462 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Is this a loopback interface? false
23:35:44.462 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Is this a multicast interface? true
23:35:44.462 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding remote address /fe80:0:0:0:f03c:94ff:fea1:d8ef%eth0
23:35:44.462 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding remote address /2400:8907:0:0:f03c:94ff:fea1:d8ef%eth0
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding remote address /192.168.146.75
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding remote address /172.105.190.26
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding remote multicast interface eth0
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding IP addresses for network interface lo
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Is this a loopback interface? true
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Is this a multicast interface? false
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding loopback address /0:0:0:0:0:0:0:1%lo
23:35:44.463 [DEBUG] [org.gradle.internal.remote.internal.inet.InetAddresses] 
Adding loopback address /127.0.0.1
23:35:44.478 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting 
to acquire shared lock on daemon addresses registry.
23:35:44.479 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock 
acquired on daemon addresses registry.
23:35:44.483 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] 
Releasing lock on daemon addresses registry.
23:35:44.486 [DEBUG] 
[org.gradle.internal.remote.internal.inet.TcpOutgoingConnector] Attempting to 
connect to [911be942-2110-4abf-a5c2-476184c92b12 port:42215, 
addresses:[/0:0:0:0:0:0:0:1, /127.0.0.1]].
23:35:44.486 [DEBUG] 
[org.gradle.internal.remote.internal.inet.TcpOutgoingConnector] Trying to 
connect to address /0:0:0:0:0:0:0:1.
23:35:44.491 [DEBUG] 
[org.gradle.internal.remote.internal.inet.TcpOutgoingConnector] Connected to 
address /[0:0:0:0:0:0:0:1]:42215.
23:35:44.505 [DEBUG] 

[jira] [Created] (OFBIZ-12870) Remove DES encryption from ofbiz crypto - insecure algorithm

2023-12-05 Thread Ioan Eugen Stan (Jira)
Ioan Eugen Stan created OFBIZ-12870:
---

 Summary: Remove DES encryption from ofbiz crypto - insecure 
algorithm
 Key: OFBIZ-12870
 URL: https://issues.apache.org/jira/browse/OFBIZ-12870
 Project: OFBiz
  Issue Type: Bug
  Components: framework/base
Reporter: Ioan Eugen Stan


In my opinion OFBiz should remove or deprecate and remove the implementation 
for DES crypto - class org.apache.ofbiz.base.crypto.DesCrypt .

DES encryption is broken and insecure to my knowledge 

[https://en.wikipedia.org/wiki/Data_Encryption_Standard]

[https://www.techtarget.com/searchsecurity/tip/Expert-advice-Encryption-101-Triple-DES-explained]

[https://docs.oracle.com/en/java/javase/11/docs/specs/security/standard-names.html]

In my opinion - it should be removed from the code in new releases.

If people have data encrypted with this they should migrate somehow.

Probably via an export-import?

 

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793365#comment-17793365
 ] 

Ioan Eugen Stan edited comment on OFBIZ-12726 at 12/5/23 5:19 PM:
--

I would like to know how to run the test from IDE as it's not very clear to me.

I have the this test failing 
|[accountingtests|http://localhost:63342/1_accountingtests.html]| 
[accounting-tests-data-load|http://localhost:63342/1_accountingtests.html#accounting-tests-data-load]|Error|

with the following error, but it does not tell me where in the code the test is 
failing. 
{noformat}
A transaction error occurred reading data
org.xml.sax.SAXException: A transaction error occurred 
reading data
org.apache.ofbiz.entity.transaction.GenericTransactionException: The 
current transaction is marked for rollback, not beginning a new 
transaction and aborting current operation; the rollbackOnly was caused 
by: Failure in create operation for entity [TestingCrypto]: 
java.lang.IllegalStateException: This object has been flagged as 
immutable (unchangeable), probably because it came from an Entity Engine
 cache. Cannot modify an immutable entity object. Use the clone method 
to create a mutable copy of this object.. Rolling back 
transaction.java.lang.IllegalStateException: This object has been 
flagged as immutable (unchangeable), probably because it came from an 
Entity Engine cache. Cannot modify an immutable entity object. Use the 
clone method to create a mutable copy of this object. (This object has 
been flagged as immutable (unchangeable), probably because it came from 
an Entity Engine cache. Cannot modify an immutable entity object. Use 
the clone method to create a mutable copy of this object.)
at 
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:299)
at 
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:261)
at 
org.apache.ofbiz.testtools.EntityXmlAssertTest.run(EntityXmlAssertTest.java:80)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at 
org.apache.ofbiz.base.start.Start.main(Start.java:89)
Caused by: 
org.apache.ofbiz.entity.transaction.GenericTransactionException: The 
current transaction is marked for rollback, not beginning a new 
transaction and aborting current operation; the rollbackOnly was caused 
by: Failure in create operation for entity [TestingCrypto]: 
java.lang.IllegalStateException: This object has been flagged as 
immutable (unchangeable), probably because it came from an Entity Engine
 cache. Cannot modify an immutable entity object. Use the clone method 
to create a mutable copy of this object.. Rolling back 
transaction.java.lang.IllegalStateException: This object has been 
flagged as immutable (unchangeable), probably because it came from an 
Entity Engine cache. Cannot modify an immutable entity object. Use the 
clone method to create a mutable copy of this object. (This object has 
been flagged as immutable (unchangeable), probably because it came from 
an Entity Engine cache. Cannot modify an immutable entity object. Use 
the clone method to create a mutable copy of this object.)
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.begin(TransactionUtil.java:143)
at 
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:277)
Caused by: java.lang.IllegalStateException: This
 object has been flagged as immutable (unchangeable), probably because 
it came from an Entity Engine cache. Cannot modify an immutable entity 
object. Use the clone method to create a mutable copy of this object.
at 
org.apache.ofbiz.entity.GenericEntity.assertIsMutable(GenericEntity.java:165)
at 
org.apache.ofbiz.entity.GenericEntity.setDelegator(GenericEntity.java:408)
at 
org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:890)
at 
org.apache.ofbiz.entity.GenericDelegator.rollback(GenericDelegator.java:2715)
at 

[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793365#comment-17793365
 ] 

Ioan Eugen Stan commented on OFBIZ-12726:
-

I would like to know how to run the test from IDE as it's not very clear to me.

 

I have
{noformat}
A transaction error occurred reading data
org.xml.sax.SAXException: A transaction error occurred 
reading data
org.apache.ofbiz.entity.transaction.GenericTransactionException: The 
current transaction is marked for rollback, not beginning a new 
transaction and aborting current operation; the rollbackOnly was caused 
by: Failure in create operation for entity [TestingCrypto]: 
java.lang.IllegalStateException: This object has been flagged as 
immutable (unchangeable), probably because it came from an Entity Engine
 cache. Cannot modify an immutable entity object. Use the clone method 
to create a mutable copy of this object.. Rolling back 
transaction.java.lang.IllegalStateException: This object has been 
flagged as immutable (unchangeable), probably because it came from an 
Entity Engine cache. Cannot modify an immutable entity object. Use the 
clone method to create a mutable copy of this object. (This object has 
been flagged as immutable (unchangeable), probably because it came from 
an Entity Engine cache. Cannot modify an immutable entity object. Use 
the clone method to create a mutable copy of this object.)
at 
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:299)
at 
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:261)
at 
org.apache.ofbiz.testtools.EntityXmlAssertTest.run(EntityXmlAssertTest.java:80)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at 
org.apache.ofbiz.base.start.Start.main(Start.java:89)
Caused by: 
org.apache.ofbiz.entity.transaction.GenericTransactionException: The 
current transaction is marked for rollback, not beginning a new 
transaction and aborting current operation; the rollbackOnly was caused 
by: Failure in create operation for entity [TestingCrypto]: 
java.lang.IllegalStateException: This object has been flagged as 
immutable (unchangeable), probably because it came from an Entity Engine
 cache. Cannot modify an immutable entity object. Use the clone method 
to create a mutable copy of this object.. Rolling back 
transaction.java.lang.IllegalStateException: This object has been 
flagged as immutable (unchangeable), probably because it came from an 
Entity Engine cache. Cannot modify an immutable entity object. Use the 
clone method to create a mutable copy of this object. (This object has 
been flagged as immutable (unchangeable), probably because it came from 
an Entity Engine cache. Cannot modify an immutable entity object. Use 
the clone method to create a mutable copy of this object.)
at 
org.apache.ofbiz.entity.transaction.TransactionUtil.begin(TransactionUtil.java:143)
at 
org.apache.ofbiz.entity.util.EntitySaxReader.parse(EntitySaxReader.java:277)
Caused by: java.lang.IllegalStateException: This
 object has been flagged as immutable (unchangeable), probably because 
it came from an Entity Engine cache. Cannot modify an immutable entity 
object. Use the clone method to create a mutable copy of this object.
at 
org.apache.ofbiz.entity.GenericEntity.assertIsMutable(GenericEntity.java:165)
at 
org.apache.ofbiz.entity.GenericEntity.setDelegator(GenericEntity.java:408)
at 
org.apache.ofbiz.entity.GenericDelegator.create(GenericDelegator.java:890)
at 
org.apache.ofbiz.entity.GenericDelegator.rollback(GenericDelegator.java:2715)
at 
org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:92){noformat}

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  

[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793342#comment-17793342
 ] 

Jacques Le Roux commented on OFBIZ-12726:
-

Yes that's it, just click on the numbers :)

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: image-2023-12-05-16-52-38-822.png
>
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793313#comment-17793313
 ] 

Ioan Eugen Stan commented on OFBIZ-12726:
-

How can i see the tests failures? 

I ran

```

$ ./gradlew cleanAll loadAll testIntegration

```

and opened 
[http://localhost:63342/ofbiz/runtime/logs/test-results/html/index.html . 
|http://localhost:63342/ofbiz/runtime/logs/test-results/html/index.html?_ijt=ejmrh78bnvnoueqi03h7pqd2ut&_ij_reload=RELOAD_ON_SAVE]
I got

!image-2023-12-05-16-52-38-822.png!

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: image-2023-12-05-16-52-38-822.png
>
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Ioan Eugen Stan (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ioan Eugen Stan updated OFBIZ-12726:

Attachment: image-2023-12-05-16-52-38-822.png

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: image-2023-12-05-16-52-38-822.png
>
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793251#comment-17793251
 ] 

Jacques Le Roux commented on OFBIZ-12726:
-

When removing {{'--add-opens=java.base/java.util=ALL-UNNAMED'}} we have now 190 
failures and 65 errors.

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GH] (ofbiz-framework): Workflow run "Build and push docker images" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Build and push docker images" on ofbiz-framework.git 
has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
565d8a37f75448eca89c345887970f7d51c08f14 / Eugen Stan 
Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7100107016

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
565d8a37f75448eca89c345887970f7d51c08f14 / Eugen Stan 
Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7100107017

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793238#comment-17793238
 ] 

Jacques Le Roux commented on OFBIZ-12726:
-

Thanks Eugen,

This was due to OFBIZ-11067

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793237#comment-17793237
 ] 

ASF subversion and git services commented on OFBIZ-12726:
-

Commit 565d8a37f75448eca89c345887970f7d51c08f14 in ofbiz-framework's branch 
refs/heads/release22.01 from Eugen Stan
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=565d8a37f7 ]

Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GH] (ofbiz-framework): Workflow run "Build and push docker images" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Build and push docker images" on ofbiz-framework.git 
has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
afe62e2d7cdcf753bf44e53a3426529bac869fce / Eugen Stan 
Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099874289

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
afe62e2d7cdcf753bf44e53a3426529bac869fce / Eugen Stan 
Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099874291

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails

2023-12-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793234#comment-17793234
 ] 

ASF subversion and git services commented on OFBIZ-12726:
-

Commit afe62e2d7cdcf753bf44e53a3426529bac869fce in ofbiz-framework's branch 
refs/heads/trunk from Eugen Stan
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=afe62e2d7c ]

Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) (#677)

UtilObjectTests was rererenced with a wrong package name.

> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> Following our discussion at 
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the 
> integration tests and found that we currently have 322 errors and 190 
> failures :/ 
> It's a blocker for releasing...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) [ofbiz-framework]

2023-12-05 Thread via GitHub


JacquesLeRoux merged PR #677:
URL: https://github.com/apache/ofbiz-framework/pull/677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (ofbiz-framework): Workflow run "Build and push docker images" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Build and push docker images" on ofbiz-framework.git 
has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
5013c3df661470b4bf2c5e7d0e2f9e40da6c49c2 / Eugen Stan 
Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099653819

With regards,
GitHub Actions via GitBox



[jira] [Commented] (OFBIZ-12731) Time zones always displayed using their daylight savings display name

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793229#comment-17793229
 ] 

Jacques Le Roux commented on OFBIZ-12731:
-

After closing OFBIZ-12721 we need to check the situation here

> Time zones always displayed using their daylight savings display name
> -
>
> Key: OFBIZ-12731
> URL: https://issues.apache.org/jira/browse/OFBIZ-12731
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes/helveticus, themes/rainbow
>Affects Versions: 18.12.06, 22.01.01
>Reporter: Daniel Watford
>Priority: Minor
>
> The timestamp displayed in the ofbiz footer will use the daylight savings 
> display name variant, even when the current date is outside of the daylight 
> savings period.
> See footer of [OFBiz: Katalogverwaltung: 
> (apache.org).|https://demo-stable.ofbiz.apache.org/catalog/control/setSessionTimeZone?tzId=Europe/London]
> At time of writing this description we are in December. Daylight savings will 
> not begin until March, but the timezone description is reported as British 
> Summer Time.
> Similarly, on the ListTimezones page, 
> [https://demo-stable.ofbiz.apache.org/catalog/control/ListTimezones,|https://demo-stable.ofbiz.apache.org/catalog/control/ListTimezones]
>  we see that the 'Europe/London' timezone is also named as British Summer 
> Time.
> The incorrect display of timezone names when outside of a daylight savings 
> period is due to 
> themes/[rainbowstone|flatgrey|helveticus]/template/Footer.ftl and 
> themes/common-theme/template/includes/ListTimezones.ftl.
> In these FTL file, there is a call to TimeZone#getDisplayName, passing a 
> boolean to indicate whether the timezone name should refer to daylight 
> savings. A true value is passed if the timezone is currently in a daylight 
> savings period or will transition to daylight savings in future.
> The logic should be changed to test the current time to see if daylight 
> savings is in effect and alter the call to TimeZone#getDisplayName 
> accordingly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GH] (ofbiz-framework): Workflow run "Build and push docker images" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Build and push docker images" on ofbiz-framework.git 
has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
ca0433d0e40ed9ac1cb73ad53be4a555ca9a3542 / Eugen Stan 
Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099626835

With regards,
GitHub Actions via GitBox



[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user asfgit (triggered by asfgit).

Head commit for run:
5013c3df661470b4bf2c5e7d0e2f9e40da6c49c2 / Eugen Stan 
Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099653866

With regards,
GitHub Actions via GitBox



[jira] [Closed] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId

2023-12-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-12721.
---
Fix Version/s: 22.01.01
   Resolution: Fixed

> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
> Fix For: 22.01.01
>
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker  
> |E| null
> freemarker.core._TemplateModelException: Java method 
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when 
> invoked on sun.util.calendar.ZoneInfo object 
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
>  see cause exception in the Java stack trace.
> 
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us...  [in template 
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
> 
> at 
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
>  ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class 
> freemarker.ext.beans.BeansWrapper cannot access class 
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base 
> does not export sun.util.calendar to unnamed module @1c852c0f
> at 
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
>  ~[?:?]
> at 
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) 
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552) 
> ~[freemarker-2.3.31.jar:2.3.31]
> at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73) 
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen 
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
>  The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally. 
> It's no longer supported by Java 17. We need to replace all occurrences of 
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set 
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> : 
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId

2023-12-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793225#comment-17793225
 ] 

ASF subversion and git services commented on OFBIZ-12721:
-

Commit 5013c3df661470b4bf2c5e7d0e2f9e40da6c49c2 in ofbiz-framework's branch 
refs/heads/release22.01 from Eugen Stan
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5013c3df66 ]

Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker  
> |E| null
> freemarker.core._TemplateModelException: Java method 
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when 
> invoked on sun.util.calendar.ZoneInfo object 
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
>  see cause exception in the Java stack trace.
> 
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us...  [in template 
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
> 
> at 
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
>  ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class 
> freemarker.ext.beans.BeansWrapper cannot access class 
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base 
> does not export sun.util.calendar to unnamed module @1c852c0f
> at 
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
>  ~[?:?]
> at 
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) 
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552) 
> ~[freemarker-2.3.31.jar:2.3.31]
> at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73) 
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen 
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
>  The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally. 
> It's no longer supported by Java 17. We need to replace all occurrences of 
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set 
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> : 
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!

2023-12-05 Thread GitBox


The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed.
Run started by GitHub user JacquesLeRoux (triggered by JacquesLeRoux).

Head commit for run:
ca0433d0e40ed9ac1cb73ad53be4a555ca9a3542 / Eugen Stan 
Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7099626824

With regards,
GitHub Actions via GitBox



Re: [PR] Fixed: Time zone display for JDK17+ (OFBIZ-12721) [ofbiz-framework]

2023-12-05 Thread via GitHub


JacquesLeRoux merged PR #676:
URL: https://github.com/apache/ofbiz-framework/pull/676


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (OFBIZ-12721) Replace all occurrences of java.util.TimeZone by java.time.ZoneId

2023-12-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793223#comment-17793223
 ] 

ASF subversion and git services commented on OFBIZ-12721:
-

Commit ca0433d0e40ed9ac1cb73ad53be4a555ca9a3542 in ofbiz-framework's branch 
refs/heads/trunk from Eugen Stan
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ca0433d0e4 ]

Fixed: Time zone display for JDK17+ (OFBIZ-12721) (#676)

Use ZoneId API to get time zone display name

Thanks Ioan Eugen

jleroux: I did not find any timeZone.getDisplayName in in Java and Groovy files 
so I guess it's OK to close.

> Replace all occurrences of java.util.TimeZone by java.time.ZoneId
> -
>
> Key: OFBIZ-12721
> URL: https://issues.apache.org/jira/browse/OFBIZ-12721
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
> Environment: Java 17
>Reporter: Jacques Le Roux
>Assignee: Ioan Eugen Stan
>Priority: Major
>
> Using JDK 17, we have this issue:
> {noformat}
> 2022-12-06 19:04:30,689 |sse-nio-8443-exec-10 |FreeMarkerWorker  
> |E| null
> freemarker.core._TemplateModelException: Java method 
> "sun.util.calendar.ZoneInfo.useDaylightTime()" threw an exception when 
> invoked on sun.util.calendar.ZoneInfo object 
> "sun.util.calendar.ZoneInfo[id=\"Europe/Paris\",offset=360,dstSa
> vings=360,useDaylight=true,transitions=184,lastRule=java.util.SimpleTimeZone[id=Europe/Paris,offset=360,dstSavings=360,useDaylight=true,startYear=0,startMode=2,startMonth=2,startDay=-1,startDayOfWeek=1,startTime=360,start
> TimeMode=2,endMode=2,endMonth=9,endDay=-1,endDayOfWeek=1,endTime=360,endTimeMode=2]]";
>  see cause exception in the Java stack trace.
> 
> FTL stack trace ("~" means nesting-related):
> - Failed at: ${timeZone.getDisplayName(timeZone.us...  [in template 
> "component://helveticus/template/includes/Footer.ftl" at line 21, column 98]
> 
> at 
> freemarker.ext.beans._MethodUtil.newInvocationTemplateModelException(_MethodUtil.java:292)
>  ~[freemarker-2.3.31.jar:2.3.31]
> [...]
> Caused by: java.lang.IllegalAccessException: class 
> freemarker.ext.beans.BeansWrapper cannot access class 
> sun.util.calendar.ZoneInfo (in module java.base) because module java.base 
> does not export sun.util.calendar to unnamed module @1c852c0f
> at 
> jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392)
>  ~[?:?]
> at 
> java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) 
> ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
> at 
> freemarker.ext.beans.BeansWrapper.invokeMethod(BeansWrapper.java:1552) 
> ~[freemarker-2.3.31.jar:2.3.31]
> at 
> freemarker.ext.beans.SimpleMethodModel.exec(SimpleMethodModel.java:73) 
> ~[freemarker-2.3.31.jar:2.3.31]
> ... 85 more
> {noformat}
> [The var timeZone is accessible in screen 
> context|https://cwiki.apache.org/confluence/display/OFBIZ/Variables+always+available+in+screen+context].
>  The java.util.TimeZone class uses sun.util.calendar.ZoneInfo internally. 
> It's no longer supported by Java 17. We need to replace all occurrences of 
> java.util.TimeZone by java.time.ZoneId.
> An easy temporary solution is to set 
> {{--add-exports=java.base/sun.util.calendar=ALL-UNNAMED}} in build.gradle:
> : 
> ['-Xms128M','-Xmx1024M','-Djdk.serialFilter=maxarray=10;maxdepth=20;maxrefs=1000;maxbytes=50','--add-exports=java.base/sun.util.calendar=ALL-UNNAMED']
> It has no impact with JDK 11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12868:

Priority: Blocker  (was: Major)

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12868:

Flags: Patch,Important

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793201#comment-17793201
 ] 

Jacques Le Roux edited comment on OFBIZ-12868 at 12/5/23 9:41 AM:
--

bq. Also I have still to handle the branches changes in pulPluginSource

I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

bq. Note: I have no tested bash scripts, they should be OK, the differences are 
minimal, just passing parameters.

Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order. 
I prefer to let the work for another person :) 
{color:#FF8B00}It should be pushed before January 8, 2024...{color}

Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]


was (Author: jacques.le.roux):
.bq Also I have still to handle the branches changes in pulPluginSource

I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

.bq Note: I have no tested bash scripts, they should be OK, the differences are 
minimal, just passing parameters.

Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order. 
I prefer to let the work for another person :) 
{color:#FF8B00}It should be pushed before January 8, 2024...{color}

Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793201#comment-17793201
 ] 

Jacques Le Roux edited comment on OFBIZ-12868 at 12/5/23 9:41 AM:
--

.bq Also I have still to handle the branches changes in pulPluginSource

I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

.bq Note: I have no tested bash scripts, they should be OK, the differences are 
minimal, just passing parameters.

Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order. 
I prefer to let the work for another person :) 
{color:#FF8B00}It should be pushed before January 8, 2024...{color}

Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]


was (Author: jacques.le.roux):
{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

{quote}Note: I have no tested bash scripts, they should be OK, the differences 
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order. 
I prefer to let the work for another person :) It should be pushed before 
January 8, 2024...



Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793201#comment-17793201
 ] 

Jacques Le Roux edited comment on OFBIZ-12868 at 12/5/23 9:40 AM:
--

{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

{quote}Note: I have no tested bash scripts, they should be OK, the differences 
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple and can be used one after the other in any order. 
I prefer to let the work for another person :) It should be pushed before 
January 8, 2024...



Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]


was (Author: jacques.le.roux):
{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

{quote}Note: I have no tested bash scripts, they should be OK, the differences 
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple, but I prefer to let the work for another person :)
They can be used one after the other in any order.

Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793201#comment-17793201
 ] 

Jacques Le Roux edited comment on OFBIZ-12868 at 12/5/23 9:37 AM:
--

{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

{quote}Note: I have no tested bash scripts, they should be OK, the differences 
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple, but I prefer to let the work for another person :)
They can be used one after the other in any order.

Here are also the changes in main build.gradle: [^OFBIZ-12868-svncheckout.patch]


was (Author: jacques.le.roux):
{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

{quote}Note: I have no tested bash scripts, they should be OK, the differences 
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple, but I prefer to let the work for another person :)
They can be used one after the other in any order.

Here are also the changes in main build.gradle:

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793201#comment-17793201
 ] 

Jacques Le Roux edited comment on OFBIZ-12868 at 12/5/23 9:36 AM:
--

{quote}Also I have still to handle the branches changes in pulPluginSource
{quote}
I finally decided to not use Gradle but only shell scripts for 3 reasons:
 * To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
 * The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
[https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion]
 * Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

{quote}Note: I have no tested bash scripts, they should be OK, the differences 
are minimal, just passing parameters.
{quote}
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat] and 
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple, but I prefer to let the work for another person :)
They can be used one after the other in any order.

Here are also the changes in main build.gradle:


was (Author: jacques.le.roux):
bq. Also I have still to handle the branches changes in pulPluginSource
I finally decided to not use Gradle but only shell scripts for 3 reasons:
* To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
* The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion
* Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

bq. Note: I have no tested bash scripts, they should be OK, the differences are 
minimal, just passing parameters.
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat]  and  
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple, but I prefer to let the work for another person :)
They can be used one after the other in any order.







> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-12868-svncheckout.patch, build.gradle.notworking, 
> gitClonePlugins.bat, gitClonePlugins.patch, gitClonePlugins.sh, 
> pullAPlugin.bat, pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12868:

Attachment: pullAllPlugins.bat

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: build.gradle.notworking, gitClonePlugins.bat, 
> gitClonePlugins.patch, gitClonePlugins.sh, pullAPlugin.bat, 
> pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793201#comment-17793201
 ] 

Jacques Le Roux commented on OFBIZ-12868:
-

bq. Also I have still to handle the branches changes in pulPluginSource
I finally decided to not use Gradle but only shell scripts for 3 reasons:
* To be able to change the current directory an Exec task must be used where 
"workingDir " is accessible. And it comes with some complications I crossed
* The pullPluginSource and pullAllPluginsSource tasks come also with some 
complications and use dependsOn which is no longer recommended to use most of 
the time: 
https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html#_conclusion
* Last but not least, for these 2 tasks we don't need to use Gradle which is 
much slower than directly using shell scripts (mins vs seconds)

bq. Note: I have no tested bash scripts, they should be OK, the differences are 
minimal, just passing parameters.
Actually the 2 new dos/bat scripts ( [^pullAllPlugins.bat]  and  
[^pullAPlugin.bat] ) have no bash scripts correspondant
They are quite simple, but I prefer to let the work for another person :)
They can be used one after the other in any order.







> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: build.gradle.notworking, gitClonePlugins.bat, 
> gitClonePlugins.patch, gitClonePlugins.sh, pullAPlugin.bat, 
> pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12868) Replace SvnCheckout in Gradle

2023-12-05 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12868:

Attachment: pullAPlugin.bat

> Replace SvnCheckout in Gradle
> -
>
> Key: OFBIZ-12868
> URL: https://issues.apache.org/jira/browse/OFBIZ-12868
> Project: OFBiz
>  Issue Type: Task
>  Components: GitHub, Gradle
>Affects Versions: 22.01.01, Upcoming Branch, 18.12.10
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: build.gradle.notworking, gitClonePlugins.bat, 
> gitClonePlugins.patch, gitClonePlugins.sh, pullAPlugin.bat, 
> pullAllPlugins.bat, pullPluginSource.bat, pullPluginSource.sh
>
>
> As mentionned in 
> https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy
> the SvnCheckout Gradle plugin will not be usable after January 8, 2024.
> So we need a replacement and it's clearly suggested by GitHub in the link 
> above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [PR] Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) [ofbiz-framework]

2023-12-05 Thread via GitHub


sonarcloud[bot] commented on PR #677:
URL: https://github.com/apache/ofbiz-framework/pull/677#issuecomment-1840366893

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=677)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=677=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=677=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=677=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=677=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=677)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=677=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=677=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Fixed: Test package name ref for UtilObjectTests (OFBIZ-12726) [ofbiz-framework]

2023-12-05 Thread via GitHub


ieugen opened a new pull request, #677:
URL: https://github.com/apache/ofbiz-framework/pull/677

   UtilObjectTests was rererenced with a wrong package name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org