[jira] [Commented] (OFBIZ-12863) Clean up demo site build scripts
[ https://issues.apache.org/jira/browse/OFBIZ-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803275#comment-17803275 ] Jacques Le Roux commented on OFBIZ-12863: - Thanks, I'll do so tmrw > Clean up demo site build scripts > > > Key: OFBIZ-12863 > URL: https://issues.apache.org/jira/browse/OFBIZ-12863 > Project: OFBiz > Issue Type: Improvement > Components: Demo >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Minor > > The three ofbiz demo sites (demo-trunk, demo-next, demo-stable) have now > hosted from docker containers rather than being built from source on the > ofbiz-vm1 host. > The scripts previously used to build the three demo sites, located under > /home/ofbizDemo, can now be removed. The ofbizDemo user can also be removed. > Removing unused scripts is worthwhile since it will avoid potential confusion > about how host ofbiz-vm1 is being used for future system administrators. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12789) Explore further use of npm modules to reduce bugs reported by sonarcloud
[ https://issues.apache.org/jira/browse/OFBIZ-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803271#comment-17803271 ] Daniel Watford commented on OFBIZ-12789: I'm happy to see this ticket closed since I think - back when I last worked on this - I had probably gone as far as I could with replacing javascript code not authored by the ofbiz project with npm modules. Even if we close this ticket, it would be good to have another ticket created addressing the outstanding sonarcloud issue, even if the fix is to alter the code in the ofbiz-framework repository. > Explore further use of npm modules to reduce bugs reported by sonarcloud > > > Key: OFBIZ-12789 > URL: https://issues.apache.org/jira/browse/OFBIZ-12789 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > Sonarcloud reports 10 bugs in ofbiz sources: > [https://sonarcloud.io/project/issues?resolved=false=BUG=apache_ofbiz-framework] > We tend to only notice bugs in new code as they will be highlighted during > pull request checking. > The majority of these bugs are related to javascript/css files under > themes/common-theme/webapp/common-theme not authored by the OFBiz project. > Explore whether suitable replacements are available for these files as npm > modules. If so, remove those files from ofbiz-framework and replace with a > corresponding dependency in > themes/common-theme/webapp/common-theme/js/package.json. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12863) Clean up demo site build scripts
[
https://issues.apache.org/jira/browse/OFBIZ-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803265#comment-17803265
]
Daniel Watford commented on OFBIZ-12863:
Hi [~jleroux] ,
Sorry that missed your comment in October:
{quote}Actually, it seems to me that we can remove not only the ofbizDemo user,
but all what is under /home/ofbizDemo, right?
{quote}
Yes, I agree, we have now transitioned all demo hosting from the ofbizDemo user
to the ofbizdocker user and can therefore remove the ofbizDemo user's home
directory, /home/ofbizDemo.
> Clean up demo site build scripts
>
>
> Key: OFBIZ-12863
> URL: https://issues.apache.org/jira/browse/OFBIZ-12863
> Project: OFBiz
> Issue Type: Improvement
> Components: Demo
>Reporter: Daniel Watford
>Assignee: Jacques Le Roux
>Priority: Minor
>
> The three ofbiz demo sites (demo-trunk, demo-next, demo-stable) have now
> hosted from docker containers rather than being built from source on the
> ofbiz-vm1 host.
> The scripts previously used to build the three demo sites, located under
> /home/ofbizDemo, can now be removed. The ofbizDemo user can also be removed.
> Removing unused scripts is worthwhile since it will avoid potential confusion
> about how host ofbiz-vm1 is being used for future system administrators.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803262#comment-17803262 ] Jacques Le Roux commented on OFBIZ-12726: - Thanks Eugen, I agree, Gil? > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png, > image-2024-01-04-18-28-27-910.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Removed unnecessary steps when building docker image with plugins (OFBIZ-12876) [ofbiz-framework]
sonarcloud[bot] commented on PR #682: URL: https://github.com/apache/ofbiz-framework/pull/682#issuecomment-1877534035 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=682) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=682=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=682=false=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=682=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=682) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12789) Explore further use of npm modules to reduce bugs reported by sonarcloud
[ https://issues.apache.org/jira/browse/OFBIZ-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803260#comment-17803260 ] Jacques Le Roux commented on OFBIZ-12789: - Hi Daniel, I had a look at https://sonarcloud.io/project/issues?resolved=false=BUG=apache_ofbiz-framework There is now only 2 issues in jquery.Jcrop.css that don't seem big. Should we not neglect and close here? > Explore further use of npm modules to reduce bugs reported by sonarcloud > > > Key: OFBIZ-12789 > URL: https://issues.apache.org/jira/browse/OFBIZ-12789 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Upcoming Branch >Reporter: Daniel Watford >Assignee: Daniel Watford >Priority: Minor > Fix For: Upcoming Branch > > > Sonarcloud reports 10 bugs in ofbiz sources: > [https://sonarcloud.io/project/issues?resolved=false=BUG=apache_ofbiz-framework] > We tend to only notice bugs in new code as they will be highlighted during > pull request checking. > The majority of these bugs are related to javascript/css files under > themes/common-theme/webapp/common-theme not authored by the OFBiz project. > Explore whether suitable replacements are available for these files as npm > modules. If so, remove those files from ofbiz-framework and replace with a > corresponding dependency in > themes/common-theme/webapp/common-theme/js/package.json. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Removed unnecessary steps when building docker image with plugins (OFBIZ-12876) [ofbiz-framework]
danwatford opened a new pull request, #682: URL: https://github.com/apache/ofbiz-framework/pull/682 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[
https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803255#comment-17803255
]
Ioan Eugen Stan commented on OFBIZ-12726:
-
I did a bit of research and found out that ./gradlew "ofbiz --test
suitename=entitytests" fails.
It might be the thing that fails the other tests.
I believe it's caused because xstream does not work with Java 17:
[https://github.com/x-stream/xstream/issues/262] .
The recommended way to fix it is to do:
{color:#6aab73}'--add-opens=java.base/java.util=ALL-UNNAMED'
{color}{color:#7a7e85}// OFBIZ-12726{color}
which we already do.
There does not seem to be a way around this other than replaxing xstream with
something else.
So I believe this issue can be closed and we can move forward.
We could open a new issue, related to this where we can consider dropping
xstream in place of something else.
But I guess we can do that at a later time.
No need to change if we have a workaround that seems ok so far.
cc [~jleroux] , [~pgil] wdyt?
```
| |No converter available Debugging information message : No
converter available type : java.util.Collections$UnmodifiableMap converter :
com.thoughtworks.xstream.converters.reflection.ReflectionConverter message[1] :
Unable to make field private static final long
java.util.Collections$UnmodifiableMap.serialVersionUID accessible: module
java.base does not "opens java.util" to unnamed module @75eeccf5
---
```
{{com.thoughtworks.xstream.converters.ConversionException: No converter
available}}
{{ Debugging information
}}
{{message : No converter available
}}
{{type:
java.util.Collections$UnmodifiableMap}}
{{converter :
com.thoughtworks.xstream.converters.reflection.ReflectionConverter
}}
{{message[1] : Unable to make field
private static final long
java.util.Collections$UnmodifiableMap.serialVersionUID accessible:
module java.base does not "opens java.util" to unnamed module @75eeccf5
}}
```|
> Running integration tests under Gradle 7.6 and JDK 17 fails
> ---
>
> Key: OFBIZ-12726
> URL: https://issues.apache.org/jira/browse/OFBIZ-12726
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Affects Versions: 22.01.01
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Attachments: image-2023-12-05-16-52-38-822.png,
> image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png,
> image-2024-01-04-18-28-27-910.png
>
>
> Following our discussion at
> https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the
> integration tests and found that we currently have 322 errors and 190
> failures :/
> It's a blocker for releasing...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803239#comment-17803239 ] Ioan Eugen Stan commented on OFBIZ-12726: - So I can confirm what [~pgil] found. Running test only a single component - that normally fails - makes the tests pass. This is the result for running: ./gradlew cleanAll loadAll "ofbiz --test suitename=accountingtests" As you can see the accountingtests pass. !image-2024-01-04-18-27-42-512.png! And this is the result for running: "./gradlew cleanAll loadAll testIntegration" . As you can see the accountingtests fail. !image-2024-01-04-18-28-27-910.png! > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png, > image-2024-01-04-18-28-27-910.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12726: Attachment: image-2024-01-04-18-28-27-910.png > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png, > image-2024-01-04-18-28-27-910.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12726) Running integration tests under Gradle 7.6 and JDK 17 fails
[ https://issues.apache.org/jira/browse/OFBIZ-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ioan Eugen Stan updated OFBIZ-12726: Attachment: image-2024-01-04-18-27-42-512.png > Running integration tests under Gradle 7.6 and JDK 17 fails > --- > > Key: OFBIZ-12726 > URL: https://issues.apache.org/jira/browse/OFBIZ-12726 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: 22.01.01 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Attachments: image-2023-12-05-16-52-38-822.png, > image-2023-12-12-18-10-16-016.png, image-2024-01-04-18-27-42-512.png > > > Following our discussion at > https://lists.apache.org/thread/kr4v21lxx493byzgpdrzfbz3whhbm82m I ran the > integration tests and found that we currently have 322 errors and 190 > failures :/ > It's a blocker for releasing... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12722) Fix Java 17 two warning issues
[
https://issues.apache.org/jira/browse/OFBIZ-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803224#comment-17803224
]
Ioan Eugen Stan commented on OFBIZ-12722:
-
[~jleroux] : Any idea why the code was done the way Daniel mentioned?
> Resolving the deprecation of GroovyTestCase might be a bit complicated.
> Groovy test suites test specifications are read in
> _ModelTestSuite#parseTestElements:_
> Fix Java 17 two warning issues
> --
>
> Key: OFBIZ-12722
> URL: https://issues.apache.org/jira/browse/OFBIZ-12722
> Project: OFBiz
> Issue Type: Sub-task
> Components: base, testtools
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> AuthHelper.java:132: warning: [removal] AccessController in java.security has
> been deprecated and marked for removal
> return AccessController.doPrivileged(
>^
> GroovyScriptTestCase.java:29: warning: [deprecation] GroovyTestCase in
> groovy.util has been deprecated
> public class GroovyScriptTestCase extends GroovyTestCase {
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12722) Fix Java 17 two warning issues
[
https://issues.apache.org/jira/browse/OFBIZ-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803221#comment-17803221
]
Ioan Eugen Stan commented on OFBIZ-12722:
-
I took a look at fixing the groovy warning - no luck yet - the code there is
pretty complex.
If we have a solution for AuthHelper, we should try it out.
Maybe we can get this done for 24.01 ?!
> Fix Java 17 two warning issues
> --
>
> Key: OFBIZ-12722
> URL: https://issues.apache.org/jira/browse/OFBIZ-12722
> Project: OFBiz
> Issue Type: Sub-task
> Components: base, testtools
>Affects Versions: Upcoming Branch
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
>
> AuthHelper.java:132: warning: [removal] AccessController in java.security has
> been deprecated and marked for removal
> return AccessController.doPrivileged(
>^
> GroovyScriptTestCase.java:29: warning: [deprecation] GroovyTestCase in
> groovy.util has been deprecated
> public class GroovyScriptTestCase extends GroovyTestCase {
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump dompurify from 3.0.6 to 3.0.7 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]
JacquesLeRoux merged PR #681: URL: https://github.com/apache/ofbiz-framework/pull/681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump dompurify from 3.0.6 to 3.0.7 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]
sonarcloud[bot] commented on PR #681: URL: https://github.com/apache/ofbiz-framework/pull/681#issuecomment-1877072923 ## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=681) **Quality Gate passed** Kudos, no new issues were introduced! [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=681=false=true) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=681=false=true) No data about Coverage [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=681=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=681) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump dompurify from 3.0.6 to 3.0.7 in /themes/common-theme/webapp/common-theme/js [ofbiz-framework]
dependabot[bot] opened a new pull request, #681: URL: https://github.com/apache/ofbiz-framework/pull/681 Bumps [dompurify](https://github.com/cure53/DOMPurify) from 3.0.6 to 3.0.7. Release notes Sourced from https://github.com/cure53/DOMPurify/releases;>dompurify's releases. DOMPurify 3.0.7 Added better protection against CSPP attacks, thanks https://github.com/kevin-mizu;>@kevin-mizu Updated browser versions for automated tests Updated Node versions for automated tests Commits https://github.com/cure53/DOMPurify/commit/aa2c561415e684f0e1e3cff57c8b1102edaa4dd4;>aa2c561 Merge pull request https://redirect.github.com/cure53/DOMPurify/issues/893;>#893 from cure53/main https://github.com/cure53/DOMPurify/commit/ab2c0812d787a1d822df64153dcf2f6c3c66e078;>ab2c081 chore: Preparing 3.0.7 release https://github.com/cure53/DOMPurify/commit/d7498e0546c0f67cf95437ae430ff2035582a689;>d7498e0 Merge pull request https://redirect.github.com/cure53/DOMPurify/issues/890;>#890 from cure53/dependabot/github_actions/github/codeql-a... https://github.com/cure53/DOMPurify/commit/813bea6e86b8143116b2871a10e9769604ed160d;>813bea6 build(deps): bump github/codeql-action from 2 to 3 https://github.com/cure53/DOMPurify/commit/31e03003777583d70fc16309d01afb7e55298a75;>31e0300 chore: mapped Node 21 to browserstack testing https://github.com/cure53/DOMPurify/commit/595fc227dbf098f3265f5ba42e9ac2d214cdff1b;>595fc22 chore: added newer node releases to test suite https://github.com/cure53/DOMPurify/commit/956e074bc2dbd44ea5b0ec5c374df92e7b500a3b;>956e074 chore: extended browser test array with latest versions https://github.com/cure53/DOMPurify/commit/d1e4f216664cc9e1ba5498a00b7d88a9cbd4c7f0;>d1e4f21 see https://redirect.github.com/cure53/DOMPurify/issues/881;>#881 https://github.com/cure53/DOMPurify/commit/d7318ee645ca782e59a00d724c61971cc781f721;>d7318ee see https://redirect.github.com/cure53/DOMPurify/issues/881;>#881 https://github.com/cure53/DOMPurify/commit/f89d72681513d749d303798ced02fa2799340989;>f89d726 fix: added better protection against CSPP, thanks https://github.com/Kevin-Mizu;>@Kevin-Mizu Additional commits viewable in https://github.com/cure53/DOMPurify/compare/3.0.6...3.0.7;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802914#comment-17802914 ] ASF subversion and git services commented on OFBIZ-12868: - Commit 7942b2b519f5433cf47481a2968442388b2b3e56 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7942b2b519 ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) As suggested by Daniel, nicer syntax in pullAllPluginsSource to get the current branch as a var > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802913#comment-17802913 ] ASF subversion and git services commented on OFBIZ-12868: - Commit 4fa1b5c4a229eae4456275aaf4e6447a8d215b88 in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=4fa1b5c4a2 ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) As suggested by Daniel, nicer syntax in pullAllPluginsSource to get the current branch as a var > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802912#comment-17802912 ] ASF subversion and git services commented on OFBIZ-12868: - Commit 65c091e0c10b357db276332a6911622444bec537 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=65c091e0c1 ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) As suggested by Daniel, nicer syntax in pullAllPluginsSource to get the current branch as a var > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802894#comment-17802894 ] ASF subversion and git services commented on OFBIZ-12868: - Commit 920e701de4f2264e923deffed7353e70825e69f4 in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=920e701de4 ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Previous conflict wrongly handled by hand in build.gradle This fixes it > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12863) Clean up demo site build scripts
[ https://issues.apache.org/jira/browse/OFBIZ-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802882#comment-17802882 ] Jacques Le Roux commented on OFBIZ-12863: - :D I was looking at https://github.com/apache/ofbiz-tools not https://github.com/apache/ofbiz-tools/tree/master/demo-backup/ofbizdocker I'll put a small README at https://github.com/apache/ofbiz-tools too > Clean up demo site build scripts > > > Key: OFBIZ-12863 > URL: https://issues.apache.org/jira/browse/OFBIZ-12863 > Project: OFBiz > Issue Type: Improvement > Components: Demo >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Minor > > The three ofbiz demo sites (demo-trunk, demo-next, demo-stable) have now > hosted from docker containers rather than being built from source on the > ofbiz-vm1 host. > The scripts previously used to build the three demo sites, located under > /home/ofbizDemo, can now be removed. The ofbizDemo user can also be removed. > Removing unused scripts is worthwhile since it will avoid potential confusion > about how host ofbiz-vm1 is being used for future system administrators. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12863) Clean up demo site build scripts
[ https://issues.apache.org/jira/browse/OFBIZ-12863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802872#comment-17802872 ] ASF subversion and git services commented on OFBIZ-12863: - Commit 1fa1d84598ba7a7187b2be3dd89be549f80e6f13 in ofbiz-tools's branch refs/heads/master from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;h=1fa1d84 ] Improved: Clean up demo site build scripts (OFBIZ-12863) Loosely related with the Jira, just a small change to see if after it shows on GH > Clean up demo site build scripts > > > Key: OFBIZ-12863 > URL: https://issues.apache.org/jira/browse/OFBIZ-12863 > Project: OFBiz > Issue Type: Improvement > Components: Demo >Reporter: Daniel Watford >Assignee: Jacques Le Roux >Priority: Minor > > The three ofbiz demo sites (demo-trunk, demo-next, demo-stable) have now > hosted from docker containers rather than being built from source on the > ofbiz-vm1 host. > The scripts previously used to build the three demo sites, located under > /home/ofbizDemo, can now be removed. The ofbizDemo user can also be removed. > Removing unused scripts is worthwhile since it will avoid potential confusion > about how host ofbiz-vm1 is being used for future system administrators. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GH] (ofbiz-framework): Workflow run "Build and push docker images" is working again!
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: c9009b3a4d028715fd602dbe533956541329cd61 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle Conflicts handled by hand in build.gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7407472369 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" is working again!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has succeeded. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: c9009b3a4d028715fd602dbe533956541329cd61 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle Conflicts handled by hand in build.gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7407472373 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Build and push docker images" failed!
The GitHub Actions job "Build and push docker images" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 6da924da5aaddeaafa02e031160d79afe93bfd34 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7407472793 With regards, GitHub Actions via GitBox
[GH] (ofbiz-framework): Workflow run "Java CI with Gradle" failed!
The GitHub Actions job "Java CI with Gradle" on ofbiz-framework.git has failed. Run started by GitHub user asfgit (triggered by asfgit). Head commit for run: 6da924da5aaddeaafa02e031160d79afe93bfd34 / Jacques Le Roux Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle Report URL: https://github.com/apache/ofbiz-framework/actions/runs/7407472787 With regards, GitHub Actions via GitBox
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802757#comment-17802757 ] ASF subversion and git services commented on OFBIZ-12868: - Commit bdbc08a4c2d91e11fae583655611ad84fa1f6c67 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bdbc08a4c2 ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802756#comment-17802756 ] ASF subversion and git services commented on OFBIZ-12868: - Commit 6da924da5aaddeaafa02e031160d79afe93bfd34 in ofbiz-framework's branch refs/heads/release22.01 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6da924da5a ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802755#comment-17802755 ] ASF subversion and git services commented on OFBIZ-12868: - Commit c9009b3a4d028715fd602dbe533956541329cd61 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=c9009b3a4d ] Fixed: Replace SvnCheckout in Gradle (OFBIZ-12868) Removes definitely SvnCheckout, pullPluginSource and pullAllPluginsSource tasks from Gradle (in build.gradle) Fixes both pullPluginSource scripts, notably uses a shallow clone rather than a blobless clone as suggested by Eugen, less space, faster Conflict handled by hand in build.gradle Conflicts handled by hand in build.gradle > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12868) Replace SvnCheckout in Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-12868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802632#comment-17802632 ] Jacques Le Roux commented on OFBIZ-12868: - Hi Eugen, Indeed, it fits better for pullPluginSource since we only want the source, the less Git footprint the better. I'll put that in the fixing commit I'll do now, thanks. About pullAllPluginsSource, to be compliant with the way the Gradle task was doing, I ultimately remove the .git dir that takes the most space. So only sources are present and I guess it's hard to take lesser space. For developers use I don't know how others do, but they certainly don't use pullAllPluginsSource because you have no relation with the repo since .git is absent. On my side, I simply clone the plugins outside of the framework in a "plugins" dir and move it under the framework. > Replace SvnCheckout in Gradle > - > > Key: OFBIZ-12868 > URL: https://issues.apache.org/jira/browse/OFBIZ-12868 > Project: OFBiz > Issue Type: Task > Components: GitHub, Gradle >Affects Versions: 22.01.01, Upcoming Branch, 18.12.10 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Blocker > Fix For: 22.01.01, Upcoming Branch, 18.12.12, 22.01 > > Attachments: OFBIZ-12868-README.patch, OFBIZ-12868-svncheckout.patch, > pullAllPluginsSource.bat, pullAllPluginsSource.sh, pullPluginSource.bat, > pullPluginSource.sh > > > As mentionned in > https://lists.apache.org/thread/on7n6nsbj0w237sqgmw7bfmw31116wcy > the SvnCheckout Gradle plugin will not be usable after January 8, 2024. > So we need a replacement and it's clearly suggested by GitHub in the link > above -- This message was sent by Atlassian Jira (v8.20.10#820010)
