[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2022-11-29 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640622#comment-17640622
 ] 

Ioan Eugen Stan commented on OFBIZ-10757:
-

I managed to start ofbiz locally (not without some errors and warnings) with 
JDK17 using the PR in https://issues.apache.org/jira/browse/OFBIZ-12400 .

As discussed on ML I think we can migrate to JDK17 and skip JDK 11 which was 
EOL'ed .

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2021-11-24 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448552#comment-17448552
 ] 

Michael Brohl commented on OFBIZ-10757:
---

Hi Stan, see my comment in OFBIZ-12400.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2021-11-24 Thread Ioan Eugen Stan (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448471#comment-17448471
 ] 

Ioan Eugen Stan commented on OFBIZ-10757:
-

Can we make some progress on this? 

I'm looking into building and running ofbiz with jdk 17 and that will require a 
gradle upgrade.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2021-02-03 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278138#comment-17278138
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

+1 for 11

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2021-02-03 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278116#comment-17278116
 ] 

Michael Brohl commented on OFBIZ-10757:
---

Hi all,

there was the idea to make the official switch to jdk11 within the next new 
branch which possibly will be 21.x .

jdk11 will be available at least until October 2024.

jdk17 (LTS) will be available from September 2021 and be available until 2025 
(four years).

I think we should decide if we want jdk11 to be the next supported JDK for 
OFBiz r21 or if we want to go with jdk17.

I tend to go with jdk11 which is mature and available and the community already 
made OFBiz ready for it.

What do you think?

 

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-08-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905015#comment-16905015
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

At OFBIZ-11138 I wrote this comment:
bq.  with Java 11 comes HTTP Client which handles HTTP2. Something we surely 
can use when we will switch to Java 11...

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-05-11 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837927#comment-16837927
 ] 

Mathieu Lirzin commented on OFBIZ-10757:


Committed  [^OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch] in revision 
1859123 on trunk, in revision 1859124 on release18.12 and in revision 1859125 
on release17.12.

I didn't backport it to release16.11 since patch application failed.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-05-09 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836187#comment-16836187
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

I think we can now close here, right? We know there are warnings but that's 
should not prevent to close, agreed?

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-04-12 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816088#comment-16816088
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Documentation done for all supported versions (R16, R17, R18, trunk) at 
revision 1857381.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-03-05 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784214#comment-16784214
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

As discussed on [dev ML|https://markmail.org/message/wgy6cjzhv5auy52q] we need 
to inform users about the conséquences of keeping on using Oracle Java. A 
change in the main README.adoc should be enough, as discussed on [dev 
ML|https://markmail.org/message/wgy6cjzhv5auy52q]

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-03-03 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782667#comment-16782667
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Done code improvement to fix the warnings at

Trunk at r{color:#22}1853904{color}, r{color:#22}1853905, r1854683, 
r1854684, {color}

{color:#22}and{color}

{color:#22}R18.12 at r1854689, r1854690, r1854692, r1854693
{color}

 

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-03-01 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782026#comment-16782026
 ] 

Taher Alkhateeb commented on OFBIZ-10757:
-

Go for it

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-03-01 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782013#comment-16782013
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

+1

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-03-01 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781493#comment-16781493
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

I think we can commit the patch excpet jdk version update in frist pass. 

 

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780480#comment-16780480
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

I created ["[OPTIONS] Java 11 and Java JDK 
origin"|https://markmail.org/message/wgy6cjzhv5auy52q] on dev ML to allow 
everyone to participate to the decisions

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-28 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780349#comment-16780349
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

A new patch with Javadoc update for ObjectType::getInstance 

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-27 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779092#comment-16779092
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Taher,

I don't think we should let all the work to Deepak ;). When you say
bq. so perhaps it might be cleaner to avoid mixing concepts in one commit.
If you think about {{ CacheSoftReference::finalize}} it's actually also a 
warning shown by Java 11. There is another which is
{{SafeObjectInputStream.java:83: warning: [deprecation] 
getProxyClass(ClassLoader,Class...) in Proxy has been deprecated}}
that I tried to fix yesterday but it's a bit more complicated because of the 
need of an InvocationHandler.

bq. Maybe the getInstance method can also get some love, it throws too many 
exceptions at the moment which kind of seems also too verbose? 
I just tried to restrict to InvocationTargetException, but Eclipse (compliance 
11, did not try to compile) does not agree and needs also those exceptions. We 
need to improve the Javadoc actually.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-26 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777817#comment-16777817
 ] 

Taher Alkhateeb commented on OFBIZ-10757:
-

I think bumping java to 11 should be done _after_ Deepak completes his prep 
work. His commit is more of a preparation for java 11, so perhaps it might be 
cleaner to avoid mixing concepts in one commit.

On the other hand, the patch looks much better. Maybe the getInstance method 
can also get some love, it throws too many exceptions at the moment which kind 
of seems also too verbose?

 

 

 

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1696#comment-1696
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Thanks Deepak,

Much easier to read, it misses

{code}
sourceCompatibility = '11'
targetCompatibility = '11'
{code}

I had a look at CacheSoftReference::finalize. It's not used anywhere so safe to 
remove.

I have updated your framework pach with the 2 points above.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-26 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1699#comment-1699
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Hi Michael,

Yes indeed, though it's not recommended (R17 not yet an official stable, no 
releases, R16 is) maybe some users could not wait and are already using R17 in 
production. So I'm mixed on that and I would prefer that we discuss it openly 
in dev ML, using either https://markmail.org/message/imobdl4fza2ujzkd (the 
"Oracle Java release model changes and consequences for the project" thread you 
created initially) or maybe creating a new thread to get a consensus about the 
choices (Adopt Open JDK or else?, Java 11 where?), thanks.


> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-framework.patch, 
> OFBIZ-10757-plugins.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-26 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1626#comment-1626
 ] 

Michael Brohl commented on OFBIZ-10757:
---

Hi [~deepak.dixit], [~jacques.le.roux], all,

I was away for a few days so missed to participate in the discussions around 
the switch to Java 11.

I propose to leave 17.12 on the Java 8 base. Adopt Open JDK is available for 
Java 8 also. Users who run projects on the stabilized 17.12 might be surprised 
with this switch, we should keep in mind that we should do these changes as 
predictable as possible.

So from my side, I would be in favor of supporting Java 8 for 16.11/17.12 and 
Adopt Open JDK 11 for 18.12 and trunk.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-25 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777634#comment-16777634
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Attached the updated patch, Please review.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, 
> OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch, 
> OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-25 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776692#comment-16776692
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Thanks Deepek,

OK, then let's dot it as Taher proposed (thanks for your detailled review 
Taher).

IN the meantime, I'll continue the discussion on Java 11 on dev ML

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-24 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776530#comment-16776530
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Hi [~jacques.le.roux] ,

>>OK my tone was maybe a bit harsh, sorry for that.

Due to some priority work I was unable to reply on your comment ,I know you 
very well, it was not a harsh answer :)

>>Your answer is not clear to me, should we follow Taher's advice or not? In 
>>other words should we not differentiate InvocationTargetException and 
>>NoSuchMethodException from ReflectiveOperationException?

In this case I agree with Taher, as we are not doing specific handling in case 
of  InvocationTargetException and NoSuchMethodException, so its good idea to 
handle ReflectiveOperationException.

I am open for both the option.

>>Now the question is should we not switch to Java 11 right now, for R17 and 
>>R18 as well?

+1 we should switch to jdk 11 for R17 and R18.

 

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-24 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776225#comment-16776225
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

OK my tone was maybe a bit harsh, sorry for that. I must say, I passed some 
time to find a solution for being able to quickly switch from a Java version to 
another (at the moment from 8 to 11 and vice versa). I have now a simple 
solution and will hopefully find the time to explain it on the wiki, maybe it 
will be helpful for others and in demo.

I have completely switched to 
[adoptopenjdk|https://adoptopenjdk.net/releases.html] which has still some 
undesirable effects on Windows but nothing unsurpassable and anyway not related 
to OFBiz.

I also switched from Eclipse 4.8 (2018-9) to Eclipse 4.10 (2018-12) to be able 
to use Java 11 compliance. Unlike my experience for last 5 years with Eclipse 
it was not an enjoyable time (false hope of updating directly). All work now 
and that's the most important.

Anyway Deepak's proposed changes are not a problem under Java 8, so, as a 1st 
step, I'll commit them in few days if nobody is against.

Now the question is should we not switch to Java 11 right now, for R17 and R18 
as well? We know in April Oracle will begin its new commercial politic and it's 
better to anticipate and switch to adoptopenjdk, if we all agree about this 
choice. I have not tested much yet but it seems to work well, using Java  8 or 
11. Being used by committers and on demo would be helpful to confirm before we 
release R17. I may have missed some points, some bear me and let's discuss it, 
better on dev ML...

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-22 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775280#comment-16775280
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Hi Deepak,

Your answer is not clear to me, should we follow Taher's advice or not? In 
other words should we not differentiate InvocationTargetException and 
NoSuchMethodException from ReflectiveOperationException?

I my opinion it's better to keep as is and commit.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-22 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775048#comment-16775048
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Hi [~taher],

Sorry for the confusion, I shared link just for reference to support your 
points.
{code:java}
This method propagates any exception thrown by the nullary constructor, 
including a checked exception. Use of this method effectively bypasses the 
compile-time exception checking that would otherwise be performed by the 
compiler. The Constructor.newInstance method avoids this problem by wrapping 
any exception thrown by the constructor in a (checked) 
InvocationTargetException.

The call


 clazz.newInstance()
 

can be replaced by


 clazz.getDeclaredConstructor().newInstance()
 

The latter sequence of calls is inferred to be able to throw the additional 
exception types InvocationTargetException and NoSuchMethodException. Both of 
these exception types are subclasses of ReflectiveOperationException
{code}

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-22 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774988#comment-16774988
 ] 

Taher Alkhateeb commented on OFBIZ-10757:
-

Hi Deepak. I read the link but not sure what it means. Did I make some sort of 
incorrect recommendation? If yes then nevermind. It's a minor point anyway.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774860#comment-16774860
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Thanks [~taher] for review. 
http://cr.openjdk.java.net/~mr/jigsaw/spec/api/deprecated-list.html

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774434#comment-16774434
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Not sure Taher, we would then hide the other cases

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774242#comment-16774242
 ] 

Taher Alkhateeb commented on OFBIZ-10757:
-

To reduce the verbosity of the code when using the new class instantiation 
logic, I recommend catching the parent (ReflectiveOperationException). The 
patches are not doing anything different between the different exceptions so 
maybe it would look nicer just to catch ReflectiveOperationException instead.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774082#comment-16774082
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Thanks [~mbrohl]

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774068#comment-16774068
 ] 

Michael Brohl commented on OFBIZ-10757:
---

Hi [~deepak.dixit],

I don't think this is related to Java 11. I have the same warnings in a 
customer project on base of the 17.12 branch with JDK 8.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774059#comment-16774059
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Yes, There are lots of warning related to UtilXml.LocalResolver.resolveEntity
{code}
2019-02-21 15:47:13,082 |kJoinPool-1-worker-1 |UtilXml   
|W| [UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with 
publicId [null] and the file/resource is [service-eca.xsd]
{code}

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774023#comment-16774023
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

{quote}runtime 'javax.xml.soap:javax.xml.soap-api:1.4.0'
 Should fix the NoClassDefFoundError: javax/xml/soap/SOAPException issue, 
Please try with cleanAll
{quote}
works!

Still a lot of warnings while launching OFBiz but nothing blocking.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773937#comment-16773937
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Thanks Michael,
{quote}
This should not be a problem if you run Eclipse with Java 8 and only set the 
project(s) to use JDK 11 for build/run.
{quote}
Yes I know, it was more for information.

Thanks Deepak,
{quote}
runtime 'javax.xml.soap:javax.xml.soap-api:1.4.0'
Should fix the NoClassDefFoundError: javax/xml/soap/SOAPException issue, Please 
try with cleanAll 
{quote}
I'll try.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773932#comment-16773932
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

I am able to run application on Mac os with jdk 11.
{code}
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
{code}

I also faced the issue related to NoClassDefFoundError: 
javax/xml/soap/SOAPException[1], after adding dependencies I am able to run the 
application. 

[1]https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-F640FA9D-FB66-4D85-AD2B-D931174C09A3

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773916#comment-16773916
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Hi Jacuques, 

runtime 'javax.xml.soap:javax.xml.soap-api:1.4.0'

Should fix the NoClassDefFoundError: javax/xml/soap/SOAPException issue, Please 
try with cleanAll 


> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773899#comment-16773899
 ] 

Michael Brohl commented on OFBIZ-10757:
---

{quote}Also got this with Eclipse: 
[https://stackoverflow.com/questions/52528693/eclipse-internal-error-polling-news-feeds]
{quote}
This should not be a problem if you run Eclipse with Java 8 and only set the 
project(s) to use JDK 11 for build/run.

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773860#comment-16773860
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Also got this with Eclipse: 
https://stackoverflow.com/questions/52528693/eclipse-internal-error-polling-news-feeds

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
> Attachments: OFBIZ-10757-framework.patch, OFBIZ-10757-plugins.patch
>
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-21 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773858#comment-16773858
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Thanks Deepak,

With the patches applied building is OK apart indeed the few warnings and the 
Groovy issue. We can wait for Groovy 3.

But running OFBiz and the test don't pass. Too much things (mostly warnings) to 
report at this stage... I thought that by removing the EntityListIterator and 
base changes things would improve. But that's not enough. So I removed all 
patches changes and still the same, fortunately it seems it's mostly a 
LifecycleException:
{noformat}
2019-02-21 10:14:04,202 |main |ControlServlet
|I| Loading webapp [partymgr], located at 
C:\projectsASF\ofbiz\applications\party\webapp\partymgr\
Feb 21, 2019 10:14:04 AM org.apache.catalina.core.ContainerBase startInternal
SEVERE: A child container failed during start
java.util.concurrent.ExecutionException: 
org.apache.catalina.LifecycleException: Failed to start component 
[StandardEngine[default-server].StandardHost[0.0.0.0].StandardContext[birt]]
at java.base/java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:191)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:951)
at 
org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
at 
java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
at 
org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:261)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.StandardService.startInternal(StandardService.java:422)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at 
org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:801)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
at org.apache.catalina.startup.Tomcat.start(Tomcat.java:372)
at 
org.apache.ofbiz.catalina.container.CatalinaContainer.start(CatalinaContainer.java:136)
at 
org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:157)
at 
org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:82)
at 
org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:201)
at 
org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70)
at org.apache.ofbiz.base.start.Start.main(Start.java:85)
Caused by: org.apache.catalina.LifecycleException: Failed to start component 
[StandardEngine[default-server].StandardHost[0.0.0.0].StandardContext[birt]]
at 
org.apache.catalina.util.LifecycleBase.handleSubClassException(LifecycleBase.java:441)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:198)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1432)
at 
org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1422)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at 
org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
at 
java.base/java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:140)
at 
org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:944)
... 21 more
Caused by: java.lang.NoClassDefFoundError: javax/xml/soap/SOAPException
at java.base/java.lang.Class.getDeclaredFields0(Native Method)
at java.base/java.lang.Class.privateGetDeclaredFields(Class.java:3062)
at java.base/java.lang.Class.getDeclaredFields(Class.java:2249)
at 
org.apache.catalina.util.Introspection.getDeclaredFields(Introspection.java:110)
at 
org.apache.catalina.startup.WebAnnotationSet.loadFieldsAnnotation(WebAnnotationSet.java:269)
at 
org.apache.catalina.startup.WebAnnotationSet.loadApplicationServletAnnotations(WebAnnotationSet.java:137)
at 
org.apache.catalina.startup.WebAnnotationSet.loadApplicationAnnotations(WebAnnotationSet.java:69)
at 

[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-20 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773688#comment-16773688
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Here is the patch, After applying this patch will get 20 warning. 

{code}
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy': class 
file for javax.annotation.concurrent.GuardedBy not found
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/.gradle/caches/modules-2/files-2.1/com.googlecode.concurrentlinkedhashmap/concurrentlinkedhashmap-lru/1.4.2/2eaf3d3c9746d526ff7e5b93931d482c3887e6ac/concurrentlinkedhashmap-lru-1.4.2.jar(/com/googlecode/concurrentlinkedhashmap/ConcurrentLinkedHashMap.class):
 warning: Cannot find annotation method 'value()' in type 'GuardedBy'
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:44:
 warning: [deprecation] finalize() in Object has been deprecated
protected void finalize() throws Throwable {
   ^
/Users/deepakdixit/sandbox/plain_ofbiz/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:48:
 warning: [deprecation] finalize() in Object has 

[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-20 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773158#comment-16773158
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

This is what I got:
{noformat}
49 warnings

> Task :test
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.codehaus.groovy.vmplugin.v7.Java7$1 
(file:/Z:/Gradle/caches/modules-2/files-2.1/org.codehaus.groovy/groovy-all/2.4.16/aa30a6479a3f6efc2ba8cd810cc2caf22a613b19/groovy-all-2.4.16.jar)
 to constructo
r java.lang.invoke.MethodHandles$Lookup(java.lang.Class,int)
WARNING: Please consider reporting this to the maintainers of 
org.codehaus.groovy.vmplugin.v7.Java7$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations
WARNING: All illegal access operations will be denied in a future release

BUILD SUCCESSFUL in 2m 24s
7 actionable tasks: 6 executed, 1 up-to-date
C:\projectsASF\ofbiz>
{noformat}
A lot of the warnings are
{quote}warning: [deprecation] newInstance() in Class has been deprecated
{quote}
Easy fix: 
[https://docs.oracle.com/javase/9/docs/api/java/lang/Class.html#newInstance--]

But some classes (24 errors) don't implement {{getDeclaredConstructor}}()

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-20 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772902#comment-16772902
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Some links for reference
https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-7744EF96-5899-4FB2-B34E-86D49B2E89B6
https://docs.oracle.com/javase/9/docs/api/java/lang/class-use/Deprecated.html


> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-19 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772177#comment-16772177
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

Fixed some deprecated method call related warnings at r#1853904 and r1853905

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-19 Thread Taher Alkhateeb (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772110#comment-16772110
 ] 

Taher Alkhateeb commented on OFBIZ-10757:
-

Yeah I agree, some of the warnings are fixable while others need more work.

The patch to upgrade to JDK 11 is very simple and I list it below.
{code:java}
Index: build.gradle
===
--- build.gradle    (revision 1853886)
+++ build.gradle    (working copy)
@@ -67,8 +67,8 @@
 )
 }
 
-sourceCompatibility = '1.8'
-targetCompatibility = '1.8'
+sourceCompatibility = '11'
+targetCompatibility = '11'
 
 // Java compile options, syntax gradlew -PXlint:none build
 tasks.withType(JavaCompile) {

{code}

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-19 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771905#comment-16771905
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

+1

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-13 Thread Deepak Dixit (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767201#comment-16767201
 ] 

Deepak Dixit commented on OFBIZ-10757:
--

I think first we can update to jdk11, and then can fix the warnings. 

Following are the two major warning
- warning: [deprecation] finalize() in Object has been deprecated
- warning: [deprecation] newInstance() in Class has been deprecated


> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-02-05 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760772#comment-16760772
 ] 

Jacques Le Roux commented on OFBIZ-10757:
-

Here are some quite relevant links (chrono order, but possible updates inside 
articles):
https://blog.joda.org/2018/08/java-is-still-available-at-zero-cost.html
https://blog.joda.org/2018/09/time-to-look-beyond-oracles-jdk.html
https://blog.joda.org/2018/09/do-not-fall-into-oracles-java-11-trap.html

> Upgrade OFBiz to use Java JDK Version 11
> 
>
> Key: OFBIZ-10757
> URL: https://issues.apache.org/jira/browse/OFBIZ-10757
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> To implement as per [Discussion 
> Thread|https://lists.apache.org/thread.html/71b8c1048f1dd4c5b3f104233c9af7b2cbc690863fe35b08ef91fcf5@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)