[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-05-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843194#comment-17843194
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit e8b6d41e29ec2052da426c786912deffaca06691 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e8b6d41e29 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

Fixes mainMenuLocation missing in AR and AP web.xml files hence error
java.lang.RuntimeException: Error rendering included menu named [MainActionMenu]
at location []: java.lang.IllegalArgumentException: Could not find menu file
in location []


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-28 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841590#comment-17841590
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Thanks Daniel,

I just updated a bit the related README.md at tools\demo-backup\ofbizdocker. 
About:
bq. One exception to deleting the data is that we do persist log files between 
refreshes.
I have checked the demos. We have 
* 373MB of old ofbiz and access logs in trunk
* 293 in stable
* 911 in next
Could you please remove them and close this issue?


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-27 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841424#comment-17841424
 ] 

Daniel Watford commented on OFBIZ-13035:


Hi [~jleroux] ,

New docker images are built and pushed to the GitHub Container Repository for 
each commit or tag on a branch. Depending on whether the build is triggered by 
a commit or a tag, the build will have '-snapshot' appended to the image tag.

The trigger of the build is governed by the following lines in 
[https://github.com/apache/ofbiz-framework/blob/trunk/.github/workflows/docker-image.yaml]
{quote}{{on:}}
{{  push:}}
{{    branches: [ trunk ]}}
{{    tags:}}
{{      - '**'}}{quote}
 

Regardless of how many builds of the docker images take place throughout the 
day, the demo sites are refreshed once a day every day at 02:35 UTC. This is 
controlled through a cronjob installed on the demo virtual machine: 
[https://github.com/apache/ofbiz-tools/blob/master/demo-backup/ofbizdocker/etc/cron.d/ofbizdocker]

The refresh process will retrieve the latest image for each demo site (trunk, 
stable, next) from the GitHub Container Registry and start a new container 
using that image. Any data that might have accumulated in the demo site is lost 
each time the refresh process is run as we also create a new database container 
for each site.

One exception to deleting the data is that we do persist log files between 
refreshes.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-27 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841413#comment-17841413
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Hi [~danwatford] ,

What is the trigger for update of demos? Is it only related to Java or Groovy 
changes?

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-25 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840797#comment-17840797
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Thanks a bunch [~danwatford], 

That was 3 days ago, and the fixing commit was yesterday. So it's OK. I'll 
remember the trick :)

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-25 Thread Daniel Watford (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840778#comment-17840778
 ] 

Daniel Watford commented on OFBIZ-13035:


Hi [~jleroux] ,

In case it helps, we have a way of checking sources for demo-trunk, although it 
is not straightforward.

>From the status bar at the footer of the demo-trunk login page we have text 
>similar to:
{quote}Copyright (c) 2001-2024 [The Apache Software 
Foundation|http://www.apache.org/]. Powered by [Apache 
OFBiz.|http://ofbiz.apache.org/] Release trunk-snapshot. revision: 
b12f2779e6fd90662baad3fee0f51dfb11215ee8. built on: 2024-04-23T16:19:05.136Z. 
with java version:: Temurin-17.0.10+7
{quote}
*trunk-snapshot* tells us we are dealing with a snapshot (rather than a 
release) from the trunk branch.

*revision b12f2779e6fd90662baad3fee0f51dfb11215ee8* states that we have built 
the docker image using commit b12f2779e6fd90662baad3fee0f51dfb11215ee8 from the 
trunk branch.

*2024-04-23T16:19:05* was the date-timestamp of the build.

We cannot directly determine which commit of the *ofbiz-plugins* repository was 
used, but we can work that out based on the build timestamp since we will alway 
use the HEAD of the ofbiz-plugins trunk branch when building the 
ofbiz-framework trunk branch.

Based on the above build timestamp it looks like the HEAD of the ofbiz-plugins 
trunk branch was 
[https://github.com/apache/ofbiz-plugins/commit/740512a4e6ad2297fe24dc4878f447e41074665d]

 

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-25 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840773#comment-17840773
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Hi Michael,

I had a doubt because of this error: 
https://demo-trunk.ofbiz.apache.org/exampleext

Actually I checked locally and I can't reproduce. It has been fixed by the last 
commit just above: 
https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b376ddfb7

I'm not sure why, it could be due to how the Docker CI process updates the 
demos. Unfortunately, unlike before we can't check the source on demos.

Anyway, apart the error already reported  by OFBIZ-10877, as long as not proved 
otherwise, there is no longer any cross-app menu location issues that can be 
reproduced locally. So I'll now rather close as fixed.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-25 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840677#comment-17840677
 ] 

Michael Brohl commented on OFBIZ-13035:
---

Hi [~jleroux] what does that mean for the state of this in trunk, quality wise?

Do we now have incomplete/inconsistent functionality or is it complete?

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-24 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840333#comment-17840333
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Actually I reported the same or similar 2 days ago. I'll have a look...

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840330#comment-17840330
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit b376ddfb7ca1702f20b665737aa084ae278d60a6 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=b376ddfb7 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

Fixes
Error rendering included menu named [ExampleAppBar] at location
[component://exampleext/widget/example/ExampleMenus.xml]:
java.lang.IllegalArgumentException: Could not find menu with name 
[ExampleAppBar]
 in location [component://exampleext/widget/example/ExampleMenus.xml]


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840177#comment-17840177
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Yes, I know, but I have no more information yet, it's from the demo trunk 
error.log

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-23 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840165#comment-17840165
 ] 

Pierre Smits commented on OFBIZ-13035:
--

HI @jacques,
In which application was this happening? Without more information this is hard 
to address.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-23 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840156#comment-17840156
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Another one for today:

2024-04-23 07:49:33,719 |-0.0.0.0-8009-exec-3 |ModelScreenWidget 
|E| Error rendering included menu named [MainActionMenu] at location []: 
java.lang.IllegalArgumentException: Could not find menu file in location []


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839837#comment-17839837
 ] 

Pierre Smits commented on OFBIZ-13035:
--

Jacques,

ExampleExt is quite the outlier compared to the average component/plugin. So 
there is no easy fix there. Any suggestions?

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839760#comment-17839760
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit 740512a4e6ad2297fe24dc4878f447e41074665d in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=740512a4e ]

Improved: Fix cross-app menu location issues (OFBIZ-13035) (#121)

address cross application menu-location issues.

modified: assetmaint/web.xml
- added context-param calendarMenuLocation (re calendar screen of a fixed asset)

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839535#comment-17839535
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Less easy:
2024-04-22 07:19:55,968 |-0.0.0.0-8009-exec-3 |ModelScreenWidget 
|E| Error rendering included menu named [MainActionMenu] at location []: 
java.lang.IllegalArgumentException: Could not find menu file in location []

I remember a typo (a space before ${ ) for one similar.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839508#comment-17839508
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Hi Pierre,

We have this one today:
2024-04-22 04:16:13,365 |-0.0.0.0-8009-exec-8 |ModelScreenWidget 
|E| Error rendering included menu named [ExampleAppBar] at location 
[component://exampleext/widget/example/ExampleMenus.xml]: 
java.lang.IllegalArgumentException: Could not find menu with name 
[ExampleAppBar] in location 
[component://exampleext/widget/example/ExampleMenus.xml]


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838641#comment-17838641
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit ae3ac360bbeedc064668e85de80c2e2228417e85 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=ae3ac360b ]

Improved: fix cross-app menu location issues (OFBIZ-13035) (#112)

modified: projectmgr/web.xml
added profileMenuLocation

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838605#comment-17838605
 ] 

Pierre Smits commented on OFBIZ-13035:
--

{quote}PR112 is only for project. Will you create other PRs for SFA, HumanRes 
and Scrum? As it's simple changes, you could also put commits for these apps in 
the PR112 if you like, no hurry at this stage as those does not create errors 
in log.
{quote}
Please put PR#112. Then it is out of the way for Project.

If additional need for such is necessary for SFA/Humanres I will create a new 
ticket. Same for those in ofbiz-plugins

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838604#comment-17838604
 ] 

Pierre Smits commented on OFBIZ-13035:
--

Thanks Jacques.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838601#comment-17838601
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

It was PR773 for SFA, I mixed localhost and demo tabs. It was actually OK. 
There are no pb either with PR774 for humanres.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838589#comment-17838589
 ] 

Pierre Smits commented on OFBIZ-13035:
--

{quote}Finally I decided to already fix the GroupUpdate error in humares. The 
rest of the PR does not hurt anyway.
{quote}
What was additionally wrong with 'GroupUpdate'? Didn't profileMenuLocation in 
humanres web.xml  fix that?

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838561#comment-17838561
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Pierre,

About
{quote}PR#112 re Project
will fix future profile view issues. Currently applications like SFA, HumanRes, 
Scrum use internal viewProfile uri to render the screen/form widgets from 
ProfileScreens.xml, while applications Accounting, Project (and others) 
redirect to the Party application. Given current Permissions situation (e.g. 
VIEW Permissions of user auditor), this is undesirable. (this is similar to 
recent discussion regarding link to PartyFinancialHistory in Accounting Main 
Page).
{quote}

PR112 is only for project. Will you create other PRs for SFA, HumanRes and 
Scrum? As it's simple changes, you could also put commits for these apps in the 
PR112 if you like, no hurry at this stage as those does not create errors in 
log. 

About PartyFinancialHistory, after reading again https://s.apache.org/hbls4 at 
OFBIZ-12384 I understand the possibly no authorised view issues with apps 
redirecting to other apps. Maybe tricky to find all such possible cases...


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838528#comment-17838528
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Hi [~pierresmits],

Finally I decided to already fix the GroupUpdate error in humares. The rest of 
the PR does not hurt anyway.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838522#comment-17838522
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

OK, it works. I simply needed to reload my local OFBiz instance

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838521#comment-17838521
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit ab35d4a751345956a6299f511053771c174ae351 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ab35d4a751 ]

Revert "Fixed: Fix cross-app menu location issues (OFBIZ-13035)"

This reverts wrong commit 0af9b20422d13d6d2641ad344779fc73dd8cd266.


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838520#comment-17838520
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

OK, something is wrong with my commit above. It already works with PR773 on 
trunk demo without this commit. I have several tabs open and thought. This 
morning I was using localhost when it was trunk demo. And the commit is not 
only useless but wrong. I picked it from ofbizsetup/Menus.xml it's not the same 
than in PartyMenus.xml provided by PR773. I'll revert this commit and try to 
understand what's wrong with my local instance that has no diff for framework 
nor plugins, so maybe data, weird.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838517#comment-17838517
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

For PRs 774 and 112, would you mind put in place the future implementations 
before, or does it make much time?

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838515#comment-17838515
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit 0af9b20422d13d6d2641ad344779fc73dd8cd266 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0af9b20422 ]

Fixed: Fix cross-app menu location issues (OFBIZ-13035)

The GroupUpdate menu was missing in SfaMenus.xm. This adds it


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-18 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838509#comment-17838509
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Mmm, I should have been tired yesterday. Actually after putting the GroupUpdate 
menu in SfaMenus.xml I did not save it. So of course it works now. I push it.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838282#comment-17838282
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Thanks Pierre,

Unfortunately after applying PR773 I still get this issue 
bq. java.lang.RuntimeException: Error rendering included menu named 
[GroupUpdate] at location []: java.lang.IllegalArgumentException: Could not 
find menu file in location []

I  quickly tried to add the GroupUpdate menu from PartyMenus.xml (sole place) 
in SfaMenus.xml to no avail.

I'll see the rest later, good evening

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838272#comment-17838272
 ] 

Pierre Smits commented on OFBIZ-13035:
--

PR#773 re SFA

fixes ProfilePage issues see 
[https://demo-trunk.ofbiz.apache.org/sfa/control/ViewAccountProfile?partyId=Company]

PR#774 re Humanres fixes:
 # profileMenuLocation fixes ProfilePage issues
see 
[https://demo-trunk.ofbiz.apache.org/humanres/control/viewprofile?partyId=Company=]
 # calendarMenuLocation fixes future parameterization hard coded workeffort 
menus in PersonTrainiingScreens.xml
 # commuicationMenuLocation fixes future alignment of communications in HR 
Portal Pages.

PR#112 re Project

will fix future profile view issues. Currently applications like SFA, HumanRes, 
Scrum use internal viewProfile uri to render the screen/form widgets from 
ProfileScreens.xml, while applications Accounting, Project (and others) 
redirect to the Party application. Given current Permissions situation (e.g. 
VIEW Permissions of user auditor), this is undesirable. (this is similar to 
recent discussion regarding link to PartyFinancialHistory in Accounting Main 
Page).

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-17 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838208#comment-17838208
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Hi Pierre,

Few questions, sorry if I miss something, 

What PR773 is supposed to fix? I see no calls to profileMenuLocation in sfa.
What PR112 is supposed to fix? I see no calls to profileMenuLocation in 
projectmgr.
What PR774 is supposed to fix? I see no calls to profileMenuLocation, 
communicationMenuLocation, nor profileMenuLocation in humanres.


> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838025#comment-17838025
 ] 

Pierre Smits commented on OFBIZ-13035:
--

HI [~jleroux] ,

PRs
 * [https://github.com/apache/ofbiz-framework/pull/773] (in ofbiz-framework)
 * [https://github.com/apache/ofbiz-plugins/pull/112] (in ofbiz-puggins)

Should fix stuff

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-17 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838010#comment-17838010
 ] 

Pierre Smits commented on OFBIZ-13035:
--

HI [~jleroux] 

I will close existing PRs in ofbiz-framework and ofbiz-plugins. And will submit 
new ones. 

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837789#comment-17837789
 ] 

Pierre Smits commented on OFBIZ-13035:
--

Will take a look tomorrow. Time to put a lid on it for now.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837786#comment-17837786
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Seems that's for another day...

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837783#comment-17837783
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Something is indeed wrong:
C:\projectsASF\Git\ofbiz-framework\plugins>git pull
Already up to date.

C:\projectsASF\Git\ofbiz-framework\plugins>git apply ..\111.patch
error: patch failed: scrum/webapp/scrum/WEB-INF/web.xml:39
error: scrum/webapp/scrum/WEB-INF/web.xml: patch does not apply
error: patch failed: projectmgr/webapp/projectmgr/WEB-INF/web.xml:42
error: projectmgr/webapp/projectmgr/WEB-INF/web.xml: patch does not apply
error: patch failed: myportal/webapp/myportal/WEB-INF/web.xml:53
error: myportal/webapp/myportal/WEB-INF/web.xml: patch does not apply
error: patch failed: projectmgr/webapp/projectmgr/WEB-INF/web.xml:47
error: projectmgr/webapp/projectmgr/WEB-INF/web.xml: patch does not apply
error: patch failed: projectmgr/widget/TimeSheetScreens.xml:231
error: projectmgr/widget/TimeSheetScreens.xml: patch does not apply
error: patch failed: scrum/webapp/scrum/WEB-INF/web.xml:44
error: scrum/webapp/scrum/WEB-INF/web.xml: patch does not apply

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837778#comment-17837778
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

There is something weird with https://github.com/apache/ofbiz-plugins/pull/111
It shows only 1 files changed but the patch shows much more (6 I guess, since 
there are 6 commits)

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837776#comment-17837776
 ] 

Pierre Smits commented on OFBIZ-13035:
--

Grrr. I missed one in HumanRes.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837774#comment-17837774
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Yes it's works

Not sure why 
https://github.com/apache/ofbiz-framework/commit/9c7c27d839b8d51217779321d5742597f504f43f
 does not appear here. We already have a such issue that Infra fixed.

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837772#comment-17837772
 ] 

Pierre Smits commented on OFBIZ-13035:
--

Hi [~jleroux]

I believe I caught them all. And set the status to patch provided.

bq. Seems that this i addressed by 
https://github.com/apache/ofbiz-framework/pull/769. 
Indeed. PR#769 (in ofbiz-framework) should have gotten in first

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837770#comment-17837770
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

{quote}Got this in project:
java.lang.RuntimeException: Error rendering included menu named 
[TimesheetActionMenu] at location 
[component://workeffort/widget/WorkEffortMenus.xml]: 
java.lang.IllegalArgumentException: Could not find menu with name 
[TimesheetActionMenu] in location 
[component://workeffort/widget/WorkEffortMenus.xml]
{quote}

Seems that this i addressed by 
https://github.com/apache/ofbiz-framework/pull/769. Let's see...

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837766#comment-17837766
 ] 

Jacques Le Roux commented on OFBIZ-13035:
-

Got this in project:
java.lang.RuntimeException: Error rendering included menu named 
[TimesheetActionMenu] at location 
[component://workeffort/widget/WorkEffortMenus.xml]: 
java.lang.IllegalArgumentException: Could not find menu with name 
[TimesheetActionMenu] in location 
[component://workeffort/widget/WorkEffortMenus.xml]

Another:
https://localhost:8443/myportal/control/showPortalPage?portalPageId=MYPORTAL_EMPLOYEE4=MYPORTAL_EMPLOYEE
java.lang.RuntimeException: Error rendering included menu named 
[TimesheetActionMenu] at location []: java.lang.IllegalArgumentException: Could 
not find menu file in location []

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-16 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837758#comment-17837758
 ] 

ASF subversion and git services commented on OFBIZ-13035:
-

Commit a9d7857c5e1b94b3066debaa6365ee2f1209b115 in ofbiz-plugins's branch 
refs/heads/trunk from Pierre Smits
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=a9d7857c5 ]

Improved:cross-app memu location issues (OFBIZ-13035) (#110)

* Improved:cross-app memu location issues (OFBIZ-13035)

address cross application menu-location issues.

modified:
in SCRUM: web.xml - add context-param for profileMenuLocation

* Improved:cross-app memu location issues (OFBIZ-13035)

address cross application menu-location issues.

modified:
in PROJECT: web.xml - add context-param for requestMenuLocation

* Improved:cross-app memu location issues (OFBIZ-13035)

address cross application menu-location issues.

modified:
in MYPORTAL: web.xml - add context-param for profiletMenuLocation

* Improved: Fix cross-app menu location issues (FBIZ-13035)

address cross application menu-location issues.

Plugins use the timesheet functionality from the workeffort component. Given 
that base approval should be in the workeffort component, duplicate menus in 
plugins should reside in workeffort

modified:
- Project/web.xml: added context-param timesheetMenuLocation
- Project/TimeSheetScreens.xml: changed ref and location  regarding timesheet 
actions
- Scrum/web.xml: added context-param timesheetMenuLocation

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)