Re: [NTG-context] \startstopcomment fails on latest beta

2012-02-03 Thread Marco Pessotto 
Hans Hagen pra...@wxs.nl writes:

 On 1-2-2012 19:31, Marco Pessotto wrote:

 Hello there.

 See the following minimal example. Without the \setupinteraction the
 document compiles just fine.

 as there is no beta this week, you can patch yourself ... scrn-wid.lua
 ... should either have

 b_scrn_comment_link

 or

 scrn_comment_box_link

 (depending on what's n your system; you can search in scrn-wid.mkiv
 for the right box name)


Well, I've applied this change and executed context --make

--- ./tex/texmf-context/tex/context/base/scrn-wid.lua~  2011-05-24 
11:32:54.0 +0200
+++ ./tex/texmf-context/tex/context/base/scrn-wid.lua   2012-02-03 
09:44:14.0 +0100
@@ -117,7 +117,7 @@
 end
 
 function commands.insertcomment(specification)
-tex.box[scrn_comment_box_link] = comments.insert(specification)
+tex.box[b_scrn_comment_link] = comments.insert(specification)
 end
 
 -- Soundclips

This is better, as the compilation doesn't fail and the comment appears
as comment, but on the page there is a literal [title=,] (in the first
example) or [title=commentname,] in the second and third example.

\setupinteraction[state=start]
\starttext
Regular 1
\startcomment
1. This won't be published, but attached as a comment
\stopcomment
Regular 2
\startcomment[commentname]
2. This won't be published, but attached as a comment
\stopcomment
Regular 3
\startcomment[commentname][]
3. This won't be published, but attached as a comment
\stopcomment
\stoptext

There is no problem in the current version (2011.05.18), but is
present in version 2011.11.29 23:11 (which is the other previous version
I have on my machine).

Thanks for your attention and all your work.

Best regards.

-- 
Marco
___
If your question is of interest to others as well, please add an entry to the 
Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___

Re: [NTG-context] \startstopcomment fails on latest beta

2012-02-03 Thread Wolfgang Schuster 

Am 03.02.2012 um 10:13 schrieb Marco Pessotto:

 This is better, as the compilation doesn't fail and the comment appears
 as comment, but on the page there is a literal [title=,] (in the first
 example) or [title=commentname,] in the second and third example.

scrn-wid.mkvi

\def\scrn_comment_start_indeed[#title][#settings]%
  {\bgroup
   \doifassignmentelse{#title}
-{\setupcurrentcomment[\currentcomment][#title]}
-{\setupcurrentcomment[\currentcomment][\c!title=#title,#settings]}%
+{\setupcurrentcomment[#title]}
+{\setupcurrentcomment[\c!title=#title,#settings]}%
   \def\scrn_comment_stop{\scrn_comment_inject\egroup}%
   
\grabbufferdatadirect\v!comment{\e!start\currentcomment}{\e!stop\currentcomment}}

@Hans: \scrn_comment_start_indeed is defined twice 

\def\scrn_comment_start_indeed
  {\doifelse{\commentparameter\c!state}\v!start
 {\scrn_comment_start_indeed}
 {\scrn_comment_start_ignore}}

\def\scrn_comment_start_indeed[#title][#settings]%
  {\bgroup
   \doifassignmentelse{#title}
 {\setupcurrentcomment[\currentcomment][#title]}
 {\setupcurrentcomment[\currentcomment][\c!title=#title,#settings]}%
   \def\scrn_comment_stop{\scrn_comment_inject\egroup}%
   
\grabbufferdatadirect\v!comment{\e!start\currentcomment}{\e!stop\currentcomment}}

Wolfgang
___
If your question is of interest to others as well, please add an entry to the 
Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___

Re: [NTG-context] \startstopcomment fails on latest beta

2012-02-03 Thread Marco Pessotto 
Wolfgang Schuster schuster.wolfg...@googlemail.com writes:

 Am 03.02.2012 um 10:13 schrieb Marco Pessotto:

 This is better, as the compilation doesn't fail and the comment appears
 as comment, but on the page there is a literal [title=,] (in the first
 example) or [title=commentname,] in the second and third example.

 scrn-wid.mkvi

 \def\scrn_comment_start_indeed[#title][#settings]%
   {\bgroup
\doifassignmentelse{#title}
 -{\setupcurrentcomment[\currentcomment][#title]}
 -{\setupcurrentcomment[\currentcomment][\c!title=#title,#settings]}%
 +{\setupcurrentcomment[#title]}
 +{\setupcurrentcomment[\c!title=#title,#settings]}%
\def\scrn_comment_stop{\scrn_comment_inject\egroup}%

 \grabbufferdatadirect\v!comment{\e!start\currentcomment}{\e!stop\currentcomment}}


Tested and works like a charm. Thanks a lot.
Best wishes

-- 
Marco
___
If your question is of interest to others as well, please add an entry to the 
Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___

Re: [NTG-context] \startstopcomment fails on latest beta

2012-02-03 Thread Hans Hagen 

On 3-2-2012 15:19, Wolfgang Schuster wrote:


@Hans: \scrn_comment_start_indeed is defined twice

\def\scrn_comment_start_indeed
   {\doifelse{\commentparameter\c!state}\v!start
  {\scrn_comment_start_indeed}
  {\scrn_comment_start_ignore}}

\def\scrn_comment_start_indeed[#title][#settings]%
   {\bgroup
\doifassignmentelse{#title}
  {\setupcurrentcomment[\currentcomment][#title]}
  {\setupcurrentcomment[\currentcomment][\c!title=#title,#settings]}%
\def\scrn_comment_stop{\scrn_comment_inject\egroup}%

\grabbufferdatadirect\v!comment{\e!start\currentcomment}{\e!stop\currentcomment}}


should be

\unexpanded\def\scrn_comment_start#category%
  {\def\currentcomment{#category}%
   \doifelselocation
 {\dodoubleempty\scrn_comment_start_status}
 {\dodoubleempty\scrn_comment_start_ignore}}

\def\scrn_comment_start_status



-
  Hans Hagen | PRAGMA ADE
  Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
 | www.pragma-pod.nl
-
___
If your question is of interest to others as well, please add an entry to the 
Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___

Re: [NTG-context] \startstopcomment fails on latest beta

2012-02-02 Thread Hans Hagen 

On 1-2-2012 19:31, Marco Pessotto wrote:


Hello there.

See the following minimal example. Without the \setupinteraction the
document compiles just fine.


as there is no beta this week, you can patch yourself ... scrn-wid.lua 
... should either have


b_scrn_comment_link

or

scrn_comment_box_link

(depending on what's n your system; you can search in scrn-wid.mkiv for 
the right box name)


Hans

-
  Hans Hagen | PRAGMA ADE
  Ridderstraat 27 | 8061 GH Hasselt | The Netherlands
tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com
 | www.pragma-pod.nl
-
___
If your question is of interest to others as well, please add an entry to the 
Wiki!

maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context
webpage  : http://www.pragma-ade.nl / http://tex.aanhet.net
archive  : http://foundry.supelec.fr/projects/contextrev/
wiki : http://contextgarden.net
___