Re: [Numpy-discussion] Developmental version numbering with git
Hi, On Tue, Nov 9, 2010 at 7:48 AM, Charles R Harris charlesr.har...@gmail.com wrote: On Tue, Nov 9, 2010 at 8:20 AM, Scott Sinclair scott.sinclair...@gmail.com wrote: On 8 November 2010 23:17, Matthew Brett matthew.br...@gmail.com wrote: Since the change to git the numpy version in setup.py is '2.0.0.dev' regardless because the prior numbering was determined by svn. Is there a plan to add some numbering system to numpy developmental version? Regardless of the answer, the 'numpy/numpy/version.py' will need to changed because of the reference to the svn naming. In case it's useful, we (nipy) went for a scheme where the version number stays as '2.0.0.dev', but we keep a record of what git commit has we are on - described here: http://web.archiveorange.com/archive/v/AW2a1CzoOZtfBfNav9hd I can post more details of the implementation if it's of any interest, In the meantime there's a patch in that direction here: https://github.com/numpy/numpy/pull/12 Tiny patch for py3k attached. Should the generated numpy/version.py be in .gitignore? Is there a better name in order to signal the generated nature of the file? Best, Matthew 0001-BF-py3k-fix-for-git-version-string.patch Description: Binary data ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
Re: [Numpy-discussion] Developmental version numbering with git
On Thu, Nov 11, 2010 at 12:32 PM, Matthew Brett matthew.br...@gmail.comwrote: Hi, On Tue, Nov 9, 2010 at 7:48 AM, Charles R Harris charlesr.har...@gmail.com wrote: On Tue, Nov 9, 2010 at 8:20 AM, Scott Sinclair scott.sinclair.za@ gmail.com wrote: On 8 November 2010 23:17, Matthew Brett matthew.br...@gmail.com wrote: Since the change to git the numpy version in setup.py is '2.0.0.dev' regardless because the prior numbering was determined by svn. Is there a plan to add some numbering system to numpy developmental version? Regardless of the answer, the 'numpy/numpy/version.py' will need to changed because of the reference to the svn naming. In case it's useful, we (nipy) went for a scheme where the version number stays as '2.0.0.dev', but we keep a record of what git commit has we are on - described here: http://web.archiveorange.com/archive/v/AW2a1CzoOZtfBfNav9hd I can post more details of the implementation if it's of any interest, In the meantime there's a patch in that direction here: https://github.com/numpy/numpy/pull/12 Tiny patch for py3k attached. Should the generated numpy/version.py be in .gitignore? Is there a better name in order to signal the generated nature of the file? I thought it already was, but if not, yes, I think it should be added. I suppose we could add a 'generated' suffix to the name to mark it as such, but really it seems the file should go into the build directory somewhere, although that might make it difficult to access if needed in other parts of the build. Having the generated file in the main tree was something that bothered me when I committed the patch, but not enought to try to fix it. Chuck ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
Re: [Numpy-discussion] Developmental version numbering with git
Hi, On Thu, Nov 11, 2010 at 11:44 AM, Charles R Harris charlesr.har...@gmail.com wrote: On Thu, Nov 11, 2010 at 12:32 PM, Matthew Brett matthew.br...@gmail.com Tiny patch for py3k attached. Should the generated numpy/version.py be in .gitignore? Is there a better name in order to signal the generated nature of the file? I thought it already was, but if not, yes, I think it should be added. I suppose we could add a 'generated' suffix to the name to mark it as such, but really it seems the file should go into the build directory somewhere, although that might make it difficult to access if needed in other parts of the build. Having the generated file in the main tree was something that bothered me when I committed the patch, but not enought to try to fix it. I never really understood what numpy/__config__.py was for, or how it came about, but I had the impression that was the place that build-time stuff got written - is that correct? Would it be a sensible place to write version information? See you, Matthew ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
Re: [Numpy-discussion] Developmental version numbering with git
On 8 November 2010 23:17, Matthew Brett matthew.br...@gmail.com wrote: Since the change to git the numpy version in setup.py is '2.0.0.dev' regardless because the prior numbering was determined by svn. Is there a plan to add some numbering system to numpy developmental version? Regardless of the answer, the 'numpy/numpy/version.py' will need to changed because of the reference to the svn naming. In case it's useful, we (nipy) went for a scheme where the version number stays as '2.0.0.dev', but we keep a record of what git commit has we are on - described here: http://web.archiveorange.com/archive/v/AW2a1CzoOZtfBfNav9hd I can post more details of the implementation if it's of any interest, In the meantime there's a patch in that direction here: https://github.com/numpy/numpy/pull/12 Cheers, Scott ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
Re: [Numpy-discussion] Developmental version numbering with git
On Tue, Nov 9, 2010 at 8:20 AM, Scott Sinclair scott.sinclair...@gmail.comwrote: On 8 November 2010 23:17, Matthew Brett matthew.br...@gmail.com wrote: Since the change to git the numpy version in setup.py is '2.0.0.dev' regardless because the prior numbering was determined by svn. Is there a plan to add some numbering system to numpy developmental version? Regardless of the answer, the 'numpy/numpy/version.py' will need to changed because of the reference to the svn naming. In case it's useful, we (nipy) went for a scheme where the version number stays as '2.0.0.dev', but we keep a record of what git commit has we are on - described here: http://web.archiveorange.com/archive/v/AW2a1CzoOZtfBfNav9hd I can post more details of the implementation if it's of any interest, In the meantime there's a patch in that direction here: https://github.com/numpy/numpy/pull/12 Thanks. I left some comments there. Chuck ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
Re: [Numpy-discussion] Developmental version numbering with git
Hi, Since the change to git the numpy version in setup.py is '2.0.0.dev' regardless because the prior numbering was determined by svn. Is there a plan to add some numbering system to numpy developmental version? Regardless of the answer, the 'numpy/numpy/version.py' will need to changed because of the reference to the svn naming. In case it's useful, we (nipy) went for a scheme where the version number stays as '2.0.0.dev', but we keep a record of what git commit has we are on - described here: http://web.archiveorange.com/archive/v/AW2a1CzoOZtfBfNav9hd I can post more details of the implementation if it's of any interest, Best, Matthew ___ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
