Re: [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags
Ok, understood. Thanks for explaining :) On 01/21/2015 05:07 PM, Joseph Qi wrote: Hi Srini, On 2015/1/22 1:55, Srinivas Eeda wrote: Hi Joesph, thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances ? I agree with the patch that bitwise operations are better than adding, but I am not able to understand the corruption it could cause. Can you please share! Suppose a the following case: The dinode i_flag already has the OCFS2_ORPHANED_FL bit set, and calling le32_add_cpu again. Then it will corrupt the i_flag. -- Joseph Thanks, --Srini ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
Re: [Ocfs2-devel] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags
Hi Srini, On 2015/1/22 1:55, Srinivas Eeda wrote: Hi Joesph, thanks a lot for submitting the above patch. I am trying to understand what kind of flag corruption have you noticed and under what circumstances ? I agree with the patch that bitwise operations are better than adding, but I am not able to understand the corruption it could cause. Can you please share! Suppose a the following case: The dinode i_flag already has the OCFS2_ORPHANED_FL bit set, and calling le32_add_cpu again. Then it will corrupt the i_flag. -- Joseph Thanks, --Srini ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
