Re: [Ocfs2-users] ocfs2-tools git: broken after commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e

2012-07-26 Thread Sunil Mushran 
On Thu, Jul 26, 2012 at 6:37 AM, Dzianis Kahanovich
wrote:

> ocfs2-tools git wrong commit: deb5ade9145f8809f1fde19cf53bdfdf1fb7963e.
>
> After "cleanup unused variable":
> -else
> -tmp = g_list_append(elem, cfs);
>
> o2cb_ctl starts to ignore >1 node. Good commit must be:
> else
> -tmp = g_list_append(elem, cfs);
> +g_list_append(elem, cfs);
>
> Attached patch.
>
>
Thanks.

Acked-by: Sunil Mushran 
___
Ocfs2-users mailing list
Ocfs2-users@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-users

[Ocfs2-users] ocfs2-tools git: broken after commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e

2012-07-26 Thread Dzianis Kahanovich 
ocfs2-tools git wrong commit: deb5ade9145f8809f1fde19cf53bdfdf1fb7963e.

After "cleanup unused variable":
-else
-tmp = g_list_append(elem, cfs);

o2cb_ctl starts to ignore >1 node. Good commit must be:
else
-tmp = g_list_append(elem, cfs);
+g_list_append(elem, cfs);

Attached patch.

-- 
WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/

Partial revert of commit deb5ade9145f8809f1fde19cf53bdfdf1fb7963e
Fixed o2cb_ctl ignoring >1 node.

Signed-off-by: Denis Kaganovich (Dzianis Kahanovich) 

diff -pruN a/o2cb_ctl/jconfig.c b/o2cb_ctl/jconfig.c
--- a/o2cb_ctl/jconfig.c2012-03-14 21:45:05.0 +0300
+++ b/o2cb_ctl/jconfig.c2012-07-26 16:06:38.0 +0300
@@ -1082,6 +1082,8 @@ JConfigStanza *j_config_add_stanza(JConf
 g_strdup(stanza_name),
 elem);
 }
+else
+g_list_append(elem, cfs);
 
 return(cfs);
 }  /* j_config_add_stanza() */
___
Ocfs2-users mailing list
Ocfs2-users@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-users