[okular] [Bug 424937] Okular sends blank pages do printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=424937

--- Comment #10 from Michael Weghorn  ---
(In reply to Michael from comment #9)
> don't forget when I print the same file from another PDF viewer it is
> printing right, I guess that means the problem isn't in the printer or
> somewhere else right?

Not necessarily. Other PDF viewers often hand over PDF to CUPS for printing, so
the processing inside CUPS (the CUPS filter chain) is different as for the case
where PostScript is passed, which Okular does by default. Therefore, issues
that only happen inside the printing system may not be exposed by using other
viewers.

When using rasterized printing, Okular also passes PDF, so that's usually a
rather good indicator (though other aspects than just the file format itself
may expose bugs in the printer or printing system as well), as is the fact
whether printing the PostScript file manually works. (If printing manually from
command line shows the same problem, the issue is probably outside of Okular.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424937] Okular sends blank pages do printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=424937

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #8 from Michael Weghorn  ---
(In reply to Michael from comment #6)
> Created attachment 131628 [details]
> ps file
> 

The file itself looks OK and is not blank, so it might be that the issue is
outside of Okular's control, somewhere in the printing system or the printer
itself.

Does it work if you print that file directly from command line like this (run
it in the directory where the file is located):

lp -d  d00028-001

> here is a ps file, for the raster test I need some more day because my
> printer is in maintenance changing the scanner lamp

Whether rasterized printing works would be interesting to know, since this
sometimes helps as a workaround for issues with the printing system.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=425289

--- Comment #6 from Michael Weghorn  ---
(In reply to Axel Braun from comment #5)
> (In reply to Michael Weghorn from comment #4)
> > Looking at the PPD:
> > 
> > There's this line in there:
> > > *cupsManualCopies: false
> > 
> > What you can *try* is changing that to
> > 
> > > *cupsManualCopies: true
> > 
> > and see whether it helps.
> 
> Unfortunately no

:(

> 
> With 'upstream' you probably mean its a CUPS issue?

Either CUPS, one of the CUPS filters (which may come from several projects, in
your case it might also be the (proprietary?) brother_lpdwrapper_mfc9340cdw
filter) or your printer firmware.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=425289

--- Comment #4 from Michael Weghorn  ---
Looking at the PPD:

There's this line in there:
> *cupsManualCopies: false

What you can *try* is changing that to

> *cupsManualCopies: true

and see whether it helps.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=425289

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |UPSTREAM
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Michael Weghorn  ---
(In reply to Axel Braun from comment #2)
> Created attachment 131556 [details]
> PPD of printer used
> 
> Printer is a Brother MFC 9340 CDW
> 
> Same issue appears if I print the ghostscript file with lp as suggested
> (produced by poppler 0.90)

Then it's an issue with either the printer or the printing system. Not much we
can do on Okular side.
As a side note, I've previously seen a similar problem with some Ricoh
multi-function device. That one had an option to "optimize empty pages away" in
its settings, and disabling that made things work as expected. However, that
might not be the same for your printer.

> 
> 'Force Rasterisation' creates indeed 2 copies!
At least there's a workaround then...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415986] Printing to HP1120C with gutenprint driver from Okular not working.

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=415986

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #19 from Michael Weghorn  ---
(In reply to bruce.samha...@samhaber.ca from comment #13)
> Created attachment 129749 [details]
> Today's /var/log/cups/error_log file
> 
> This is the "/var/log/cups/error_log" file from the 2 printouts today. [...]

Unfortunately, this seems to have been created using log level "warning". Can
you set CUPS's log level to "Debug" in /etc/cups/cupsd.conf, restart CUPS, try
again and attach an updated log?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 396879] Full screen mode doesn't work in wayland

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=396879

--- Comment #4 from Michael Weghorn  ---
*** Bug 396880 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 396880] Presentation mode in wayland shows panel, obscuring part of the document

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=396880

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Michael Weghorn  ---
Works for me now on Debian testing, seems to have been fixed somewhere outside
of Okular itself, s. bug 396879.

*** This bug has been marked as a duplicate of bug 396879 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 396879] Full screen mode doesn't work in wayland

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=396879

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REPORTED|RESOLVED

--- Comment #3 from Michael Weghorn  ---
(In reply to Patrick Silva from comment #2)
> Full screen mode works as expected on my wayland session.

Works on my Debian testing as well now, while it did not in the past. The same
is true for LibreOffice Impress with the kf5 integration ("VCL plugin"), so
this actually seems to have been fixed somewhere in the Qt/kf5 libs.

Operating System: Debian GNU/Linux 
KDE Plasma Version: 5.17.5
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.2
Kernel Version: 5.7.0-3-amd64
OS Type: 64-bit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 424937] Okular sends blank pages do printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=424937

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||m.wegh...@posteo.de

--- Comment #5 from Michael Weghorn  ---
2 questions:

1) Can you attach the PostScript file that Okular generates and hands over to
CUPS? It's stored a /var/spool/cups/d-001?
(If that one is blank, Okular/Poppler probably does something strange,
otherwise it's probably not their fault.)

2) Does enabling "Force rasterization" in the "PDF options" tab in the print
dialog help? (potential workaround)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 425289] Printing problem: 2 copies on a double sided printer

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=425289

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Michael Weghorn  ---
(In reply to Axel Braun from comment #0)
> My feeling is we need to trigger 2 separate print jobs, can this be?

This shouldn't be necessary and is generally not a good idea. E.g. if the
printer requests to type a PIN when printing (a feature called "confidential
printing") or is used by multiple users in parallel and has some functionality
to keep printouts of the same print job "in order", that will break (or require
to type the PIN/password multiple times).

Your issue is most probably one of the printer/printing system.

Some questions/thoughts:

1) What printer is this? Can you attach the printer's PPD file (located at
/etc/cups/ppd/?

2) Can you try whether you have the same issue when printing the PostScript
file generated by Okular from command line?
It's located in /var/spool/cups/d-001 and you can print it using

lp -n2 -d 

3) Does anything change if you check the "Force rasterization" checkbox in the
"PDF options" tab of the print dialog?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D20868: Support '#page=' fragment to open at page

[Michael Weghorn]

michaelweghorn abandoned this revision.
michaelweghorn added a comment.


  In D20868#615357 , @aacid wrote:
  
  > Please move as a Merge Request in https://invent.kde.org/kde/okular
  >
  > We have pre-commit CI and lots of checks including clazy and clang-tidy 
there so it's a much better place for doing the review/approval/merge of the 
code.
  
  
  Finally moved there: 
https://invent.kde.org/graphics/okular/-/merge_requests/265
  Sorry for the extreme delay!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20868

To: michaelweghorn, #okular, aacid
Cc: aacid, davidhurka, okular-devel, johnzh, andisa, siddharthmanthan, 
maguirre, fbampaloukas, joaonetto, kezik, ngraham, darcyshen

[okular] [Bug 423694] Prints the square of the quantity requested: ask for 2,get 4; ask for 3, get 9, ask for 4,get 16 sheets.

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=423694

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
What happens if you print from command line instead of using Okular?

Please try what happens in these two cases:

1) Printing the original document, command (put actual printer name and name of
document accordingly):

lp -d  

2) Printing the PostScript file that was generated by Okular. That one should
be in /var/spool/cups/d-001

Please ask if more details are needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422690] Margins often cut when printing (2020 - Okular-1.10.0)

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=422690

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |UPSTREAM

--- Comment #7 from Michael Weghorn  ---
(In reply to kolAflash from comment #6)
> Opened an issue for CUPS.
> https://github.com/OpenPrinting/cups-filters/issues/250
> I'd be grateful if you have an eye on that issue and may help answering
> upcoming questions regarding Okular.

I've subscribed there.

> > Can you try whether setting the "Force rasterization" option in the "PDF
> > options" tab of the print dialog works for you as a workaround?
> 
> Indeed, "Force rasterization" workarounds the issue.
> 
> I guess enabling rasterization by default would cause other problems?
> (I actually didn't open this issue for myself, but because other users have
> the same problem in the company I'm working for - so I'd be grateful for a
> general solution)

Rasterization basically means that images are generated, so the files can
become rather large, which can e.g. result in more memory being required and/or
slower printing.


Assuming this is actually a bug somewhere in the CUPS filter chain, I'm closing
this bug report as UPSTREAM for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422600] Okular is unable to print to fit page

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=422600

--- Comment #4 from Michael Weghorn  ---
And does it work if you explicitly enable rasterization? This might help to
avoid issues with the CUPS filter chain, s.a. bug 422690.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422690] Margins often cut when printing (2020 - Okular-1.10.0)

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=422690

--- Comment #5 from Michael Weghorn  ---
Since this works OK with CUPS-PDF and the same issue happens when printing
using command line, I think this is not an Okular issue, but rather somewhere
in the CUPS filter chain.
Closing as RESOLVED UPSTREAM accordingly.

(In reply to kolAflash from comment #4)
> Could you ask the Evince/Gnome people for advice?
> Maybe it's a special trick they are intentionally applying.
> Because with Evince it's really everything correct.

Evince generates PDF print data, whereas Okular (by default) generates
PostScript print data, so the CUPS filter chain is a different one in that
case.

Can you try whether setting the "Force rasterization" option in the "PDF
options" tab of the print dialog works for you as a workaround?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422600] Okular is unable to print to fit page

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=422600

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #3 from Michael Weghorn  ---
Works fine for me in a quick test with Okular 1.10.2 on Debian testing using
the CUPS-PDF printer using A4 as page size.

Does it work for you when "printing" using CUPS-PDF instead of the actual
printer as well?

If so, you please attach:
* your printer's PPD file, located at /etc/cups/.ppd
* CUPS log (or relevant part of that for the print job):
/var/log/cups/error_log, with 'LogLevel debug' set in /etc/cups/cupsd.conf
(might have to set 'ErrorLog /var/log/cups/error_log' in
'/etc/cups/cups-files.conf' or otherwise search in journal, depending on how
your distro configures this)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422690] Margins often cut when printing (2020 - Okular-1.10.0)

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=422690

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||m.wegh...@posteo.de
 Status|REPORTED|NEEDSINFO

--- Comment #3 from Michael Weghorn  ---
(In reply to kolAflash from comment #1)
> Created attachment 129168 [details]
> different logs and printouts (mind extra scanning margins)

At a quick glance, the Postscript file generated by Okular looks OK to me (file
'debian_11-beta-20200609/var/spool/cups/d00018-001_-_print-area' in the
attached tar file); if you open that in Okular, it looks the same as the PDF
file 'numeric_test.pdf'.

The processing to fit that to the page etc. is done by CUPS (and the
corresponding so-called CUPS filters), according to the options Okular passes,
which are those for the first case (from the error_log file):

> D [09/Jun/2020:21:25:03 +0200] [Job 18] argv[5]="Collate ColorModel=KGray 
> finishings=3 fit-to-page job-billing media=A4 number-up=1 
> number-up-layout=lrtb outputorder=normal page-bottom=41 page-left=10 
> page-right=10 page-top=10 portrait sides=one-sided job-uuid=urn:uuid:c 
> 7d3001b-0e41-33d2-5eec-70168aa8d6ee job-originating-host-name=localhost 
> date-time-at-creation= date-time-at-processing= time-at-creation=1591730703 
> time-at-processing=1591730703 document-name-supplied=okular_ufzIXL.ps 
> PageSize=A4"

This looks OK to me at a quick glance. Therefore, this might be an issue
outside of Okular.

Some questions:

1) What happens if you print that file using the same options using command
line, i.e.:

lp -d HP_DeskJet_1000_at_fbox_hpcups -o "Collate ColorModel=KGray finishings=3
fit-to-page job-billing media=A4 number-up=1 number-up-layout=lrtb
outputorder=normal page-bottom=41 page-left=10 page-right=10 page-top=10
portrait sides=one-sided job-uuid=urn:uuid:c
7d3001b-0e41-33d2-5eec-70168aa8d6ee job-originating-host-name=localhost
date-time-at-creation= date-time-at-processing= time-at-creation=1591730703
time-at-processing=1591730703 document-name-supplied=okular_ufzIXL.ps
PageSize=A4" debian_11-beta-20200609/var/spool/cups/d00018-001_-_print-area

2) Does it make any difference if you just use this command?

lp -d HP_DeskJet_1000_at_fbox_hpcups -o fit-to-page
debian_11-beta-20200609/var/spool/cups/d00018-001_-_print-area

3) What happens if you print the PDF file numeric_test.pdf_able-job_1474.pdf
from Okular to the CUPS-PDF printer instead of your physical one? (seems to
work fine for me on Debian testing)

4) Do you have any other printer you can test with, and if so, how does it
behave?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 351849] Margins often cut when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=351849

Michael Weghorn  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #43 from Michael Weghorn  ---
(In reply to kolAflash from comment #40)
> Created attachment 129046 [details]
> scanned Evince-20.04 and Okular-3.36.1 printings
> 
> I can reproduce the problem with the original attachment:
> https://bugs.kde.org/attachment.cgi?id=94244
> [...]

Please create a new bug report and leave a link here.

(And also attach CUPS's error log with LogLevel set to "debug" in
/etc/cups/cupsd.conf, and your printer's PPD, located at
/etc/cups/ppd/.ppd)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406053] Top of the page is cut of when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406053

--- Comment #15 from Michael Weghorn  ---
(In reply to Matthias from comment #12)
> (In reply to Michael Weghorn from comment #11)
> 
> > 1) Did you select any additional information in the print dialog, e.g. set
> > the "Force rasterization" checkbox?
> No, I haven't done anything in particular. Force rasterization is off.

What happens if you switch it on?

> > 2) What margins are set when you check that in the "Properties" dialog in
> > the print dialog? Does changing all margins to 0 make a difference?
> 6.35mm on the left and right, 12.7mm on the top and the bottom. It can't
> change them to 0, the GUI won't allow me to change them to anything less
> than these values.
> 
> > 3) What "Scale mode" is selected in the "PDF Options" tab in the print
> > dialog?
> Fit to printable area

That's interesting. At a quick glance, attachment 128311 looks like the missing
content might pretty much match the page margins, i.e. the non-printable area
of the printer ("6.35mm on the left and right, 12.7mm on the top and the
bottom".
However, if "fit to printable area" is selected, the content should
automatically scaled down by CUPS, since it is passed the "fit-to-page" option,
which can also be seen in your error_log:

Mai 09 14:52:14 localhost.localdomain cupsd[126424]: argv[5]="Collate
finishings=3 fit-to-page job-billing media=A4 number-up=1 number-up-layout=lrtb
outputorder=normal page-bottom=36 page-left=18 page-right=18 page-top=36
portrait sides=one-sided job-uuid=urn:uuid:f319f4b2-6461-357b-7ff1-f7b3153c271b
job-originating-host-name=localhost date-time-at-creation=
date-time-at-processing= time-at-creation=1589028734
time-at-processing=1589028734 document-name-supplied=okular_PwkqEO.ps
PageSize=A4"

What happens if you print the original PDF file and the generated PostScript
file using 'lp' from command line, i.e. passing it directly to CUPS rather than
using Okular?

i.e.

lp -d HL-2030-series -o fit-to-page -o PageSize=A4 

and

lp -d HL-2030-series -o fit-to-page -o PageSize=A4 d00129-001.ps

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415986] Printing to HP1120C with gutenprint driver from Okular not working.

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=415986

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #9 from Michael Weghorn  ---
Hi Bruce,

(In reply to bruce.samha...@samhaber.ca from comment #6)
> Yes this is the same problem as BUG 415985 but with the GUTENPrint driver
> (.PPD file)

if we should examine the issue with that driver/PPD as well, we'd need the same
information that was needed in bug 415985, in particular the PPD and the CUPS 
error_log. It might well be that this is also an issue with the CUPS filter
chain.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406053] Top of the page is cut of when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406053

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #11 from Michael Weghorn  ---
(In reply to Matthias from comment #8)
> I've looked at the IPP traffic that I uploaded earlier using Wireshark, and
> I found that Okular transmits the data to be printed in PDF format.
> 
> So I extracted that PDF from the pcapng capure file, saved it to disk,
> opened it with Okular and found… a blank page with nothing on it. So that
> seems to be why nothing is printed. I'm attaching said PDF here in the hope
> that it helps to figure out what's going on.

That's interesting, since Okular usually generates PostScript for printing by
default.
Okular does not generate IPP data itself, but uses the 'lpr' or 'lp' command to
pass the file to CUPS (or in the case of "Force rasterization" checkbox sent,
the Qt library handles passing the file to CUPS).

(In reply to Matthias from comment #10)
> Created attachment 128311 [details]
> Second example after it's been mangled by okular
> 
> This is what's left of the PDF when Okular sends it to CUPS via IPP

Some more questions:

1) Did you select any additional information in the print dialog, e.g. set the
"Force rasterization" checkbox?

2) What margins are set when you check that in the "Properties" dialog in the
print dialog? Does changing all margins to 0 make a difference?

3) What "Scale mode" is selected in the "PDF Options" tab in the print dialog?

4) The file passed to the CUPS Printing system for a print job is saved in
/var/spool/cups/d-001. Can you attach that file as well? That
should be a PostScript or PDF file. You might have to set 'PreserveJobFiles
Yes' in /etc/cups/cupsd.conf in case the file is not present in your case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406053] Top of the page is cut of when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406053

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||m.wegh...@posteo.de
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Michael Weghorn  ---
Some questions to narrow this further down:

1) Can you attach the PPD file of the printer, which should be located at
/etc/cups/ppd/.ppd ?

2) Can you attach a CUPS debug log when doing such a printout?
(set 'LogLevel debug' in /etc/cups/cupsd.conf, then restart CUPS, print, and
attach /var/log/cups/error_log (or the relevant part of it). (Depending on the
setting for 'ErrorLog' in /etc/cups/cups-files.conf, the log output may
alternatively go to the journal, so either retrieve it from there or set
'ErrorLog /var/log/cups/error_log'

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415985] Okular is not printing to HP1120C printer with driver HP DeskJet 1120C Foomatic/pcl3

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=415985

--- Comment #5 from Michael Weghorn  ---
Note: There's also bug 415986 describing mostly the same issue for the same
printer with another PPD/driver in use.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415986] Printing to HP1120C with gutenprint driver from Okular not working.

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=415986

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||m.wegh...@posteo.de

--- Comment #5 from Michael Weghorn  ---
Do I understand correctly that this is basically the same bug report as 415985
(also reported by you), just for another driver/PPD?

If so, please answer the same questions as asked in bug 415985 comment 4?


(In reply to bruce.samha...@samhaber.ca from comment #4)
> Any advise on how to get a driver to use the full features of the printer
> including the special feature - banner mode? 

That depends on the PPD/driver you're using, so I'd suggest to check whether
you can find another one for that model.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 415985] Okular is not printing to HP1120C printer with driver HP DeskJet 1120C Foomatic/pcl3

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=415985

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||m.wegh...@posteo.de

--- Comment #4 from Michael Weghorn  ---
Some questions to narrow down the issue:

1) Does printing from other Qt/KDE applications work, e.g. Kate?

2) Can you attach the PPD of the printer, located at
/etc/cups/ppd/.ppd?

3) Can you please attach the CUPS debug log which can be retrieved as described
in bug 418551 comment 1 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 418551] Duplex printing setting ignored

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=418551

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Michael Weghorn  ---
For further analysis, can you please attach:

1) the PPD of the printer, located at /etc/cups/ppd/.ppd

2) a CUPS debug log of one such printout (set 'LogLevel debug' in
/etc/cups/cupsd.conf, then restart CUPS, print, and attach
/var/log/cups/error_log (or the relevant part of it). (Depending on the setting
for 'ErrorLog' in /etc/cups/cups-files.conf, the log output may alternatively
go to the journal, so either retrieve it from there or set 'ErrorLog
/var/log/cups/error_log').

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407998] Okular scales down pages when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=407998

--- Comment #16 from Michael Weghorn  ---
(In reply to Éric Brunet from comment #15)
> (In reply to Michael Weghorn from comment #11)
> > This is https://phabricator.kde.org/D10974 and I quickly verified that
> > current development version of Okular actually offers either "Fit to
> > printable area" or "Fit to full page" when opening a TIFF file.
> 
> This is very good indeed, but it seems to me a third option is needed:
>  Keep the actual image size and do no scaling at all
> 
> At the moment, if I load a pdf of size 15cm x 8cm, I do not know how to
> print it to have a 15cm x 8cm picture in the middle of an empty A4 sheet of
> paper.
> 
> Or did I miss an option somewhere ?

At least in Okular 1.9.3, you can select this for the scale mode in the "PDF
Options" tab: "None; print original size". It should do exactly what you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 418485] unable to find the Okular component: The shared library was not found ubuntu

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=418485

--- Comment #5 from Michael Weghorn  ---
(In reply to LASSOUED Ghassen from comment #4)
> (In reply to Michael Weghorn from comment #3)
> > OK, let's close as WORKSFORME then.
>  Sorry, i have not meant that you should close or something. 

Sorry, I might have misunderstood then. If your initial problem is still there
after reinstalling the Okular packages as mentioned in comment 1, feel free to
reopen and provide additional information...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 418485] unable to find the Okular component: The shared library was not found ubuntu

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=418485

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Michael Weghorn  ---
OK, let's close as WORKSFORME then.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 418485] unable to find the Okular component: The shared library was not found ubuntu

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=418485

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Michael Weghorn  ---
Does reinstalling Okular via this command on command line help?

apt install --reinstall libokular5core8 okular

(In reply to LASSOUED Ghassen from comment #0)
> Please, is there a solution keeping my pdf files intact ? because i have
> important notes in them

Good news in any case is that the PDF files themselves should not be affected
in any way, it's "just" the Okular installation that is somehow messed up on
your system.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 416796] Display of music on staff lines are difficult to read

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=416796

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Michael Weghorn  ---
Can you attach a sample PDF file?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 263042] XFA Forms are not supported

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=263042

--- Comment #19 from Michael Weghorn  ---
(In reply to Albert Astals Cid from comment #18)
> There's non-Free apps on Linux that let you work with XFA files if you
> really really need to, use your favourite search engine to find them.

And PDFium, which is used e.g. by Chromium, has some support for XFA. When I
looked at this a while ago (probably about two years ago) and tested a few
files, that turned out not to be far from ideal, but that *might* have changed
in the meantime. (Back then, XFA support was not enabled by default, but there
was a compile option).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375012] cannot print in custom dimensions

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=375012

--- Comment #19 from Michael Weghorn  ---
(In reply to bruce.samha...@samhaber.ca from comment #18)
> (In reply to Bug Janitor Service from comment #17)
> 
> The upgrade to openSUSE 15.1 LEAP is complete.  HPLIP version 3.18.6 is
> installed according to YAST. I had installed HPLIP 3.19.10 from command line
> when configuring the printer the configuration stated that there was no
> HPLIP so it installed HPLIP version 3.18.6 from repository. 
> 
> Okular does not print at all to the HP1120C printer. It does print to my
> Epson printer. I have tried both drivers the Gutenprint and Cups_Pcl.

Having one bug report for one issue helps to keep focus and avoid confusion.
Therefore, please open a new bug report for this, if you think that this is
actually an Okular issue (e.g. printing does work for all other applications)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375012] cannot print in custom dimensions

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=375012

--- Comment #12 from Michael Weghorn  ---
(In reply to bruce.samha...@samhaber.ca from comment #11)
> I am using OpenSUSE 13.2 which appears to use qt3. qt4 and qt5 are not even
> install options, so I guess I need to upgrade to a more recent OpenSUSE
> version.  
> See attachments YAST...* and YAST_Okular...

Yes, please upgrade, that's a very old and unsupported version then. Thanks for
the additional information.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375012] cannot print in custom dimensions

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=375012

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #7 from Michael Weghorn  ---
(In reply to Michael Weghorn from comment #1)
> This sounds very much like a Qt bug which has just recently been fixed by
> Albert in Qt's development branch:
> https://codereview.qt-project.org/#/c/215054/

@Gregor B. Rosenauer: Given this: Are you still experiencing your original
issue or is this no longer the case with current Okular versions?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 375012] cannot print in custom dimensions

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=375012

--- Comment #6 from Michael Weghorn  ---
(In reply to bruce.samha...@samhaber.ca from comment #2)
> Created attachment 122940 [details]
> Okular print properties Page Custom size media
> 
> When printing from Okular with a page that is a Custom size sheet, tried
> setting the media size property in Page and advance  Tabs to the 'custom'
> sheet. In the page tab it remembers the Custom setting but does not allow
> editing of the sheet dimensions. Okular should be using the dimensions from
> the file automatically. In the Advanced tab the "Media Size" property is
> listed twice, wher the first occurance saves the selected option of 'Custom'
> but the second occurance always reverts back to 'Letter' This appears to be
> the reason for the Error.

What version of Okular are you using? The screenshot looks like this is still a
Qt 4 based version, and as far as I know, this has been fixed in Qt 5, so
should no longer be the case for recent Okular versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |UPSTREAM

--- Comment #21 from Michael Weghorn  ---
(In reply to Matthew Trescott from comment #20)
> Qt 5.13.0. I filed a bug upstream:
> https://bugreports.qt.io/browse/QTBUG-76982

Thanks! Closing this bug report then.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #19 from Michael Weghorn  ---
(In reply to Matthew Trescott from comment #18)
> Same problem happens with Kate. :/

... in which case this isn't Okuklar's fault, but seems somewhat related to the
Qt print dialog in general. What Qt version do you have?

Can we close this bug as RESOLVED UPSTREAM (since Qt has it's own issue tracker
at [1])?

Feel free to continue commenting, though, even if the bug is closed.
However, unless you have an old Qt version (which seems to be unlikely since
you mention you're using Arch), I'm running out of ideas...

[1] http://bugreports.qt.io/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #17 from Michael Weghorn  ---
(In reply to Matthew Trescott from comment #16)
> Created attachment 121353 [details]
> CUPS error log when printing with LibreOffice
> 
> No, neither of those files exist. And as I said, LibreOffice doesn't have
> this problem. Here's the CUPS error log when printing with LibreOffice (I
> included a bit more at the beginning this time)

Indeed, this log has "PageSize=Letter" as expected.

> 
> I noticed that LibreOffice sends CUPS a PDF, while Okular sends CUPS a
> PostScript file. Maybe something goes wrong in the PDF -> PostScript
> conversion in Okular/Poppler?

I think the problem is earlier already, since the wrong value of the option is
used, so I'd expect that Poppler is passed A4 already and thus generates A4 (as
it's told).

What happens with other Qt/KDE applications, like e.g. Kate?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #15 from Michael Weghorn  ---
(In reply to Matthew Trescott from comment #13)
> Created attachment 121352 [details]
> CUPS log when printing

This log (s. the 'argv[5]' line) shows that A4 is explicitly set for the page
size. This shouldn't happen if you have Letter selected in the print dialog,
and as mentioned, I couldn't reproduce with the same PPD.

Is there any file /etc/cups/lpoptions or $HOME/.cups/lpoptions present, and if
so, can you attach them here (or try to delete them and see what happens then)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408818

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED
 CC||m.wegh...@posteo.de

--- Comment #10 from Michael Weghorn  ---
(In reply to Wolfgang Bauer from comment #8)
> (In reply to Wolfgang Bauer from comment #7)
> > I think it's caused by this Qt bug:
> > https://bugreports.qt.io/browse/QTBUG-73730
> > 
> > Should be fixed in the latest 5.12.4.
> 
> PS: I can indeed open the attached file just fine here with Qt 5.12.4 (and
> ark/okular 19.04.2).

Thanks for the information. Closing as RESOLVED UPSTREAM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408851] Crash when trying to open *.fb2 file

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408851

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||m.wegh...@posteo.de

--- Comment #1 from Michael Weghorn  ---
s. bug 408818 comment 4

*** This bug has been marked as a duplicate of bug 408818 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408818] Ark crashed when trying to open *.fb2 file

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408818

--- Comment #9 from Michael Weghorn  ---
*** Bug 408851 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407998] Okular scales down pages when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=407998

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #11 from Michael Weghorn  ---
(In reply to Nate Graham from comment #10)
> (In reply to Sergio from comment #9)
> > I have finally managed installing a recent version of okular (1.7.2). The
> > operation of the scaling menu is a bit unclear to me, though.
> > 
> > 1. It is presented as a PDF option, but okular supports many more formats.
> > For instance, the option is absent for tiff, which is a nice multipage
> > format for things like BW document scans with Group4 compression (even if
> > those can certainly be embedded in PDF). Similarly, the option is absent for
> > PNG, etc.
> It's being implemented for other file formats too. I can't find the patch
> right now but I know it's in progress!

This is https://phabricator.kde.org/D10974 and I quickly verified that current
development version of Okular actually offers either "Fit to printable area" or
"Fit to full page" when opening a TIFF file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 185636] More printing options for page control

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=185636

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|CONFIRMED   |RESOLVED

--- Comment #10 from Michael Weghorn  ---
(In reply to David Hurka from comment #9)
> Created attachment 120708 [details]
> Print options for page set
> 
> This seems to be fixed now. 
> 
> KDE Frameworks 5.58
> Qt 5.12.0
> Okular 1.7.1

Yes, it's been implemented in the Qt print dialog, s.
https://codereview.qt-project.org/c/qt/qtbase/+/215390 .

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #9 from Michael Weghorn  ---
What Poppler version do you have?

Can you increase CUPS log level ('LogLevel debug' in /etc/cups/cupsd.conf),
restart CUPS and attach the resulting CUPS log ( /var/log/cups/error/log ; or
relevant parts of it ) when printing again?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #8 from Michael Weghorn  ---
Created attachment 120617
  --> https://bugs.kde.org/attachment.cgi?id=120617=edit
file in /var/spool/cups/ generated by Okular with dummy printer using same PPD

I cannot reproduce on Debian testing (okular 4:17.12.2-2.2, poppler 0.71.0-5)
with a dummy printer set up with the same PPD, s. attached file that Okular
generates for printing in my case, which is Letter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408272

--- Comment #6 from Michael Weghorn  ---
(In reply to Oliver Sander from comment #5)
> > Make Okular remember the last scaling setting setting rather than always 
> > resetting to the default value
> 
> +1 for this approach.  It also applies to a few other options in the print
> dialog, e.g., duplex printing.

If so, another question is whether to have that for the current session and
document only. E.g. I don't like Evince's behaviour of preselecting all print
options from the last printout, regardless of the document (so that e.g. if you
decide to once print multiple pages per sheet, you'll have it next time as well
if you open a completely different document).

An alternative might be to add a setting for the default scaling option in
Okular's settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408270

--- Comment #6 from Michael Weghorn  ---
*** Bug 406237 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408273] Scaling mode "Print original size" is confusing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408273

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |DUPLICATE

--- Comment #14 from Michael Weghorn  ---
(In reply to Matthew Trescott from comment #13)
> I've opened separate bug reports.
> 
> https://bugs.kde.org/show_bug.cgi?id=408270
> https://bugs.kde.org/show_bug.cgi?id=408271
> https://bugs.kde.org/show_bug.cgi?id=408272
> https://bugs.kde.org/show_bug.cgi?id=408273

Thanks! Closing this one then.

*** This bug has been marked as a duplicate of bug 408270 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408272

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 408271] Print-to-PDF defaults to A4 regardless of locale or original document size

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=408271

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #12 from Michael Weghorn  ---
(In reply to fabrice salvaire from comment #11)
> I filled an issue about that some years ago ...
> 
> In concrete terms, we cannot print a document using Okular if we need a 1:1
> scale.
> 
> In other words, a user will get wrong dimensions if it prints a 10 cm square
> using Okular.
> 
> This issue doesn't happen if we print using the lpr command, but Evince has
> the same issue if we don't change the default setting so as to apply any
> scale adjustment  (i.e. tweak a parameter in a tab ...).
> 
> The right way is to implement printing as in Acroread !!!

As mentioned above, Okular now allows to apply different options for scaling if
you have a recent enough version. With regard to what option should be selected
by default, that can for sure be discussed...


@Matthew: Any more comments/ideas on comment 10? Otherwise, if there's a common
understanding, I'd suggest to continue the single aspects in separate new bug
reports as needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

--- Comment #10 from Michael Weghorn  ---
(In reply to Matthew Trescott from comment #7)
> [...]
> I just double-checked this to make certain. I turned off WiFi temporarily so
> CUPS would hold my print job (it's a network printer), then printed my
> Letter-size PDF. I double-checked the printer properties in Okular to make
> sure that it was set to Letter (Letter is the default for the print queue
> so the paper size was already correctly set). However, when I opened the
> corresponding PostScript document in /var/spool/cups, it had the distinctive
> sqrt(2) side ratio of A-size paper. This confirms the results I had when I
> permitted the print jobs to go through previously and discovered this bug---I
> just didn't want to waste paper this time.
> 
> Summary: the bug here is that Okular always prints in A4 to physical
> printers,
> even when a different paper size has been selected.

This didn't happen in my case. Can you attach the generated PostScript file as
well as the PPD of your printer here (which is located at
'/etc/cups/ppd/.ppd)?


> But mightn't it be the responsibility of the application using the Qt print
> dialog (Okular in this case) to tell Qt what paper size to default to for
> "Print to PDF"? My wild guess at the internals of how this works is just that
> the application provides a PDF which Qt forwards unmodified to the OS's print
> server, along with the metadata needed to adjust the printer settings. I
> doubt
> the Qt print dialog would be smart enough to parse the PDF it gets (if indeed
> my theory of how it works is correct) to figure out what paper size to use.
> 
> Summary: the bug here is that the Printer Properties dialog for Print to PDF
> defaults to A4 for the paper size, rather than the size of the document
> being printed.

I guess the application *could* set the paper size. I'd say whether or not this
is desirable depends on the use case. As mentioned in my previous comment for
the real physical printer, I'm happy with the A4 default. In my opinion, this
is not a bug at a quick glance, but would rather be an enhancement request to
change it if you think using the current document's size should be preselected.
(Choosing the "correct" default is hard and you'll probably never find any that
everybody is happy with...)


> Ah, yes. It does work, and it makes sense since PDF files don't seem to have
> any semantic concept of margins. But in that case, "Fit to printable area"
> should not be the default scaling setting, since it adds margins where most
> PDFs will probably not need them.
> 
> Summary: the bug here is that that the "Fit to printable area" scaling
> setting is the default, rather than "Fit to full page"

Whatever should be the "correct" default can for sure be discussed. Basically
the same as above: It's not really a bug in my opinion. If you think it should
be changed, I'd say: Feel free to file a request to change this and let's see
what decision will be taken.
Note that there's already bug 404510 that requests the possibilty to store the
preferred scaling setting, so maybe this would "fix" your case as well?


> > > - "Print original size" shifts the entire document down and to the right.
> > 
> > I can confirm this with default margins set. Again: Does this still happen
> > when you set all margins to 0? (no longer happens then in my case)
> > This might need a closer look, not sure if it's supposed to work like this.
> 
> Indeed, setting margins to zero does cause it to be positioned correctly.
> However, I would guess this setting should be called "crop to fit printable
> area" and make the horizontal cropping equal between the left and right
> sides,
> and the vertical cropping equal between top and bottom. Currently it's not
> very useful.
> 
> Summary: the bug here is that "Print original size" shifts the document
> content to fit the top and left margins, rather than cropping the document
> on all sides to fit the margins.

At a quick glance, there's mainly two options to handle the current options:

A) what happens currently: print margins are honoured; the document is not
scaled, so the painting starts at the top-left of the printable area with
original size. Whatever doesn't fit, just get's lost.
B) alternative: print margins are ignored when the "Print original size" is
selected. If the document has sufficient margins, this is fine, otherwise parts
might get cropped.

If the document is smaller than the paper size (e.g. printing A5 to A4) and the
document doesn't have proper margins, A) might be desirable, but I see that
e.g. when printing A4 to A4, B) may be preferrable.
I'm personally not sure how to best deal with this.
(

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Ever confirmed|1   |0
 Resolution|WAITINGFORINFO  |---

--- Comment #9 from Michael Weghorn  ---
Requested info has been provided in comment 7. I hope I'll find the time to
answer sometime soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406831] RFC compliant URL to specify page number not treated properly

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406831

--- Comment #5 from Michael Weghorn  ---
Change on Phabricator: https://phabricator.kde.org/D20868

-- 
You are receiving this mail because:
You are the assignee for the bug.

D20868: Support '#page=' fragment to open at page

[Michael Weghorn]

michaelweghorn created this revision.
michaelweghorn added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
michaelweghorn requested review of this revision.

REVISION SUMMARY
  Support the '#page=' fragment to specify which page
  to open the document at, in addition to the existing '#'
  syntax.
  For PDF, the '#page=' fragment is specified in RFC 8118,
  section 3.
  
  BUG: 406831

TEST PLAN
  1. Put a test file that has multiple pages at '/tmp/testfile.pdf'
  2. Check that all of the following commands open the test file on page 2:
  
okular /tmp/testfile.pdf#2 okular /tmp/testfile.pdf#page=2 okular 
file:///tmp/testfile.pdf#2 okular file:///tmp/testfile.pdf#page=2

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/kdebug406831_support_rfc_compliant_way_to_open_at_page

REVISION DETAIL
  https://phabricator.kde.org/D20868

AFFECTED FILES
  part.cpp

To: michaelweghorn, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 406831] RFC compliant URL to specify page number not treated properly

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406831

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #4 from Michael Weghorn  ---
That sounds quite easy to implement. I'm taking a quick look.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REOPENED|NEEDSINFO

--- Comment #6 from Michael Weghorn  ---
Thanks for testing and sorry for closing the bug so quickly.

(In reply to Matthew Trescott from comment #5)
> Okay, this is NOT a duplicate. Please read it carefully and test it for
> yourself. The default settings still produce poor results, although it as
> now at least possible to get suitable output.

I have tested myself. All tests involving a real physical printer in the
following refer to printing on am HP Officejet 4620.
Tests were done using the current Okular development version (as of commit
1f08c4724520414611e3eb3d6719ff9ef1209d5f) on Debian testing (with Qt 5.11.3).

> The main problem seems to be that Okular defaults to A4 paper regardless of
> the paper size of the input document.

For real CUPS queues, Okular defaults to the default paper size set for the
given queue. Therefore, it defaults to A4 if A4 is set as the default paper
size and e.g. to A6 if A6 is set as the default paper size (as can be done e.g.
using the command 'lpoptions -p  -o PageSize=A6').
I personally like this behaviour, since my printer only has A4 paper loaded,
and I don't even have paper in US Letter size, so want to print documents in US
letter size on A4 paper.
I do understand that others may prefer another behaviour, though.


> - On physical printers, Okular seems to ignore the paper size setting in the
> Printer Properties dialog.

Can you elaborate on this?
In my case, selecting e.g. A5 as paper size in Okular will result in only the
area of an A5 page being printed upon on the A4 paper, and the rest remaining
blank.
Choosing A4 will result in the A4 area being printed upon (except margins,
depending on the scaling settings).


> - When using Print to PDF, Okular defaults to A4 even when the input
> document size is Letter. Changing the paper size in Printer Properties
> actually takes effect, however.

Without checking, I'd guess that this comes from the Qt print dialog which
Okular uses.

> However, even when the paper size for Print to PDF is corrected (set to
> Letter in my case), enabling "Force rasterization" produces incorrect
> results when the following scaling settings are used:
> 
> - "Fit to printable area" results in the entire document being scaled down,
> although the margins are already more than sufficient for printing.

As far as I understand, this "works as designed". Okular doesn't take into
account the margins already in the document, but scales the whole document
(including what you already see as margins) to fit into the printable area,
i.e. the whole output paper size from which the printer margins (as set in the
print dialog's "Properties" -> "Page" tab) are subtracted (which defaults to
the printer's hardware margins for physical printers or some other minimum
value e.g. for the "Print to PDF" case; I think that's from the Qt print dialog
and nothing Okular-specific).

Does this work as expected if you manually set the margins there to 0?


> - "Print original size" shifts the entire document down and to the right.

I can confirm this with default margins set. Again: Does this still happen when
you set all margins to 0? (no longer happens then in my case)
This might need a closer look, not sure if it's supposed to work like this.

> To summarize, the only settings that produce normal print output for a
> standard 8.5 x 11" document are either:
> 
> - Print to PDF with the paper size manually set to Letter instead of A4
> _AND_ "Force rasterization" disabled.
> - Print to PDF with the paper size manually set to Letter instead of A4
> _AND_ "Force rasterization" enabled _AND_ scaling set to "Fit to full page"
> 
> I don't mean to be the unhappy customer when I didn't pay for the software,
> but in the future it would be nice to have bug reports verified fixed before
> they're closed as duplicates. It would make reporting bugs so much easier if
> I didn't have to put this much effort into proving to developers that the
> bug exists. Thanks.

Sorry again. Anyway, to be honest, I didn't see much in your initial
description in addition to the bug I closed it as a duplicate of.

With the additional info above: Can you explicitly mention what of the
described behaviour you exactly to consider to be a bug? I think it might help
to later split things into separate bug reports if you think that there's
multiple issues, but let's first try to make sure there's a common
understanding.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406646] Okular Can not really change page color

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406646

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 CC|m.wegh...@posteo.de |
 Status|NEEDSINFO   |REPORTED

--- Comment #3 from Michael Weghorn  ---
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406646] Okular Can not really change page color

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406646

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||m.wegh...@posteo.de
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Michael Weghorn  ---
(In reply to widon1104 from comment #0)
> In attached file, I change the page color to green, but only left and right
> side change the color to green, the part has words do not change at all.

Can you please attach the actual file that you have opened in Okular in
addition (attachment shows the screenshot)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn added a comment.


  In D18179#450252 , @ngraham wrote:
  
  > OK, let's go for it!
  >
  > @michaelweghorn I hope you know this means you're on the hook to fix any 
bugs that crop up, right? :)
  
  
  @ngraham: Thanks for landing this! Yes, I'm aware. :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REOPENED|RESOLVED

--- Comment #3 from Michael Weghorn  ---
Ah, sorry for not being more explicit. Bug 348172 has the "Version Fixed In"
set to 19.04.0, i.e. you'll get that feature with the upcoming Okular version
only.

The scaling options are just below the "Force rasterization" option (i.e. under
"Options" -> "PDF Options" in the print dialog).

*** This bug has been marked as a duplicate of bug 348172 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 348172] Scaling options missing in print dialog

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=348172

--- Comment #27 from Michael Weghorn  ---
*** Bug 406237 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 406237] PDFs get an added margin when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=406237

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||m.wegh...@posteo.de

--- Comment #1 from Michael Weghorn  ---
This sounds like bug 348172, therefore I'm closing this as a duplicate.

https://phabricator.kde.org/D7962 added the possibility to select whether or
not the document should be scaled to take into account hardware printer margins
if the "Force rasterization" option is set in the printer dialog.

Please reopen if margins are still added when no scaling has explicitly been
selected there.

(By the way, https://phabricator.kde.org/D18179 is supposed to make the same
options available without having the "Force rasterization" checkbox enabled as
well.)

*** This bug has been marked as a duplicate of bug 348172 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 348172] Scaling options missing in print dialog

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=348172

Michael Weghorn  changed:

   What|Removed |Added

 CC||matthewtresc...@gmail.com

--- Comment #26 from Michael Weghorn  ---
*** Bug 406237 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn marked 2 inline comments as done.

REPOSITORY
  R223 Okular

BRANCH
  arcpatch-D18179

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#442825 , @ngraham wrote:
  
  > Do you really not have commit access yet? You should apply. :) 
https://techbase.kde.org/Contribute/Get_a_Contributor_Account
  >
  > Meanwhile, I'll land this for you.
  
  
  Thanks a lot! Actually, I haven't contributed very much to KDE so far, so 
don't think I really qualify for commit access.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn removed a dependency: D10974: Add option to ignore print margins 
for non-PDF generators.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn removed a dependent revision: D18179: PDF: Implement scaling 
options for non-rasterized printing.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#442598 , @aacid wrote:
  
  > If someone wants to test it and approve it and Michael says he'll fix any 
bug that arises from here i'm happy enough
  
  
  I promise that I'll try to fix any issues arising from this. The same goes 
for D18179 .

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/UPDATE_D10974

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular, ngraham
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#442381 , @ngraham wrote:
  
  >   I'm still not thrilled about the {nav Force Rasterization} situation (I 
think it should be implicitly turned on when the user chooses an option that 
requires it) but the combobox is good.
  
  
  Does D18179  solve this? It makes the 
scaling options work without having to enable "Force Rasterization", so there 
should no longer be any need to implicitly turn it on.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn added a comment.


  Is there anything I can still do right now or do I just need to wait for the 
review?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, 
joaonetto, tfella, darcyshen

[okular] [Bug 405709] [Feature request] Printing to PDF - remember last used location

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=405709

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
(In reply to Ovidiu-Florin BOGDAN from comment #0)
> OBSERVED RESULT
> The proposed location is always the location of the original file.
That's not exactly what I get. The suggested path in my case is the working
directory + a filename appended (based on the document that is open), which is
not necessarily the same location as that of the currently open file.

At a quick glance, it looks to me like the current handling is implemented in
the Qt print dialog, more precisely the 'QUnixPrintWidget::QUnixPrintWidget'
constructor, s.
https://code.qt.io/cgit/qt/qtbase.git/tree/src/printsupport/dialogs/qprintdialog_unix.cpp#n1412
.

(In reply to Ovidiu-Florin BOGDAN from comment #1)
> Also it would be useful to remember the last printer used. It always
> presents the default printer.
I'm quite sure this is also what the Qt print dialog does, nothing
Okular-specific.


Kate e.g., which also uses the Qt print dialog, behaves the same way in my
case.

Calling QPrinter::setOutputFileName should probably make the above code take up
the path set this way (though I didn't have any closer look), but I'm unsure
whether it makes sense to do this specifically just for Okular (and what else
would have to be taken into account).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 396879] Full screen mode doesn't work in wayland

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=396879

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 404549] Printing N copies results in N^2 copies printed instead

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=404549

Michael Weghorn  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #9 from Michael Weghorn  ---
Thanks for all the information. I don't see anything obvious at first sight.

However, the file you attached for 6 is another one, and the comment for the
attachment also says '/tmp/okular_vTQSft.ps'. It's the file generated by Okular
(identical to the one from step 3), not the one generated by the CUPS filters.
The other file should have been saved as "/tmp/tofile", but it may be that CUPS
wasn't allowed to write '/tmp' due to some system restrictions (e.g. AppArmor
policies,...).
You might try using another path, e.g. '$HOME/tofile', i.e. use the '-v
file:$HOME/tofile' option for the lpadmin command and see whether this works.

Anyway the CUPS log shows that this is the CUPS filter chain for the print job:

> D [22/Feb/2019:11:51:36 +0300] [Job 1095] 4 filters for job:
> D [22/Feb/2019:11:51:36 +0300] [Job 1095] gstopdf (application/postscript to 
> application/pdf, cost 0)
> D [22/Feb/2019:11:51:36 +0300] [Job 1095] pdftopdf (application/pdf to 
> application/vnd.cups-pdf, cost 66)
> D [22/Feb/2019:11:51:36 +0300] [Job 1095] gstoraster 
> (application/vnd.cups-pdf to application/vnd.cups-raster, cost 99)
> D [22/Feb/2019:11:51:36 +0300] [Job 1095] 
> /usr/lib/cups/filter/rastertokpsl_A3 (application/vnd.cups-raster to 
> printer/Kyocera_TASKalfa_1801, cost 0)

Some more questions:

A) Do you know where the '/usr/lib/cups/filter/rastertokpsl_A3' filter comes
from? Is it some (proprietary) binary provided by the vendor (Kyocera)?

B) Is the result the same when you manually print the file from step 3 using
the following command (using the options from the CUPS log)?

lp -d Kyocera_TASKalfa_1801 -n 3  -o "Collate finishings=3 fit-to-page
job-billing media=A4 number-up=1 number-up-layout=lrtb outputorder=normal
page-bottom=10 page-left=12 page-right=12 page-top=10 portrait sides=one-sided
Duplex=None PageSize=A4" d01096-001

C) And does anything change if you leave out all the specific options and just
use this command:

lp -d Kyocera_TASKalfa_1801 -n 3  d01096-001

To check whether one of the filters does something odd, you can check their
"intermediate" results. Using the file from step 3, you can run the first
filter using

PPD=/etc/cups/ppd/Kyocera_TASKalfa_1801.ppd /usr/lib/cups/filter/gstopdf 1
$USER title 3 "Collate finishings=3 fit-to-page job-billing media=A4
number-up=1 number-up-layout=lrtb outputorder=normal page-bottom=10
page-left=12 page-right=12 page-top=10 portrait sides=one-sided Duplex=None
PageSize=A4" d01096-001 > result_from_gstopdf

and then check the file "result_from_gstopdf" whether it has 3 pages or more

Then using that file, you can run the next filter:

PPD=/etc/cups/ppd/Kyocera_TASKalfa_1801.ppd /usr/lib/cups/filter/pdftopdf 1
$USER title 3 "Collate finishings=3 fit-to-page job-billing media=A4
number-up=1 number-up-layout=lrtb outputorder=normal page-bottom=10
page-left=12 page-right=12 page-top=10 portrait sides=one-sided Duplex=None
PageSize=A4" result_from_gstopdf > result_from_pdftopdf

and check its result again, etc. (though I'm not sure what format the last
filter generates and whether you can simply view it).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 404549] Printing N copies results in N^2 copies printed instead

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=404549

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #2 from Michael Weghorn  ---
This sounds like it might be related to the CUPS filter chain, rather than
Okular.

The following information might help to further narrow this down:

1) Does this happen for all files or just specific ones?

2) Can you attach the CUPS log for one such print job (with LogLevel set to
debug)?

3) the file as generated by Okular: Can you (using a non-confidential file)
* temporarily disable the printer using 'sudo cupsdisable '
* start printing from Okular
* attach the print file called 'd_001' from directory '/var/spool/cups'
(which should be a PostScript file)
You can then enable the printer again using 'sudo cupsenable ?

4) Can you attach the PPD files of the printer(s), which should be located at
/etc/cups/ppd/?

5) What is the device URI of the printer (which is shown e.g. when running
'lpstat -v'?

6) Can you attach the file as generated by the CUPS filters? In order to get
this, you can set up a dummy printer that prints to a file as follows:
* set 'FileDevice Yes' in /etc/cup/cups-files.conf
* restart CUPS
* set up a dummy printer that prints to a file, using the real printer's PPD
file:
  'sudo lpadmin -p tofile -v file:/tmp/tofile -P /etc/cups/ppd/
-E'
* print the PDF file from Okular to the "tofile" printer
* attach the file that is generated at /tmp/tofile

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18744: Add action in Edit menu to select the current page

[Michael Weghorn]

michaelweghorn added a comment.


  In D18744#412409 , @michaelweghorn 
wrote:
  
  > The test plan still says that Ctrl+P will select the page ("or press 
combination of CTRL and P to select the entire page"). As far as I understand 
the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) 
Can you update the description accordingly?
  
  
  And as far as I can see, the same applies for the docbook.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg
Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, 
ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

D18744: Add action in Edit menu to select the current page

[Michael Weghorn]

michaelweghorn added a comment.


  The test plan still says that Ctrl+P will select the page ("or press 
combination of CTRL and P to select the entire page"). As far as I understand 
the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) 
Can you update the description accordingly?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg
Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, 
ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=403848

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #2 from Michael Weghorn  ---
(In reply to happy from comment #0)
> ADDITIONAL INFORMATION
> Minor (for me) because I don't often do markup and I can just uncheck "warn
> me if closing multiple tabs"; but if modifying documents was part of your
> work flow then this would be more severe (ie: false warnings obscuring real
> ones)

Can you explain what exactly you mean by this?

A quick test for me showed that when unchecking "warn me if closing multiple
tabs",

* no dialog appears when closing multiple unmodified documents (as you want it
to be)
* a dialog "Do you want to save your changes to  or discard them?" still
appears if any of the documents was modified (e.g. an annotation was added)

This is what I would have expected and what I'd consider to be the "correct"
behaviour. Can you describe what should be different in your eyes?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 403772] Support animation from latex package 'animate'

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=403772

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn added a comment.


  In D18179#394712 , @aacid wrote:
  
  > The only way i can think of is making the long form not havve default values
  >
  > https://paste.kde.org/p55lx6vrh
  
  
  Thanks, that looks good. I have done it this way now.
  
  (Note to self: Make sure not to have strange settings in 
$HOME/.cups/lpoptions while testing ...)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49715.
michaelweghorn added a comment.


  Changes in this revision:
  
  - make new 'printFiles()' have no default values for parameters, so that 
param order can be the same as in the original one (thanks Albert!)
  
  - add "TODO" comment to merge both versions

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18179?vs=49614=49715

BRANCH
  michaelweghorn/UPDATE_D18179

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn added a comment.


  In D10974#394709 , @aacid wrote:
  
  > I don't really have the time to spend print stuff to check if this does 
what it says it does, so i'm just doing code review from the pure formal way.
  
  
  Many thanks for taking the time to look at this anyway!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn marked 4 inline comments as done.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49697.
michaelweghorn added a comment.


  Adapted according to Albert's feedback:
  
  - Remove (now) unneeded imclude
  - remove 'virtual' keyword in derived class

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10974?vs=49608=49697

BRANCH
  michaelweghorn/UPDATE_D10974

REVISION DETAIL
  https://phabricator.kde.org/D10974

AFFECTED FILES
  CMakeLists.txt
  core/document.h
  core/fileprinter.cpp
  core/printoptionswidget.cpp
  core/printoptionswidget.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  interfaces/printinterface.h
  part.cpp

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn added a comment.


  If you have any other idea on how to avoid that issue with the printFiles() 
methods, I'd be thankful to hear about this.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn added a comment.


  In D18179#394030 , @aacid wrote:
  
  > We would need a @since marker for the enum and for the new methods and a 
  >  // TODO merge with function above when a BIC change happens somehwere else
  >  would also make sense
  
  
  I added these. I did not add a TODO comment to merge for the new printFiles() 
method, though. In the current constellation, merging them would break the API, 
since the position of the 'scaleMode' parameter is another one (can't be the 
last param for the new version, since it has no default value) and I guess this 
is undesirable, even when an ABI change appears?.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49614.
michaelweghorn marked an inline comment as done.
michaelweghorn added a comment.


  - Adapt order of ScaleMode enum values as implicitly suggested in Albert's 
comment (I missed that at first)

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18179?vs=49612=49614

BRANCH
  
michaelweghorn/D18179_20190116_WAITING_FOR_REVIEW_allowScaledPrintingWithoutRasterization

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling options for non-rasterized printing

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49612.
michaelweghorn retitled this revision from "PDF: Implement scaling for 
non-rasterized printing" to "PDF: Implement scaling options for non-rasterized 
printing".
michaelweghorn edited the summary of this revision.
michaelweghorn added a comment.


  Changes in this revision:
  
  - add '@since' markes and TODO comments to merge functions when a binary 
incompatible change is done elsewhere
  - adapt enum to prepare for use of binary AND/OR

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18179?vs=49519=49612

BRANCH
  
michaelweghorn/D18179_20190116_WAITING_FOR_REVIEW_allowScaledPrintingWithoutRasterization

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49608.
michaelweghorn added a comment.


  Changes in this revision:
  
  - undo changes in 'interfaces/'
  - emit a qWarning() when 'dynamic_cast' fails

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10974?vs=49510=49608

BRANCH
  
michaelweghorn/WAITING_FOR_REVIEW_D10974_20190116T1115_add_scaling_options_for_other_generators

REVISION DETAIL
  https://phabricator.kde.org/D10974

AFFECTED FILES
  CMakeLists.txt
  core/document.cpp
  core/document.h
  core/fileprinter.cpp
  core/printoptionswidget.cpp
  core/printoptionswidget.h
  generators/poppler/generator_pdf.cpp
  generators/poppler/generator_pdf.h
  interfaces/printinterface.h
  part.cpp

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

[Michael Weghorn]

michaelweghorn marked an inline comment as done.
michaelweghorn added a comment.


  Thanks for the feedback and info. I've update the change accordingly now.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

[Michael Weghorn]

michaelweghorn marked 2 inline comments as done.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49519.
michaelweghorn added a comment.


  Undo accidental whitespace changes

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18179?vs=49518=49519

BRANCH
  michaelweghorn/UPDATE_20191115_D18179_allowScaledPrintingWithoutRasterization

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D18179: PDF: Implement scaling for non-rasterized printing

[Michael Weghorn]

michaelweghorn updated this revision to Diff 49518.
michaelweghorn added a comment.


  Implement improvements suggested by Albert:
  
  - use an enum rather than a bool for scale mode
  - avoid ABI breakage by adding extra methods that take an additional 
parameter for scale mode and make existing methods call those
  
  What's a bit ugly here is that 'scaleMode' cannot be the last
  parameter in the new 'FilePrinter::printFile' method, as it
  has to come before those params that have a default value.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18179?vs=49225=49518

BRANCH
  michaelweghorn/UPDATE_20191115_D18179_allowScaledPrintingWithoutRasterization

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen

D10974: Add option to ignore print margins for non-PDF generators

[Michael Weghorn]

michaelweghorn marked an inline comment as done.
michaelweghorn added inline comments.

INLINE COMMENTS

> aacid wrote in document.h:728
> this is binary incompatible :/
> 
> We could just let it be a QWidget but document it has to be a 
> PrintOptionsWidge subclass, and then on the user do a dynamic_cast and 
> complain if it is not a PrintOptionsWidget, but maybe we can just say meh and 
> break the BC.

I have changed the return type to a QWidget* again, but only for the Document 
class itself, not in the other places. As far as I understand, this place here 
is the only one relevant for the ABI. Is this correct?

Currently, there is no complaint if a plain QWidget* is returned, it's just 
handled as it used to be then. Should I change that (e.g. emit a 'qWarning()')?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10974

To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, 
darcyshen