[okular] [Bug 484294] Size of the text in forms while editing is dependent on pdf size

2024-05-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=484294

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REPORTED
 CC||nicolas.fe...@gmx.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 443403] Reduce the size of the digital signature display

2024-04-15 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=443403

--- Comment #37 from Nicolas Fella  ---
Git commit 465b9ff5cea0cc4d4f35308ac1bb3d84a912cda9 by Nicolas Fella.
Committed on 15/04/2024 at 12:24.
Pushed by nicolasfella into branch 'master'.

Let poppler pick the font size when signing signature fields

Currently we use the default font sizes for NewSignatureData, which are 10 for
fontSize and 20 for leftFontSize

This can be too large for a small signature field, leasing to cut-off text

When passing 0 poppler picks a suitable size depending on the size of the
signature field

M  +5-0generators/poppler/formfields.cpp

https://invent.kde.org/graphics/okular/-/commit/465b9ff5cea0cc4d4f35308ac1bb3d84a912cda9

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification

2024-04-02 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=474888

Nicolas Fella  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/ea243a
   ||2a03f9249c3fc36bdbcdb71d987
   ||de064ce
 Resolution|--- |FIXED

--- Comment #5 from Nicolas Fella  ---
Git commit ea243a2a03f9249c3fc36bdbcdb71d987de064ce by Nicolas Fella, on behalf
of Nicolas Fella.
Committed on 02/04/2024 at 11:04.
Pushed by aacid into branch 'master'.

Fix DocumentHasPassword check

A document can be encrypted without requiring a password to open/sign it.

Currently we assume we need a password to sign it for such documents, but
that's not correct.

Instead of checking whether the document is encrypted remember whether
we needed a password for opening.

M  +2-1generators/poppler/generator_pdf.cpp
M  +2-0generators/poppler/generator_pdf.h

https://invent.kde.org/graphics/okular/-/commit/ea243a2a03f9249c3fc36bdbcdb71d987de064ce

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 484524] Okular crashes when closing annotation window

2024-03-26 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=484524

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
Summary|Okular crashes on Plasma 6  |Okular crashes when closing
   |when closing annotation |annotation window
   |window  |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 484127] After inserting a bookmark, the bookmark cannot be updated immediately under the sidebar bookmarks tab, and it can only be updated after checking "Show in all documents" repeated

2024-03-21 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=484127

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 481748] menu is unusable; hover over menu is worse; can't even see Help|version

2024-02-24 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=481748

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 480901] "Configure Okular" window under "Settings" menu is slow to open

2024-02-05 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=480901

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #1 from Nicolas Fella  ---
Created attachment 165568
  --> https://bugs.kde.org/attachment.cgi?id=165568=edit
Hotspot analysis

Slowness seems to come from initializing text-to-speech stuff

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 479942] Okular crashes when saving a document

2024-01-17 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=479942

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Keywords|qt6 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474661] Norwegian withholding tax form - wrong calculation of percent value

2023-12-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=474661

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #11 from Nicolas Fella  ---
The form field has a AFNumber_Keystroke(2, 0, 0, 0, "", true) keystroke script
(that Okular doesn't implement, which is another bug in itself)

This means . is decimal and , is thousand separator.

Acrobat and Firefox don't even let me type in a comma, Chromium treats it as a
decimal separator.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 443403] Reduce the size of the digital signature display

2023-12-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=443403

--- Comment #34 from Nicolas Fella  ---
There are multiple scenarios to consider here:

1) Singing a predefined signature field. Here the size is fixed and currently
we risk cutting off the text because it is too large. The font size should
automatically be chosen so that the text fits into the predefined box

2) We add a new signature to the document. Here we get to choose the bounding
box, but we have to consider that space on the document may be limited. Ideally
we would have something like I described in
https://bugs.kde.org/show_bug.cgi?id=443403#c9
- When adding a signature we collect the necessary information
- Then we calculate a reasonable suggested bounding box and place that
somewhere on the document
- Then the user is able to move and resize the proposed signature as they
desire. When resizing the font scales appropriately so that the text always
fits
- The user hits "Apply" of some sort and the signature is baked into the signed
document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification

2023-12-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=474888

Nicolas Fella  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474888] Signing requires (empty) password in document that has password-restriction for modification

2023-12-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=474888

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #2 from Nicolas Fella  ---
The prompt comes from
https://invent.kde.org/graphics/okular/-/blob/master/part/signaturepartutils.cpp#L409

DocumentHasPassword comes from
https://invent.kde.org/graphics/okular/-/blob/master/generators/poppler/generator_pdf.cpp#L1593

The assumption seems to be that if the document is encrypted we need the
password to *read* it, but that's not the case here

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 474889] Form field misuse leads to 'NaN' which won't disappear

2023-12-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=474889

Nicolas Fella  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||nicolas.fe...@gmx.de

--- Comment #1 from Nicolas Fella  ---
The form field uses the AFNumber_Keystroke script, which we don't implement
(see
https://invent.kde.org/graphics/okular/-/blob/master/core/script/builtin.js#L152)

https://invent.kde.org/graphics/okular/-/merge_requests/519 covers this

That means the expected behavior would be to reject any input that is not a
digit or separator

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 473405] Okular crash when chrome is running and the computer goes to sleep mode.

2023-10-04 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=473405

--- Comment #3 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 473602 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] Poor peformance when opening PDF with lots of forms

2023-09-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Nicolas Fella  ---
Seems fixed by
https://invent.kde.org/graphics/okular/-/commit/521ea660eee1abcf9bb90b7be06f9a38e0f78bb9

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 473560] Okular cashes when displaying settings configure backends PDF and D-Trust 4.1 id-card inside card reader

2023-08-20 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=473560

Nicolas Fella  changed:

   What|Removed |Added

   Severity|critical|normal
 CC||nicolas.fe...@gmx.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 473405] Okular crash when chrome is running and the computer goes to sleep mode.

2023-08-15 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=473405

Nicolas Fella  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||nicolas.fe...@gmx.de

--- Comment #2 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 461723 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390707] Two-finger touchscreen zoom gesture should respect finger position

2023-08-11 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=390707

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/3306e4
   ||f35d212f9eb64d28108b2b68401
   ||2c9ce4e

--- Comment #9 from Nicolas Fella  ---
Git commit 3306e4f35d212f9eb64d28108b2b684012c9ce4e by Nicolas Fella.
Committed on 11/08/2023 at 13:27.
Pushed by nicolasfella into branch 'master'.

Hold zoom center below fingers on pinch zoom

Which feels more natural than always zooming towards the center of the window.

Co-authored-by: Steffen Hartleib 

Co-authored-by: Oliver Sander 

M  +101  -11   part/pageview.cpp
M  +6-0part/pageview.h

https://invent.kde.org/graphics/okular/-/commit/3306e4f35d212f9eb64d28108b2b684012c9ce4e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390707] Two-finger touchscreen zoom gesture should respect finger position

2023-08-02 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=390707

Nicolas Fella  changed:

   What|Removed |Added

 CC||apanda...@gmail.com

--- Comment #8 from Nicolas Fella  ---
*** Bug 472924 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 472924] Pinch to Zoom on a touch screen zooms to the center of the screen and not to the intended part of the page

2023-08-02 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=472924

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||nicolas.fe...@gmx.de

--- Comment #1 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 390707 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 421755] The two finger touchscreen gesture to zoom in out (pinch in/pinch out) results in the document to scroll by a large amount.

2023-07-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=421755

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/-/commit/db6866
   ||2372984e643184a6d1f8eb63e51
   ||9e2646d

--- Comment #11 from Nicolas Fella  ---
Git commit db68662372984e643184a6d1f8eb63e519e2646d by Nicolas Fella.
Committed on 08/07/2023 at 12:04.
Pushed by nicolasfella into branch 'master'.

Avoid accidental scrolling when performing pinch gesture

When starting a pinch the user first touches with one finger. That causes the
QScroller to enter the pressed state.
Then when the second finger touches and moves this causes the QScroller to
interpret it as a scroll. This causes
the view position of the document to move

To avoid this send InputRelease to the scroller when a pinch starts to make
sure it is no longer in pressed state.
Also don't send any input to the scroller while the pinch is ongoing to avoid
it entering the pressed state again.

M  +19   -4part/pageview.cpp

https://invent.kde.org/graphics/okular/-/commit/db68662372984e643184a6d1f8eb63e519e2646d

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 472041] Wayland: Clicking the "View Mode" button while the window is unfocused makes the context menu appear in its own window

2023-07-07 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=472041

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Keywords||wayland

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471347] Windows: Dark Scheme Bug

2023-06-25 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=471347

Nicolas Fella  changed:

   What|Removed |Added

 CC||baliczeri...@gmail.com

--- Comment #6 from Nicolas Fella  ---
*** Bug 471441 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471441] Dark theme for Windows not working properly

2023-06-25 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=471441

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #3 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 471347 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471347] Windows: Dark Scheme Bug

2023-06-25 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=471347

Nicolas Fella  changed:

   What|Removed |Added

 CC||8bb91edf1...@mail.ru

--- Comment #5 from Nicolas Fella  ---
*** Bug 470347 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 470347] Menu bar appears with white text on white background when using breeze dark theme

2023-06-25 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=470347

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||nicolas.fe...@gmx.de
 Status|REPORTED|RESOLVED

--- Comment #2 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 471347 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471347] Windows: Dark Scheme Bug

2023-06-24 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=471347

Nicolas Fella  changed:

   What|Removed |Added

 CC||emir_s...@icloud.com

--- Comment #4 from Nicolas Fella  ---
*** Bug 471411 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 471411] Broken theme on Windows

2023-06-24 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=471411

Nicolas Fella  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||nicolas.fe...@gmx.de
 Resolution|--- |DUPLICATE

--- Comment #1 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 471347 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 469171] ChatGPT

2023-04-30 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=469171

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 CC||nicolas.fe...@gmx.de
 Status|REPORTED|RESOLVED

--- Comment #1 from Nicolas Fella  ---
Please see https://community.kde.org/Get_Involved/Issue_Reporting for how to
report bugs/requests.

In particular see
https://community.kde.org/Get_Involved/Issue_Reporting#Proposing_a_solution.
You should always describe problems instead of proposing (vague) solutions.
Based on the problem description we then can discuss whether using AI/ChatGPT
would be an appropriate solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461371] PDFs digitally signed with Okular become locked in Adobe Acrobat so no one else can sign it

2023-04-28 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461371

--- Comment #4 from Nicolas Fella  ---
https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1372 fixes the
issue for me

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461371] PDFs digitally signed with Okular become locked in Adobe Acrobat so no one else can sign it

2023-04-28 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461371

--- Comment #3 from Nicolas Fella  ---
It looks like this does not explain the problem. Signing
https://invent.kde.org/graphics/okular/-/blob/master/autotests/data/hello_with_dummy_signature.pdf
with Acrobat doesn't add a DocMDP entry either.

The relevant part of the document signed by Okular:

%% Original object ID: 32 0
29 0 obj
<<
  /ByteRange [
0
490918
499126
378
  ]
  /Contents
  /Filter /Adobe.PPKLite
  /M (D:20230428140625+02'00')
  /Name (Nicolas Fella)
  /SubFilter /adbe.pkcs7.detached
  /Type /Sig
>>
endobj

And by Acrobat:

%% Original object ID: 18 0
23 0 obj
<<
  /ByteRange [
0
3871
8413
9388
  ]
  /Contents
  /Filter /Adobe.PPKLite
  /M (D:20230428140204+02'00')
  /Name (Nicolas Fella)
  /Prop_Build <<
/App <<
  /Name /Adobe#20Acrobat#20Reader#20#2864-bit#29
  /OS [
/Win
  ]
  /R 1507584
  /REx (2023.001.20143)
  /TrustedMode true
>>
/Filter <<
  /Date (Apr  4 2023 18:35:16)
  /Name /Adobe.PPKLite
  /R 131104
  /V 2
>>
/PubSec <<
  /Date (Apr  4 2023 18:35:16)
  /R 131105
>>
  >>
  /SubFilter /adbe.pkcs7.detached
  /Type /Sig
>>
endobj

The difference is the /Prop_Build entry, but not sure this explains the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461371] PDFs digitally signed with Okular become locked in Adobe Acrobat so no one else can sign it

2023-04-27 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461371

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #2 from Nicolas Fella  ---
PDF allows for some fine-grained control about what you can do with a signed
document and what not

Looking at https://www.verypdf.com/document/pdf-format-reference/pg_0733.htm I
see this:

The access permissions granted for this document. Valid values are:
1 No changes to the document are permitted; any change to the document
invalidates the signature
2 Permitted changes are filling in forms, instantiating page templates, and
signing; other changes invalidate the signature.
3 Permitted changes are the same as for 2, as well as annotation creation,
deletion, and modification; other changes invalidate the signature

Default value: 2

Okular/Poppler doesn't set this, so the default (2) applies. That should
explain why you cannot add a new signature (which is technically similar to
adding an annotation). You should be able to do the things described in 2, like
filling in forms.

Note that this is my understanding based on reading the linked site and the
poppler source, I haven't reproduced the issue to confirm yet

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468274] Okular opens a new instance instead of new tab (Virtual Desktops)

2023-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=468274

--- Comment #5 from Nicolas Fella  ---
Do you have the "Open new files in tabs" option enabled?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 468274] Okular opens a new instance instead of new tab (Virtual Desktops)

2023-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=468274

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #3 from Nicolas Fella  ---
Okular always either opens a new instance or a new tab, depending on your
settings, regardless of desktops or activities.

I'm not sure I understand how you want it to behave. Do you want it to open a
new tab when it's on the current desktop and open a new instance otherwise?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 430153] Custom stamp doesn't automatically appear under the stamps drop-down menu

2023-02-04 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=430153

Nicolas Fella  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||nicolas.fe...@gmx.de
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 462304] Okular and other poppler related tools cannot handle some pdf pages

2022-11-28 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=462304

Nicolas Fella  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|CONFIRMED   |RESOLVED

--- Comment #11 from Nicolas Fella  ---
Thanks for creating the poppler bug report. I will close this then

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 462304] Okular and other poppler related tools cannot handle some pdf pages

2022-11-27 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=462304

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #4 from Nicolas Fella  ---
When opening that file poppler prints "Bogus memory allocation size".
Presumably because the embedded image data is too large in some way.

The allocation seems to come from
https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/poppler/JBIG2Stream.cc#L1575

numInputSyms is 0, numNewSyms is 3092673499. 3092673499 is larger than 2^31 and
smaller than 2^32. It is stored as unsigned int, so that's fine, but when
passing that to gmallocn_checkoverflow it gets converted to int causing an
overflow. Once it reaches
https://gitlab.freedesktop.org/poppler/poppler/-/blob/master/goo/gmem.h#L112
count is -1202293797 and the allocation fails

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 462159] crashes when using three finger swipe

2022-11-23 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=462159

Nicolas Fella  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||nicolas.fe...@gmx.de
 Resolution|--- |FIXED

--- Comment #1 from Nicolas Fella  ---
This should be fixed with
https://invent.kde.org/qt/qt/qtwayland/-/commit/4d900fb4e68f8b3c0956948d613a072622fbc803

Unfortunately Kubuntu seems to be behind on shipping the latest Qt bugfix
releases

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461093] User filled content in IRS fillable forms not rendered

2022-11-01 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461093

Nicolas Fella  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461093] User filled content in IRS fillable forms not rendered

2022-10-28 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461093

--- Comment #4 from Nicolas Fella  ---
I opened https://www.irs.gov/pub/irs-pdf/f1040.pdf in Okular. It warns about
unsupported XFA Forms, but I can see and edit the forms fine, so I don't know
what you mean with "All fields are empty"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461093] User filled content in IRS fillable forms not rendered

2022-10-28 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461093

Nicolas Fella  changed:

   What|Removed |Added

 Status|RESOLVED|REPORTED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 461093] User filled content in IRS fillable forms not rendered

2022-10-28 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=461093

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 443403] Reduce the size of the digital signature display

2022-10-07 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=443403

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #9 from Nicolas Fella  ---
Adjusting the font size according to the box size could be a relatively easy
way to address this.

However I think the overall UX could still be improved. We are asking the user
to specify an area where they initially have no idea what size would be
appropriate for the content. The the user has to figure out the best size 
through trial and error. Perhaps we could do something like

1. The user starts signing
2. Okular asks which certificate should be used
3. Based on the certificate content Okular calculates a suggested rectangle and
places that somewhere
4. The user can resize and move the rectangle as needed
5. The user saves and the PDF is signed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 459302] Link for help about signatures is dead

2022-09-18 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=459302

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #1 from Nicolas Fella  ---
Replacing the fr in the URL with en or de makes it work
(https://docs.kde.org/stable5/en/okular/okular/signatures.html#adding_digital_signatures),
so it looks like a problem with the french localization?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 457520] Okular Open new files in tabs

2022-08-05 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=457520

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[i18n] [Bug 457057] inconsistency in polish translation of the keyboard shortcut description

2022-07-24 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=457057

Nicolas Fella  changed:

   What|Removed |Added

Version|22.04.3 |unspecified
  Component|general |pl
   Assignee|okular-devel@kde.org|kdei18n-pl-uw...@lists.sour
   ||ceforge.net
 CC||nicolas.fe...@gmx.de
Product|okular  |i18n

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] Poor peformance when opening PDF with lots of forms

2022-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

--- Comment #5 from Nicolas Fella  ---
That also means the issue is only triggered on high-dpi screens

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] Poor peformance when opening PDF with lots of forms

2022-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

--- Comment #4 from Nicolas Fella  ---
page->_o_nearestPixmap always returns a pixmap with DPR 1, but a dpr of 2 is
needed for me, hence the detach in setDevicePixelRatio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] Poor peformance when opening PDF with lots of forms

2022-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

--- Comment #3 from Nicolas Fella  ---
Commenting
https://invent.kde.org/graphics/okular/-/blob/master/gui/pagepainter.cpp#L109
out makes it run smooth

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] Poor peformance when opening PDF with lots of forms

2022-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

--- Comment #2 from Nicolas Fella  ---
Created attachment 148048
  --> https://bugs.kde.org/attachment.cgi?id=148048=edit
Hotspot Flamegraph

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] Poor peformance when opening PDF with lots of forms

2022-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

--- Comment #1 from Nicolas Fella  ---
Created attachment 148047
  --> https://bugs.kde.org/attachment.cgi?id=148047=edit
The PDF

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 452406] New: Poor peformance when opening PDF with lots of forms

2022-04-08 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=452406

Bug ID: 452406
   Summary: Poor peformance when opening PDF with lots of forms
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: nicolas.fe...@gmx.de
  Target Milestone: ---

STEPS TO REPRODUCE
1. Open the attached PDF 
2. Click "Show Forms"
3. Scroll around in the PDF

OBSERVED RESULT
Scrolling lags a lot


EXPECTED RESULT
Scrolling works normally


SOFTWARE/OS VERSIONS
KDE Frameworks Version: master 
Qt Version: 5.15.3

ADDITIONAL INFORMATION
Poppler from master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 449552] CUPS and DBus crashes

2022-02-03 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=449552

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #2 from Nicolas Fella  ---
https://bugs.kde.org/show_bug.cgi?id=432740 shows a similar backtrace, which
suggests the issue might be with Qt's printing code

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 448360] Can't configure path in PDF Backends on Windows

2022-01-13 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=448360

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 439723] While printing special sample file or generating a printer preview for it the UI freezes

2022-01-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=439723

--- Comment #1 from Nicolas Fella  ---
> It seems to run on the same thread as the UI if I am not mistaken?

yes, that appears to be the case.

What might make sense is to change "Document::PrintError print(QPrinter
)" to something like "PrintJob print(QPrinter )" where PrintJob
is a (KJob derived) class that encapsulates an async print operation. 

However that touches the generator interface, which as I understand is subject
to ABI constraints?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 439723] While printing special sample file or generating a printer preview for it the UI freezes

2022-01-12 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=439723

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 444971] Okular crashed when opening a markdown file

2021-11-04 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=444971

--- Comment #1 from Nicolas Fella  ---
Can reproduce on current master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 444971] Okular crashed when opening a markdown file

2021-11-04 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=444971

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 431762] Search bar text field eats hotkeys

2021-01-17 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=431762

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de
 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Nicolas Fella  ---


*** This bug has been marked as a duplicate of bug 431493 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 431493] Okular search bar no longer closed when pressing Esc

2021-01-17 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=431493

Nicolas Fella  changed:

   What|Removed |Added

 CC||war...@gmx.de

--- Comment #3 from Nicolas Fella  ---
*** Bug 431762 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 423755] Okular: please provide stable installers outside of MS Store

2020-07-01 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=423755

Nicolas Fella  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #3 from Nicolas Fella  ---
I agree that there should be a proper website to download it from.

https://okular.kde.org/download.php and
https://kde.org/applications/en/graphics/org.kde.okular come to my mind.

I will ask some other people for input though

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 423755] Okular: please provide stable installers outside of MS Store

2020-07-01 Thread Nicolas Fella
https://bugs.kde.org/show_bug.cgi?id=423755

Nicolas Fella  changed:

   What|Removed |Added

 CC||nicolas.fe...@gmx.de

--- Comment #1 from Nicolas Fella  ---
There is a daily build of the stable release available at
https://binary-factory.kde.org/view/Windows%2064-bit/job/Okular_Release_win64/

-- 
You are receiving this mail because:
You are the assignee for the bug.

D14102: Add share action to selection context menu

2020-05-18 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, darcyshen, aacid


D22713: Use KRun::runApplication instead of KRun::runService

2020-04-14 Thread Nicolas Fella
nicolasfella abandoned this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22713

To: nicolasfella, #okular, aacid
Cc: aacid, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, ngraham, darcyshen


D22713: Use KRun::runApplication instead of KRun::runService

2019-07-24 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  KRun::runService is about to be deprecated. The difference is that runService 
waits for the application to register on DBUs, wich seems irrelevant here

REPOSITORY
  R223 Okular

BRANCH
  rs

REVISION DETAIL
  https://phabricator.kde.org/D22713

AFFECTED FILES
  core/document.cpp

To: nicolasfella, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid


D22713: Use KRun::runApplication instead of KRun::runService

2019-07-24 Thread Nicolas Fella
nicolasfella edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D22713

To: nicolasfella, #okular
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, 
darcyshen, aacid


D20832: Fix some clazy warning

2019-05-21 Thread Nicolas Fella
nicolasfella added inline comments.

INLINE COMMENTS

> aacid wrote in parttest.cpp:258
> QStringliteral is broken on windows with non ascii chars, please turn this 
> back to QString::fromUtf8 so tests don't start failing.

Might be worth a comment so the next person knows?

REPOSITORY
  R223 Okular

BRANCH
  fix_some_clazy_warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20832

To: mlaurent, aacid
Cc: nicolasfella, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid


D18637: Update some files to QQC2 and fix minor bug

2019-02-01 Thread Nicolas Fella
nicolasfella added a comment.


  +1

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18637

To: ognarb, #okular
Cc: nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid


D18397: Fix crash on canceling the file open dialog

2019-01-27 Thread Nicolas Fella
nicolasfella accepted this revision.

REPOSITORY
  R223 Okular

BRANCH
  arcpatch-D18397

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause, apol, nicolasfella
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid


D18397: Fix crash on canceling the file open dialog

2019-01-19 Thread Nicolas Fella
nicolasfella added a comment.


  I think the "proper" thing to do would be to check whether the resultCode is 
Activity.RESULT_OK or Activity.RESULT_CANCELED

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause
Cc: nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid


D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Nicolas Fella
nicolasfella added a reviewer: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D16048

To: kadabash, aacid
Cc: okular-devel, ngraham, aacid


D14102: Add share action to selection context menu

2018-07-13 Thread Nicolas Fella
nicolasfella edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: okular-devel, ngraham, aacid


D14102: Add share action to selection context menu

2018-07-13 Thread Nicolas Fella
nicolasfella created this revision.
nicolasfella added reviewers: Okular, aacid, apol.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Enable sharing a selection via Purpose.

REPOSITORY
  R223 Okular

BRANCH
  share

REVISION DETAIL
  https://phabricator.kde.org/D14102

AFFECTED FILES
  ui/pageview.cpp

To: nicolasfella, #okular, aacid, apol
Cc: okular-devel, ngraham, aacid