Re: [openstack-dev] [goal][python3] week 7 update
Doug Hellmann writes: > Doug Hellmann writes: > >> Doug Hellmann writes: >> >>> == Things We Learned This Week == >>> >>> When we updated the tox.ini settings for jobs like pep8 and release >>> notes early in the Rocky session we only touched some of the official >>> repositories. I'll be working on making a list of the ones we missed so >>> we can update them by the end of Stein. >> >> I see quite a few repositories with tox settings out of date (about 350, >> see below). Given the volume, I'm going to prepare the patches and >> propose them a few at a time over the next couple of weeks. > > Zuul looked bored this morning so I went ahead and proposed a few of the > larger batches of these changes for the Charms, OpenStack Ansible, and > Horizon teams. TripleO also has quite a few, but since we know the gate > is unstable I will hold off on those for now. > > There will be more patches when there is CI capacity again. > > Doug All of these patches have now been proposed. Doug __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [goal][python3] week 7 update
Doug Hellmann writes: > Doug Hellmann writes: > >> == Things We Learned This Week == >> >> When we updated the tox.ini settings for jobs like pep8 and release >> notes early in the Rocky session we only touched some of the official >> repositories. I'll be working on making a list of the ones we missed so >> we can update them by the end of Stein. > > I see quite a few repositories with tox settings out of date (about 350, > see below). Given the volume, I'm going to prepare the patches and > propose them a few at a time over the next couple of weeks. Zuul looked bored this morning so I went ahead and proposed a few of the larger batches of these changes for the Charms, OpenStack Ansible, and Horizon teams. TripleO also has quite a few, but since we know the gate is unstable I will hold off on those for now. There will be more patches when there is CI capacity again. Doug __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [goal][python3] week 7 update
Jeremy Stanley writes: > On 2018-09-28 13:58:52 -0400 (-0400), William M Edmonds wrote: >> Doug Hellmann wrote on 09/26/2018 06:29:11 PM: >> >> > * We do not want to set the override once in testenv, because that >> > breaks the more specific versions used in default environments like >> > py35 and py36 (at least under older versions of tox). >> >> >> I assume that something like >> https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=fa64a93c965e6a6692711962ad6584534da81695 >> should be a perfectly acceptable alternative in at least some cases. >> Agreed? > > I believe the confusion is that ignore_basepython_conflict didn't > appear in a release of tox until after we started patching projects > for this effort (in fact it was added to tox in part because we > discovered the issue in originally attempting to use basepython > globally). Right. The scripted patches work with older versions of tox as well. They also have the benefit of only changing the environments into which the new setting is injected, which means if you have a py27-do-something-random environment it isn't going to suddenly start using python 3 instead of python 2.7. The thing we care about for the goal is ensuring that the required jobs run under python 3. Teams are, as always, completely free to choose alternative implementations if they are willing to update the patches (or write alternative ones). Doug __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [goal][python3] week 7 update
On 9/28/18 1:38 PM, Jeremy Stanley wrote: On 2018-09-28 13:58:52 -0400 (-0400), William M Edmonds wrote: Doug Hellmann wrote on 09/26/2018 06:29:11 PM: * We do not want to set the override once in testenv, because that breaks the more specific versions used in default environments like py35 and py36 (at least under older versions of tox). I assume that something like https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=fa64a93c965e6a6692711962ad6584534da81695 should be a perfectly acceptable alternative in at least some cases. Agreed? I believe the confusion is that ignore_basepython_conflict didn't appear in a release of tox until after we started patching projects for this effort (in fact it was added to tox in part because we discovered the issue in originally attempting to use basepython globally). Yeah, if you're okay with requiring tox 3.1+ then you can use that instead. We've been avoiding it for now in other projects because some of the distros aren't shipping tox 3.1 yet and some people prefer not to mix distro Python packages and pip ones. At some point I expect we'll migrate everything to the new behavior though. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [goal][python3] week 7 update
On 2018-09-28 13:58:52 -0400 (-0400), William M Edmonds wrote: > Doug Hellmann wrote on 09/26/2018 06:29:11 PM: > > > * We do not want to set the override once in testenv, because that > > breaks the more specific versions used in default environments like > > py35 and py36 (at least under older versions of tox). > > > I assume that something like > https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=fa64a93c965e6a6692711962ad6584534da81695 > should be a perfectly acceptable alternative in at least some cases. > Agreed? I believe the confusion is that ignore_basepython_conflict didn't appear in a release of tox until after we started patching projects for this effort (in fact it was added to tox in part because we discovered the issue in originally attempting to use basepython globally). -- Jeremy Stanley signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [goal][python3] week 7 update
Doug Hellmann wrote on 09/26/2018 06:29:11 PM: > * We do not want to set the override once in testenv, because that > breaks the more specific versions used in default environments like > py35 and py36 (at least under older versions of tox). I assume that something like https://git.openstack.org/cgit/openstack/nova-powervm/commit/?id=fa64a93c965e6a6692711962ad6584534da81695 should be a perfectly acceptable alternative in at least some cases. Agreed? __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [goal][python3] week 7 update
Doug Hellmann writes: > == Things We Learned This Week == > > When we updated the tox.ini settings for jobs like pep8 and release > notes early in the Rocky session we only touched some of the official > repositories. I'll be working on making a list of the ones we missed so > we can update them by the end of Stein. I see quite a few repositories with tox settings out of date (about 350, see below). Given the volume, I'm going to prepare the patches and propose them a few at a time over the next couple of weeks. As background, each repo needs a patch (to master only) that looks like [1]. It needs to set the "basepython" parameter in all of the relevant tox environments to "python3" to force using python 3. It is most important to set the docs, linters, pep8, releasenotes, lower-constraints and venv environments, but we also wanted to include bindep and cover if they are present. The patches I prepare will update all of those environments. We should also include any other environments that run jobs, but teams may want to duplicate some (and add the relevant jobs) rather than changing all of the functional test jobs. As with the other functional job changes, I will leave those up to the project teams. As the commit message on [1] explains, we are using "python3" on purpose: * We do not want to specify a minor version number, because we do not want to have to update the file every time we upgrade python. * We do not want to set the override once in testenv, because that breaks the more specific versions used in default environments like py35 and py36 (at least under older versions of tox). In case you want to watch for them, all of the new patches will use "fix tox python3 overrides" as the first line of the commit message (the tracking tool looks for that string). Doug [1] https://review.openstack.org/#/c/573355/ __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
