Re: [Openvpn-devel] [PATCH applied] Re: unify code path for adding PKCS#11 providers
Hi, *sigh* - "Marc Becker via Openvpn-devel", this so messes up my workflow... (can DMARC please go somewhere and die, alone, with no friends?). I had to reapply these patches 1/3 and 2/3 to get the author right, so you'll see new commit IDs. For 1/3, these are: On Thu, Dec 15, 2022 at 08:55:19AM +0100, Gert Doering wrote: > commit b08f8cbb2b92f3ee0eced39d11665befea3aec87 (master) > commit f1995ccca4c105e71728101bb719d235f5605b33 (release/2.6) new: commit 8958a365479348c1500dee44e1a8b27e7e35a96f ( master) commit bcceded96775cc5a131bb9ab11ba855c7576603d (release/2.6) Author: Marc Becker Date: Sun Dec 11 20:09:13 2022 +0100 unify code path for adding PKCS#11 providers nothing in the actual patch has changed, just the author (and that, of course, changes the commit IDs). gert -- "If was one thing all people took for granted, was conviction that if you feed honest figures into a computer, honest figures come out. Never doubted it myself till I met a computer with a sense of humor." Robert A. Heinlein, The Moon is a Harsh Mistress Gert Doering - Munich, Germany g...@greenie.muc.de signature.asc Description: PGP signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: unify code path for adding PKCS#11 providers
I do claim that I have no idea about pkcs11-helper, but this patch isn't *that* complex, just using the existing wrapper... but still thanks to Frank for reviewing. I have test compiled on Gentoo with "pkcs11-helper-1.27.0-r1", and "it compiled". I *do* find this part a bit nonintuitive... pkcs11_addProvider( ..., cert_private ? TRUE : FALSE) .. we have a bool, pass it to a bool, and evaluate it in tri-state, to pass true, if the bool is true, and false, if it is not... wat? One day, someone should reformat the rest of pkcs11.c, though... this stuff is outright ugly msg( M_INFO, "PKCS#11: Adding PKCS#11 provider '%s'", provider ); (but I'm aware that OpenVPN had this phase when every function call needed to be distributed to the maximum number of lines possible...) Your patch has been applied to the master and release/2.6 branch. commit b08f8cbb2b92f3ee0eced39d11665befea3aec87 (master) commit f1995ccca4c105e71728101bb719d235f5605b33 (release/2.6) Author: Marc Becker via Openvpn-devel Date: Sun Dec 11 20:09:13 2022 +0100 unify code path for adding PKCS#11 providers Signed-off-by: Marc Becker Acked-by: Frank Lichtenheld Message-Id: <20221211190913.190-1-marc.bec...@astos.de> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25642.html Signed-off-by: Gert Doering -- kind regards, Gert Doering ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
