[pacman-dev] two patches for makepkg

2009-10-02 Thread huntxu

1. let makepkg work with icc
this patch is inspired by the gentoo wiki page  
http://en.gentoo-wiki.com/wiki/ICC
First of all, you should install icc of course, see  
http://aur.archlinux.org/packages.php?ID=2252
Add your icc CFLAGS/CXXFLAGS($ICCCFLAGS  $ICCCXXFLAGS) to  
/etc/makepkg.conf.

Add icc to the BUILDENV array in /etc/makepkg.conf
Add packages' names (one per line) you want to compiled with icc to  
/etc/package.icc, if a package is not listed in this file, it will be  
compiled with gcc.
Add per-package CFLAGS for packages(package's name followed by CFLAGS per  
line) you want to compiled with icc to /etc/package.icc-cflags. A few  
packages benefit greatly from the -O3 flag like python and sqlite  
according to the gentoo wiki.


2. let makepkg install custom license automatically
When making packages whose licenses are custom, we use PKGBUILD to  
install the license file manually. Since it is a common step for those  
packages, why not let makepkg do that automatically?
Just specify $licensefile in your PKGBUILD(like $licensefile=LICENSE) and  
ensure the license file is in $startdir, it then will be automatically  
install to $pkgdir/usr/share/licenses/$pkgname/$licensefile when packaging.



--
best regards,
hunt

makepkg-custom-license.diff
Description: Binary data


makepkg-icc.diff
Description: Binary data



Re: [pacman-dev] two patches for makepkg

2009-10-02 Thread Xavier
On Fri, Oct 2, 2009 at 7:43 PM, Ray Rashif schivmeis...@gmail.com wrote:
 2009/10/2 huntxu mhun...@gmail.com


 2. let makepkg install custom license automatically
 When making packages whose licenses are custom, we use PKGBUILD to
 install the license file manually. Since it is a common step for those
 packages, why not let makepkg do that automatically?
 Just specify $licensefile in your PKGBUILD(like $licensefile=LICENSE) and
 ensure the license file is in $startdir, it then will be automatically
 install to $pkgdir/usr/share/licenses/$pkgname/$licensefile when packaging.


 I don't quite like this one. Custom licenses are not always handmade, they
 can reside somewhere in $srcdir. Even if this is an optional variable,
 it's sort of not really worth it.

 It can be a path, or makepkg could parse $license for the word custom and
 look in $startdir for the file of which the name is after the colon eg.
 custom:FOO. Can be handled many ways, but..is it worth the extra code, and
 KISS to let a variable define something which can just be scripted inside
 build() easily?



I guess we now have enough reasons for not accepting that one.

Comments welcome on the icc one :)