Re: [Pixman] [PATCH 1/5] configure.ac: Fail the ARM/iwMMXt test if not compiling with -march=iwmmxt
On Sat, May 19, 2012 at 12:34 PM, Søren Sandmann sandm...@cs.au.dk wrote: Matt Turner matts...@gmail.com writes: On Fri, May 18, 2012 at 2:41 PM, Matt Turner matts...@gmail.com wrote: If not compiling with -march=iwmmxt, the configure test will still pass, thinking that the __builtin_arm_* intrinsic is a function instead of generating a single instruction. Since no linking is done, the configure test doesn't catch this, and we get linking errors in the build. Already committed and didn't mean to resend. Sent this instead of the correct 5th patch. That patch will be on the mailing list shortly. I have no objections to this series, but it probably should wait to go in until after 0.26.0 (due some time next week). Søren Works for me. ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
[Pixman] [PATCH 1/5] configure.ac: Fail the ARM/iwMMXt test if not compiling with -march=iwmmxt
If not compiling with -march=iwmmxt, the configure test will still pass, thinking that the __builtin_arm_* intrinsic is a function instead of generating a single instruction. Since no linking is done, the configure test doesn't catch this, and we get linking errors in the build. --- configure.ac |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 5ff78eb..027a168 100644 --- a/configure.ac +++ b/configure.ac @@ -619,6 +619,9 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ #ifndef __arm__ #error IWMMXT is only available on ARM #endif +#ifndef __IWMMXT__ +#error IWMMXT not enabled (with -march=iwmmxt) +#endif #if defined(__GNUC__) (__GNUC__ 4 || (__GNUC__ == 4 __GNUC_MINOR__ 5)) #error Need GCC = 4.5 for IWMMXT intrinsics #endif -- 1.7.3.4 ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
Re: [Pixman] [PATCH 1/5] configure.ac: Fail the ARM/iwMMXt test if not compiling with -march=iwmmxt
On Fri, May 18, 2012 at 2:41 PM, Matt Turner matts...@gmail.com wrote: If not compiling with -march=iwmmxt, the configure test will still pass, thinking that the __builtin_arm_* intrinsic is a function instead of generating a single instruction. Since no linking is done, the configure test doesn't catch this, and we get linking errors in the build. Already committed and didn't mean to resend. Sent this instead of the correct 5th patch. That patch will be on the mailing list shortly. ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman
