Review Request 120842: [kcm-effects] Use Loader for the Video Item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- Review request for kwin, Plasma and Martin Klapetek. Repository: kwin Description --- Currently just opening the Desktop Effects KCM loads QtMultimedia which in turn loads gstreamer 0.10. If one opens any other KCM in systemsettings and changes without applying the change, the window freezes when the warning dialog gets shown, because the warning message pulls in Phonon with maybe the Gstreamer backend which uses gstreamer 1.0. This is bad, bad and breaks everything. By using a Loader the problem scope gets reduced. It still happens but only if one actually watches a video. Only opening the KCM doesn't trigger the problem any more. Diffs - kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d Diff: https://git.reviewboard.kde.org/r/120842/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/#review69253 --- Ship it! Looks good! - Martin Klapetek On Oct. 28, 2014, 11:29 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- (Updated Oct. 28, 2014, 11:29 a.m.) Review request for kwin, Plasma and Martin Klapetek. Repository: kwin Description --- Currently just opening the Desktop Effects KCM loads QtMultimedia which in turn loads gstreamer 0.10. If one opens any other KCM in systemsettings and changes without applying the change, the window freezes when the warning dialog gets shown, because the warning message pulls in Phonon with maybe the Gstreamer backend which uses gstreamer 1.0. This is bad, bad and breaks everything. By using a Loader the problem scope gets reduced. It still happens but only if one actually watches a video. Only opening the KCM doesn't trigger the problem any more. Diffs - kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d Diff: https://git.reviewboard.kde.org/r/120842/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120842/#review69255
---
kcmkwin/kwincompositing/qml/Effect.qml
https://git.reviewboard.kde.org/r/120842/#comment48414
You can just set the Loader's active property instead of messing with the
source.
kcmkwin/kwincompositing/qml/Effect.qml
https://git.reviewboard.kde.org/r/120842/#comment48415
onLoaded: {}
- Kai Uwe Broulik
On Okt. 28, 2014, 10:29 vorm., Martin Gräßlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120842/
---
(Updated Okt. 28, 2014, 10:29 vorm.)
Review request for kwin, Plasma and Martin Klapetek.
Repository: kwin
Description
---
Currently just opening the Desktop Effects KCM loads QtMultimedia which
in turn loads gstreamer 0.10. If one opens any other KCM in
systemsettings and changes without applying the change, the window
freezes when the warning dialog gets shown, because the warning message
pulls in Phonon with maybe the Gstreamer backend which uses
gstreamer 1.0. This is bad, bad and breaks everything.
By using a Loader the problem scope gets reduced. It still happens but
only if one actually watches a video. Only opening the KCM doesn't
trigger the problem any more.
Diffs
-
kcmkwin/kwincompositing/qml/Effect.qml
a2a003cc33e99cc8881fb7fd149a56684e6d3a4d
kcmkwin/kwincompositing/qml/Video.qml
c217eb44fa60fab276dd0fe5ff86fd726a26ea7d
Diff: https://git.reviewboard.kde.org/r/120842/diff/
Testing
---
Thanks,
Martin Gräßlin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- (Updated Oct. 28, 2014, 12:58 p.m.) Review request for kwin, Plasma and Martin Klapetek. Changes --- adjusted as Kai Uwe suggested. Thanks for those hints! Repository: kwin Description --- Currently just opening the Desktop Effects KCM loads QtMultimedia which in turn loads gstreamer 0.10. If one opens any other KCM in systemsettings and changes without applying the change, the window freezes when the warning dialog gets shown, because the warning message pulls in Phonon with maybe the Gstreamer backend which uses gstreamer 1.0. This is bad, bad and breaks everything. By using a Loader the problem scope gets reduced. It still happens but only if one actually watches a video. Only opening the KCM doesn't trigger the problem any more. Diffs (updated) - kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d Diff: https://git.reviewboard.kde.org/r/120842/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/#review69284 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 28, 2014, 11:58 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- (Updated Okt. 28, 2014, 11:58 vorm.) Review request for kwin, Plasma and Martin Klapetek. Repository: kwin Description --- Currently just opening the Desktop Effects KCM loads QtMultimedia which in turn loads gstreamer 0.10. If one opens any other KCM in systemsettings and changes without applying the change, the window freezes when the warning dialog gets shown, because the warning message pulls in Phonon with maybe the Gstreamer backend which uses gstreamer 1.0. This is bad, bad and breaks everything. By using a Loader the problem scope gets reduced. It still happens but only if one actually watches a video. Only opening the KCM doesn't trigger the problem any more. Diffs - kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d Diff: https://git.reviewboard.kde.org/r/120842/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/ --- Review request for Plasma. Repository: plasma-desktop Description --- Configuration for kwinrc and reloading KWin. As I'm not quite sure how the mechanism works, please verify that everything needed is loaded, saved, set, whatever :-) Diffs - kcms/lookandfeel/autotests/kcmtest.cpp 08fae140be58fc3fe105b5d8770c764f077359e5 kcms/lookandfeel/autotests/lookandfeel/contents/defaults d16963a33a88ada2d41d966bef64a972474064bc kcms/lookandfeel/kcm.h b6b6ec99884814037ea53ca8692ed9d19a22811b kcms/lookandfeel/kcm.cpp 3ede2e05e339fbea17c504d631ccaea90728c74b Diff: https://git.reviewboard.kde.org/r/120847/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- (Updated Oct. 28, 2014, 2:01 p.m.) Status -- This change has been marked as submitted. Review request for kwin, Plasma and Martin Klapetek. Repository: kwin Description --- Currently just opening the Desktop Effects KCM loads QtMultimedia which in turn loads gstreamer 0.10. If one opens any other KCM in systemsettings and changes without applying the change, the window freezes when the warning dialog gets shown, because the warning message pulls in Phonon with maybe the Gstreamer backend which uses gstreamer 1.0. This is bad, bad and breaks everything. By using a Loader the problem scope gets reduced. It still happens but only if one actually watches a video. Only opening the KCM doesn't trigger the problem any more. Diffs - kcmkwin/kwincompositing/qml/Effect.qml a2a003cc33e99cc8881fb7fd149a56684e6d3a4d kcmkwin/kwincompositing/qml/Video.qml c217eb44fa60fab276dd0fe5ff86fd726a26ea7d Diff: https://git.reviewboard.kde.org/r/120842/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/#review69289 --- Ship it! kcms/lookandfeel/kcm.cpp https://git.reviewboard.kde.org/r/120847/#comment48440 just out of curiosity: window switchers are still shipped as separate packages (as this line suggests) or are inside the lf package? - Marco Martin On Ott. 28, 2014, 2 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/ --- (Updated Ott. 28, 2014, 2 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Configuration for kwinrc and reloading KWin. As I'm not quite sure how the mechanism works, please verify that everything needed is loaded, saved, set, whatever :-) Diffs - kcms/lookandfeel/autotests/kcmtest.cpp 08fae140be58fc3fe105b5d8770c764f077359e5 kcms/lookandfeel/autotests/lookandfeel/contents/defaults d16963a33a88ada2d41d966bef64a972474064bc kcms/lookandfeel/kcm.h b6b6ec99884814037ea53ca8692ed9d19a22811b kcms/lookandfeel/kcm.cpp 3ede2e05e339fbea17c504d631ccaea90728c74b Diff: https://git.reviewboard.kde.org/r/120847/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher
On Oct. 28, 2014, 3:23 p.m., Marco Martin wrote: kcms/lookandfeel/kcm.cpp, line 218 https://git.reviewboard.kde.org/r/120847/diff/1/?file=322480#file322480line218 just out of curiosity: window switchers are still shipped as separate packages (as this line suggests) or are inside the lf package? That's how I imagined it to work: * default switcher is part of lf package * kwin's internal logic on how to load isn't changed what I'm currently trying to figure out is how to find the theme from KWin side or whether it's possible to get the lf package to install the window switcher to the path KWin would expect. Latter would be preffered as it would mean not adjusting KWin at all. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/#review69289 --- On Oct. 28, 2014, 3 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/ --- (Updated Oct. 28, 2014, 3 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Configuration for kwinrc and reloading KWin. As I'm not quite sure how the mechanism works, please verify that everything needed is loaded, saved, set, whatever :-) Diffs - kcms/lookandfeel/autotests/kcmtest.cpp 08fae140be58fc3fe105b5d8770c764f077359e5 kcms/lookandfeel/autotests/lookandfeel/contents/defaults d16963a33a88ada2d41d966bef64a972474064bc kcms/lookandfeel/kcm.h b6b6ec99884814037ea53ca8692ed9d19a22811b kcms/lookandfeel/kcm.cpp 3ede2e05e339fbea17c504d631ccaea90728c74b Diff: https://git.reviewboard.kde.org/r/120847/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120849/ --- Review request for kwin and Plasma. Repository: kwin Description --- We assume the configured layout name is a look and feel package. Thus the Switcher is located at contents/windowswitcher/WindowSwitcher.qml of that package. Diffs - tabbox/tabboxconfig.h f953102986b2d5577cc89321e7fecdea336bfc07 tabbox/tabboxhandler.cpp cae64e3aec31af223a51fa4126798c736df411f1 Diff: https://git.reviewboard.kde.org/r/120849/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120850: Move KWin's window switcher sidebar to Look'n'Feel package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- Review request for Plasma. Repository: plasma-workspace Description --- Move KWin's window switcher sidebar to Look'n'Feel package Diffs - lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b lookandfeel/contents/windowswitcher/WindowSwitcher.qml e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 Diff: https://git.reviewboard.kde.org/r/120850/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120850: Move KWin's window switcher sidebar to Look'n'Feel package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69299 --- Ship it! lookandfeel/contents/windowswitcher/WindowSwitcher.qml https://git.reviewboard.kde.org/r/120850/#comment48453 property alias is cheaper lookandfeel/contents/windowswitcher/WindowSwitcher.qml https://git.reviewboard.kde.org/r/120850/#comment48455 Then use FrameSvg not FrameSvgItem lookandfeel/contents/windowswitcher/WindowSwitcher.qml https://git.reviewboard.kde.org/r/120850/#comment48452 You don't need this. You're clipping the child list view which fills the parent, and clipping is expensive. IIRC ScrollArea will automatically clip scroll contents, so you can get rid of both the explicit clip calls - David Edmundson On Oct. 28, 2014, 3:55 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- (Updated Oct. 28, 2014, 3:55 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Move KWin's window switcher sidebar to Look'n'Feel package Diffs - lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b lookandfeel/contents/windowswitcher/WindowSwitcher.qml e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 Diff: https://git.reviewboard.kde.org/r/120850/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 335710, which changed state. Bug 335710 Summary: Plasma shell randomly swaps screen panels on login https://bugs.kde.org/show_bug.cgi?id=335710 What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120850: Move KWin's window switcher sidebar to Look'n'Feel package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69304 --- Still related to the comment of the previous review request.. If the lf package actually provides the qml files of the switcher, kindof removes the point of the defaults file... or is it still possible to set a different switcxher in the kwin config? in this case this patch is fine, provided all the other switchers to be in the same package format - Marco Martin On Ott. 28, 2014, 3:55 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- (Updated Ott. 28, 2014, 3:55 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Move KWin's window switcher sidebar to Look'n'Feel package Diffs - lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b lookandfeel/contents/windowswitcher/WindowSwitcher.qml e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 Diff: https://git.reviewboard.kde.org/r/120850/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120850: Move KWin's window switcher sidebar to Look'n'Feel package
On Oct. 28, 2014, 5:26 p.m., Marco Martin wrote: Still related to the comment of the previous review request.. If the lf package actually provides the qml files of the switcher, kindof removes the point of the defaults file... or is it still possible to set a different switcxher in the kwin config? in this case this patch is fine, provided all the other switchers to be in the same package format or is it still possible to set a different switcxher in the kwin config? yes. Though the configuration module needs adjustment. That it's still possible to configure another switcher can be seen in https://git.reviewboard.kde.org/r/120849/ - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69304 --- On Oct. 28, 2014, 4:55 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- (Updated Oct. 28, 2014, 4:55 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Move KWin's window switcher sidebar to Look'n'Feel package Diffs - lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b lookandfeel/contents/windowswitcher/WindowSwitcher.qml e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 Diff: https://git.reviewboard.kde.org/r/120850/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120850: Move KWin's window switcher sidebar to Look'n'Feel package
On Oct. 28, 2014, 5:04 p.m., David Edmundson wrote: I'm not sure what I should do with your comments :-) I'm only moving the code, it's not new. If you think this needs improvement I suggest to just come up with the patch once it's merged. After all it looks like you are way more into the matter than I am. Just be careful with the clip, it might be that KWin internally needs it. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69299 --- On Oct. 28, 2014, 4:55 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- (Updated Oct. 28, 2014, 4:55 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- Move KWin's window switcher sidebar to Look'n'Feel package Diffs - lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b lookandfeel/contents/windowswitcher/WindowSwitcher.qml e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 Diff: https://git.reviewboard.kde.org/r/120850/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? - Aleix Pol Gonzalez On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-develm=141434675118408w=2). Is there any limitation of libkgapi2, so that I should use KAccounts?? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Ashish Bansal wrote: Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-develm=141434675118408w=2). Is there any limitation of libkgapi2, so that I should use KAccounts?? It's not about libkgapi, you'll end up using it with both, it's so that you can re-use the login information with KTp, KDEPIM, etc. You can ask about it in kdepim mailing lists. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/ --- (Updated Oct. 28, 2014, 11:47 a.m.) Review request for Plasma and David Edmundson. Changes --- Set a minimum size on the applet and set switchWidth and switchHeight so it will become an icon when it's too small to look decent. Repository: kdeplasma-addons Description --- Config options from previous c++ version kept though names are a bit diferent. Images not yet supported. Puzzle starts at 0 in the top left corner, maybe should start with 1 in the corner though. This is my first port to plasma qml, so I may have used some of the non suggested/recommended components, if so let me know and I'll fix it. Diffs (updated) - applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 applets/fifteenPuzzle/Messages.sh PRE-CREATION applets/fifteenPuzzle/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz applets/fifteenPuzzle/images/blanksquare.svg applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 513cc0084df7247a520807620361b0426623727e applets/fifteenPuzzle/src/Messages.sh bab24ae73049f37d9693cf062eaaa98ca1e6bab0 applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b applets/fifteenPuzzle/src/fifteen.cpp ebdcf2c0756a17ea174c0fc5fd106e157b223063 applets/fifteenPuzzle/src/fifteenPuzzle.h cf7885380f0e152d51cf2dc7557444e9b425b596 applets/fifteenPuzzle/src/fifteenPuzzle.cpp 8a1528988f3e693d20179db4a209309b0aad87fd applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui ff82f331db4cee2d66f526954be63f0f5d81d250 applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 applets/systemloadviewer/package/contents/ui/ColorPicker.qml 92062db546dcff67f930d4888180f4e753798c27 Diff: https://git.reviewboard.kde.org/r/120806/diff/ Testing --- I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. The icon is not working in the widget adder, not sure where to install that to for it to work. Images not supported yet, though they are in the config, maybe should remove from config until they are supported? Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/ --- (Updated Oct. 28, 2014, 11:48 a.m.) Review request for Plasma and David Edmundson. Changes --- Add minimum size and set switch to the minimum size so it becomes an icon at smaller sizes. Repository: kdeplasma-addons Description --- Config options from previous c++ version kept though names are a bit diferent. Images not yet supported. Puzzle starts at 0 in the top left corner, maybe should start with 1 in the corner though. This is my first port to plasma qml, so I may have used some of the non suggested/recommended components, if so let me know and I'll fix it. Diffs - applets/CMakeLists.txt 63e6e25628d18ee474231acd2a21711841dee592 applets/fifteenPuzzle/CMakeLists.txt 04d5e55fd246684855d49484f1233dac054a0124 applets/fifteenPuzzle/Messages.sh PRE-CREATION applets/fifteenPuzzle/icons/CMakeLists.txt 106884f432c1d1e0b0584959af854c79ede4ea6d applets/fifteenPuzzle/icons/hisc-app-fifteenpuzzle.svgz applets/fifteenPuzzle/images/blanksquare.svg applets/fifteenPuzzle/package/contents/config/config.qml PRE-CREATION applets/fifteenPuzzle/package/contents/config/main.xml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/ColorPicker.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/Piece.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/configAppearance.qml PRE-CREATION applets/fifteenPuzzle/package/contents/ui/main.qml PRE-CREATION applets/fifteenPuzzle/plasma-applet-fifteenPuzzle.desktop 513cc0084df7247a520807620361b0426623727e applets/fifteenPuzzle/src/Messages.sh bab24ae73049f37d9693cf062eaaa98ca1e6bab0 applets/fifteenPuzzle/src/fifteen.h 2a27f5b109988003de45fb64c457484ebdfdbc8b applets/fifteenPuzzle/src/fifteen.cpp ebdcf2c0756a17ea174c0fc5fd106e157b223063 applets/fifteenPuzzle/src/fifteenPuzzle.h cf7885380f0e152d51cf2dc7557444e9b425b596 applets/fifteenPuzzle/src/fifteenPuzzle.cpp 8a1528988f3e693d20179db4a209309b0aad87fd applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui ff82f331db4cee2d66f526954be63f0f5d81d250 applets/fifteenPuzzle/src/piece.h d0e58d0f9d38d4a1ef2110b974b3f4f6938293e1 applets/fifteenPuzzle/src/piece.cpp 2efb72ecf69d9beaa53367bc2f3c9cee88238f28 applets/systemloadviewer/package/contents/ui/ColorPicker.qml 92062db546dcff67f930d4888180f4e753798c27 Diff: https://git.reviewboard.kde.org/r/120806/diff/ Testing --- I've tested it with plasmoidviewer -a org.kde.plasma.fifteenpuzzle. The icon is not working in the widget adder, not sure where to install that to for it to work. Images not supported yet, though they are in the config, maybe should remove from config until they are supported? Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Added kdepim and kdepimlibs in groups Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Gerrit: merging feature branches
Hi all, Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. now i tried the following 3 approaches, that all fail miserably: * from my branch: git push gerrit HEAD:refs/for/master gives [remote rejected] master - refs/for/master (no new changes) * from master: git rebase mart/basicDeleteUndo, then git push gerrit master:refs/for/master . it complains that a commit doesn't have an id (all of my commits in the branch have it) * from master: git merge mart/basicDeleteUndo: complains as well that a commit doesn't have id (may be the merge commit in this case?) in the end the nearest i could get is https://gerrit.vesnicky.cesnet.cz/r/#/c/130 Can the feature branch workflow work at all in gerrit or is better to just use master? -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Gerrit: merging feature branches
On Tuesday 28 October 2014, Marco Martin wrote: in the end the nearest i could get is https://gerrit.vesnicky.cesnet.cz/r/#/c/130 and don't think that one is really usable, since it generated a review request per commit. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120849/#review69364 --- Ship it! Lol, the patch looks pretty scary compared to the actual change. tabbox/tabboxhandler.cpp https://git.reviewboard.kde.org/r/120849/#comment48480 why not? (by different name, oc) - Thomas Lübking On Okt. 28, 2014, 3:53 nachm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120849/ --- (Updated Okt. 28, 2014, 3:53 nachm.) Review request for kwin and Plasma. Repository: kwin Description --- We assume the configured layout name is a look and feel package. Thus the Switcher is located at contents/windowswitcher/WindowSwitcher.qml of that package. Diffs - tabbox/tabboxconfig.h f953102986b2d5577cc89321e7fecdea336bfc07 tabbox/tabboxhandler.cpp cae64e3aec31af223a51fa4126798c736df411f1 Diff: https://git.reviewboard.kde.org/r/120849/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120876: Forward-port Fix and future-proof Dr Konqi security methods on Bugzilla from kde-runtime
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking. Bugs: 337742 https://bugs.kde.org/show_bug.cgi?id=337742 Repository: plasma-workspace Description --- discussion was in https://git.reviewboard.kde.org/r/120431/ removed the version checks, as we know we have kdelibs = 4.5 ;-) Diffs - drkonqi/bugzillaintegration/reportassistantpages_bugzilla.h 50cf05f drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp 5a6096f drkonqi/bugzillaintegration/bugzillalib.h 570169b drkonqi/bugzillaintegration/bugzillalib.cpp 8fd8399 Diff: https://git.reviewboard.kde.org/r/120876/diff/ Testing --- builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120877: Convert switch statements to if/else due to MSVC limitation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- Review request for kdewin and Plasma. Repository: plasma-framework Description --- MSVC is unable to recognise e.g. FrameSvg::TopBorder | FrameSvg::LeftBorder as a compile-time const expression (error C2051: case expression not constant) Diffs - src/plasma/private/framesvg_helpers.h 5b96cd5 Diff: https://git.reviewboard.kde.org/r/120877/diff/ Testing --- Builds with MSVC 2013 64bit. framesvg related tests pass, other unrelated tests still fail. Test project V:/build/frameworks/plasma/work/msvc2013-RelWithDebInfo-master Start 1: plasma-dialogqmltest 1/10 Test #1: plasma-dialogqmltest ...***Failed1.15 sec Start 2: plasma-fallbackpackagetest 2/10 Test #2: plasma-fallbackpackagetest . Passed0.16 sec Start 3: plasma-packagestructuretest 3/10 Test #3: plasma-packagestructuretest ***Failed0.19 sec Start 4: plasma-packageurlinterceptortest 4/10 Test #4: plasma-packageurlinterceptortest ... Passed0.12 sec Start 5: plasma-pluginloadertest 5/10 Test #5: plasma-pluginloadertest Passed1.44 sec Start 6: plasma-framesvgtest 6/10 Test #6: plasma-framesvgtest Passed0.64 sec Start 7: coronatest 7/10 Test #7: coronatest .***Failed0.16 sec Start 8: plasma-storagetest 8/10 Test #8: plasma-storagetest .***Failed0.12 sec Start 9: plasma-sortfiltermodeltest 9/10 Test #9: plasma-sortfiltermodeltest . Passed0.14 sec Start 10: i18ndcheck Could not find executable SH-NOTFOUND Looked in the following places: SH-NOTFOUND SH-NOTFOUND.exe Release/SH-NOTFOUND Release/SH-NOTFOUND.exe Debug/SH-NOTFOUND Debug/SH-NOTFOUND.exe MinSizeRel/SH-NOTFOUND MinSizeRel/SH-NOTFOUND.exe RelWithDebInfo/SH-NOTFOUND RelWithDebInfo/SH-NOTFOUND.exe Deployment/SH-NOTFOUND Deployment/SH-NOTFOUND.exe Development/SH-NOTFOUND Development/SH-NOTFOUND.exe Unable to find executable: SH-NOTFOUND 10/10 Test #10: i18ndcheck .***Not Run 0.00 sec 50% tests passed, 5 tests failed out of 10 Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120878: Remove unused header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner Description --- Since scripting/runnerscript.cpp is not compiled, we get a linking error by exporting but not defining RunnerScript. Diffs - src/abstractrunner.cpp 4da0394 Diff: https://git.reviewboard.kde.org/r/120878/diff/ Testing --- Tested building using MSVC 64bit Thanks, Andrius da Costa Ribas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
